[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221866. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Co

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna added a comment. done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67996/new/ https://reviews.llvm.org/D67996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna updated this revision to Diff 221985. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixed the remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67996/new/ https://reviews.llvm.org/D67

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

This revision was automatically updated to reflect the committed changes. Closed by commit rL373003: Convert FileSystem::Open() to return Expected (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. @labath how's this one looking? need any changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222165. lawrence_danna added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h lldb/include/ll

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222168. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. style fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: ll

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. fixed style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222170. lawrence_danna added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h lldb/

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373090: remove File::SetStream(), make new files instead. (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222190. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. rebased, and converted Set* methods into constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. @labath, OK sets are now constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere, vadimcn. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. One small step in my long running quest to improve python exception handling in LLDB. Replace GetInteger() whi

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 258810. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: ll

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:3153-3159 + long long py_return = unwrapOrSetPythonException( + As(implementor.CallMethod(callee_name))); // if it fails, print the error but oth

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 258831. lawrence_danna added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig lldb/bindings/py

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259131. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. wrap long line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files:

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:585-597 +llvm::Expected result = pfunc.Call(PythonString(child_name)); -if (!result.IsAllocated()) -return UINT32_MAX; +long long retval = unwrapOrSetPythonException(A

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

This revision was automatically updated to reflect the committed changes. Closed by commit rG737521217295: get rid of PythonInteger::GetInteger() (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D78462?vs=259131&id=259134#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. Remove LLDBSwigPython_GetIndexOfChildWithName and associated functions. They are not used. Repository: rG LL

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259659. lawrence_danna added a comment. fix python2 projblems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added a comment. @omjavaid sorry I didn't catch that on pre-submit testing. `PyLong_AsLongLong` and friends do not automatically convert on python2 like they do on python3. It's fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259700. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig lldb/binding

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259916. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files: lldb/bindings/python/python-typemaps.swig lldb/binding

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added a comment. @omjavaid ok to re-land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

This revision was automatically updated to reflect the committed changes. Closed by commit rG52712d3ff7a2: Re-land "get rid of PythonInteger::GetInteger()" (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D78462?vs=259916&id=262908#toc Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName

lawrence_danna abandoned this revision. lawrence_danna added a comment. despite there being no references to this function, it is not actually unused. This change causes `TestFormattersSBAPI.py` to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/trunk/scripts/Python/python-typemaps.swig:481 + PyBuffer_Release(&view); + $1 = ($1_ltype) buf; + $2 = ($2_ltype) (size/sizeof($*1_type)); labath wrote: > v

<    1   2   3   4   5