[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

lawrence_danna added inline comments. Comment at: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1075-1096 +static int readfn(void *ctx, char *buffer, int n) +{ + auto state = PyGILState_Ensure(); + auto *file = (PyObject *) ctx; + int result = -1; +

[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

lawrence_danna added a comment. @labath > (Please add lldb-commits to future reviews, so that people are aware of > what's going on.) ok > Couldn't we just change the File::Read/Write functions to call these directly Like I said to @zturner , this is possible, but it can't work with the exist

[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

lawrence_danna added inline comments. Comment at: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1075-1096 +static int readfn(void *ctx, char *buffer, int n) +{ + auto state = PyGILState_Ensure(); + auto *file = (PyObject *) ctx; + int result = -1; +

[Lldb-commits] [PATCH] D111910: Fix Xcode project for debugserver

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere. lawrence_danna requested review of this revision. Herald added a project: LLDB. It seems StringConvert.cpp was moved, and the Xcode project file wasn't updated. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D111910: Fix Xcode project for debugserver

This revision was automatically updated to reflect the committed changes. Closed by commit rG4594f8116543: Fix Xcode project for debugserver (authored by Lawrence D'\''Anna , committed by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere. lawrence_danna requested review of this revision. Herald added a project: LLDB. The help string can be more helpful by explaining these are aliases for 'process connect' Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

lawrence_danna updated this revision to Diff 380257. lawrence_danna added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111965/new/ https://reviews.llvm.org/D111965 Files: lldb/source/Interpreter/CommandInterpreter.cpp

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac5a6641fa4: [lldb] improve the help strings for gdb-remote and kdp-remote (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11196

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added a subscriber: mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. LLDB doesn't use only the python stable ABI, which means loading it into an

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added subscribers: dang, mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. It is surprisingly difficult to write a simple python script that can r

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added a comment. In D112973#3101602 , @JDevlieghere wrote: > FWIW `crashlog.py` has a good example of how to import LLDB. It's complicated > slightly by us having to honor the `LLDB_DEFAULT_PYTHON_VERSION`, but > otherwise it's pretty si

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 383978. lawrence_danna added a comment. change lldb-python into a script instead of a feature of Driver.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Fil

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added subscribers: dang, pengfei. lawrence_danna requested review of this revision. Herald added a project: LLDB. Jim says: lldb has a -Q or --source-quietly option, which supposedly

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna updated this revision to Diff 384155. lawrence_danna added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/ https://reviews.llvm.org/D112988 Files: lldb/docs/man/lldb.rst lldb/test/Shell/Driver/TestQ

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. In D112988#3103463 , @jingham wrote: > There was one typo I pointed out, and it would be good to add a test. I'm > sure this worked at some point, but wasn't tested so it w

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna added a comment. In D112988#3103574 , @jingham wrote: > Ha! It was apparently so easy to add the test that it wasn't noticeable (at > least by me!). > > This isn't directly relevant to your patch, since this wasn't behavior you > changed

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2a6c08bbc38: [lldb] fix --source-quietly (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham, stella.stamenova. lawrence_danna requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Followup to https://reviews.llvm.org/D112988 Sorry

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

lawrence_danna added a comment. In D112988#3103992 , @stella.stamenova wrote: > It looks like some of the tests need to be updated after this change (at > least on Windows, the Windows LLDB bot is broken now): > > https://lab.llvm.org/buildbot/#/builder

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f01f78593d6: [lldb] update TestEchoCommands (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added a comment. @JDevlieghere That approach would work great for my purposes, i'll update like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 __

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna added a comment. In D113047#3106732 , @stella.stamenova wrote: > The Windows buildbot is still broken after this change: > > https://lab.llvm.org/buildbot/#/builders/83/builds/11630 sorry again :/ I will fix. It's takaing me a alittle

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna added a comment. @stella.stamenova fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 385711. lawrence_danna added a comment. updated according to reviewer feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files: lldb/bindings/interfac

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 385712. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files:

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 386170. lawrence_danna added a comment. changed internal apis to use StructuredData instead of char* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files: l

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBHostOS.h:23 + const char *GetScriptInterpreterInfo(); + JDevlieghere wrote: > Is still still relevant? nope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 386198. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files: lldb/

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbef51eb43c2: [lldb] make it easier to find LLDB's python (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://re

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. lawrence_danna requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Apparently "{sys.prefix}/bin/python3" isn't where you find the python

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added a comment. In D112973#3122496 , @stella.stamenova wrote: > Windows buildbot is broken: > > https://lab.llvm.org/buildbot/#/builders/83/builds/11865 eek, sorry. fix is here: https://reviews.llvm.org/D113650 Repository: rG LLVM G

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:413 +static const char GetInterpreterInfoScript[] = R"( +import os stella.stamenova wrote: > Does `sys.executable` not work for some reas

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:432 + elif os.name == 'posix': + exename = "python" + str(sys.version_info[0]) + info['executable'] = os.path.join(sys.prefix, 'bin', exename) --

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386599. lawrence_danna added a comment. Herald added a subscriber: mgorny. maybe this approach is better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files:

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. OK this should work in all configs I think, as long as sys.executable ultimately points at something under sys.prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386878. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. fix cmake error message condition for cross-compile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ h

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386967. lawrence_danna added a comment. cleanup cmake usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt lldb/bindings/python

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3128674 , @stella.stamenova wrote: > Can you please disable the test on Windows or back your change out until > there's a fix? There are already other failures that are getting missed > because the bot is red.

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386968. lawrence_danna added a comment. revert change that disabled the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt lld

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna updated this revision to Diff 386970. lawrence_danna added a comment. rebased, and include win32 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://reviews.llvm.org/D112972 Files: lldb/CMakeLists.txt lldb/bindings

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386995. lawrence_danna added a comment. cmake fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt lldb/bindings/python/get-pytho

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna updated this revision to Diff 386996. lawrence_danna added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://reviews.llvm.org/D112972 Files: lldb/CMakeLists.txt lldb/bindings/python/CMakeLists.t

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c2cf3a314d9: [lldb] fix -print-script-interpreter-info on windows (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ h

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGae389b2450bd: [lldb] use EXT_SUFFIX for python extension (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://rev

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3136407 , @aprantl wrote: > This seems to have broken the green dragon incremental bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/ Crosscompiling LLDB with Python requires manually s

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3136407 , @aprantl wrote: > This seems to have broken the green dragon incremental bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/ looks like its fixed now. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jingham, JDevlieghere. Herald added a subscriber: mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. distutils is deprecated and will be removed, so we shouldn't be using it. We were

[Lldb-commits] [PATCH] D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu

This revision was automatically updated to reflect the committed changes. Closed by commit rG63270710f13a: [lldb] remove usage of distutils, fix python path on debian/ubuntu (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jingham, JDevlieghere. lawrence_danna requested review of this revision. Herald added a project: LLDB. Some pythons are configured to set platlib somewhere outside of their sys.prefix. It's important that we at least u

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. @clayborg Does this fix it for you? https://reviews.llvm.org/D114973 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___ lldb-

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit rG27ca9458012c: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D114973?vs=391384&id=391541#toc Repository: rG LLVM Git

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed whitespace and commited Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114973/new/ https://reviews.llvm.org/D114973 _

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere, vadimcn. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lawrence_danna added a comment. thanks @vadimcn for pointing this out. The buffer protocol does not allow us

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. thanks @vadimcn for pointing this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. Those errors don't look like they could possibly be related to these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 __

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added a comment. In D77480#1963315 , @labath wrote: > Thanks for getting back to this. Is there any reasonable way of testing this > (e.g. an existing python class with temporary buffer storage), or would we > have to implement our own PyB

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255447. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig Index:

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255464. lawrence_danna added a comment. delete operator= too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255772. lawrence_danna added a comment. fix initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig Inde

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8de17bca658: Fix illegal early call to PyBuffer_Release in swig typemaps (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/n

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + aadsm wrote: > labath wrote: > > Could you also `= delete` the copy operations to make sure nothing funny > > happens with those. > The `= delete` is unsup

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:500 + } +}; + lawrence_danna wrote: > aadsm wrote: > > labath wrote: > > > Could you also `= delete` the copy operations to make sure nothing funny > > > happens with th

[Lldb-commits] [PATCH] D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it

lawrence_danna accepted this revision. lawrence_danna added a comment. This revision is now accepted and ready to land. Looks fine to me, assuming that the tests pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86381/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D87051: scan-build-py: fix multiprocessing error

lawrence_danna created this revision. lawrence_danna added reviewers: ldionne, chandlerc, jasonmolenda, JDevlieghere. Herald added subscribers: cfe-commits, dexonsmith, whisperity. Herald added a project: clang. lawrence_danna requested review of this revision. Recent versions of python3's multipr

[Lldb-commits] [PATCH] D87051: scan-build-py: fix multiprocessing error

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c642828612d: scan-build-py: fix multiprocessing error (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87051/new/ https://review

[Lldb-commits] [PATCH] D68152: refactor: move IOObject::m_should_close_fd into subclasses

lawrence_danna created this revision. lawrence_danna added reviewers: labath, JDevlieghere, jasonmolenda. Herald added a project: LLDB. m_should_close_fd doesn't need to be in IOObject. It will be useful for my next change to move it down into File and Socket. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D68152: refactor: move IOObject::m_should_close_fd into subclasses

This revision was automatically updated to reflect the committed changes. Closed by commit rG117512715d66: refactor: move IOObject::m_should_close_fd into subclasses (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68152/ne

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. File::Clear() is an ugly function. It's only used in one place, which is the swig typemaps for FILE*. This patch refactors and renames that function to make it

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 64. lawrence_danna added a comment. rebased, removed duplicate test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h l

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. Add new methods to SBDebugger to set IO files as SBFiles instead of as FILE* streams. In future commits, the FILE* methods will be deprecated and these will bec

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 85. lawrence_danna added a comment. clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API/SBDebugger.h lldb/inclu

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This patch adds SWIG typemaps that can convert arbitrary python file objects into lldb_private::File. A SBFile may be initialized from a python file using the co

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna updated this revision to Diff 222459. lawrence_danna added a comment. review fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68160/new/ https://reviews.llvm.org/D68160 Files: lldb/include/lldb/Host/File.h lldb/scripts/Python/p

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Host/common/File.cpp:166-167 +FILE *File::TakeStreamAndClear() { + GetStream(); + FILE *stream = m_stream; + m_stream = NULL; labath wrote: > `FILE *

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222516. lawrence_danna marked 7 inline comments as done. lawrence_danna added a comment. fixed according to reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222520. lawrence_danna added a comment. propagated updates from parent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API/SBDebugger.

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBFile.h:16-21 +/* These tags make no difference at the c++ level, but + * when the constructors are called from python they control + * how python files are c

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222522. lawrence_danna added a comment. flush fix for python2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h lldb/includ

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222528. lawrence_danna added a comment. add reproducer instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h l

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/scripts/Python/python-typemaps.swig:464 } + +// These two pybuffer macros are copied out of swig/Lib/python/pybuffer.i, `swig/LICENSE` says the following, so

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

This revision was automatically updated to reflect the committed changes. lawrence_danna marked an inline comment as done. Closed by commit rL373285: File::Clear() -> File::TakeStreamAndClear() (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: ll

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222537. lawrence_danna added a comment. pushed validity checks out to the SB layer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222538. lawrence_danna added a comment. assertions instead of exceptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API/SBDebugge

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1687532 , @labath wrote: > It seems to be that instead of subclassing a fully-functional File class, it > would be better to create an abstract class, that both `File` and the new > python thingy could implement.

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222661. lawrence_danna added a comment. no inlines in the API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h lldb/includ

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222664. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. no inlines in the API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Fi

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68181: SBDebugger::SetInputFile, SetOutputFile, etc.. lawrence_danna added a child revision: D68188: allow arbitrary pyth

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222749. lawrence_danna added a comment. updated based on an abstract base clase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SB

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1689544 , @labath wrote: > This way the decision whether to "own" something is decoupled from the > decision what api do you use to actually write to the file, and I _think_ it > would make things clearer. What d

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222750. lawrence_danna added a comment. rename LLDBPythonFile -> OwnedPythonFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/S

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222751. lawrence_danna added a comment. style fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/include/lldb/Hos

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222753. lawrence_danna added a comment. use a python helper instead of funny tag structs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBFile.h:16-21 +/* These tags make no difference at the c++ level, but + * when the constructors are called from python they control + * how python files are c

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1691129 , @labath wrote: > Hmm... I like your solution of the typemap problem, but this CRTP class seems > to be way more complicated than needed. There shouldn't be any need for CRTP > as we already have regular

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. @labath any more comments on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

lawrence_danna updated this revision to Diff 222851. lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. rm NativeFile::make_shared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68317/new/ https://reviews.llvm.org/D6831

  1   2   3   4   5   >