[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

This revision was automatically updated to reflect the committed changes. kwk marked an inline comment as done. Closed by commit rG8970d88b65f0: Simplify LZMA decoding by using ArrayRef::take_back (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d7fb29914e3: [lldb] Avoid resource leak (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68638/new/ https://reviews.llvm.org/D68638 Files:

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224838. kwk added a comment. - Silence FileCheck in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files: lldb/test/Shell/ObjectFile/ELF/minidebuginfo-corrupt-xz.ya

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk created this revision. kwk added a reviewer: labath. Herald added subscribers: llvm-commits, lldb-commits, MaskRay, hiraditya, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added projects: LLDB, LLVM. kwk updated this revision to Diff 224838

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224839. kwk added a comment. - restore formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files: lldb/test/Shell/ObjectFile/ELF/minidebuginfo-corrupt-xz.yaml ll

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk marked an inline comment as done. kwk added inline comments. Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:379-380 // being a single SHT_SYMTAB section are upheld. - std::vector Symbols; + Optional> Symbols; std::vector DynamicSymbols; }; labath

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk planned changes to this revision. kwk added a comment. Move tests over to `llvm/llvm/test/ObjectYAML/ELF/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk marked an inline comment as done. kwk added a comment. Moved `yaml2obj` tests under llvm subtree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 ___ lldb-c

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224852. kwk added a comment. - moved test files over to llvm subtree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 Files: lldb/test/Shell/ObjectFile/ELF/minidebuginfo-c

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk added a comment. In D68943#1708068 , @MaskRay wrote: > This is not correct. A lot of yaml2obj tests fail with: > > > yaml2obj: error: unknown section referenced: '.symtab' by YAML section > > '.rela.text' @MaskRay I'm so sorry. You're absolutely rig

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk updated this revision to Diff 224968. kwk marked 6 inline comments as done. kwk added a comment. - Remove unnecessary section - Have consitent ordering of run, check and YAML lines - use ## for comments in YAML - Remove not needed Entry and Sections - Only have Name for a symbol - Moved test f

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk added a comment. @grimar I've tackled the most obvious of your comments. I will now see what fails in `llvm/test/tools/yaml2obj`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 _

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk added a comment. I noticed that the order of sections does matter to some tests. Before the `.symtab` section was always the first one and now it is the last of the implicit sections being created. Some `Link: X` checks break because `X` points to a different section. In order to compensat

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

kwk abandoned this revision. kwk added a comment. Abandoning for D69041 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 ___ ll

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

kwk planned changes to this revision. kwk added a comment. Still tests are running locally... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69254/new/ https://reviews.llvm.org/D69254 ___ lldb-commits m

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

kwk created this revision. Herald added subscribers: lldb-commits, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a project: LLDB. kwk planned changes to this revision. kwk added a comment. Still tests are running locally... Afte

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

kwk requested review of this revision. kwk added subscribers: grimar, labath. kwk added a comment. @grimar @labath tests did pass locally. Are you fine with this change then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69254/new/ https://reviews

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9129a281cd5b: [lldb] drop .symtab removal in minidebuginfo tests (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69254/new/ https://reviews

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. LGTM with the exception of a local variable name. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2008 uint32_t num_dumped = 0; +Mangled::NamePreference preferenc

[Lldb-commits] [PATCH] D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling

kwk added inline comments. Comment at: lldb/source/Commands/Options.td:8 + def tm_smn : Option<"show-mangled-names", "m">, Group<1>, +Desc<"Do not demangle symbol names before showing them.">; } Does it make sense to tell what the default is here? Reposit

[Lldb-commits] [PATCH] D68909: change shortcut for 'step out' from 'o' to 'f'

kwk added a comment. Are there no tests for this code? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68909/new/ https://reviews.llvm.org/D68909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D51830: Add a way to make scripted breakpoints

kwk added inline comments. Comment at: source/Core/SearchFilter.cpp:757 + } + if (m_cu_spec_list.FindFileIndex(0, sym_ctx.comp_unit, false) == UINT32_MAX) +return false; // Fails the file check @jingham Do you know why you check for the CU again here? I

[Lldb-commits] [PATCH] D65682: Give a little more info when "run_to_x_breakpoint" fails

kwk requested changes to this revision. kwk added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:789 + signal_threads = signaled) +test.fail("Stopped for another reaso

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

kwk added inline comments. Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737 TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) { + if (!MangledName.consumeFront(".?A")) { Why not change the return type to `llvm::Expected`? Then you hav

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

kwk marked an inline comment as done. kwk added inline comments. Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737 TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) { + if (!MangledName.consumeFront(".?A")) { thakis wrote: > kwk wrote:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk created this revision. Herald added subscribers: llvm-commits, lldb-commits, MaskRay, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: espindola. Herald added projects: LLDB, LLVM. kwk added reviewers: labath, jankratochvil. kwk marked an inline comment as done. kwk updated thi

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/TestMiniDebugInfo.py:1 +""" Testing debugging of a binary with "mixed" dwarf (with/without fission). """ +import lldb I just saw

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217331. kwk added a comment. - Change header comment of minidebuginfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/packages/Python/lldbsuite/test/linux/min

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217334. kwk added a comment. - Improve documentation of GetGnuDebugDataObjectFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217341. kwk added a comment. - Added documentation source for mini debuginfo commands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/packages/Python/lldbsuit

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217339. kwk added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/Makefile lldb/pac

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217894. kwk marked 4 inline comments as done. kwk added a comment. - Apply review comments - Move LZMA logic to lldb/Host/LZMA.h as suggested by labath - Simplify LZMA function signatures - Remove LZMA_OK from switch - Add llvm-nm to the list of lldb test dependen

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217895. kwk added a comment. - fixed lzma functions when LLVM_ENABLE_LZMA is not enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/include/lldb/Host/LZM

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp:79 + // If there's none in the orignal object file, we add it to it. + if (auto gdd_obj_file = + obj_file->GetGnuDebugDataObjectFile()) { labath wrote: > Wo

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217924. kwk marked an inline comment as done. kwk added a comment. - Fix header comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/include/lldb/Host/LZMA

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. Currently the test `lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/TestMiniDebugInfo.py` fails if `LLVM_ENABLE_LZMA` is not defined because the test stupidly assumes that support for minidebuginfo is available. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 217933. kwk added a comment. - Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/include/lldb/Host/LZMA.h lldb/packages/Python/lldbsuite/test/linux/mi

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218288. kwk added a comment. - add @skipIfLzmaSupportMissing and cleanup - Don't put braces around one statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: ll

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218289. kwk marked 3 inline comments as done. kwk added a comment. - Fix DataExtractor data. llvm does not "always use auto". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218297. kwk marked 3 inline comments as done. kwk added a comment. - Moved .symtab add/replace to OBjectFileELF::CreateSections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D667

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218299. kwk added a comment. - Move find LZMA section in CMake from LLVM to LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/cmake/modules/LLDBConfig.cmak

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked 5 inline comments as done. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1849-1851 + if (m_gnuDebugDataObjectFile != nullptr) { +return m_gnuDebugDataObjectFile; + } labath wrote: > Not a big deal, bu

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218300. kwk marked an inline comment as done. kwk added a comment. - Moved and renamed m_gnu_debug_data_object_file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h:395 + + std::shared_ptr m_gnuDebugDataObjectFile; }; labath wrote: > move this next to other instance variables. Fixed in 0427898acf4

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218374. kwk marked 24 inline comments as done. kwk added a comment. - Remove left-over variable in CMake - Move LLDB_ENABLE_LZMA into Config.h.cmake - Remove unused code - Change signature of lldb_private::lzma::uncompress - Fixup - Fixup - When using the ObjectFi

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath I did go over a lot of your comments. Thank you for helping me in becoming in a better contributor. I'm still not done with the python/make -> lit test transition but the rest is mostly covered. Comment at: lldb/cmake/modules/LLDBConfig.cmake:337

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218618. kwk marked an inline comment as done. kwk added a comment. Herald added a reviewer: alexshap. - add lit test for minidebuginfo - Fixup - test - Fiddle with the lit test - Fix binary in lit test - Working lit test - still need to only run it when minidebugi

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218621. kwk added a comment. - remove not needed include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218623. kwk added a comment. squashed and rebased on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBCon

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. I've tackled the easy comments now and will come back to the more detailed ones as well. I'm not ignoring them. Comment at: lldb/CMakeLists.txt:101 - set(LLDB_TEST_DEPS lldb) + set(LLDB_TEST_DEPS lldb llvm-nm llvm-strip) labath wrot

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219064. kwk marked 16 inline comments as done. kwk added a comment. - Removed not needed test dependencies - Changed return type of lzma::getUncompressedSize - Moved minidebuginfo to subtree that deals with ELF - Apply review comments Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added a comment. labath, please see my answer to your question and maybe help me out why you think I don't test what I want to test. Comment at: lldb/lit/Breakpoint/minidebuginfo-set-and-hit-breakpoint.test:50 + +# RUN: LD_LIBRARY_PATH

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/lit/Breakpoint/minidebuginfo-set-and-hit-breakpoint.test:50 + +# RUN: LD_LIBRARY_PATH=$LD_LIBRARY_PATH:%T %lldb -x -b -o 'b multiplyByThree' -o 'b multiplyByFour' -o 'breakpoint list -v' -o 'run' -

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219369. kwk added a comment. - Remove -x from %lldb because that expands to the command which already includes it - Improve and fix the minidebuginfo-set-and-hit-breakpoint.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath I have greatly improved the set and hit breakpoint test. Thank you again @jankratochvil for bringing my attention to `-Wl,--dynamic-list`. That helped to put one symbol in `.dynsym` explicitly. I will see if I can utilize that knowledge to separate out the patch thi

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk created this revision. kwk added a reviewer: labath. Herald added subscribers: lldb-commits, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a project: LLDB. This change ensures that the .dynsym section will be parsed even when

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 219587. kwk added a comment. - Added llvm-strip to the list of support tools Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked an inline comment as done. kwk added a comment. @JDevlieghere I change the support tool. It was @labath who requested (D66791#inline-601050 ) to outsource this patch. In that change you can find the whole reason which is somewhat more lo

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 219594. kwk marked an inline comment as done. kwk added a comment. - update comment for .symtab section with minidebuginfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 F

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. Fixed the comment as per request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 219605. kwk added a comment. - Rephrase comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-dynsym-alone.c lldb/lit/Mod

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 219677. kwk added a comment. Updated commit message and squashed commits into one rebased onto master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Mod

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

This revision was automatically updated to reflect the committed changes. Closed by commit rL371599: [LLDB][ELF] Load both, .symtab and .dynsym sections (authored by kwk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked 3 inline comments as done. kwk added a comment. @labath I've addressed your comment rewrites in a fixup commit that I've commited without a review (llvm-svn: 371600): https://reviews.llvm.org/rLLDB371600 Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219680. kwk added a comment. Rebased on master to include changes from D67390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: ll

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2711-2731 Section *symtab = section_list->FindSectionByType(eSectionTypeELFSymbolTable, true).get(); -if (!symtab) { - // The

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219848. kwk marked 5 inline comments as done. kwk added a comment. - Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/cmake/modules/L

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @MaskRay I've addressed your comments. Comment at: lldb/source/Host/common/LZMA.cpp:129 + uint64_t uncompressedSize = 0; + auto err = getUncompressedSize(InputBuffer, uncompressedSize); + if (err) labath wrote: > MaskRay wrote: > > if (a

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @stella.stamenova I've reverted this patch and thanks for letting me know. @labath I didn't notice that tests failed, I'm really sorry. @labath how shall we go about this? We do have the situation that when you lookup a symbol you might find it twice if it is in `.dynsym` a

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/lit/Modules/ELF/minidebuginfo-corrupt-xz.yaml:1 +# REQUIRES: system-linux, lzma + labath wrote: > system-linux shouldn't be required here. One of the reasons I wanted to have > the

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 220273. kwk added a comment. - [LLDB][ELF] Fixup for comments in D67390 - Change test expectation to find 2 instead of 1 symbol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/n

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. In D67390#1671018 , @labath wrote: > In D67390#1667270 , @kwk wrote: > > > @labath how shall we go about this? We do have the situation that when you > > lookup a symbol you might find it twice

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @clayborg what address is it exactly to store here `std::map SymbolMapType;`? As an example `dc_symbol.GetAddress().GetFileAddress()` is something that would work but as soon as we have minidebuginfo, then we might end having the same symbol coming from two different object

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @clayborg thank you for this explanation. My patch for minidebuginfo is already done in D66791 . But this one here I was asked to pull out as a separate patch. For good reasons as we see. I wonder how this extra parameter `SymbolMapType` of

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @clayborg are you on IRC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk added a reviewer: jankratochvil. kwk edited the summary of this revision. jankratochvil added a comment. Personally I would check GIT history for some reasons it was written this way. The indica

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

kwk added a comment. @jankratochvil the file only has two revisions: https://github.com/llvm/llvm-project/commits/b9c1b51e45b845debb76d8658edabca70ca56079/lldb/include/lldb/Core/LoadedModuleInfoList.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D67915: [LLDB] Fix logically dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rL372608: [LLDB] Fix logically dead code (authored by kwk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67915?v

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @clayborg @labath I'm still trying to only add symbols when they are unique. Take this already existing test: ./bin/llvm-lit -avv ~/llvm-project/lldb/lit/SymbolFile/DWARF/debug-types-line-tables.s The symbols that are being added at the end of `ObjectFileELF::ParseSymbol

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 221689. kwk added a comment. - [LLDB][ELF] Fixup for comments in D67390 - Change test expectation to find 2 instead of 1 symbol - symbol uniqueness by using elf::ELFSymbol Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 221690. kwk added a comment. - Revert "Change test expectation to find 2 instead of 1 symbol" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. Please wait before reviewing this patch again. I will let you know when things do work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 __

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 221968. kwk added a comment. - Adjust other occurrence of AddSymbol where ELF plays a role - Working tests - Use unordered_set for storing unique elf symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222029. kwk added a comment. - Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-dynsym-alone.c lldb/lit/Modules/ELF/

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222073. kwk added a comment. - Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-dynsym-alone.c lldb/lit/Modules/ELF/

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222075. kwk marked 10 inline comments as done. kwk added a comment. - Change order of compare members to match order of member definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.l

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. Not all is answered now but please respect: https://reviews.llvm.org/D67390#1683705 Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:371-373 + r.st_name = st_name; + return elf::ELFSymbol::operator==(r) && + st_name_string == rhs.st_n

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222076. kwk added a comment. - make the section name part of NamedELFSymbol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-d

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked 9 inline comments as done. kwk added a comment. I think I've finished the implementation now and should have answered all your comments and concerns. I run tests now. I would appreciate if you (@clayborg , @labath , @jankratochvil ) can take a look at this patch again.

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222080. kwk marked an inline comment as done. kwk added a comment. - Use symbol name including @VERSION suffix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lld

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. Interesting. It looks like we indeed have a test (the only one failing atm.) that wants a symbol to be added twice: [ RUN ] MangledTest.NameIndexes_FindFunctionSymbols /home/kkleine/llvm/lldb/unittests/Core/MangledTest.cpp:186: Failure Expected: 1 To be eq

[Lldb-commits] [PATCH] D61368: Fix build URL in new LLDB website

kwk added a comment. In D61368#1485840 , @teemperor wrote: > I just realized that you probably don't have commit access yet, so I'll > commit this for you. Thanks for the patch! Thank you @teemperor ! Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. In D61440#1488174 , @teemperor wrote: > LGTM module some minor code style issues (You removed some `virtual`s but > didn't fix the indentation of the parameters on the next line, see the inline > comments for examples). @teemperor

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. @teemperor I would have loved to use clang-format for this but apparently the LLDB code is still manually formatted. It would be a bliss to just use the LLVM clang-format style and never ever talk about "style" again. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. In D61440#1488450 , @teemperor wrote: > FYI, I still think there are some style issues there (e.g. the > AppleObjCRuntimeV2.cpp change makes it longer than 80 chars) but I can just > clang-format this before committing. > > Otherwise

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. In D61440#1488470 , @teemperor wrote: > Not sure how you invoke git clang-format, but I assume you specified the > wrong commit range... That is correct in this case I've used clang format directly on the whole file. Sorry if that

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. @teemperor I've squashed my commits without the last one that did those many changes in the file `lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp`. I hope at least the result is fine now. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D61440: C.128 override, virtual keyword handling

kwk added a comment. In D61440#1489064 , @teemperor wrote: > Looks good now, thanks! Thank you for being patient with me! Can you merge the change for me please? I don't have commit rights, yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D61483: [www] list command: lldb run

kwk added a comment. In D61483#1489264 , @labath wrote: > This is the old documentation. You should edit the new one in > `docs/use/map.rst`. Oh, good to know. The new documentation is also updated. May I ask why we have two documentation and don't jus

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To ease the adoption of LLDB for users coming from GDB, I've added the command line option `-ex` to the `lldb` binary. It is an alias the the `--one-line` option which > Tells the debugger to execute

<    1   2   3   >