[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

2022-02-07 Thread Khem Raj via Phabricator via lldb-commits
raj.khem added a comment. I tested this patch and it fixes lldb build. Thanks for taking care of this,. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 ___ lldb

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

2021-06-04 Thread Khem Raj via Phabricator via lldb-commits
raj.khem added a comment. http://sprunge.us/FJzZXL is a file from harfbuzz and it warns a.cc:28670:32: error: variable 'supp_size' set but not used [-Werror,-Wunused-but-set-variable] unsigned int size0, size1, supp_size = 0; I do not have -Werror enabled but it still is reported as err

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-05-20 Thread Khem Raj via Phabricator via lldb-commits
raj.khem created this revision. raj.khem added a project: LLDB. Herald added subscribers: JDevlieghere, atanasyan, arichardson, sdardis. raj.khem requested review of this revision. Herald added a subscriber: lldb-commits. This helps fixing lldb-server build regression > /mnt/b/yoe/master/build/tm

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-05-20 Thread Khem Raj via Phabricator via lldb-commits
raj.khem updated this revision to Diff 346855. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102872/new/ https://reviews.llvm.org/D102872 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp Index: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp ==

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-05-21 Thread Khem Raj via Phabricator via lldb-commits
raj.khem added a comment. In D102872#2773106 , @DavidSpickett wrote: > I assume this is caused by the removal of the specific > `NativeRegisterContextLinux_mips` and you are building lldb on MIPS but > you're going to connect to another debug server (g

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

2020-01-06 Thread Khem Raj via Phabricator via lldb-commits
raj.khem added a comment. this is now in master, and I am seeing build failures in cross-building clang, e.g. when building clang for arm on a x86_64 host. its resorting to finding, libz from buildhost instead of target sysroot ( using --sysroot) and failing in link step. e.g. FAILED: bin/llvm

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

2020-01-07 Thread Khem Raj via Phabricator via lldb-commits
raj.khem added a comment. In D70764#1807405 , @smeenai wrote: > In D70764#1803559 , @raj.khem wrote: > > > this is now in master, and I am seeing build failures in cross-building > > clang, e.g. when building clang