https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/96802
This is the same diff I've put up at many times before. I've been trying to add
some brand new functionality to the LLDB test infrastucture, and we all know
that no good deed goes unpunished. The last attempt
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kevinfrei wrote:
> @petrhosek Is there a way you can help @kevinfrei validate this on Fuchsia
Specifically, I'm adding tests that require dwp/llvm-dwp laying around
somewhere, and it looks like Fuchsia doesn't put it in the 'normal' location,
and I have no idea how to simply disable an LLDB te
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/96802
>From 5db458e34f9db981d78bdac0ba18a97d506fb404 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 01/13] Trying to deal with Linux AArch64 test failures :/
---
...
kevinfrei wrote:
> What do you mean by "normal" location?
"normal" as defined by whoever wrote Makefile.rules originally and thought that
was the correct place to file tools like ar and objcopy, I guess? So, on your
build machine, do you know where the llvm-dwp file might be installed? Because
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/96802
>From 4f0477c3ab3bbd6dcd83e755ad484031301b6a82 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 01/13] Trying to deal with Linux AArch64 test failures :/
---
...
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/96802
>From 95832768ffb3b115e95df19ae5ef14231cad32cc Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 01/13] Trying to deal with Linux AArch64 test failures :/
---
...
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/96802
>From 95832768ffb3b115e95df19ae5ef14231cad32cc Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 01/13] Trying to deal with Linux AArch64 test failures :/
---
...
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/96802
>From 95832768ffb3b115e95df19ae5ef14231cad32cc Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 01/13] Trying to deal with Linux AArch64 test failures :/
---
...
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/96802
>From a7894b87df9afa9f22263e4d8ddec955978dea45 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 01/13] Trying to deal with Linux AArch64 test failures :/
---
...
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/96802
>From 790db0c3dece1699a6cc6e670ddd0f7099840386 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 01/13] Trying to deal with Linux AArch64 test failures :/
---
...
kevinfrei wrote:
@JDevlieghere could you stamp this so I can see if I've managed to make the
tests work on the Fuchsia build (which I can't reproduce locally)
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@l
kevinfrei wrote:
Friendly ping @JDevlieghere
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/98101
Reverts llvm/llvm-project#96802
Attempt #5 fails. It's been 6 months. I despise Makefile.rules and have no
ability to even *detect* these failures without _landing_ a diff. In the mean
time, we have no testin
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/98101
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/98344
This is all the tests and fixes I've had percolating since my first attempt at
this in January. After 6 months of trying, I've given up on adding the ability
to test DWP files in LLDB API tests. I've left both
kevinfrei wrote:
@JDevlieghere or @clayborg if one of you could please approve & land this, I
*believe* this disables the tests that caused the previous diff to be reverted.
https://github.com/llvm/llvm-project/pull/98344
___
lldb-commits mailing list
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/98351
This should disable the failing test on the ubuntu build bots @JDevlieghere (I
forgot to disable the 'baseline' test, as it tests the debugger's basic
handling of DWP files, but again, the API infrastructure d
kevinfrei wrote:
"fixed forward" with
[PR98351](https://github.com/llvm/llvm-project/pull/98351/commits) if someone
can approve & land that (it just disabled the baseline test for DWP stuff, as
well: I missed it because the dwp tests run on all the machines I have access
to :/ )
https://gith
kevinfrei wrote:
> @kevinfrei , I'm so sorry to tell you that I have reverted this patch. The
> revert commit is
> [27b2f4f](https://github.com/llvm/llvm-project/commit/27b2f4f861b8aeeabc4eb1a97649062de8fa3992)
> and I left some notes there, which I also copy here:
>
> The patch #98344 causes
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/99362
@walter-erquinigo found the the [PR with testing and a fix for
DebugInfoD](https://github.com/llvm/llvm-project/pull/98344) caused an issue
when working with stripped binaries.
The issue is that when you're w
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/99362
>From 1494617c82065e44617b013c96ba51e578706d75 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 1/2] Trying to deal with Linux AArch64 test failures :/
Reapply "D
@@ -106,12 +106,19 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP
&module_sp,
FileSpec dsym_fspec =
PluginManager::LocateExecutableSymbolFile(module_spec, search_paths);
if (!dsym_fspec || IsDwpSymbolFile(module_sp, dsym_fspec)) {
-// If we have a stripp
kevinfrei wrote:
> This LGTM, although I'd rather have someone like @clayborg taking a look
Yeah, I try not to bug him too much, since he's a coworker and I already get
his time in a few recurring meetings. I might actually try to grab a VC with
him to see if there's some other scenario I'm mi
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/99362
>From b3fe99591b7bc6dad2e9cc46bd4fc2c2f87d1eff Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 1/2] Trying to deal with Linux AArch64 test failures :/
Reapply "D
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/99362
>From f498534a60636a6b8ee06f27dcd04a5074537180 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 1/2] Trying to deal with Linux AArch64 test failures :/
Reapply "D
kevinfrei wrote:
@JDevlieghere I think this still wants your approval. I squashed all the
original commits, but kept the single final change to address the issue Walter
found as a separate commit.
https://github.com/llvm/llvm-project/pull/99362
___
l
kevinfrei wrote:
Ping @JDevlieghere
https://github.com/llvm/llvm-project/pull/99362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -983,6 +1005,73 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(const lldb::addr_t address) {
+ uint8_t buf[4];
+ Status error;
+ size_t byte_read = ReadMemory(address, buf, 4, error);
+ if (byte_read != 4)
+retu
@@ -271,6 +282,17 @@ Status ProcessElfCore::DoLoadCore() {
return error;
}
+void ProcessElfCore::UpdateBuildIdForNTFileEntries() {
+ if (!m_nt_file_entries.empty()) {
kevinfrei wrote:
I'd suggest adding it to that pass as well, though it will be a little b
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/92492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/92492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -117,6 +117,13 @@ class ProcessElfCore : public
lldb_private::PostMortemProcess {
lldb::addr_t end;
lldb::addr_t file_ofs;
std::string path;
+lldb_private::UUID uuid; //.note.gnu.build-id
+ };
+
+ struct Section_Note {
+uint32_t namesz;
+uint32_t d
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/92572
Here we go with attempt #5.
Again, no changes to the LLDB code diffs that have been looked at several times.
For the tests, I added a `@skipIfCurlSupportMissing` annotation so that the
Debuginfod mocked server
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/92572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/92572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/92572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/92572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kevinfrei wrote:
FYI: The previous diff exposed a bug in some ARM code that @DavidSpicket fixed
in #91585, but (for understandable reasons) he didn't want to be left holding
the back on restoring this diff, so I integrated some post-land feedback from
@labath and put the diff back up for revie
@@ -2835,6 +2835,34 @@ void PruneThreadPlans();
AddressRanges &matches, size_t alignment,
size_t max_matches);
+ template
+ lldb::addr_t FindInMemoryGeneric(IT &&iterator, lldb::addr_t low,
+
@@ -0,0 +1,142 @@
+//===-- SymbolLocatorDebuginfod.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/7] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've plumb
@@ -0,0 +1,142 @@
+//===-- SymbolLocatorDebuginfod.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -46,6 +46,10 @@ bool canUseDebuginfod();
/// environment variable.
SmallVector getDefaultDebuginfodUrls();
+/// Sets the list of debuginfod server URLs to query. This overrides the
+/// environment variable DEBUGINFOD_URLS.
+void setDefaultDebuginfodUrls(SmallVector URLs);
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
@@ -47,6 +47,10 @@ namespace llvm {
using llvm::object::BuildIDRef;
+SmallVector DebuginfodUrls;
kevinfrei wrote:
Done
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lis
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/8] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've plumb
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/9] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've plumb
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From fc24f4c0ba2328009796a09ae2c2c925c773af44 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/9] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've plumb
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From 190fb1529bfe0ecdb5e5a30d335ccdca45463c32 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 01/10] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've plu
kevinfrei wrote:
> We need to respect the setting `symbols.enable-external-lookup` and not do
> anything with debuginfod if this is set to false.
>
> You can get this value by calling:
>
> ```
> ModuleList::GetGlobalModuleListProperties().GetEnableExternalLookup()
> ```
>
> Otherwise I fear t
kevinfrei wrote:
> This breaks targeting macOS versions older than 10.12 for unnecessary reasons:
>
> ```
> ../../llvm/lib/Debuginfod/Debuginfod.cpp:54:6: error: 'shared_mutex' is
> unavailable: introduced in macOS 10.12
> std::shared_mutex UrlsMutex;
> ^
> ```
>
> You should be able to u
kevinfrei wrote:
> This change broke building against LLVM dylib:
>
> ```
> /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld:
> cannot find -lLLVMDebuginfod: No such file or directory
> collect2: error: ld returned 1 exit status
> samu: subcommand failed
> ```
>
> Ful
kevinfrei wrote:
> This change broke building against LLVM dylib:
>
> ```
> /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld:
> cannot find -lLLVMDebuginfod: No such file or directory
> collect2: error: ld returned 1 exit status
> samu: subcommand failed
> ```
>
> Ful
kevinfrei wrote:
> > This change broke building against LLVM dylib:
> > ```
> > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld:
> > cannot find -lLLVMDebuginfod: No such file or directory
> > collect2: error: ld returned 1 exit status
> > samu: subcommand failed
> > `
kevinfrei wrote:
> Sounds like some configs don't create `LLVMDebuginfod` target possibly
> because it isn't enabled. Is there a cmake option to disable `LLVMDebuginfod`
> or some magic in the Cmake config file for this target?
Nothing that I could find. The library is written such that if the
kevinfrei wrote:
Is there some documentation that both me & google are missing somewhere? I'm
trying to read between the lines of the scenario that's broken, with nothing
but a log (that refers to a bunch of pretty important configuration files from
somewhere I can't find) with a repo configur
kevinfrei wrote:
I've spent 5 or 6 more hours fighting this and I'm fully stuck on "No Repro". I
have a libLLVM-git18.so built, independent of building LLDB. Then I configured
LLDB to build against that as a standalone entity and validated that it worked
(all on my personal machine, which is r
kevinfrei wrote:
Ran the first script, sudo nina install-distribution, then ran the second
script.
I don't see the build depending on what's been installed, as it looks like
setting LLVM_DIR makes the .so dependency on the binary sitting in the
rel-llvm/lib directory instead.
[build.log.gz](
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/75388
If you type `settings show ` LLDB might crash, depending on the version of
libedit you're compiled with, and whether you're compiled with
`-DLLDB_EDITLINE_USE_WCHAR=0` (and depending on how the optimizer lays
@@ -978,8 +978,14 @@ void Editline::DisplayCompletions(
break;
fprintf(editline.m_output_file, "More (Y/n/a): ");
-char reply = 'n';
-int got_char = el_getc(editline.m_editline, &reply);
+// The type for the output and the type for the parameter are diffe
@@ -978,8 +978,14 @@ void Editline::DisplayCompletions(
break;
fprintf(editline.m_output_file, "More (Y/n/a): ");
-char reply = 'n';
-int got_char = el_getc(editline.m_editline, &reply);
+// The type for the output and the type for the parameter are diffe
kevinfrei wrote:
I'll try to get this together tonight or tomorrow morning.
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kevinfrei wrote:
doBuild.sh:
```
#!/bin/sh
./llvm-config.sh
cd rel-llvm
ninja -v
sudo ninja -v install-distribution
cd ..
./lldb-config.sh
cd rel-lldb
ninja -v
```
llvm-config.sh:
```
#!/bin/sh
cmake -G Ninja \
-B rel-llvm \
-S llvm/llvm \
-DCMAKE_BUILD_TYPE=Release \
-DLLVM_ENABLE_PROJEC
kevinfrei wrote:
Sorry: nice long holiday break. So calling that library a "left over from a
previous build" confuses me. What's the point of the
`-DLLVM_DIR=/home/freik/src/rel-llvm/lib/cmake/llvm` argument to the second
cmake config if not to instruct the build where to find stuff from the f
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/85693
Finally getting back to Debuginfod tests, I've migrated my tests from shell to
API (at @JDevlieghere's suggestion) and addressed a couple issues that came
about during testing.
>From 9713607cd4839ad355c7fd2e7
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/85693
>From 9713607cd4839ad355c7fd2e786ae7eb5a96f637 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Fri, 15 Mar 2024 08:54:04 -0700
Subject: [PATCH 1/3] Tests (w/fixes) for initial DebugInfoD LLDB integration
Summa
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/85693
>From 9713607cd4839ad355c7fd2e786ae7eb5a96f637 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Fri, 15 Mar 2024 08:54:04 -0700
Subject: [PATCH 1/3] Tests (w/fixes) for initial DebugInfoD LLDB integration
Summa
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei converted_to_draft
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/85693
>From 9713607cd4839ad355c7fd2e786ae7eb5a96f637 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Fri, 15 Mar 2024 08:54:04 -0700
Subject: [PATCH 1/4] Tests (w/fixes) for initial DebugInfoD LLDB integration
Summa
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/85693
>From 9713607cd4839ad355c7fd2e786ae7eb5a96f637 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Fri, 15 Mar 2024 08:54:04 -0700
Subject: [PATCH 1/4] Tests (w/fixes) for initial DebugInfoD LLDB integration
Summa
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei closed
https://github.com/llvm/llvm-project/pull/79181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4377,26 +4377,40 @@ const std::shared_ptr
&SymbolFileDWARF::GetDwpSymbolFile() {
FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths();
ModuleSpec module_spec;
module_spec.GetFileSpec() = m_objfile_sp->GetFileSpec();
+FileSpec dwp_filespec;
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/85693
>From 9713607cd4839ad355c7fd2e786ae7eb5a96f637 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Fri, 15 Mar 2024 08:54:04 -0700
Subject: [PATCH 1/5] Tests (w/fixes) for initial DebugInfoD LLDB integration
Summa
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kevinfrei wrote:
@JDevlieghere ping :)
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/85693
>From fc0eda99c7cceeaefd33477c9b08e7221a5a6e2a Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Fri, 15 Mar 2024 08:54:04 -0700
Subject: [PATCH 1/5] Tests (w/fixes) for initial DebugInfoD LLDB integration
Summa
@@ -210,6 +210,12 @@ else
ifeq "$(SPLIT_DEBUG_SYMBOLS)" "YES"
DSYM = $(EXE).debug
endif
+
+ ifeq "$(MERGE_DWOS)" "YES"
kevinfrei wrote:
Updated. It also turns out that MAKE_DWP implies MAKE_DWO, so I removed it from
the test
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/85693
>From fc0eda99c7cceeaefd33477c9b08e7221a5a6e2a Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Fri, 15 Mar 2024 08:54:04 -0700
Subject: [PATCH 1/6] Tests (w/fixes) for initial DebugInfoD LLDB integration
Summa
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/86292
@GeorgeHuyubo noticed an unchecked shared pointer result in
https://github.com/llvm/llvm-project/pull/85693/. This is the fix for that
issue.
>From 6bc82c0820963050752e6faabef7ec10e8c81f2f Mon Sep 17 00:00:00
@@ -44,6 +44,25 @@ llvm::StringRef
SymbolVendorELF::GetPluginDescriptionStatic() {
"executables.";
}
+// If this is needed elsewhere, it can be exported/moved.
+static bool IsDwpSymbolFile(const lldb::ModuleSP &module_sp,
+const FileSpec &
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/86292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kevinfrei wrote:
> New tests apparently are failing on Arm/AArch64 Linux.
The failure indicates that the failing tests' build don't include a UUID, which
*should* be generated by the changes to Makefile.rules. Any idea how I ought to
proceed with reproducing a build on a system that I have no
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/86812
> The previous diff (and it's subsequent fix) were reverted as the tests didn't
> work properly on the AArch64 & ARM LLDB buildbots. I made a couple more minor
> changes to tests (from @clayborg's feedback) an
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/86812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/86812
>From 5e3a35bb69b0bd6c3950deaba35a78c085bc5728 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 1/4] Trying to deal with Linux AArch64 test failures :/
---
.../S
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/86812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kevinfrei wrote:
> I have such a system and have dug into the DebugInfoD "space" recently and
> would be more than willing (eager, even) to help! If you are on the Discord
> server, we can message and find a way to collaborate (I am hawkinsw).
Just joined. I can sort of use Discord (I mentor h
1 - 100 of 175 matches
Mail list logo
