[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 532196. splhack added a comment. - s/AdbClientSP/AdbClientUP/g - Updated `Status &error` arg to `GetAdbClient` - Added error checks in AndroidPlatform for `GetAdbClient` - Added DownloadModuleSliceWithAdbClientError test for the GetAdbClient error Repository

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 532243. splhack added a comment. Rename it to platform.plugin.remote-android.package-name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.package-name

splhack updated this revision to Diff 532245. splhack added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files: lldb/source/Plugins/Platform/Android/CMakeLists.txt

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack added a comment. I will submit a diff to deal with how to use the AdbClient in PlatformAndroid later. Most likely we could use only one instance of AdbClient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0b9605a544d: [lldb][ObjectFileELF] Set ModuleSpec file offset and size (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ htt

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

This revision was automatically updated to reflect the committed changes. Closed by commit rG12dee9d3cd76: [lldb][Android] Support zip .so file (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

This revision was automatically updated to reflect the committed changes. Closed by commit rG49f55b025d81: [lldb][Android] Add PlatformAndroidTest (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.package-name

This revision was automatically updated to reflect the committed changes. Closed by commit rGfabd16c7460e: [lldb][Android] Add platform.plugin.remote-android.package-name (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. ResolveSharedLibraryPathWithZipExisting and ResolveSharedLibraryPathWithZipMissing are failing on Windows. Looking into. https://lab.llvm.org/buildbot/#/builders/219/builds/3674 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D152759 introduced the Android .zip so file support, but it only considered POSIX path.

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. Fixed Windows test failures in D153390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 ___ lldb-comm

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack added a comment. Yes, in fact ZipFileResolverTest is the test what is running on Windows, and failing due to POSIX vs Windows path. This diff will fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llv

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4071d22516: [lldb][Windows] Fix ZipFileResolver tests (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llv

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack added a comment. verified, Windows buildbot is now green. https://lab.llvm.org/buildbot/#/builders/219 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llvm.org/D153390 _

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. RFC https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580 SBFileSpec and SBModuleSpec will be used f

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. RFC https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580 Updated Target::GetOrCreateModule to call

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. RFC https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580 Use SWIG for the target get module callbac

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 534803. splhack added a comment. Move SetTargetGetModuleCallback from Debugger to Platform. https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580/4?u=splhack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 534804. splhack added a comment. Move SetTargetGetModuleCallback from SBDebugger to SBPlatform. https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580/4?u=splhack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added a reviewer: clayborg. splhack updated this revision to Diff 475962. splhack added a comment. splhack published this revision for review. Herald added a project: LLDB. Herald added a subs

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack added a comment. Either way works as long as we can pass the Android serial number to AdbClient.cpp. This diff just followed the current code which is actually already working for USB-connected devices and emulator. So adding TCPIP-connected device support here makes sense. m_device

[Lldb-commits] [PATCH] D139332: [LLDB][Android] Add platform options

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added a reviewer: clayborg. splhack updated this revision to Diff 480112. splhack added a comment. splhack published this revision for review. Herald added a project: LLDB. Herald added a subs

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack added a comment. @clayborg https://reviews.llvm.org/D139332 is the platform Android options version. I'm happy with either of this connect url version https://reviews.llvm.org/D138164 or platform options version https://reviews.llvm.org/D139332. Repository: rG LLVM Github Monorepo

<    1   2