krytarowski added a comment.
I would reject this patch.
http://reviews.llvm.org/D14790
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In http://reviews.llvm.org/D14530#293000, @clayborg wrote:
> This patch was accepted on November 13th. So yes this is ready to land. Not
> sure what you are waiting for?
Thank you for your reply. I cannot land them myself as I'm not a committer.
My latest patches
krytarowski added a comment.
Sorry for problems, I will investigate it.
Repository:
rL LLVM
http://reviews.llvm.org/D14844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
Could you please reference a hyperlink to the breakage? Have we got some
mailing list to monitor it? Jumping over logs in waterfall isn't much
convenient.
Repository:
rL LLVM
http://reviews.llvm.org/D14844
___
lldb-
krytarowski added a comment.
In http://reviews.llvm.org/D14844#293692, @labath wrote:
> If anyone hasn't found the link yet. it's
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653.
> There is no mailing list but you can monitor the webpage containing all
> builtbot
krytarowski added a comment.
In http://reviews.llvm.org/D14844#293787, @tberghammer wrote:
> The problem is that in PlatformNetBSD::Initialize you call
> Platform::SetHostPlatform unconditionally. You want to
> call Platform::SetHostPlatform only if we are running on NetBSD so you have
> to su
krytarowski created this revision.
krytarowski added reviewers: clayborg, emaste.
krytarowski added subscribers: joerg, lldb-commits, sivachandra, tberghammer.
krytarowski set the repository for this revision to rL LLVM.
This should push forward integration of the NetBSD code with others.
This co
krytarowski added a comment.
I've pasted a diff to address this regression as http://reviews.llvm.org/D14876
Please readd NetBSD platform connectors again and see what will happen.
Repository:
rL LLVM
http://reviews.llvm.org/D14844
___
lldb-comm
krytarowski added a comment.
This commit will possible break Xcode too.. but I cannot do anything with it. I
will leave it to MacOSX owners.
Repository:
rL LLVM
http://reviews.llvm.org/D14844
___
lldb-commits mailing list
lldb-commits@lists.llvm
krytarowski added a comment.
Thank you, please land http://reviews.llvm.org/D14530 again.
Repository:
rL LLVM
http://reviews.llvm.org/D14876
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
krytarowski created this revision.
krytarowski added reviewers: clayborg, emaste.
krytarowski added subscribers: lldb-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
It's high time.
Repository:
rL LLVM
http://reviews.llvm.org/D14904
Files:
www/build.html
www/d
---
packages/Python/lldbsuite/test/lldbtest.py | 2 ++
packages/Python/lldbsuite/test/plugins/builder_netbsd.py | 4
2 files changed, 6 insertions(+)
create mode 100644 packages/Python/lldbsuite/test/plugins/builder_netbsd.py
diff --git a/packages/Python/lldbsuite/test/lldbtes
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
For the reference, there was availability outage during this weekend
on reviews.llvm.org. I was suggested to send a patch to this mailing
list as a fall-back.
Please review and merge with the LLDB sources.
On 22.11.2015 17:23, Kamil Rytarowski via
krytarowski removed rL LLVM as the repository for this revision.
krytarowski updated this revision to Diff 41102.
krytarowski added a comment.
Readd accidently removed section.
http://reviews.llvm.org/D14904
Files:
www/build.html
www/download.html
www/index.html
www/status.html
www/te
krytarowski created this revision.
krytarowski added reviewers: emaste, tfiala.
krytarowski added subscribers: joerg, lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
This is used in tests.
Repository:
rL LLVM
http://reviews.llvm.org/D15065
Files:
packages/Python/l
krytarowski created this revision.
krytarowski added reviewers: clayborg, emaste.
krytarowski added subscribers: joerg, lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Other platform parts needed to build this code are already merged.
2nd attempt.
Repository:
rL LLVM
krytarowski added a comment.
In http://reviews.llvm.org/D15065#298279, @zturner wrote:
> This doesn't look substantially different than builder_freebsd. Assuming
> there is no practical difference, how about just using that for both
> freebsd and netbsd?
The linux2, win32 and freebsd targets
krytarowski added a comment.
@labath feel free to disagree with the regex files. It was copied from LLVM. If
you disagree, help me please to export it in LLVM build for everybody or find a
better solution.
pkgsrc-wip commit affirming that it works:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pk
krytarowski updated this revision to Diff 41366.
krytarowski added a comment.
Upload the proper latest patch.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
Files:
cmake/modules/LLDBStandalone.cmake
scripts/CMakeLists.txt
source/Utility/CMakeLists.txt
tools/lldb-mi/MIUtilParse.h
krytarowski added a comment.
In http://reviews.llvm.org/D15067#298701, @Eugene.Zelenko wrote:
> I build LLVM/Clang with LLVM_ENABLE_WARNINGS=ON, so I'll need to use
> llvm-config from build directory. I'm not sure how well find_program will
> work if path to /bin will be not added to PATH, so p
Author: kamil
Date: Fri Dec 4 15:23:24 2015
New Revision: 254768
URL: http://llvm.org/viewvc/llvm-project?rev=254768&view=rev
Log:
Fix typo in a comment
Modified:
lldb/trunk/source/Core/IOHandler.cpp
Modified: lldb/trunk/source/Core/IOHandler.cpp
URL:
http://llvm.org/viewvc/llvm-project/ll
Author: kamil
Date: Sat Dec 5 12:46:56 2015
New Revision: 254853
URL: http://llvm.org/viewvc/llvm-project?rev=254853&view=rev
Log:
Define new builder_netbsd
Summary: This is used in tests.
Reviewers: emaste, tfiala, clayborg
Subscribers: zturner, lldb-commits, joerg
Differential Revision: htt
Author: kamil
Date: Sat Dec 5 13:41:37 2015
New Revision: 254858
URL: http://llvm.org/viewvc/llvm-project?rev=254858&view=rev
Log:
Document NetBSD platform support on the webpage
Summary: It's high time.
Reviewers: emaste, clayborg
Subscribers: labath, joerg, lldb-commits
Differential Revisio
Author: kamil
Date: Sat Dec 5 15:46:37 2015
New Revision: 254865
URL: http://llvm.org/viewvc/llvm-project?rev=254865&view=rev
Log:
Plug-in PlatformNetBSD initializer and terminator
Summary: Other platform parts needed to build this code are already merged.
Reviewers: emaste, clayborg
Subscribe
krytarowski created this revision.
krytarowski added reviewers: emaste, tfiala, clayborg.
krytarowski added subscribers: joerg, lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
The getwd() and getcwd() functions conform to IEEE Std 1003.1-1990
(``POSIX.1''). The IEEE Std
krytarowski created this revision.
krytarowski added reviewers: emaste, clayborg, tfiala.
krytarowski added subscribers: lldb-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
The base make(1) on NetBSD is BSD make.
In the default installation of NetBSD GNU make comes v
krytarowski created this revision.
krytarowski added reviewers: tfiala, joerg, emaste, clay.chang.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Add new functions:
- expectedFailureNetBSD()
- expectedFlakeyNetBSD()
- skipIfNetBSD(
krytarowski created this revision.
krytarowski added reviewers: clayborg, emaste, tfiala.
krytarowski added subscribers: joerg, lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
NetBSD soon will reuse this featur while running tests.
Repository:
rL LLVM
http://reviews.
krytarowski updated the summary for this revision.
krytarowski updated this revision to Diff 42013.
Repository:
rL LLVM
http://reviews.llvm.org/D15262
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/test/lldbtest.py
krytarowski updated this revision to Diff 42014.
Repository:
rL LLVM
http://reviews.llvm.org/D15262
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lld
Author: kamil
Date: Mon Dec 7 15:21:12 2015
New Revision: 254944
URL: http://llvm.org/viewvc/llvm-project?rev=254944&view=rev
Log:
getwd(3) with NULL pointer extension is supported on NetBSD
Summary:
The getwd() and getcwd() functions conform to IEEE Std 1003.1-1990
(POSIX.1). The IEEE Std 1003
Author: kamil
Date: Mon Dec 7 15:24:25 2015
New Revision: 254947
URL: http://llvm.org/viewvc/llvm-project?rev=254947&view=rev
Log:
Return gmake as the default name for GNU make on NetBSD
Summary:
The base make(1) on NetBSD is BSD make.
In the default installation of NetBSD GNU make comes via pk
Author: kamil
Date: Mon Dec 7 15:25:57 2015
New Revision: 254948
URL: http://llvm.org/viewvc/llvm-project?rev=254948&view=rev
Log:
Add initial NetBSD support in lldbsuite/test/lldbtest.py
Summary:
Add new functions:
- expectedFailureNetBSD()
- expectedFlakeyNetBSD()
- skipIfNetBSD()
Add
Author: kamil
Date: Mon Dec 7 15:26:56 2015
New Revision: 254949
URL: http://llvm.org/viewvc/llvm-project?rev=254949&view=rev
Log:
Add NetBSD in platform specific logging of the specified category in
RegisterCommandsTestCase()
Summary: NetBSD soon will reuse this feature while running tests.
R
krytarowski added a comment.
Thank you!
Repository:
rL LLVM
http://reviews.llvm.org/D15261
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
Thank you!
Repository:
rL LLVM
http://reviews.llvm.org/D15260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
Thank you!
Repository:
rL LLVM
http://reviews.llvm.org/D15263
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
Thank you!
Repository:
rL LLVM
http://reviews.llvm.org/D15262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski created this revision.
krytarowski added reviewers: emaste, joerg, clay.chang, tfiala.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Herald added a subscriber: emaste.
NetBSD is like FreeBSD and Linux in these routines.
Repo
krytarowski updated this revision to Diff 42372.
krytarowski added a comment.
Strip zero character from platform name
Repository:
rL LLVM
http://reviews.llvm.org/D15374
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/test/lldbtest.py
Author: kamil
Date: Thu Dec 10 16:56:56 2015
New Revision: 255308
URL: http://llvm.org/viewvc/llvm-project?rev=255308&view=rev
Log:
Add NetBSD support in the buildDriver and buildLibrary routines
Summary: NetBSD is like FreeBSD and Linux in these routines.
Reviewers: clay.chang, tfiala, emaste,
krytarowski added a comment.
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D15374
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
I had this working with 2.8:
--- source/Plugins/SymbolFile/PDB/CMakeLists.txt.orig 2016-04-27
00:55:50.0 +
+++ source/Plugins/SymbolFile/PDB/CMakeLists.txt
@@ -1,7 +1,11 @@
-set(LLVM_PRIVATE_LINK_COMPONENTS
-DebugInfoPDB)
+#set(LLVM_PRIV
krytarowski added a comment.
In http://reviews.llvm.org/D19685#417896, @zturner wrote:
> I don't think we should be adding more CMake hacks in lldb when llvm is
> supposed to handle this. Why don't the existing lines work?
I don't know. Perhaps because LLVM and Clang requires newer cmake than
krytarowski updated this revision to Diff 55729.
krytarowski added a comment.
Set minimal required CMake to 2.8.12.2 - fixes build on NetBSD with CMake 3.5.2
Repository:
rL LLVM
http://reviews.llvm.org/D19685
Files:
CMakeLists.txt
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/
krytarowski created this revision.
krytarowski added reviewers: emaste, labath, zturner.
krytarowski added subscribers: lldb-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
NetBSD ships with pkgsrc that installs versioned Python executables with
suffix, like: python2.
krytarowski added a comment.
In http://reviews.llvm.org/D19685#417911, @zturner wrote:
> Can't you just remove that line and let it inherit the minimum version from
> LLVM?
It doesn't work.
CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present. A line of c
krytarowski added a comment.
In http://reviews.llvm.org/D19772#417922, @zturner wrote:
> Don't we already call FindPythonInterp from somewhere else in the LLDB's
> CMake files?
$ git grep FindPythonInterp
cmake/modules/LLDBStandalone.cmake:include(FindPythonInterp)
scripts/Python/m
krytarowski added a comment.
In http://reviews.llvm.org/D19685#417919, @zturner wrote:
> Ahh ok. Well setting it to 2.8.12 is still fine, if that fixes the problem
> with no other changes then that seems like the best fix.
No other changes are needed.
Repository:
rL LLVM
http://reviews.l
krytarowski added a comment.
I'm using standalone build, it may be the reason why this value isn't inherited.
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
krytarowski added a comment.
If the change should go to LLDBStandalone.cmake -- can I just put there in one
go all the bits for standalone builds?
--- cmake/modules/LLDBStandalone.cmake.orig 2016-04-27 00:55:49.0
+
+++ cmake/modules/LLDBStandalone.cmake
@@ -2,61 +2,82 @@
krytarowski added a comment.
Great! I think I will close
In http://reviews.llvm.org/D19772#417952, @zturner wrote:
> I'm not sure anyone else uses the standalone build, so as long as the
> changes you're making are confined to LLDBStandalone, it should be fine
Thanks!
I think I can close thi
krytarowski added a comment.
Thanks, since it has been accepted. I will commit it and move to LLDBStandalone.
Repository:
rL LLVM
http://reviews.llvm.org/D19685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: kamil
Date: Sun May 1 05:23:24 2016
New Revision: 268191
URL: http://llvm.org/viewvc/llvm-project?rev=268191&view=rev
Log:
Fix NetBSD build with CMake 3.5.2
Summary:
Building HEAD of LLDB fails in linking against DebugInfoPDB. It also prints the
following warning:
```
CMake Warning (de
krytarowski abandoned this revision.
krytarowski added a comment.
This change will be merged into http://reviews.llvm.org/D15067
Repository:
rL LLVM
http://reviews.llvm.org/D19772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
krytarowski updated this revision to Diff 55742.
krytarowski added a comment.
Revamp the patch and reduce it only to the CMake part.
Leave regex code for later.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
Files:
cmake/modules/LLDBStandalone.cmake
Index: cmake/modules/LLDBStandalon
krytarowski added a comment.
please take a look @zturner @labath
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added inline comments.
Comment at: cmake/modules/LLDBStandalone.cmake:85
@@ -63,3 +84,3 @@
if (PYTHON_EXECUTABLE STREQUAL "")
set(Python_ADDITIONAL_VERSIONS 3.5 3.4 3.3 3.2 3.1 3.0 2.7 2.6 2.5)
When I am including conditionally `include(FindP
krytarowski added a comment.
In http://reviews.llvm.org/D15067#419632, @labath wrote:
> Looks good.
Thanks!
Are you accepting it with the patch in `scripts/CMakeLists.txt` as noted in the
comment?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
krytarowski added a comment.
I'm going to test NetBSD.
http://reviews.llvm.org/D20106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In http://reviews.llvm.org/D15067#419964, @labath wrote:
> Good question. I don't really have an opinion on that... Is it just that
> single line? (this would be simpler if you uploaded the final version :) ).
> If it just that single line, then I think it's fine. I
krytarowski retitled this revision from "Design building out of sources" to
"Add CMake bits necessary for standalone build".
krytarowski updated this revision to Diff 56970.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
Files:
cmake/modules/LLDBStandalone.cmake
scripts/CMakeLists.txt
krytarowski added a comment.
Updated. Can I commit it this way as it is?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote:
> I would like to see implemented my comment about LLVM_CONFIG and
> find_program().
Could you first push this to clang? I don't want to drift from clang myself.
Repository:
rL LLVM
http://review
krytarowski created this revision.
krytarowski added reviewers: emaste, clayborg.
krytarowski added subscribers: lldb-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
The editline(3) library in NetBSD is by default internally wide.
Repository:
rL LLVM
http://reviews
krytarowski removed rL LLVM as the repository for this revision.
krytarowski updated this revision to Diff 57011.
http://reviews.llvm.org/D20188
Files:
include/lldb/Host/Editline.h
Index: include/lldb/Host/Editline.h
===
--- inclu
krytarowski added a comment.
I changed the string to "some platforms".
http://reviews.llvm.org/D20188
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
@Eugene.Zelenko do you agree with this patch and what @labath wrote?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: kamil
Date: Thu May 12 14:46:08 2016
New Revision: 269330
URL: http://llvm.org/viewvc/llvm-project?rev=269330&view=rev
Log:
Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD
Summary: The editline(3) library in NetBSD is by default internally wide.
Reviewers: clayborg, emaste
Subscribers: joerg,
Author: kamil
Date: Thu May 12 14:49:17 2016
New Revision: 269332
URL: http://llvm.org/viewvc/llvm-project?rev=269332&view=rev
Log:
Add CMake bits necessary for standalone build
Summary: Developed on NetBSD with pkgsrc.
Reviewers: zturner, labath
Subscribers: jevinskie, zturner, tfiala, Eugene.
krytarowski resigned from this revision.
krytarowski removed a reviewer: krytarowski.
krytarowski added a comment.
This patch looks dead -- no activity.
Repository:
rL LLVM
http://reviews.llvm.org/D14182
___
lldb-commits mailing list
lldb-commits
krytarowski created this revision.
krytarowski added reviewers: joerg, emaste, clayborg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
NetBSD 7.0 ships with too old libstdc++ and it lacks .
It's no longer true in the current version --
krytarowski abandoned this revision.
krytarowski added a comment.
I'm giving up on LLDB in NetBSD-7.0, I'm working on upcoming NetBSD-8.0.
Repository:
rL LLVM
http://reviews.llvm.org/D20224
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
krytarowski added a subscriber: krytarowski.
krytarowski added a comment.
Looks good, however could we merge firstly Plugins/Process/NetBSD
http://reviews.llvm.org/D20274 ? Otherwise I will need to keep syncing my patch
forever for generic changes.
Thanks!
http://reviews.llvm.org/D20278
__
krytarowski added a comment.
There is `Mutex::` used in my code. And it's going to be removed soon.
http://reviews.llvm.org/D20278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
> Does remote debugging interest you?
Yes.
However, on the other hand it's low priority for me right now. I will rebase to
FreeBSD once I will get improved system support in ptrace(2) and functional
process/core instrumentation.
Repository:
rL LLVM
http://rev
krytarowski added a comment.
I'm going to test it now.
Repository:
rL LLVM
http://reviews.llvm.org/D20344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski accepted this revision.
krytarowski added a comment.
It works for me.
Repository:
rL LLVM
http://reviews.llvm.org/D20344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
krytarowski added a comment.
NetBSD is using newer libstdc++.
#include
std::set s = std::set(std::allocator());
int main() { return 0; }
Compiles (I need to specify the -std=c++11 option) and runs.
I will try it out in the context of LLDB CMake scripts.
http://reviews.llvm.org/D20671
krytarowski abandoned this revision.
krytarowski added a comment.
It no longer builds due to mutex refactoring. Remove as it will need to be
redone for remote debugging.
Repository:
rL LLVM
http://reviews.llvm.org/D20274
___
lldb-commits mailing
krytarowski created this revision.
krytarowski added reviewers: labath, zturner.
krytarowski added subscribers: lldb-commits, llvm-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
LLVM doesn't install "CheckAtomic" cmake file, so add it locally.
Bump required CMake vers
krytarowski added a comment.
In https://reviews.llvm.org/D22999#501999, @tberghammer wrote:
> I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as
> the 2 copy will diverge over time and cause extra maintenance cost. What do
> you think about trying to change LLVM to in
krytarowski added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D22999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In https://reviews.llvm.org/D23830#524039, @labath wrote:
> @krytarowski: I thought I'd switch netbsd as well, as all the other platforms
> are doing it already. However, if you want to stick with the system demangler
> by default, I can easily change it to OFF ...
krytarowski added a subscriber: joerg.
krytarowski added a comment.
Looks OK for NetBSD. @joerg are you fine with this?
https://reviews.llvm.org/D23830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
krytarowski added a comment.
The proper way to fix it is to install CheckAtomic from LLVM/Clang.
See https://reviews.llvm.org/D22999
Repository:
rL LLVM
https://reviews.llvm.org/D23881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
krytarowski added a comment.
In https://reviews.llvm.org/D23881#525405, @mgorny wrote:
> In https://reviews.llvm.org/D23881#525401, @krytarowski wrote:
>
> > The proper way to fix it is to install CheckAtomic from LLVM/Clang.
> >
> > See https://reviews.llvm.org/D22999
>
>
> Wasn't that rejected?
krytarowski abandoned this revision.
krytarowski added a comment.
Will be addressed in LLVM/Clang.
Repository:
rL LLVM
https://reviews.llvm.org/D22999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
krytarowski added a comment.
In https://reviews.llvm.org/D23881#525420, @mgorny wrote:
> In https://reviews.llvm.org/D23881#525411, @krytarowski wrote:
>
> > In https://reviews.llvm.org/D23881#525405, @mgorny wrote:
> >
> > > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote:
> > >
>
krytarowski added a subscriber: krytarowski.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_N
On NetBSD /usr/share/misc/style says:
/*
* Kernel include files come first.
*/
#include /* first, */
#include /* next, */
#include /* and then the rest, */
#include /* sorted lexicographically. */
#include
#include /* Non-local incl
krytarowski added a comment.
It looks good. Remaining TODO for standalone builds:
- sanitize six.py usage (it's installed into system-wide directory, where
standard py-six lands)
- bump cmake_minimum_required(VERSION 2.8.12.2) to 3.4.3 in
cmake/modules/LLDBStandalone.cmake
Final bits for Windo
krytarowski added a comment.
In https://reviews.llvm.org/D23883#539471, @mgorny wrote:
> In https://reviews.llvm.org/D23883#539442, @krytarowski wrote:
>
> > It looks good. Remaining TODO for standalone builds:
> >
> > - sanitize six.py usage (it's installed into system-wide directory, where
> >
krytarowski added a subscriber: krytarowski.
krytarowski added a comment.
There are no debug registers supported right now on NetBSD and I was forced to
duplicate the code. It's on TODO and I prefer to streamline the kernel.
Repository:
rL LLVM
https://reviews.llvm.org/D24694
Author: kamil
Date: Tue Sep 20 17:26:29 2016
New Revision: 282032
URL: http://llvm.org/viewvc/llvm-project?rev=282032&view=rev
Log:
Unbreak the NetBSD build after recent changes
Similar to r281922 "Try to fix freebsd and android builds."
Replace .AppendArgument(cstr) with .AppendArgument(llvm::S
krytarowski created this revision.
krytarowski added reviewers: joerg, emaste.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Signals 1-32 are matching the default UNIX platform.
There are platform specific ones above 32.
From the `/usr
krytarowski added a comment.
Thank you. After fixing the order I'm going to land this diff.
Comment at: source/Plugins/Process/Utility/CMakeLists.txt:6
@@ -5,2 +5,3 @@
FreeBSDSignals.cpp
+ NetBSDSignals.cpp
GDBRemoteSignals.cpp
emaste wrote:
> Should keep
krytarowski added inline comments.
Comment at: source/Target/UnixSignals.cpp:66
@@ -64,4 +65,3 @@
case llvm::Triple::FreeBSD:
case llvm::Triple::OpenBSD:
return std::make_shared();
emaste wrote:
> Not part of your change, but just sp
krytarowski updated this revision to Diff 42800.
krytarowski added a comment.
Improve abc order of source files
Repository:
rL LLVM
http://reviews.llvm.org/D15482
Files:
source/Plugins/Process/Utility/CMakeLists.txt
source/Plugins/Process/Utility/NetBSDSignals.cpp
source/Plugins/Proces
Author: kamil
Date: Mon Dec 14 18:50:19 2015
New Revision: 255592
URL: http://llvm.org/viewvc/llvm-project?rev=255592&view=rev
Log:
Welcome to NetBSD signals
Summary:
Signals 1-32 are matching the default UNIX platform.
There are platform specific ones above 32.
From the `/usr/include/sys/signa
101 - 200 of 274 matches
Mail list logo
