If this is just for one controlled test
> whose arguments are guaranteed to no ever have any quotes or desensitized
> spaces like:
>
> hello\ world
>
> Then it is ok, but not ok to just call the small new "split" function you
> added a replacement for shlex?
>
>
Author: jdevlieghere
Date: Wed Apr 17 18:37:19 2019
New Revision: 358635
URL: http://llvm.org/viewvc/llvm-project?rev=358635&view=rev
Log:
[Shell] Simplify Extracting Python Version
Instead of parsing the Python version with a fairly convoluted regex,
just print the major and minor version and ca
Author: jdevlieghere
Date: Thu Apr 18 10:31:20 2019
New Revision: 358693
URL: http://llvm.org/viewvc/llvm-project?rev=358693&view=rev
Log:
[Docs] Add LLDB bots
Added:
lldb/trunk/docs/resources/bots.rst
Modified:
lldb/trunk/docs/index.rst
Modified: lldb/trunk/docs/index.rst
URL:
http://l
Author: jdevlieghere
Date: Fri Apr 19 11:02:35 2019
New Revision: 358773
URL: http://llvm.org/viewvc/llvm-project?rev=358773&view=rev
Log:
[Docs] Make Doxygen functional
This fixes the doxygen configuration to be functional again. I removed
the customer header and footer, as well as the no-longer
Author: jdevlieghere
Date: Fri Apr 19 12:03:58 2019
New Revision: 358777
URL: http://llvm.org/viewvc/llvm-project?rev=358777&view=rev
Log:
[Docs] Add more info about building the docs
Including the C++ and Python reference.
Modified:
lldb/trunk/docs/resources/build.rst
Modified: lldb/trunk/
Author: jdevlieghere
Date: Fri Apr 19 15:37:55 2019
New Revision: 358792
URL: http://llvm.org/viewvc/llvm-project?rev=358792&view=rev
Log:
[Tests] Split float test into float and doubles
As I was waiting for the test suite to complete at 99% I noticed this
test taking quite a bit of time. Since i
Author: jdevlieghere
Date: Mon Apr 22 13:05:02 2019
New Revision: 358916
URL: http://llvm.org/viewvc/llvm-project?rev=358916&view=rev
Log:
[Reproducers] Fix lifetime issue
Deallocating the data recorder in during the ::Keep() operation causes
problems down the line when exiting the debugger. The
Author: jdevlieghere
Date: Mon Apr 22 15:41:55 2019
New Revision: 358928
URL: http://llvm.org/viewvc/llvm-project?rev=358928&view=rev
Log:
[Docs] Move API docs to the front page
This moves the links to the C++ and Python API docs up to the main page.
As of now the links are still broken [1], but
Author: jdevlieghere
Date: Tue Apr 23 08:57:47 2019
New Revision: 359004
URL: http://llvm.org/viewvc/llvm-project?rev=359004&view=rev
Log:
[Docs] Add 301 redirects for old URLs
Added:
lldb/trunk/docs/.htaccess
Modified:
lldb/trunk/docs/conf.py
Added: lldb/trunk/docs/.htaccess
URL:
http:
Author: jdevlieghere
Date: Tue Apr 23 09:00:43 2019
New Revision: 359005
URL: http://llvm.org/viewvc/llvm-project?rev=359005&view=rev
Log:
[Docs] Add missing leading slash
Modified:
lldb/trunk/docs/.htaccess
Modified: lldb/trunk/docs/.htaccess
URL:
http://llvm.org/viewvc/llvm-project/lldb/t
Author: jdevlieghere
Date: Tue Apr 23 10:44:40 2019
New Revision: 359016
URL: http://llvm.org/viewvc/llvm-project?rev=359016&view=rev
Log:
[Reproducers] Limit logging to calls that cross the API boundary.
We recently moved API logging into the instrumentation macros. This made
that logging is now
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/97043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
LGTM. This has definitely come up in the past. If you feel motivated, I'm sure
there must be a way to detect this issue in Python and we could have
assert/warning/error that captures this at the dotest level.
https://github.com/llvm/llvm-project/pull/97043
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/94794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,17 +90,9 @@ void InstrumentationRuntimeASanLibsanitizers::Activate() {
if (!process_sp)
return;
- lldb::ModuleSP module_sp = GetRuntimeModuleSP();
-
Breakpoint *breakpoint = ReportRetriever::SetupBreakpoint(
- module_sp, process_sp, ConstString("sanitizer
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/94794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> > > LGTM. This has definitely come up in the past. If you feel motivated, I'm
> > > sure there must be a way to detect this issue in Python and we could have
> > > assert/warning/error that captures this at the dotest level.
> >
> >
> > Agreed, making it part of `dotest`
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/97126
This is an improved attempt to improve the semantics of SupportFile
equivalence, taking into account the feedback from #95606.
Pavel's comment about the lack of a concise name because the concept isn't
tri
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/97300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/97126
>From 0c39366879c56ceb0ef6b021d8098bc73e26445b Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 28 Jun 2024 16:50:05 -0700
Subject: [PATCH 1/2] [lldb] Make semantics of SupportFile equivalence exp
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/97126
>From 0c39366879c56ceb0ef6b021d8098bc73e26445b Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 28 Jun 2024 16:50:05 -0700
Subject: [PATCH 1/3] [lldb] Make semantics of SupportFile equivalence exp
https://github.com/JDevlieghere commented:
I'm excited to see these extension points getting documented! What would make
this even more valuable is having a page that documents all of LLDB's extension
points (and explains the duality between scripting LLDB interactions vs
scripting LLDB's beha
@@ -11,6 +11,65 @@ some of these things by going through an example, explaining
how to use
Python scripting to find a bug in a program that searches for text in a
large binary tree.
+Operating System Thread Plugins
+---
+
+.. automodapi:: lldb.plug
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/97262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -75,7 +75,7 @@ def __init__(self):
class Pipe(object):
def __init__(self, prefix):
while True:
-self.name = "lldb-" + str(random.randrange(1e10))
+self.name = "lldb-" + str(random.randrange(int(1e10)))
Author: Jonas Devlieghere
Date: 2024-07-01T11:34:05-07:00
New Revision: 0323d8d83ccad9a74df36d2662e96aa0f56e3060
URL:
https://github.com/llvm/llvm-project/commit/0323d8d83ccad9a74df36d2662e96aa0f56e3060
DIFF:
https://github.com/llvm/llvm-project/commit/0323d8d83ccad9a74df36d2662e96aa0f56e3060.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/97126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/96983
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/issues/97380#issuecomment-2203028709
https://github.com/llvm/llvm-project/pull/97381
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/97490
Currently, LLDB prints out a rather unhelpful error message when passed a file
that it doesn't recognize as an executable.
> error: '/path/to/file' doesn't contain any 'host' platform
> architectures: arm64
Author: Jonas Devlieghere
Date: 2024-07-03T09:03:47-07:00
New Revision: f057130b169fe551b1fec6633fadba26ef19bcdd
URL:
https://github.com/llvm/llvm-project/commit/f057130b169fe551b1fec6633fadba26ef19bcdd
DIFF:
https://github.com/llvm/llvm-project/commit/f057130b169fe551b1fec6633fadba26ef19bcdd.d
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/97555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,13 +18,10 @@
using namespace lldb;
using namespace lldb_private;
-Listener::Listener(const char *name)
-: m_name(name), m_broadcasters(), m_broadcasters_mutex(), m_events(),
- m_events_mutex(), m_is_shadow() {
+Listener::Listener(const char *name) : m_name(name
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/97555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/97552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -518,6 +518,15 @@ void CommandInterpreter::Initialize() {
AddAlias("re", cmd_obj_sp);
}
+ cmd_obj_sp = GetCommandSPExact("scripting execute");
+ if (cmd_obj_sp) {
+AddAlias("sc", cmd_obj_sp);
+AddAlias("scr", cmd_obj_sp);
+AddAlias("scri", cmd_obj_sp);
+
@@ -80,7 +80,13 @@ def test_command_abbreviations_and_aliases(self):
# Check a command that wants the raw input.
command_interpreter.ResolveCommand(r"""sc print("\n\n\tHello!\n")""",
result)
self.assertTrue(result.Succeeded())
JDevliegh
JDevlieghere wrote:
> The reason behind this change is to have a top-level command that will cover
> scripting related subcommands.
Which other scripting subcommands do you envision, besides the
[template](https://github.com/llvm/llvm-project/pull/97273) subcommand?
https://github.com/llvm/l
@@ -487,6 +487,33 @@ class PluginManager {
static LanguageSet GetAllTypeSystemSupportedLanguagesForExpressions();
+ // Scripted Interface
+ static bool
+ RegisterPlugin(llvm::StringRef name, llvm::StringRef description,
+ ScriptedInterfaceCreateInstance c
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -29,6 +29,9 @@ add_subdirectory(UnwindAssembly)
set(LLDB_STRIPPED_PLUGINS)
get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS)
+get_property(LLDB_EXTRA_PLUGINS GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS)
+list(APPEND LLDB_ALL_PLUGINS ${LLDB_EXTRA_PLUGINS})
--
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -124,6 +124,10 @@ typedef lldb::REPLSP (*REPLCreateInstance)(Status &error,
lldb::LanguageType language,
Debugger *debugger, Target *target,
const
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
@@ -68,6 +68,13 @@ class ScriptedInterface {
return true;
}
+ static bool
+ CreateInstance(lldb::ScriptLanguage language,
+ std::vector command_interpreter_usages,
+ std::vector api_usages) {
+return false;
+ }
JDev
@@ -487,6 +487,33 @@ class PluginManager {
static LanguageSet GetAllTypeSystemSupportedLanguagesForExpressions();
+ // Scripted Interface
+ static bool
+ RegisterPlugin(llvm::StringRef name, llvm::StringRef description,
+ ScriptedInterfaceCreateInstance c
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/97490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/98089
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/98041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/98344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/98344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM.
As a nice to have, maybe add a short explanation to the first mutex explaining
that these operations are only allowed between thread lists belonging to the
same process. Your current comment makes it sound as if that only appli
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/98293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/98388
The memory read can fail for a malformed fileset. Handle it gracefully instead
of passing a nullptr to the std::string constructor.
rdar://131477833
>From 30f9ae1d2a086e7cf6ef713cc1e7ca91490169e5 Mon Sep 1
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/98388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/98420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
This is looking good, but needs a (pexpect) test. I would also like to add a
setting to make the prefix and suffix configurable, like we do for things like
`show-progress-ansi-prefix` and `show-autosuggestion-ansi-prefix`. That way
user can pick their
https://github.com/JDevlieghere approved this pull request.
This is more robust and I like that it doesn't risk breaking the clang resource
directory path. LGTM.
https://github.com/llvm/llvm-project/pull/98464
___
lldb-commits mailing list
lldb-commi
JDevlieghere wrote:
That was an oversight. Thanks for restoring this. LGTM.
https://github.com/llvm/llvm-project/pull/98623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/98623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
CC @clayborg as this probably explains the Android debugging regression.
https://github.com/llvm/llvm-project/pull/98623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/98566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/98975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/98976
The help output incorrectly states that this command takes a shared library
name () while really it takes a path to a symbol file.
rdar://131777043
>From 6cc124159e40ca432eba328828c04a9f3d66f103 Mon Sep 17
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/99535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,194 @@
+//===--- DirectToIndirectFCR.cpp - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -163,11 +166,83 @@ TotalArgsSizeInWords(bool is_rv64,
return total_size;
}
+static bool UpdateRegister(RegisterContext *reg_ctx,
+ const lldb::RegisterKind reg_kind,
+ const uint32_t reg_num, const addr_t value) {
+ Log
@@ -0,0 +1,194 @@
+//===--- DirectToIndirectFCR.cpp - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere requested changes to this pull request.
This PR does two things that are orthogonal, therefore they should be separate
PRs. Please omit the whitespace changes (those can be addressed separately as
well). Also, please make sure to have a self contained PR descript
https://github.com/JDevlieghere approved this pull request.
Neat
https://github.com/llvm/llvm-project/pull/99721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/99909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -127,6 +130,157 @@ class CommandObjectScriptingRun : public CommandObjectRaw
{
CommandOptions m_options;
};
+#pragma mark CommandObjectScriptingTemplateList
+
+#define LLDB_OPTIONS_scripting_template_list
+#include "CommandOptions.inc"
+
+class CommandObjectScriptingTemp
https://github.com/JDevlieghere approved this pull request.
LGTM modulo comment.
https://github.com/llvm/llvm-project/pull/97273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/7
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-07-23T11:29:12-07:00
New Revision: 34e67ffe1947b399f57002f8cf60340a391ce8c0
URL:
https://github.com/llvm/llvm-project/commit/34e67ffe1947b399f57002f8cf60340a391ce8c0
DIFF:
https://github.com/llvm/llvm-project/commit/34e67ffe1947b399f57002f8cf60340a391ce8c0.d
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/100421
Prevent passing a nullptr to std::string::insert in
ObjectFileMachO::GetDependentModules. Calling GetCString on an empty
ConstString will return a nullptr, which is undefined behavior. Instead,
use the GetSt
JDevlieghere wrote:
This PR looks scarier than it is because it contains an NFC commit that
introduces an early return to save a level of indentation. I recommend
reviewing the two commits separately and/or ignoring whitespace changes.
https://github.com/llvm/llvm-project/pull/100421
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/100288
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/100421
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. Can you please bump the version number in the `package.json` file so we
can publish an update to the marketplace?
https://github.com/llvm/llvm-project/pull/99926
___
lldb-commits maili
JDevlieghere wrote:
Rather than a regex for the triple, can you use a combination of `oslist` and
`archs`? `expectedFailureAll` is supposed to combine the conditions, so the
regex should be equivalent to:
```
@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
```
https://github.com/ll
JDevlieghere wrote:
How are these tests failing? Neither of them seem to be testing something
specific to x86_64 and presumably the test are passing on [the aarch64 windows
buildbot](https://lab.llvm.org/buildbot/#/builders/141)?
https://github.com/llvm/llvm-project/pull/100473
__
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/100586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/100674
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t
byte_size) {
return llvm::APFloatBase::Bogus();
}
+std::optional
+TypeSystemClang::GetObjCBitSize(QualType qual_type,
+ExecutionContextScope *exe_scope) {
+ assert(qual_ty
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t
byte_size) {
return llvm::APFloatBase::Bogus();
}
+std::optional
+TypeSystemClang::GetObjCBitSize(QualType qual_type,
+ExecutionContextScope *exe_scope) {
+ assert(qual_ty
@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t
byte_size) {
return llvm::APFloatBase::Bogus();
}
+std::optional
+TypeSystemClang::GetObjCBitSize(QualType qual_type,
+ExecutionContextScope *exe_scope) {
+ assert(qual_ty
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/100674
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/100660
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/100660
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
Please don't use environment variables to pass options to the `make`
invocation. It makes it really hard to reproduce build failures because you
can't just copy-paste the failing invocation to debug the build. I went throug
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/100836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
The change itself looks good modulo formatting. Can you please update one of
the existing tests to cover this use case?
https://github.com/llvm/llvm-project/pull/101062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
JDevlieghere wrote:
This patch fixes the deserialization of the "address" field which surely can be
tested in isolation. The existing test (`TestObjectFileJSON.py`) has `address`
set to zero, which is why this happens to work today. It should be possible to
either update the test or add a new
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/101208
Currently, CommandObjects are obtaining a target in a variety of ways. Often
the command incorrectly operates on the selected target. As an example, when a
breakpoint command is running, the current target
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
301 - 400 of 5286 matches
Mail list logo
