[Lldb-commits] [lldb] r334454 - [Test] Update static variable test.

2018-06-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Jun 11 16:26:15 2018 New Revision: 334454 URL: http://llvm.org/viewvc/llvm-project?rev=334454&view=rev Log: [Test] Update static variable test. Before Pavel's change in r334181, we were printing too many global variables. This patch updates the test suite to ensure

[Lldb-commits] [lldb] r334456 - Exempt some compilers from new static variable test.

2018-06-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Jun 11 17:15:59 2018 New Revision: 334456 URL: http://llvm.org/viewvc/llvm-project?rev=334456&view=rev Log: Exempt some compilers from new static variable test. Apparently some compilers generate incomplete debug information which caused the updated test to fail. Th

[Lldb-commits] [lldb] r334615 - [FileSpec] Delegate common operations to llvm::sys::path

2018-06-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jun 13 09:23:21 2018 New Revision: 334615 URL: http://llvm.org/viewvc/llvm-project?rev=334615&view=rev Log: [FileSpec] Delegate common operations to llvm::sys::path With the recent changes in FileSpec to use LLVM's path style, it is possible to delegate a bunch of c

Re: [Lldb-commits] [lldb] r334615 - [FileSpec] Delegate common operations to llvm::sys::path

2018-06-13 Thread Jonas Devlieghere via lldb-commits
Good catch, thanks! On Wed, Jun 13, 2018 at 9:34 AM Pavel Labath wrote: > On Wed, 13 Jun 2018 at 17:27, Jonas Devlieghere via lldb-commits > wrote: > > > > Author: jdevlieghere > > Date: Wed Jun 13 09:23:21 2018 > > New Revision: 334615 > > > > UR

[Lldb-commits] [lldb] r334618 - [FileSpec] Simplify getting extension and stem.

2018-06-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jun 13 09:36:07 2018 New Revision: 334618 URL: http://llvm.org/viewvc/llvm-project?rev=334618&view=rev Log: [FileSpec] Simplify getting extension and stem. As noted by Pavel on lldb-commits, we don't need the temp path, we can just pass the filename directly into ex

[Lldb-commits] [lldb] r334631 - [ObjC] Use llvm::StringRef in summary providers

2018-06-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jun 13 11:15:14 2018 New Revision: 334631 URL: http://llvm.org/viewvc/llvm-project?rev=334631&view=rev Log: [ObjC] Use llvm::StringRef in summary providers Replace const char pointers with llvm::StringRef and use its equality operator for string comparisons. Modifi

[Lldb-commits] [lldb] r334638 - [ObjC] Add dataformatter for NSDecimalNumber

2018-06-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jun 13 11:47:04 2018 New Revision: 334638 URL: http://llvm.org/viewvc/llvm-project?rev=334638&view=rev Log: [ObjC] Add dataformatter for NSDecimalNumber This patch adds a data formatter for NSDecimalNumber. The latter is a Foundation object used for representing and

[Lldb-commits] [lldb] r334663 - [FileSpec] Make style argument mandatory for SetFile. NFC

2018-06-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jun 13 15:08:14 2018 New Revision: 334663 URL: http://llvm.org/viewvc/llvm-project?rev=334663&view=rev Log: [FileSpec] Make style argument mandatory for SetFile. NFC SetFile has an optional style argument which defaulted to the native style. This patch makes that ar

[Lldb-commits] [lldb] r334664 - [FileSpec] Make style argument mandatory for SetFile. NFC

2018-06-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jun 13 15:23:48 2018 New Revision: 334664 URL: http://llvm.org/viewvc/llvm-project?rev=334664&view=rev Log: [FileSpec] Make style argument mandatory for SetFile. NFC Fix SetFile uses in hosts that I missed in r334663. Modified: lldb/trunk/source/Host/freebsd/Ho

[Lldb-commits] [lldb] r334668 - [FileSpec] Make style argument mandatory for SetFile. NFC

2018-06-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jun 13 15:54:52 2018 New Revision: 334668 URL: http://llvm.org/viewvc/llvm-project?rev=334668&view=rev Log: [FileSpec] Make style argument mandatory for SetFile. NFC Update SetFile uses in the unittests. Modified: lldb/trunk/unittests/Host/SymbolsTest.cpp l

Re: [Lldb-commits] [lldb] r335263 - Fix an issue where DW_OP_deref might be dereferencing a file address. Convert the file address to a load address so this works.

2018-06-21 Thread Jonas Devlieghere via lldb-commits
Hi Greg, Would you mind adding a test case for this? Thanks, Jonas > On Jun 21, 2018, at 6:58 PM, Greg Clayton via lldb-commits > wrote: > > Author: gclayton > Date: Thu Jun 21 10:58:06 2018 > New Revision: 335263 > > URL: http://llvm.org/viewvc/llvm-project?rev=335263&view=rev > Log: > Fix

[Lldb-commits] [lldb] r335271 - [DataFormatter] Add CFDictionary data formatter

2018-06-21 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Jun 21 12:13:47 2018 New Revision: 335271 URL: http://llvm.org/viewvc/llvm-project?rev=335271&view=rev Log: [DataFormatter] Add CFDictionary data formatter Add data formatter for NSCFDictionary/CFDictionaryRef. Differential revision: https://reviews.llvm.org/D48450

[Lldb-commits] [lldb] r335430 - [FileSpec] Refactor append and prepend implemenetations. NFC

2018-06-24 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Sun Jun 24 03:18:01 2018 New Revision: 335430 URL: http://llvm.org/viewvc/llvm-project?rev=335430&view=rev Log: [FileSpec] Refactor append and prepend implemenetations. NFC Replaces custom implementations of append and prepend with calls to llvm's path library. This is

[Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

2018-06-24 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Sun Jun 24 06:31:44 2018 New Revision: 335432 URL: http://llvm.org/viewvc/llvm-project?rev=335432&view=rev Log: [FileSpec] Always normalize Removing redundant components from the path seems pretty harmless. Rather than checking whether this is necessary and then actuall

[Lldb-commits] [lldb] r335448 - Revert "[FileSpec] Always normalize"

2018-06-25 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Jun 25 03:11:53 2018 New Revision: 335448 URL: http://llvm.org/viewvc/llvm-project?rev=335448&view=rev Log: Revert "[FileSpec] Always normalize" This reverts r335432 because remove_dots() is expensive and measuring its impact showed an observable performance regress

Re: [Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

2018-06-25 Thread Jonas Devlieghere via lldb-commits
this actually is > important for performance of lldb > <https://reviews.llvm.org/D45977#1078510>. > On Sun, 24 Jun 2018 at 14:36, Jonas Devlieghere via lldb-commits > wrote: > > > > Author: jdevlieghere > > Date: Sun Jun 24 06:31:44 2018 > > New Revision:

[Lldb-commits] [lldb] r335776 - [SymbolFile] Implement GetCompleteObjCClass for .debug_names

2018-06-27 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jun 27 12:58:39 2018 New Revision: 335776 URL: http://llvm.org/viewvc/llvm-project?rev=335776&view=rev Log: [SymbolFile] Implement GetCompleteObjCClass for .debug_names When running the test suite with .debug_names a bunch of tests were failing because GetCompleteOb

[Lldb-commits] [lldb] r336272 - [CMake] Move some variables around

2018-07-04 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jul 4 06:59:25 2018 New Revision: 336272 URL: http://llvm.org/viewvc/llvm-project?rev=336272&view=rev Log: [CMake] Move some variables around This improves consistency by creating a CMake variable for the dsymutil path. The motivation is that for Swift, the dsymuti

[Lldb-commits] [lldb] r336278 - [CMake] Use LLVM_RUNTIME_OUTPUT_INTDIR for LLDB exectuable

2018-07-04 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jul 4 07:34:32 2018 New Revision: 336278 URL: http://llvm.org/viewvc/llvm-project?rev=336278&view=rev Log: [CMake] Use LLVM_RUNTIME_OUTPUT_INTDIR for LLDB exectuable Apparently there's a difference between using LLVM_RUNTIME_OUTPUT_INTDIR and LLVM_BINARY_DIR. The f

[Lldb-commits] [lldb] r336279 - [CMake] Remove redundant path component

2018-07-04 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jul 4 07:38:21 2018 New Revision: 336279 URL: http://llvm.org/viewvc/llvm-project?rev=336279&view=rev Log: [CMake] Remove redundant path component Fixes spurious path component introduced in r336278. The variable is cached so might require you to re-run CMake. Mod

[Lldb-commits] [lldb] r336290 - [lit] Don't require semicolon separator

2018-07-04 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jul 4 10:14:52 2018 New Revision: 336290 URL: http://llvm.org/viewvc/llvm-project?rev=336290&view=rev Log: [lit] Don't require semicolon separator This patch removes the requirement for a semicolon as a separator when passing arguments to lit. It relies on the shle

[Lldb-commits] [lldb] r324227 - [test] Un-XFAIL TestRaise.RaiseTestCase.test_restart_bug

2018-07-06 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 5 03:39:04 2018 New Revision: 324227 URL: http://llvm.org/viewvc/llvm-project?rev=324227&view=rev Log: [test] Un-XFAIL TestRaise.RaiseTestCase.test_restart_bug This test was marked as an expected failure because of PR20231 but it seems to consistently result in

[Lldb-commits] [lldb] r336988 - Convert a location information from PDB to a DWARF expression

2018-07-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Fri Jul 13 03:29:27 2018 New Revision: 336988 URL: http://llvm.org/viewvc/llvm-project?rev=336988&view=rev Log: Convert a location information from PDB to a DWARF expression The current version of SymbolFilePDB::ParseVariableForPDBData function always initializes variab

[Lldb-commits] [lldb] r337261 - Move pretty stack trace printer into driver.

2018-07-17 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Jul 17 03:04:19 2018 New Revision: 337261 URL: http://llvm.org/viewvc/llvm-project?rev=337261&view=rev Log: Move pretty stack trace printer into driver. We used to have a pretty stack trace printer in SystemInitializerCommon. This was disabled on Apple because we di

[Lldb-commits] [lldb] r337291 - [CMake] Have check-lldb-unit use CMAKE_CURRENT_BINARY_DIR

2018-07-17 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Jul 17 08:11:15 2018 New Revision: 337291 URL: http://llvm.org/viewvc/llvm-project?rev=337291&view=rev Log: [CMake] Have check-lldb-unit use CMAKE_CURRENT_BINARY_DIR llvm-lit uses `map_config` directives (generated at configuration-time) to make it possible to pass

[Lldb-commits] [lldb] r337932 - [ProcessGDBRemote] handle result from ConnectToDebugserver

2018-07-25 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jul 25 08:20:15 2018 New Revision: 337932 URL: http://llvm.org/viewvc/llvm-project?rev=337932&view=rev Log: [ProcessGDBRemote] handle result from ConnectToDebugserver We ignored the result from ConnectToDebugserver, causing certain errors (like a failed handshake) n

[Lldb-commits] [lldb] r342142 - [DWARFExpression] Read literars as unsigned values.

2018-09-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Sep 13 08:18:39 2018 New Revision: 342142 URL: http://llvm.org/viewvc/llvm-project?rev=342142&view=rev Log: [DWARFExpression] Read literars as unsigned values. After landing r341457, we started seeing a failure on the swift-lldb bots. The change was correct and pret

[Lldb-commits] [lldb] r342634 - [target] Change target create's behavior wrt loading dependent files.

2018-09-20 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Sep 20 02:09:13 2018 New Revision: 342634 URL: http://llvm.org/viewvc/llvm-project?rev=342634&view=rev Log: [target] Change target create's behavior wrt loading dependent files. When creating a target, lldb loads all dependent files (i.e. libs in LC_LOAD_DYLIB for M

[Lldb-commits] [lldb] r342633 - [NFC] Turn "load dependent files" boolean into an enum

2018-09-20 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Sep 20 02:09:05 2018 New Revision: 342633 URL: http://llvm.org/viewvc/llvm-project?rev=342633&view=rev Log: [NFC] Turn "load dependent files" boolean into an enum This is an NFC commit to refactor the "load dependent files" parameter from a boolean to an enum value.

[Lldb-commits] [lldb] r324488 - [test] Enable setting category for inline tests.

2018-02-07 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Feb 7 08:10:59 2018 New Revision: 324488 URL: http://llvm.org/viewvc/llvm-project?rev=324488&view=rev Log: [test] Enable setting category for inline tests. Inlined tests have a test function that is actually an instance method, which requires a slightly different a

[Lldb-commits] [lldb] r324492 - [test] Don't drop existing categories for methods.

2018-02-07 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Feb 7 09:34:46 2018 New Revision: 324492 URL: http://llvm.org/viewvc/llvm-project?rev=324492&view=rev Log: [test] Don't drop existing categories for methods. The change in r324488 dropped the existing category attribute in for instance methods. This patch corrects

[Lldb-commits] [lldb] r325339 - Re-enable lang/objc/modules/TestObjCModules

2018-02-16 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Fri Feb 16 04:33:10 2018 New Revision: 325339 URL: http://llvm.org/viewvc/llvm-project?rev=325339&view=rev Log: Re-enable lang/objc/modules/TestObjCModules The reason this test was disabled is no longer relevant. However, it didn't turn into an unexpected success becaus

[Lldb-commits] [lldb] r325568 - Handle typeof() expressions

2018-02-20 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 20 02:15:08 2018 New Revision: 325568 URL: http://llvm.org/viewvc/llvm-project?rev=325568&view=rev Log: Handle typeof() expressions Before this patch, LLDB was not able to evaluate expressions that resulted in a value with a typeof- or decltype-type. This patch

[Lldb-commits] [lldb] r326081 - [Support] Replace HashString with djbHash.

2018-02-26 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 26 03:30:13 2018 New Revision: 326081 URL: http://llvm.org/viewvc/llvm-project?rev=326081&view=rev Log: [Support] Replace HashString with djbHash. This removes the HashString function from StringExtraces and replaces its uses with calls to djbHash from DJB.h Th

[Lldb-commits] [lldb] r326082 - Revert "[Support] Replace HashString with djbHash."

2018-02-26 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 26 04:05:18 2018 New Revision: 326082 URL: http://llvm.org/viewvc/llvm-project?rev=326082&view=rev Log: Revert "[Support] Replace HashString with djbHash." It looks like some of our tests depend on the ordering of hashed values. I'm reverting my changes while I

[Lldb-commits] [lldb] r326091 - Re-land: "[Support] Replace HashString with djbHash."

2018-02-26 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 26 07:16:42 2018 New Revision: 326091 URL: http://llvm.org/viewvc/llvm-project?rev=326091&view=rev Log: Re-land: "[Support] Replace HashString with djbHash." This patch removes the HashString function from StringExtraces and replaces its uses with calls to djbHa

[Lldb-commits] [lldb] r326552 - [testsuite] Remove workaround for categories and inline tests.

2018-03-02 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Fri Mar 2 02:38:11 2018 New Revision: 326552 URL: http://llvm.org/viewvc/llvm-project?rev=326552&view=rev Log: [testsuite] Remove workaround for categories and inline tests. Adding categories to inline tests does not work because the attribute is set at the function le

[Lldb-commits] [lldb] r326687 - [test] Add dotest wrapper

2018-03-05 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Mar 5 02:03:44 2018 New Revision: 326687 URL: http://llvm.org/viewvc/llvm-project?rev=326687&view=rev Log: [test] Add dotest wrapper This adds a wrapper around dotest, similar to llvm-lit in llvm. The wrapper is created in the binary directory, next to LLDB and all

[Lldb-commits] [lldb] r327501 - Update selected thread after loading mach core

2018-03-14 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Mar 14 04:50:10 2018 New Revision: 327501 URL: http://llvm.org/viewvc/llvm-project?rev=327501&view=rev Log: Update selected thread after loading mach core The OS plugins might have updated the thread list after a core file has been loaded. The physical thread in the

[Lldb-commits] [lldb] r327512 - [test] Disable TestMachCore everywhere except on Darwin

2018-03-14 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Mar 14 07:16:23 2018 New Revision: 327512 URL: http://llvm.org/viewvc/llvm-project?rev=327512&view=rev Log: [test] Disable TestMachCore everywhere except on Darwin Apparently the parser is wrapped inside ifdef's so the logic isn't available on non-Darwin platforms.

[Lldb-commits] [lldb] r327519 - [dotest] Rename llvm-dotest -> lldb-dotest and make it a custom target

2018-03-14 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Mar 14 08:36:32 2018 New Revision: 327519 URL: http://llvm.org/viewvc/llvm-project?rev=327519&view=rev Log: [dotest] Rename llvm-dotest -> lldb-dotest and make it a custom target This renames llvm-dotest to lldb-dotest and makes it a custom target so you can run `ni

[Lldb-commits] [lldb] r328020 - [lldb-dotest] Wrap arguments in single quotes

2018-03-20 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Mar 20 12:18:11 2018 New Revision: 328020 URL: http://llvm.org/viewvc/llvm-project?rev=328020&view=rev Log: [lldb-dotest] Wrap arguments in single quotes If we don't wrap arguments to the wrapper in single quotes, combined arguments, for example for -E, don't reach

Re: [Lldb-commits] [lldb] r328020 - [lldb-dotest] Wrap arguments in single quotes

2018-03-21 Thread Jonas Devlieghere via lldb-commits
and then just breaking it up around > semicolons. This will still not be perfect forwarding, but it will already > be a big improvement over how it's handled right now. > > > On Tue, 20 Mar 2018 at 19:20, Jonas Devlieghere via lldb-commits < > lldb-commits@lists.llvm.org>

[Lldb-commits] [lldb] r328089 - [dotest] Use subprocess.call to forward arguments in wrapper

2018-03-21 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Mar 21 04:13:56 2018 New Revision: 328089 URL: http://llvm.org/viewvc/llvm-project?rev=328089&view=rev Log: [dotest] Use subprocess.call to forward arguments in wrapper As suggested by Pavel on lldb-commits. Originally I picked os.system because it was so much more

[Lldb-commits] [lldb] r328966 - [test] Exit lldb-dotest in a more Pythonic way.

2018-04-02 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Apr 2 03:44:36 2018 New Revision: 328966 URL: http://llvm.org/viewvc/llvm-project?rev=328966&view=rev Log: [test] Exit lldb-dotest in a more Pythonic way. As suggested by Keith Smiley in: https://github.com/apple/swift-lldb/pull/486 Modified: lldb/trunk/test/l

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

2018-04-04 Thread Jonas Devlieghere via lldb-commits
> On Apr 4, 2018, at 5:12 PM, Adrian Prantl wrote: > > > >> On Apr 4, 2018, at 9:07 AM, Zachary Turner wrote: >> >> Sure, but getting lit to run one file at a time is a nice incremental step >> towards that and can make both patches easier to review. > > Agreed, I just want to make sure th

[Lldb-commits] [lldb] r329889 - [dotest] Use in-tree dsymutil on Darwin

2018-04-12 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Apr 12 02:25:32 2018 New Revision: 329889 URL: http://llvm.org/viewvc/llvm-project?rev=329889&view=rev Log: [dotest] Use in-tree dsymutil on Darwin Summary: With the upstream implementation of dsymutil containing almost all functionality from the one shipped with Xc

[Lldb-commits] [lldb] r329890 - [dotest] Fix syntax error and typo.

2018-04-12 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Apr 12 02:35:17 2018 New Revision: 329890 URL: http://llvm.org/viewvc/llvm-project?rev=329890&view=rev Log: [dotest] Fix syntax error and typo. Python uses `elif` rather than `else if`. Fixes r329889. Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.p

[Lldb-commits] [lldb] r329891 - Don't assume backing thread shares protocol ID.

2018-04-12 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Apr 12 02:58:20 2018 New Revision: 329891 URL: http://llvm.org/viewvc/llvm-project?rev=329891&view=rev Log: Don't assume backing thread shares protocol ID. When we're dealing with virtual (memory) threads created by the OS plugins, there's no guarantee that the real

[Lldb-commits] [lldb] r329897 - Revert "Don't assume backing thread shares protocol ID."

2018-04-12 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Apr 12 03:51:52 2018 New Revision: 329897 URL: http://llvm.org/viewvc/llvm-project?rev=329897&view=rev Log: Revert "Don't assume backing thread shares protocol ID." This reverts r329891 because the test case is timing out on linux: http://lab.llvm.org:8011/builders/

[Lldb-commits] [lldb] r330002 - Prevent deadlock in OS Plugins

2018-04-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Fri Apr 13 03:25:23 2018 New Revision: 330002 URL: http://llvm.org/viewvc/llvm-project?rev=330002&view=rev Log: Prevent deadlock in OS Plugins Summary: When performing a synchronous resume, the API mutex is held until the process is stopped. This is fine, except for whe

[Lldb-commits] [lldb] r330005 - Re-land "Don't assume backing thread shares protocol ID."

2018-04-13 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Fri Apr 13 04:31:34 2018 New Revision: 330005 URL: http://llvm.org/viewvc/llvm-project?rev=330005&view=rev Log: Re-land "Don't assume backing thread shares protocol ID." When we're dealing with virtual (memory) threads created by the OS plugins, there's no guarantee tha

[Lldb-commits] [lldb] r330275 - [LIT] Have lit run the lldb test suite

2018-04-18 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Apr 18 10:08:49 2018 New Revision: 330275 URL: http://llvm.org/viewvc/llvm-project?rev=330275&view=rev Log: [LIT] Have lit run the lldb test suite This is the first in what will hopefully become a series of patches to replace the driver logic in dotest.py with LIT.

[Lldb-commits] [lldb] r330518 - [lit] Generate a single lit cfg file for tests that require dotest.py

2018-04-21 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Sat Apr 21 11:23:04 2018 New Revision: 330518 URL: http://llvm.org/viewvc/llvm-project?rev=330518&view=rev Log: [lit] Generate a single lit cfg file for tests that require dotest.py The current way that the lit configuration is generated for the LLDB tests that run usin

[Lldb-commits] [lldb] r330568 - [CMake] Gate 'dsymutil' dependency

2018-04-23 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Apr 23 01:44:06 2018 New Revision: 330568 URL: http://llvm.org/viewvc/llvm-project?rev=330568&view=rev Log: [CMake] Gate 'dsymutil' dependency Only add `dsymutil` as a test dependency when this is not a stand-alone build (LLDB_BUILT_STANDALONE). Modified: lldb/

[Lldb-commits] [lldb] r331277 - [lit] Replace generator expressions in lit.site.cfg

2018-05-01 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue May 1 09:19:48 2018 New Revision: 331277 URL: http://llvm.org/viewvc/llvm-project?rev=331277&view=rev Log: [lit] Replace generator expressions in lit.site.cfg The lit site configuration for the test suite can contain generator expressions such as $ that need to be

[Lldb-commits] [lldb] r331285 - Revert "[lit] Replace generator expressions in lit.site.cfg"

2018-05-01 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue May 1 10:08:09 2018 New Revision: 331285 URL: http://llvm.org/viewvc/llvm-project?rev=331285&view=rev Log: Revert "[lit] Replace generator expressions in lit.site.cfg" Using GENERATE breaks generators that support multiple configurations, e.g. MSVC. Reverting for n

[Lldb-commits] [lldb] r331463 - [CMake] Unify and relayer testing

2018-05-03 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu May 3 09:54:10 2018 New Revision: 331463 URL: http://llvm.org/viewvc/llvm-project?rev=331463&view=rev Log: [CMake] Unify and relayer testing This patch restructures part of LLDB's testing configuration: 1. I moved the test dependencies up the chain so every dotest

[Lldb-commits] [lldb] r331764 - [test] Re-enable TestUnicodeSymbols

2018-05-08 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue May 8 06:28:34 2018 New Revision: 331764 URL: http://llvm.org/viewvc/llvm-project?rev=331764&view=rev Log: [test] Re-enable TestUnicodeSymbols Re-enable TestUnicodeSymbols now that we use the in-tree dsymutil. This was disabled because the hashing of unicode symbol

[Lldb-commits] [lldb] r351489 - [CMake] Fix lldb-test-depends target

2019-01-17 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Jan 17 14:25:20 2019 New Revision: 351489 URL: http://llvm.org/viewvc/llvm-project?rev=351489&view=rev Log: [CMake] Fix lldb-test-depends target The lldb-test-depends target was using the old CMake variable name LLDB_TEST_DEPENDS instead of LLDB_TEST_DEPS. This patc

[Lldb-commits] [lldb] r351497 - [lit] Fix lldbtest format

2019-01-17 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Jan 17 15:30:06 2019 New Revision: 351497 URL: http://llvm.org/viewvc/llvm-project?rev=351497&view=rev Log: [lit] Fix lldbtest format The lldbtest format was incorrectly detecting XFAIL as FAIL because it was looking for the `FAIL:` substring in the dotest output.

[Lldb-commits] [lldb] r351501 - [Reproducers] Refactor reproducer info

2019-01-17 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Jan 17 17:04:59 2019 New Revision: 351501 URL: http://llvm.org/viewvc/llvm-project?rev=351501&view=rev Log: [Reproducers] Refactor reproducer info In the original reproducer design, I expected providers to be more dynamic than they turned out. For example, we don't

[Lldb-commits] [lldb] r351524 - [Reproducers] Fix reproducers unittest.

2019-01-17 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Jan 17 23:17:05 2019 New Revision: 351524 URL: http://llvm.org/viewvc/llvm-project?rev=351524&view=rev Log: [Reproducers] Fix reproducers unittest. Fix fallout from r351501 in the reproducer unittest. Modified: lldb/trunk/unittests/Utility/ReproducerTest.cpp M

[Lldb-commits] [lldb] r351611 - [dotest] Add logging to investigate CI issue.

2019-01-18 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Fri Jan 18 15:05:19 2019 New Revision: 351611 URL: http://llvm.org/viewvc/llvm-project?rev=351611&view=rev Log: [dotest] Add logging to investigate CI issue. We're seeing an odd issue on GreenDragon's lldb-cmake-matrix. Dotest is unable to move a log file (OSError: [Err

[Lldb-commits] [lldb] r351779 - [Test] Fix up tests affected by the new LLVM header.

2019-01-21 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Jan 21 19:50:44 2019 New Revision: 351779 URL: http://llvm.org/viewvc/llvm-project?rev=351779&view=rev Log: [Test] Fix up tests affected by the new LLVM header. The new LLVM header is one line shorter than the old one, which lead to some test failures. Ideally tests

[Lldb-commits] [lldb] r351902 - Revert "[dotest] Add logging to investigate CI issue."

2019-01-22 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Jan 22 16:13:47 2019 New Revision: 351902 URL: http://llvm.org/viewvc/llvm-project?rev=351902&view=rev Log: Revert "[dotest] Add logging to investigate CI issue." We figured out the issue so the logging is no longer necessary. It turns out we were using a session fo

[Lldb-commits] [lldb] r352259 - [lldb] Update shebang python2 -> python

2019-01-25 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Fri Jan 25 17:05:02 2019 New Revision: 352259 URL: http://llvm.org/viewvc/llvm-project?rev=352259&view=rev Log: [lldb] Update shebang python2 -> python Modified: lldb/trunk/lit/Quit/expect_exit_code.py Modified: lldb/trunk/lit/Quit/expect_exit_code.py URL: http://

Re: [Lldb-commits] [PATCH] D57275: [testsuite] Remove seven dependency

2019-01-26 Thread Jonas Devlieghere via lldb-commits
On Fri, Jan 25, 2019 at 8:44 PM Zachary Turner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > The idea behind seven is that it’s a place to put stuff that we need for > py2/py3 interoperability that doesn’t already exist in six. Yes, maybe > there’s only one thing there now, but there co

[Lldb-commits] [lldb] r352397 - [testsuite] Remove trailing characters from command output.

2019-01-28 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Jan 28 10:07:28 2019 New Revision: 352397 URL: http://llvm.org/viewvc/llvm-project?rev=352397&view=rev Log: [testsuite] Remove trailing characters from command output. When running the test suite on macOS with Python 3 we noticed a difference in behavior between Pyt

[Lldb-commits] [lldb] r352398 - [testsuite] Remove unused seven module imports.

2019-01-28 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Jan 28 10:07:41 2019 New Revision: 352398 URL: http://llvm.org/viewvc/llvm-project?rev=352398&view=rev Log: [testsuite] Remove unused seven module imports. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py lldb/trunk/packa

[Lldb-commits] [lldb] r352538 - [Reproducers] Add file provider

2019-01-29 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Jan 29 12:36:38 2019 New Revision: 352538 URL: http://llvm.org/viewvc/llvm-project?rev=352538&view=rev Log: [Reproducers] Add file provider This patch adds the file provider which is responsible for capturing files used by LLDB. When capturing a reproducer, we use

[Lldb-commits] [lldb] r352556 - [test] Use correct macro in FileCollectorTest.cpp

2019-01-29 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Jan 29 14:53:47 2019 New Revision: 352556 URL: http://llvm.org/viewvc/llvm-project?rev=352556&view=rev Log: [test] Use correct macro in FileCollectorTest.cpp This test was supposed to be skipped on Windows but was using the wrong macro name. Modified: lldb/trun

[Lldb-commits] [lldb] r352570 - Add FileCollector + test to Xcode project.

2019-01-29 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Jan 29 15:48:53 2019 New Revision: 352570 URL: http://llvm.org/viewvc/llvm-project?rev=352570&view=rev Log: Add FileCollector + test to Xcode project. Added: lldb/trunk/lldb.xcworkspace/xcshareddata/ lldb/trunk/lldb.xcworkspace/xcshareddata/IDEWorkspaceCheck

[Lldb-commits] [lldb] r352696 - Add lldb-docs target to Xcode project

2019-01-30 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jan 30 15:56:55 2019 New Revision: 352696 URL: http://llvm.org/viewvc/llvm-project?rev=352696&view=rev Log: Add lldb-docs target to Xcode project This patch adds the lldb-docs target which generates the Sphinx html documentation. Modified: lldb/trunk/lldb.xcode

[Lldb-commits] [lldb] r352703 - Add Sphinx generated html files as output to the build phase.

2019-01-30 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Jan 30 16:40:38 2019 New Revision: 352703 URL: http://llvm.org/viewvc/llvm-project?rev=352703&view=rev Log: Add Sphinx generated html files as output to the build phase. This will ensure we don't rerun Sphinx when the files exist. Modified: lldb/trunk/lldb.xcod

[Lldb-commits] [lldb] r352780 - [unittest] Fix scalar unit test.

2019-01-31 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Jan 31 10:48:17 2019 New Revision: 352780 URL: http://llvm.org/viewvc/llvm-project?rev=352780&view=rev Log: [unittest] Fix scalar unit test. The test was using ASSERT_EQ instead of ASSERT_STREQ which meant we were comparing string addresses instead of the actual str

[Lldb-commits] [lldb] r353087 - Update stale comment in lang/c/struct_types/main.c

2019-02-04 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 4 12:33:35 2019 New Revision: 353087 URL: http://llvm.org/viewvc/llvm-project?rev=353087&view=rev Log: Update stale comment in lang/c/struct_types/main.c rdar://47322760 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/struct_types/main.c Modifi

[Lldb-commits] [lldb] r353195 - [Reproducers] Instrumentation Framework: Serialization

2019-02-05 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 5 10:46:36 2019 New Revision: 353195 URL: http://llvm.org/viewvc/llvm-project?rev=353195&view=rev Log: [Reproducers] Instrumentation Framework: Serialization This is the is serialization/deserialization part of the reproducer instrumentation framework. For all

[Lldb-commits] [lldb] r353196 - [unittests] Fix warning

2019-02-05 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 5 10:46:37 2019 New Revision: 353196 URL: http://llvm.org/viewvc/llvm-project?rev=353196&view=rev Log: [unittests] Fix warning warning: comparison of integers of different signs: 'const int' and 'const unsigned long' [-Wsign-compare] Modified: lldb/trunk/

[Lldb-commits] [lldb] r353239 - Remove accidentally commited file in xcshareddata

2019-02-05 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 5 15:35:01 2019 New Revision: 353239 URL: http://llvm.org/viewvc/llvm-project?rev=353239&view=rev Log: Remove accidentally commited file in xcshareddata Removed: lldb/trunk/lldb.xcworkspace/xcshareddata/ ___ lldb

[Lldb-commits] [lldb] r353258 - Sort Xcode project

2019-02-05 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 5 17:30:45 2019 New Revision: 353258 URL: http://llvm.org/viewvc/llvm-project?rev=353258&view=rev Log: Sort Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/viewvc/l

[Lldb-commits] [lldb] r353259 - [Reproducers] Add instrumentation to Xcode project

2019-02-05 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 5 17:31:00 2019 New Revision: 353259 URL: http://llvm.org/viewvc/llvm-project?rev=353259&view=rev Log: [Reproducers] Add instrumentation to Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxpro

Re: [Lldb-commits] [lldb] r353257 - Little more cleanup on https://reviews.llvm.org/D57552

2019-02-05 Thread Jonas Devlieghere via lldb-commits
Thanks Jim! On Tue, Feb 5, 2019 at 5:27 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Tue Feb 5 17:27:45 2019 > New Revision: 353257 > > URL: http://llvm.org/viewvc/llvm-project?rev=353257&view=rev > Log: > Little more cleanup on https://reviews.l

[Lldb-commits] [lldb] r353271 - [Reproducers] lldb-instr: tool to generate instrumentation macros.

2019-02-05 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 5 20:33:14 2019 New Revision: 353271 URL: http://llvm.org/viewvc/llvm-project?rev=353271&view=rev Log: [Reproducers] lldb-instr: tool to generate instrumentation macros. This patch introduces a new tool called 'lldb-instr'. It automates the workflow of insertin

[Lldb-commits] [lldb] r353324 - [Reproducers] SBReproducer framework: Capture & Replay

2019-02-06 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Feb 6 10:57:42 2019 New Revision: 353324 URL: http://llvm.org/viewvc/llvm-project?rev=353324&view=rev Log: [Reproducers] SBReproducer framework: Capture & Replay This is part two of the reproducer instrumentation framework. It contains the code to capture and repla

[Lldb-commits] [lldb] r353326 - Add SBReproducer to Xcode project

2019-02-06 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Feb 6 11:05:43 2019 New Revision: 353326 URL: http://llvm.org/viewvc/llvm-project?rev=353326&view=rev Log: Add SBReproducer to Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://ll

[Lldb-commits] [lldb] r353361 - Fix my mistake adding SBReproducer the Xcode project

2019-02-06 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Feb 6 17:42:47 2019 New Revision: 353361 URL: http://llvm.org/viewvc/llvm-project?rev=353361&view=rev Log: Fix my mistake adding SBReproducer the Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxp

[Lldb-commits] [lldb] r353362 - [Driver] Don't try to replay reproducer in the driver.

2019-02-06 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Wed Feb 6 17:49:07 2019 New Revision: 353362 URL: http://llvm.org/viewvc/llvm-project?rev=353362&view=rev Log: [Driver] Don't try to replay reproducer in the driver. Because the macros for the SBReproducers have not been committed yet, the driver should not attempt to

[Lldb-commits] [lldb] r353444 - [lldb-instr] Make lldb-instr a test dependency

2019-02-07 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Feb 7 10:41:59 2019 New Revision: 353444 URL: http://llvm.org/viewvc/llvm-project?rev=353444&view=rev Log: [lldb-instr] Make lldb-instr a test dependency Modified: lldb/trunk/CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-

[Lldb-commits] [lldb] r353472 - [CommandInterpreter] Early return on error (NFC)

2019-02-07 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Thu Feb 7 13:51:20 2019 New Revision: 353472 URL: http://llvm.org/viewvc/llvm-project?rev=353472&view=rev Log: [CommandInterpreter] Early return on error (NFC) We save two levels of indentation by returning early if the given file doesn't exists or cannot be opened. M

[Lldb-commits] [lldb] r353721 - Update SymbolVendorMacOSX for new GetUUID interface

2019-02-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 11 09:19:26 2019 New Revision: 353721 URL: http://llvm.org/viewvc/llvm-project?rev=353721&view=rev Log: Update SymbolVendorMacOSX for new GetUUID interface The interface changed in r353714. Modified: lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendo

[Lldb-commits] [lldb] r353752 - Use of `@return` is not appropriate for a function with a void return type.

2019-02-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 11 13:43:18 2019 New Revision: 353752 URL: http://llvm.org/viewvc/llvm-project?rev=353752&view=rev Log: Use of `@return` is not appropriate for a function with a void return type. The comment for this declaration causes a warning with -Wdocumentation: Invalid @r

[Lldb-commits] [lldb] r353768 - Some cleanup after moving to std::make_shared

2019-02-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 11 15:48:59 2019 New Revision: 353768 URL: http://llvm.org/viewvc/llvm-project?rev=353768&view=rev Log: Some cleanup after moving to std::make_shared Addresses Tatyana Krasnukha's feedback from D57990. Modified: lldb/trunk/source/Core/IOHandler.cpp lldb

[Lldb-commits] [lldb] r353769 - [ObjectFileMachO] Revert std::make_shared

2019-02-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 11 15:49:13 2019 New Revision: 353769 URL: http://llvm.org/viewvc/llvm-project?rev=353769&view=rev Log: [ObjectFileMachO] Revert std::make_shared This caused a rather interesting error message on MSVC: error C2338 and I'm not sure how to properly fix it. Modifi

[Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

2019-02-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 11 16:30:21 2019 New Revision: 353778 URL: http://llvm.org/viewvc/llvm-project?rev=353778&view=rev Log: Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows. Apparently there are multiple places where MSVC complains about instantiations with extended aligment. I t

[Lldb-commits] [lldb] r353783 - [Thread] Update the correct variable

2019-02-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 11 17:04:57 2019 New Revision: 353783 URL: http://llvm.org/viewvc/llvm-project?rev=353783&view=rev Log: [Thread] Update the correct variable The new shared pointer was assigning to the temporary instead of the member (m_curr_frames_sp). Modified: lldb/trunk

[Lldb-commits] [lldb] r353795 - Remove redundant ::get() for smart pointer. (NFC)

2019-02-11 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Mon Feb 11 19:47:39 2019 New Revision: 353795 URL: http://llvm.org/viewvc/llvm-project?rev=353795&view=rev Log: Remove redundant ::get() for smart pointer. (NFC) This commit removes redundant calls to smart pointer’s ::get() method. https://clang.llvm.org/extra/clang-t

[Lldb-commits] [lldb] r353869 - [lldb-instr] Pass PCHContainerOperations to ClangTool

2019-02-12 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 12 10:19:34 2019 New Revision: 353869 URL: http://llvm.org/viewvc/llvm-project?rev=353869&view=rev Log: [lldb-instr] Pass PCHContainerOperations to ClangTool On a local modules build this would cause an error. > fatal error: no handler registered for module for

[Lldb-commits] [lldb] r353906 - [Reproducers] Integrate FileProvider with clang

2019-02-12 Thread Jonas Devlieghere via lldb-commits
Author: jdevlieghere Date: Tue Feb 12 17:30:41 2019 New Revision: 353906 URL: http://llvm.org/viewvc/llvm-project?rev=353906&view=rev Log: [Reproducers] Integrate FileProvider with clang This patch hooks up clang and lldb's reproducers functionality. It ensures that when capturing a reproducer, h

Re: [Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

2019-02-13 Thread Jonas Devlieghere via lldb-commits
> On 12/02/2019 01:30, Jonas Devlieghere via lldb-commits wrote: > > Author: jdevlieghere > > Date: Mon Feb 11 16:30:21 2019 > > New Revision: 353778 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=353778&view=rev > > Log: > > Define _ENABLE_E

<    1   2   3   4   5   6   7   8   9   10   >