[Lldb-commits] [PATCH] D119997: Add a little test for simple breaking on overloaded functions by name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Jim! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119997/new/ https://reviews.llvm.org/D119997 ___

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "global" lldbinit file

JDevlieghere added a comment. In D119831#3325798 , @labath wrote: > It's worth noting that (as a part of the consistency), I have changed the > cmake > variable to point to a directory instead of a file. This means that the init > file name is currently

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "global" lldbinit file

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D119831#3329959 , @labath wrote: > In D119831#3329894 , @JDevlieghere > wrote: > >> Specifyin

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, aprantl, mib. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Jim noticed that the regex command is unintentionally recursive: Let's use the following command regex as an exampl

[Lldb-commits] [PATCH] D120100: [lldb] Expose eBroadcastBitProgress to the SWIG SBAPI (NFC)

JDevlieghere added a comment. Removing the enum from SBDebugger is an ABI breaking change. I think this has been in tree for a while, so if we shipped this like this in the last release, we cannot guarantee that this won't break anyone. Can we avoid the issue by defining the interface file? R

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

JDevlieghere updated this revision to Diff 409824. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120101/new/ https://reviews.llvm.org/D120101 Files: lldb/source/Commands/CommandObjectRegexCommand.cpp lldb/source/Commands/CommandObjectReg

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectRegexCommand.cpp:38 +// Parse the number following '%'. +const size_t idx = std::atoi(str.c_str() + pos + 1); + mib wrote: > Are we assuming that the number following `%` wi

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

JDevlieghere updated this revision to Diff 409963. JDevlieghere added a comment. Use Pavel's //not-as-cool// solution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120101/new/ https://reviews.llvm.org/D120101 Files: lldb/source/Commands/CommandObjectRegexCommand.cpp lldb/source/Co

[Lldb-commits] [PATCH] D120100: [lldb] Expose eBroadcastBitProgress to the SWIG SBAPI

JDevlieghere added a comment. In D120100#3331656 , @labath wrote: > I'm not sure how we ended up with the .i files in the first place, but maybe > a good solution to this problem would be to ditch those and generate bindings > from .h files directly. >

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120100/new/ https://reviews.llvm.org/D120100 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

JDevlieghere updated this revision to Diff 410326. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - Allow using `%0` - Return an error when using an out of range index CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120101/new/ https://reviews.llvm.org/D12010

[Lldb-commits] [PATCH] D119915: Replace use of double underscore in identifiers

JDevlieghere added a comment. Assuming all issues have been fixed, can you add this clang-tidy check to the `.clang-tidy` file in the root of the repository? That should make it less likely this regresses again in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D120322: [lldb] Simplify HostThreadMacOSX

JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostThreadMacOSX.mm:17-20 + NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; + lldb::thread_result_t result = HostThreadPosix::ThreadCreateTrampoline(arg); + [pool drain]; + return resul

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice cleanup Comment at: lldb/source/Host/common/HostNativeThreadBase.cpp:55-56 HostNativeThreadBase::ThreadCreateTrampoline(lldb::thread_arg_t arg) { - ThreadL

[Lldb-commits] [PATCH] D120425: [lldb/host] Remove monitor_signals argument from process monitoring functions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120425/new/ https://reviews.llvm.org/D120425 ___

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

JDevlieghere added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); I see an opportunity for a little RAII helper. Re

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a6dbedf5a92: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

JDevlieghere added a comment. This seems trivial enough, but adding Greg as he wrote most of lldb-vscode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113616/new/ https://reviews.llvm.org/D113616 ___ ll

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

JDevlieghere added a comment. This is really great, this is going to save me a lot of time. I wonder if we should take this even further and make it a first class command in lldb, similar to `apropos`. (I wouldn't make it part of apropos, because it can already be overwhelming.) By making it it

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

JDevlieghere added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); labath wrote: > JDevlieghere wrote: > > I see an op

[Lldb-commits] [PATCH] D120517: PlatformMacOSX should be activated for lldb built to run on an iOS etc device

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120517/new/ https://reviews.llvm.org/D120517 ___

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

JDevlieghere added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); andcarminati wrote: > JDevlieghere wrote: > > labat

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Prepare decouple instance and plugin names

JDevlieghere accepted this revision. JDevlieghere added a comment. (Still) LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119146/new/ https://reviews.llvm.org/D119146 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

JDevlieghere added a comment. > I'm not entirely sure what's the best fix here. @JDevlieghere, what do you > think? Can we just remove the output arguments from the LLDB_INSTRUMENT_VA > invocation (given how logging their entry values is pretty useless)? Yup, the way I dealt with that for the r

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

JDevlieghere added a comment. I like Jim's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120292/new/ https://reviews.llvm.org/D120292 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D120593: [Support] Allow the ability to change WithColor's auto detection function

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, RKSimon, jdenny. Herald added subscribers: dexonsmith, hiraditya. JDevlieghere requested review of this revision. Herald added a project: LLVM. `WithColor` has an "auto detection mode" which looks whether the corresponding

[Lldb-commits] [PATCH] D120593: [Support] Allow the ability to change WithColor's auto detection function

JDevlieghere updated this revision to Diff 411533. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120593/new/ https://reviews.llvm.org/D120593 Files: lldb/tools/driver/Driver.cpp llvm/include/llvm/Support/WithColor.h llvm/lib/Support/WithColor.cpp Index: llvm/lib/Support/WithColor.

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

JDevlieghere added a comment. Yup, that works too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120284/new/ https://reviews.llvm.org/D120284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

JDevlieghere added a comment. Nit: can we use a colon instead of dash? We have a bunch of places already where we're "concatenating" errors with a colon so I'd like to keep that consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120594/new/

[Lldb-commits] [PATCH] D120599: Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120599/new/ https://reviews.llvm.org/D120599

[Lldb-commits] [PATCH] D120598: [lldb/crashlog] Fix scripted_crashlog_json.test failure

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120598/new/ https://reviews.llvm.org/D120598 ___

[Lldb-commits] [PATCH] D120593: [Support] Allow the ability to change WithColor's auto detection function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa83cf7a84628: [Support] Allow the ability to change WithColor's auto detection function (authored by JDevlieghere). Herald added a project: LLDB. Re

[Lldb-commits] [PATCH] D120607: [lldb/test] Re-enable TestEvents.py on Darwin and fix crashes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120607/new/ https://reviews.llvm.org/D120607 ___

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

JDevlieghere added a comment. Herald added a project: All. I think the better solution here is to get rid of the `using namespace llvm;` in the implementation file instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.

[Lldb-commits] [PATCH] D120762: [lldb] Protect control variables in IOHandler with a mutex to avoid a data race

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, jingham, labath. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Fixes a data race between the main thread and the process handling thread: WARNING:

[Lldb-commits] [PATCH] D120766: [lldb] Devirtualize IOHandler::{IsActive, SetIsDone, GetIsDone} (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, jingham, labath, mib. Herald added a project: All. JDevlieghere requested review of this revision. There are no implementations overriding these methods. https://reviews.llvm.org/D120766 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere updated this revision to Diff 412316. JDevlieghere retitled this revision from "[lldb] Protect control variables in IOHandler with a mutex to avoid a data race" to "[lldb] Avoid data race in IOHandlerProcessSTDIO". JDevlieghere edited the summary of this revision. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere added a comment. In D120762#3352628 , @labath wrote: > These kinds of changes rarely fix a bug -- usually they just change a > (detectable) data race into some nondeterministic runtime behavior. > > That's because, even though e.g. `IsActive

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Process.cpp:4343 +std::lock_guard guard(m_mutex); +if (GetIsDone()) + break; labath wrote: > I'm confused. How come this doe

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere updated this revision to Diff 412337. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Fix typo in `SetIsRunning`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120762/new/ https://reviews.llvm.org/D120762 Files: lldb/source/Target/Process.cpp

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere added a comment. In D120762#3353655 , @labath wrote: > Are you sure that we're still sending input to the process (I'm not sure how > much test coverage for this do we have)? I'll rerun the tests tomorrow with my typo and see if anything ca

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere updated this revision to Diff 412479. JDevlieghere added a comment. Unsurprisingly no tests failed with the typo. Added a test case to cover reading from stdin through the `IOHandlerProcessSTDIO`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120762/new/ https://reviews.ll

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. It's always great to see changes that enable more testing. I left one inline comment/nit but besides that this LGTM. Comment at: lldb/source/Target/Platform.cpp:

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

JDevlieghere added a comment. Thanks for cleaning up the implementation file. LGMT module removing the added `lldb_private::` which I believe we no longer need. Comment at: lldb/include/lldb/Core/DataFileCache.h:164 /// True if the signature was successfully decoded, fals

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120594/new/ https://reviews.llvm.org/D120594 ___

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

JDevlieghere added a comment. I think you might be looking at a combination of the old and the new patch. The new mutex protects the whole `Cancel` and `SetIsRunning`. I don't think this needs to be a recursive mutex because these functions are not calling each other. They both indirectly prote

[Lldb-commits] [PATCH] D120762: [lldb] Avoid data race in IOHandlerProcessSTDIO

This revision was automatically updated to reflect the committed changes. Closed by commit rG10222764a9a3: [lldb] Avoid data race in IOHandlerProcessSTDIO (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D120762?vs=412479&id=412567#toc

[Lldb-commits] [PATCH] D120766: [lldb] Devirtualize IOHandler::{IsActive, SetIsDone, GetIsDone} (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG37eb15ad7ab2: [lldb] Devirtualize IOHandler::{IsActive,SetIsDone,GetIsDone} (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D120766?vs=4

[Lldb-commits] [PATCH] D120836: [LLDB] Remove cases of using namespace llvm:: from header file

JDevlieghere added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:46 using namespace lldb_private; +using namespace llvm::dwarf; Why not `lldb_private::dwarf`? Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleD

[Lldb-commits] [PATCH] D120836: [LLDB] Remove cases of using namespace llvm:: from header file

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:35 +using namespace dwarf; using namespace std; extern int g_verbose; [[ https://llvm.org/docs/CodingStandards.html#do-not-use-using-namespace-std | Oh

[Lldb-commits] [PATCH] D120836: [LLDB] Remove cases of using namespace llvm:: from header file

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:19 using namespace lldb; +using namespace dwarf; shafik wrote: > JDevlieghere wrote: > > Wouldn't it be more consistent to use `lldb_private::dwarf` everyw

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

JDevlieghere accepted this revision. JDevlieghere added a comment. Thank you! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

This revision was automatically updated to reflect the committed changes. Closed by commit rG71e278805a72: [lldb] Fix DataExtractor symbol conflict (authored by emrekultursay, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D120718?vs=412621&id=412740#toc Reposito

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. FWIW I'm planning some changes to the error reporting "soonish". The gist is using error/warning events which Xcode (or VSCode) can subscribe to. I'll send out an RFC with m

[Lldb-commits] [PATCH] D120923: [lldb] Remove FileSystem::Initialize from VFS mapping

JDevlieghere created this revision. JDevlieghere added reviewers: bnbarham, mib, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch removes the ability to instantiate the LLDB FileSystem class based on a VFS overlay. This also removes the "hack" where

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere added a comment. Might a `llvm::once_flag` + `llvm::call_once` be simpler? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews.llvm.org/D120892 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D120923: [lldb] Remove FileSystem::Initialize from VFS mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG59eb70527741: [lldb] Remove FileSystem::Initialize from VFS mapping (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:84 static ConstString GetEventIdentifier(); + static const char * + BreakpointEventTypeAsCString(lldb::BreakpointEventType type); Why not a llvm::StringRef? Repos

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere accepted this revision. JDevlieghere added a comment. Cool, thanks for the explanation. Ship it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews.llvm.org/D120892 __

[Lldb-commits] [PATCH] D120966: Remove cases of using namespace std

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120966/new/ https://reviews.llvm.org/D120966 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, mib, aprantl, kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds support for showing progress events when using lldb on the command line. It spawns a separate

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 412926. JDevlieghere added a comment. Remove unrelated formatting changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 Files: lldb/include/lldb/API/SBCommandInterpreterRunOptions.h lldb/include

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 412937. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. - Fix typo - Reduce stack size CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 Files: lldb/include/lldb/API/SBCom

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1822 +[this] { return ProgressHandlerThread(); }, +8 * 1024 * 1024); // Use larger 8MB stack for this thread +if (progress_handler_thread) { mib wrote: > Why

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 413058. JDevlieghere added a comment. - Reduce flickering by not printing the last status message when the the progress is complete - Add `...` as suggested by Adrian offline - Make ANSI (vt100) escape codes a requirement in order to show progress to si

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:413-416 +if (!has_path && !has_uuid) + return error_with_message("Dictionary should have key 'path' or 'uuid'"); +if (!dict->HasKey("load_addr")) + return er

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120969/new/ https://reviews.llvm.org/D120969 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 413108. JDevlieghere added a comment. - Move progress event handling in the regular event handler thread CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 Files: lldb/include/lldb/Core/Debugger.h ll

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 413110. JDevlieghere added a comment. - Unstage `lldb/include/lldb/Interpreter/CommandInterpreter.h`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 Files: lldb/include/lldb/Core/Debugger.h lldb/

[Lldb-commits] [PATCH] D120961: [LLDB] Flush stream at the end of PrintCommandOutput

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120961/new/ https://reviews.llvm.org/D120961 ___

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1757 + File &output = GetOutputFile(); + if (!output.GetIsTerminalWithColors() || !GetShowProgress()) +return; aprantl wrote: > And

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 413159. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - Make sure the output is both interactive and supports colors - Add more comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.ll

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1757 + File &output = GetOutputFile(); + if (!output.GetIsTerminalWithColors() || !GetShowProgress()) +return; JDevlieghere wrote: > aprantl wrote: > > And withColors also implies

[Lldb-commits] [PATCH] D121062: [lldb] Add a setting to change the progress color

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. Add a setting to change how progress is shown in a color enabled terminal. This follows the existing `-pref

[Lldb-commits] [PATCH] D121062: [lldb] Add a setting to change the progress color

JDevlieghere updated this revision to Diff 413263. JDevlieghere added a comment. ShowProgress{Prefix,Suffix} -> ShowProgressAnsi{Prefix,Suffix} CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121062/new/ https://reviews.llvm.org/D121062 Files: lldb/include/lldb/Core/Debugger.h lldb/s

[Lldb-commits] [PATCH] D121064: [lldb] Add a setting to change the autosuggestion ANSI escape codes

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. Herald added a project: All. JDevlieghere requested review of this revision. I'm a big fan of the autosuggestion feature but my terminal/color scheme doesn't display faint any differently than regular lldb output

[Lldb-commits] [PATCH] D121062: [lldb] Add a setting to change the progress ANSI escape codes

JDevlieghere updated this revision to Diff 413269. JDevlieghere retitled this revision from "[lldb] Add a setting to change the progress color" to "[lldb] Add a setting to change the progress ANSI escape codes". JDevlieghere added a comment. Fix copy/paste error in the help CHANGES SINCE LAST

[Lldb-commits] [PATCH] D121064: [lldb] Add a setting to change the autosuggestion ANSI escape codes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG080635ef2791: [lldb] Add a setting to change the autosuggestion ANSI escape codes (authored by JDevlieghere). Herald added a project: LLDB. Reposito

[Lldb-commits] [PATCH] D121131: [lldb] Support "bright" ANSI colors

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. Support ANSI escape codes for bright colors variants. Most modern terminals support them. Still LLDB is

[Lldb-commits] [PATCH] D121064: [lldb] Add a setting to change the autosuggestion ANSI escape codes

JDevlieghere added a comment. In D121064#3362890 , @teemperor wrote: > LGTM, thanks! FWIW, if you have `fish` installed you might wanna check what > they are doing on your terminal for its autosuggestions (and we might wanna > steal their default, even

[Lldb-commits] [PATCH] D121131: [lldb] Support "bright" ANSI colors

JDevlieghere added a comment. Adding @aprantl as a reviewer because he also likes colors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121131/new/ https://reviews.llvm.org/D121131 ___ lldb-commits maili

[Lldb-commits] [PATCH] D121036: Fix target.save-jit-objects when the CWD is not writeable

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValue.h:314 void SetValueChangedCallback(std::function callback) { -assert(!m_callback); m_callback = std::move(callback); That's a weird assert Com

[Lldb-commits] [PATCH] D121131: [lldb] Support "bright" ANSI colors

This revision was automatically updated to reflect the committed changes. Closed by commit rG0acc9e4b5edd: [lldb] Support "bright" ANSI colors (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D121131?vs=413511&id=413585#toc Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D121155: [lldb] Add --exists flag to `settings set`

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda, mib. Herald added a subscriber: dang. Herald added a project: All. JDevlieghere requested review of this revision. Add a --exists/-e flag to `settings set` that sets the setting if it exists, but doesn't print

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: All. JDevlieghere requested review of this revision. Avoid a static initializer for Log::Channel in LLDBLog.cpp https://reviews.llvm.org/D121161 Files: lldb/source/Utility/LLDBLog.cpp Index: l

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 413654. JDevlieghere marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/CoreProperties.td lldb/source/Core/

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added a comment. Thanks for the review Greg! Comment at: lldb/source/Core/CoreProperties.td:137 +DefaultTrue, +Desc<"Whether to show progress or not.">; def UseSourceCache: Property<"use-source-cache", "Boolean">, clayborg wrote: > Might

[Lldb-commits] [PATCH] D121036: Fix target.save-jit-objects when the CWD is not writeable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121036/new/ https://reviews.llvm.org/D121036 ___

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere added a comment. In D121161#3367806 , @labath wrote: > The class has a constexpr constructor. I thought that would be enough to > avoid runtime initialization. Is this being flagged by something? It is getting flagged by -Wglobal-constructo

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added a comment. In D120972#3368055 , @jingham wrote: > In D120972#3368008 , @clayborg > wrote: > >> This is fine as a starting point, my only question is if the setting should >> be "interpreter.sh

[Lldb-commits] [PATCH] D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. These are not meant to be on hot code paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121226/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

JDevlieghere added a comment. LGTM. I left a comment with a suggestion for a context manager but that's up to you. Comment at: lldb/examples/python/crashlog.py:1023-1024 + +async_state = debugger.GetAsync() +debugger.SetAsync(False) + This is the perf

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a27b99825a5: [lldb] Show progress events in the command line driver (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D121062: [lldb] Add a setting to change the progress ANSI escape codes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG097d46f41c46: [lldb] Add a setting to change the progress color (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D121

[Lldb-commits] [PATCH] D121155: [lldb] Add --exists flag to `settings set`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a0fa4db39d8: [lldb] Add --exists flag to `settings set` (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D121155?vs=413615&id=414016#toc Repo

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added a comment. In D120972#3369002 , @thakis wrote: > This breaks building on Windows where GetMessage is defined to GetMessageW: > http://45.33.8.238/win/54664/step_4.txt > > Please fix (just rename to something else), or revert for now if

[Lldb-commits] [PATCH] D121252: [lldb] Add SBType::IsAggregateType

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121252/new/ https://reviews.llvm.org/D121252 ___

[Lldb-commits] [PATCH] D121290: [lldb] Create an enum to specify the kind of ArchSpec matching

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121290/new/ https://reviews.llvm.org/D121290 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Assuming this isn't relevant anymore, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121305/new/ https://reviews.llvm.org/D1213

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere abandoned this revision. JDevlieghere added a comment. In D121161#3369641 , @labath wrote: > Amusingly enough, the problem is the custom operator| used for bitmask enums. > D121281 ought to fix that (by mak

<    5   6   7   8   9   10   11   12   13   14   >