[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

JDevlieghere added a comment. In D124673#3484157 , @MaskRay wrote: > I vaguely recall that some lldb bots use a stand-alone build. Yup, that's correct. The bot in question is https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ Reposi

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere added a comment. Can we add a pexpect test for this? Comment at: lldb/source/Core/Debugger.cpp:1873-1875 + if (message.size() + prefix_width + suffix_width >= term_width) +message.erase(message.begin() + term_width - prefix_width - suffix_width, +

[Lldb-commits] [PATCH] D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, mib. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. https://reviews.llvm.org/D124799 Files: lldb/source/Plugins/Platform/MacOSX/CMakeLists.tx

[Lldb-commits] [PATCH] D124800: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, mib. Herald added a project: All. JDevlieghere requested review of this revision. https://reviews.llvm.org/D124800 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp lldb/source/Plugins/Platfor

[Lldb-commits] [PATCH] D124801: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, mib. Herald added a project: All. JDevlieghere requested review of this revision. Make GetSharedModuleWithLocalCache consider the device support directory. In the past we only needed the device support direct

[Lldb-commits] [PATCH] D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG41c0ff1e740b: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D124799?vs=4

[Lldb-commits] [PATCH] D124800: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG322b4130415a: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repo

[Lldb-commits] [PATCH] D124801: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe53019a8ff77: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory (authored by JDevlieghere). Herald added a project: LLD

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

JDevlieghere added inline comments. Comment at: lldb/CMakeLists.txt:3-5 +if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS) + set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake) +endif() Can this go in `lldb/cmake/modules/LLDBStandalone.cmake`? Repository:

[Lldb-commits] [PATCH] D124872: [lldb] Add a function to check if lldb is running in an interactive session

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds a function to check if lldb is running in an interactive debug session. Currently this API only works on macOS. It's expected to

[Lldb-commits] [PATCH] D124873: [lldb] Session transcript should use the async debugger streams

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. When writing out the session transcript, output should be printed to the async debugger streams. https://reviews.llvm.org/D124873 Files: lldb/s

[Lldb-commits] [PATCH] D124873: [lldb] Session transcript should use the async debugger streams

JDevlieghere updated this revision to Diff 426821. JDevlieghere added a comment. Typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124873/new/ https://reviews.llvm.org/D124873 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp ===

[Lldb-commits] [PATCH] D124872: [lldb] Add a function to check if lldb is running in an interactive session

JDevlieghere updated this revision to Diff 426822. JDevlieghere added a comment. IsInteractiveSession -> IsInteractiveGraphicSession CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124872/new/ https://reviews.llvm.org/D124872 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/comm

[Lldb-commits] [PATCH] D124873: [lldb] Session transcript should use the async debugger streams

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d08c778c01e: [lldb] Session transcript should use the async debugger streams (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D124872: [lldb] Add a function to check if lldb is running in an interactive session

This revision was automatically updated to reflect the committed changes. Closed by commit rGb945b62cf35e: [lldb] Add a function to check if lldb is running in an interactive session (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D124

[Lldb-commits] [PATCH] D124947: Allow `target create` with no local file

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124947/new/ https://reviews.llvm.org/D124947 ___

[Lldb-commits] [PATCH] D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I'm far from an expert on this but the change makes sense to me and has good test coverage. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. This looks reasonable to me, but I'm not sure if there's anything special about the executable module that would result in us doing the wrong thing. I'm sure Jim or Pavel will know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

JDevlieghere added a comment. Does that mean that the interactive crashlogs (`crashlog -i`) do this correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125042/new/ https://reviews.llvm.org/D125042 _

[Lldb-commits] [PATCH] D125107: [lldb] Parallelize fetching symbol files in crashlog.py

JDevlieghere created this revision. JDevlieghere added reviewers: mib, clayborg. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. When using dsymForUUID, the majority of time symbolication a crashlog with crashlog.py is spent w

[Lldb-commits] [PATCH] D125107: [lldb] Parallelize fetching symbol files in crashlog.py

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:272 if self.show_symbol_progress(): -print('Getting symbols for %s %s...\n' % (uuid_str, self.path), end=' ') +print('Getting symbols for %s %s...' % (uu

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1873-1875 + if (message.size() + prefix_width + suffix_width >= term_width) +message.erase(message.begin() + term_width - prefix_width - suffix_width, + message.end()); ---

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBCompileUnit.h:37 + uint32_t GetIndexForLineEntry(lldb::SBLineEntry &line_entry, +bool exact = false) const; How's this different from `FindLineEntryIndex`?

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBCompileUnit.h:37 + uint32_t GetIndexForLineEntry(lldb::SBLineEntry &line_entry, +bool exact = false) const; mib wrote: > JDevlieghere wrote: > > How's this

[Lldb-commits] [PATCH] D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:80-111 +// Static Variables +static uint32_t g_initialize_count = 0; + +void PlatformDarwin::Initialize() { + Platform::Initialize(); + + if (g_initialize_count++ == 0) {

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added inline comments. Comment at: lldb/test/API/commands/breakpoint/set/address-nomodule/TestBreakpointAddressNoModule.py:11 +def get_address_from_symbol(self, symbol): +target = lldbutil.run_to_breakpoint_make_target(self, "a.out", True) +bp =

[Lldb-commits] [PATCH] D125107: [lldb] Parallelize fetching symbol files in crashlog.py

JDevlieghere closed this revision. JDevlieghere added a comment. a8abb695859ad4e7fe695b9ee238a2b0cd00af7c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125107/new/ https://reviews.llvm.org/D125107 __

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

JDevlieghere added a comment. LGTM PS: Small typo in your summary: `s/abot/about/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125154/new/ https://reviews.llvm.org/D125154 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D125218: [lldb][NFC] Make cmd a reference in GenerateOptionUsage

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125218/new/ https://reviews.llvm.org/D125218 ___

[Lldb-commits] [PATCH] D125219: [lldb][NFC] Simplify GenerateOptionUsage

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125219/new/ https://reviews.llvm.org/D125219 ___

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. crashlog.py catches every exception in order to format them. This results in both the exception name as well as the backtrace getting swallowed. He

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return mib wrote: > What a

[Lldb-commits] [PATCH] D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125594/new/ https://reviews.llvm.org/D125594 ___

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGae016e4f7c85: [lldb] Don't swallow crashlog exceptions (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp:155 + // add the symbol ObjectFile to this Module. + if (dsym_objfile_sp.get() && !module_sp->GetSymbolFileFileSpec()) { +module_sp->SetSymbolFileFileS

[Lldb-commits] [PATCH] D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125616/new/ https://reviews.llvm.org/D125616 ___

[Lldb-commits] [PATCH] D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. Avoid a OverflowError when the pc is zero. This can happen for "unknown frames" where the crashlog generator reports a zero pc. We could omit them a

[Lldb-commits] [PATCH] D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG9defb3b4b4a3: [lldb] Prevent underflow in crashlog.py (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D111791: [lldb] Add --all option to "memory region"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Minor nit but LGTM Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1707 +ConstString name = range_info.GetName(); +ConstString section_name; +

[Lldb-commits] [PATCH] D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125915/new/ https://reviews.llvm.org/D125915 ___

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere added inline comments. Comment at: lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py:29-30 +self.launch(use_colors=True) +# Set the terminal to a random width +term_width = random.randint(10, 42) +self.e

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. Still a few places where we have a dedicated assert Comment at: lldb/test/API/commands/breakpoint/set/address-nomodule/TestBreakpointAddressNoModule.py:25 +debugger.HandleCommand(f"break set -a {main_address:#x}") +self.assertTrue(

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:118-119 -# Any frame above frame zero and we have to subtract one to -# get the previous line entry. +# We should substract 1 to every frame's pc abo

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125928/new/ https://reviews.llvm.org/D125928 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

JDevlieghere added a comment. Separating the notion of an expression and an expression list seems worthwhile. I did a very high level pass but I'll take a more detailed look tomorrow. Comment at: lldb/include/lldb/Expression/DWARFExpressionList.h:1-2 +//===-- DWARFExpressionLi

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere added inline comments. Comment at: lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py:49-50 +self.do_test(80, ['Locating external symbol file for a.out...', + 'Loading Apple DWARF index for a.out...', +

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the decorator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 ___ lldb-co

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. A deployment target that's less than 10.13.4 causes an error saying that 'ptsname_r' is only available on mac

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

This revision was automatically updated to reflect the committed changes. Closed by commit rGea4864007c72: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Passes the test suite on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126057/new/ https://reviews.llvm.org/D126057 __

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere accepted this revision. JDevlieghere added a comment. No worries, thank you for your patience. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 _

[Lldb-commits] [PATCH] D126076: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Report the correct register number (GENERIC_REGNUM_FLAGS) for cpsr. This fixes TestLldbGdbServer.py on Apple Silicon. https://reviews.llv

[Lldb-commits] [PATCH] D126076: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1cf154dd476: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126078: [lldb] Improve formatting of dlopen error messages (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126078/new/ https://reviews.llvm.org/D126078 ___

[Lldb-commits] [PATCH] D126081: [lldb] Fix spurious lldb_assert in PrintCommandOutput

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, mib. Herald added a project: All. JDevlieghere requested review of this revision. When the string passed to PrintCommandOutput doesn't end with a newline, `writte`n will exceed `size` and result in an lldbassert

[Lldb-commits] [PATCH] D126080: Adapt C++ std::string dataformatter for D125496

JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126080/new/ https://reviews.llvm.org/D126080 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. Please let me know if you need someone to land this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 ___ lldb-commi

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa3c3482ceb52: [lldb] Consider binary as module of last resort (authored by hawkinsw, committed by JDevlieghere). Reposito

[Lldb-commits] [PATCH] D126081: [lldb] Fix spurious lldb_assert in PrintCommandOutput

This revision was automatically updated to reflect the committed changes. Closed by commit rGd252d9231c4a: [lldb] Fix spurious assertion in PrintCommandOutput (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D126103: Remove `friend` classes from TypeCategoryMap

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126103/new/ https://reviews.llvm.org/D126103 ___

[Lldb-commits] [PATCH] D126217: [lldb] Improve TestAppleSimulatorOSType.py error message

JDevlieghere created this revision. JDevlieghere added reviewers: augusto2112, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Show a more informative error message when we fail to parse the simctl output. It was inspired by https://reviews.llvm.org/D109336 w

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces

JDevlieghere added a comment. Test? :-) Comment at: lldb/examples/python/crashlog.py:567-570 +frame_regex = re.compile(r'^([0-9]+)' r'\s'# id +r'+(.+?)'r'\s+' # img_name +r'(0x

[Lldb-commits] [PATCH] D126217: [lldb] Improve TestAppleSimulatorOSType.py error message

This revision was automatically updated to reflect the committed changes. Closed by commit rG436eaf8d32fa: [lldb] Improve TestAppleSimulatorOSType.py error message (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

JDevlieghere added a comment. In D126109#3534522 , @hawkinsw wrote: > @DavidSpickett Thanks (again) for the feedback. Once I fix the nit, is the > proper protocol for you to review again? I am sorry to ask but I don't know > the right procedure and don'

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

JDevlieghere added inline comments. Comment at: lldb/examples/python/cont_to_bkpt.py:5 +def __init__(self, debugger, unused): +return + Nit: The "Pythonic" way of doing is using `pass` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Target.h:1451 + /// Print all the signals set in this target. + void PrintDummySignals(Stream &strm, Args signals, size_t num_signals); + Was `Args` supposed to be a reference here? If not

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

JDevlieghere added a comment. I was about to push a fix but it seems like it was already fixed by: commit 4391625255c62074037d95a55232a87eae70c60b Author: Kazu Hirata Date: Wed May 25 09:49:05 2022 -0700 [lldb] Fix an unused function warning This patch fixes:

[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

JDevlieghere added a comment. Very nice Comment at: lldb/source/Core/SourceManager.cpp:69-73 + FileSpec resolved_fspec = file_spec; + if (!FileSystem::Instance().Exists(file_spec) && + file_spec.GetDirectory().GetCString()[0] == '~') { +FileSystem::Instance().Resolve

[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126435/new/ https://reviews.llvm.org/D126435 ___

[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Commands/CommandObjectProcess.cpp:1477-1479 +bool only_target_values; +bool do_clear; +bool dummy; jingh

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

This revision was automatically updated to reflect the committed changes. Closed by commit rG84b9985f5f63: [lldb] Fix broken bad-address-breakpoint test (authored by hawkinsw, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Apparently closing a revision requires it to be accepted first. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68671/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D126507: [lldb/fuzzer] Moving target fuzzer into separate subdirectory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126507/new/ https://reviews.llvm.org/D126507 __

[Lldb-commits] [PATCH] D126507: [lldb/fuzzer] Moving target fuzzer into separate subdirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG5451c4b4fb54: [lldb/fuzzer] Moving target fuzzer into separate subdirectory (authored by cassanova, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D126507?vs=432414&id=432

[Lldb-commits] [PATCH] D126557: [lldb] Fix cross compiling on macOS

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126557/new/ https://reviews.llvm.org/D126557 ___

[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126789/new/ https://reviews.llvm.org/D126789 ___

[Lldb-commits] [PATCH] D126596: [lldb, test] Fix typos in the lldb tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Interesting insight in which tests were clearly copied from the sample test. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D127247: On Darwin systems, follow transition from on-disk dyld to shared-cache dyld at process launch

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. This was also reviewed internally and we've been living on this patch for a while now. Testing is provided by running the existing test suite on macOS Ventura. Repository:

[Lldb-commits] [PATCH] D127252: [lldb] Use objc_getRealizedClassList_trylock if available

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. In order to avoid stranding the Objective-C runtime lock, we switched from `objc_copyRealizedClassList` to its non

[Lldb-commits] [PATCH] D127258: [lldb] Mark API tests as XFAIL if they have expected failures and no passing tests

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, mib. Herald added a project: All. JDevlieghere requested review of this revision. Currently, when an API test has no passing tests but at least one unsupported test, we report the test as unsupported. This patch slightly c

[Lldb-commits] [PATCH] D127258: [lldb] Mark API tests as XFAIL if they have expected failures and no passing tests

JDevlieghere updated this revision to Diff 434984. JDevlieghere added a comment. I was in the process of writing a comment saying that we could be even more accurate by parsing the number of tests with a particular result code from the dotest output but that that seemed overkill before I changed

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

JDevlieghere added a comment. Here are the results: Before: Unsupported: 145 Passed : 873 Failed : 7 After: Unsupported : 167 Passed : 834 Expectedly Failed: 16 Unresolved : 1 Failed : 7 Note that this pat

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

JDevlieghere updated this revision to Diff 435170. JDevlieghere added a comment. Mark the test as FAIL or PASS if there's at least one test that respectively failed or passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127258/new/ https://reviews.llvm.org/D127258 Files: lldb/test

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

JDevlieghere added a comment. In D127258#3565279 , @kastiglione wrote: > instead of reducing and picking returning a single result, can we return the > raw counts and then report the totals of the counts? No, the lit test format does not support that.

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3202a592317: [lldb] Parse the dotest output to determine the most appropriate result code (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D127252: [lldb] Use objc_getRealizedClassList_trylock if available

JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Thanks Jim, I've addressed your comments in the final commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127252/new/ https://reviews.llvm.org/D127252 _

[Lldb-commits] [PATCH] D127252: [lldb] Use objc_getRealizedClassList_trylock if available

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc43703481d8: [lldb] Use objc_getRealizedClassList_trylock on macOS Ventura and later (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D127252?vs=434941&id=435269#toc Repos

[Lldb-commits] [PATCH] D127331: [lldb] Update TestModuleLoadedNotifys.py for macOS Ventura

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. On macOS Ventura and later, dyld and the main binary will be loaded again when dyld moves itself into the shared cache. Update the test acc

[Lldb-commits] [PATCH] D127336: [lldb] Remove default argument from getBuildArtifact

JDevlieghere created this revision. Herald added a project: All. JDevlieghere requested review of this revision. Remove default argument from lldbtest.getBuildArtifact. https://reviews.llvm.org/D127336 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/functionalities/gdb_

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

JDevlieghere created this revision. JDevlieghere added reviewers: kastiglione, mib. Herald added a project: All. JDevlieghere requested review of this revision. Add a function to make it easier to debug a test failure caused by an unexpected state. Currently, tests are using `assertEqual` which r

[Lldb-commits] [PATCH] D127331: [lldb] Update TestModuleLoadedNotifys.py for macOS Ventura

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b55eb80734: [lldb] Update TestModuleLoadedNotifys.py for macOS Ventura (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D127331?vs=435282&id=

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

JDevlieghere updated this revision to Diff 435372. JDevlieghere added a comment. Implement Ismail's suggestion: AssertionError: stopped (5) != exited (10) : Got exit event CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127355/new/ https://reviews.llvm.org/D127355 Files: lldb/packag

[Lldb-commits] [PATCH] D127362: [lldb/crashlog] Show help when the command is called without any argument

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with a test :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127362/new/ https://reviews.llvm.org/D127362 ___

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

This revision was automatically updated to reflect the committed changes. Closed by commit rGce825e46743b: [lldb] Add assertState function to the API test suite (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D127378: [lldb] Use assertState in more tests (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In never realized we had both `assertEqual` and `assertEquals`. Great... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127378/new/ h

[Lldb-commits] [PATCH] D127410: [lldb] Add table with custom LLDB asserts

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Add table with custom LLDB asserts to the docs. https://reviews.llvm.org/D127410 Files: lldb/docs/resources/test.rst Index: lldb/docs/reso

[Lldb-commits] [PATCH] D127410: [lldb] Add table with custom LLDB asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rG6565580f1b40: [lldb] Add table with custom LLDB asserts to the docs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D127437: [LLDB][Docs] Fix formatting of example code-block

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127437/new/ https://reviews.llvm.org/D127437 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense to me. Maybe add a small shell test that includes the example from the description? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

JDevlieghere added a comment. Can this go into `lldb-target-fuzzer/CMakeLists.txt`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___ lldb-commits mailing lis

<    10   11   12   13   14   15   16   17   18   19   >