https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/132255
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -54,6 +54,79 @@ bool fromJSON(const llvm::json::Value &, DisconnectArguments
&,
/// body field is required.
using DisconnectResponse = VoidResponse;
+/// Arguments for `initialize` request.
+struct InitializeRequestArguments {
+ /// The ID of the debug adapter.
+ std::st
@@ -112,3 +112,48 @@ def test_readMemory(self):
# Reads at offset 0x0 fail
mem = self.dap_server.request_readMemory("0x0", 0, 6)
self.assertEqual(mem["success"], False)
+
+def test_writeMemory(self):
+"""
+Tests the 'writeMemory' requ
@@ -52,14 +37,33 @@ struct SourceBreakpoint : public Breakpoint {
static bool BreakpointHitCallback(void *baton, lldb::SBProcess &process,
lldb::SBThread &thread,
lldb::SBBreakpointLocation &location);
-}
@@ -397,6 +402,23 @@ struct DAP {
InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t
bp_id);
InstructionBreakpoint *GetInstructionBPFromStopReason(lldb::SBThread
&thread);
+
+ /// Checks if the request is cancelled.
+ bool IsCancelled(const protocol
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/133811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
I may need to split this up into a smaller set of patches. Let me know what you
think.
https://github.com/llvm/llvm-project/pull/133624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -12,25 +12,35 @@
#include "DAPForward.h"
#include "lldb/API/SBBreakpoint.h"
#include "lldb/lldb-enumerations.h"
+#include "llvm/ADT/StringRef.h"
#include
#include
namespace lldb_dap {
-struct ExceptionBreakpoint {
- DAP &dap;
- std::string filter;
- std::string l
@@ -19,10 +19,39 @@
#include "lldb/lldb-forward.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
-#include
+#include
+#include
namespace lldb_dap {
+class EndOfFileError : public llvm::ErrorInfo {
+public:
+ static char ID;
+
+ EndOfFileError() = def
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130169
>From c183231db80d6c97bdd5e9bd0b21d041189146e8 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 18 Mar 2025 14:05:38 -0700
Subject: [PATCH 01/12] [lldb-dap] Adding support for cancelling a request.
Adding
@@ -49,6 +41,17 @@ struct BreakpointBase {
/// breakpoint in one of the DAP breakpoints that we should report changes
/// for.
static constexpr const char *kDAPBreakpointLabel = "dap";
+
+protected:
+ /// Associated DAP session.
+ DAP &dap;
+
+ /// An optional expressi
@@ -52,14 +37,33 @@ struct SourceBreakpoint : public Breakpoint {
static bool BreakpointHitCallback(void *baton, lldb::SBProcess &process,
lldb::SBThread &thread,
lldb::SBBreakpointLocation &location);
-}
ashgti wrote:
A `SIGPIPE` is raised if your process writes a pipe that is closed on the other
end. If the python script is getting that then `lldb-dap` must have closed
stdin.
The Transport `input` does take ownership of stdin
(https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-da
ashgti wrote:
Wanted to also double check with @labath as well, any additional thoughts?
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/133811
>From 9053618204265ea71a6a30382937cff584f8c02d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 31 Mar 2025 14:36:16 -0700
Subject: [PATCH 1/2] [lldb-dap] Do not take ownership of stdin.
There isn't any b
@@ -571,7 +571,7 @@ int main(int argc, char *argv[]) {
}
lldb::IOObjectSP input = std::make_shared(
- fileno(stdin), File::eOpenOptionReadOnly, true);
+ fileno(stdin), File::eOpenOptionReadOnly, false);
ashgti wrote:
Applied.
https://github.com
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/133811
There isn't any benefit to taking ownership of stdin and it may cause issues if
`Transport` is dealloced.
>From 9053618204265ea71a6a30382937cff584f8c02d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 3
@@ -19,10 +19,39 @@
#include "lldb/lldb-forward.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
-#include
+#include
+#include
namespace lldb_dap {
+class EndOfFileError : public llvm::ErrorInfo {
+public:
+ static char ID;
+
+ EndOfFileError() = def
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130169
>From c183231db80d6c97bdd5e9bd0b21d041189146e8 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 18 Mar 2025 14:05:38 -0700
Subject: [PATCH 01/13] [lldb-dap] Adding support for cancelling a request.
Adding
ashgti wrote:
Does setting the 3rd param to `false` on
https://github.com/llvm/llvm-project/blob/5e2860a8d375ded2d2912894e380fefc8cb1f23a/lldb/tools/lldb-dap/lldb-dap.cpp#L574
change anything for you?
https://github.com/llvm/llvm-project/pull/133791
@@ -0,0 +1,103 @@
+import * as vscode from "vscode";
+import * as child_process from "child_process";
+import * as util from "util";
+import { LLDBDapServer } from "./lldb-dap-server";
+import { createDebugAdapterExecutable } from "./debug-adapter-factory";
+import { ConfigureButt
@@ -90,117 +99,119 @@ async function getDAPExecutable(
return foundPath;
}
- return undefined;
+ throw new ErrorWithNotification(
+"Unable to find the path to the LLDB debug adapter executable.",
+new OpenSettingsButton("lldb-dap.executable-path"),
+ );
}
-
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130026
>From 88f1cf3469c9f24a768f5147c22cfe414aea014e Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Sat, 8 Mar 2025 17:55:34 -0800
Subject: [PATCH 1/4] [lldb-dap] Adding logging helpers.
Improving logging by defin
https://github.com/ashgti approved this pull request.
Overall looks great, a few questions / follow items
https://github.com/llvm/llvm-project/pull/129262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130090
>From f26c9a79ca234bee77ec1a9694bf8be2d0e3745c Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 13:21:10 +0100
Subject: [PATCH 1/8] [lldb-dap] Updating RequestHandler to encode/decode
arguments
@@ -57,235 +77,306 @@ class RequestHandler {
DAP &dap;
};
-class AttachRequestHandler : public RequestHandler {
-public:
- using RequestHandler::RequestHandler;
+/// Base class for handling DAP requests. Handlers should declare their
+/// arguments and response body types l
@@ -663,58 +671,65 @@ void DAP::SetTarget(const lldb::SBTarget target) {
}
bool DAP::HandleObject(const protocol::Message &M) {
- // FIXME: Directly handle `Message` instead of serializing to JSON.
- llvm::json::Value v = toJSON(M);
- llvm::json::Object object = *v.getAsObj
@@ -663,58 +671,65 @@ void DAP::SetTarget(const lldb::SBTarget target) {
}
bool DAP::HandleObject(const protocol::Message &M) {
- // FIXME: Directly handle `Message` instead of serializing to JSON.
- llvm::json::Value v = toJSON(M);
- llvm::json::Object object = *v.getAsObj
@@ -0,0 +1,130 @@
+import * as child_process from "node:child_process";
+import * as vscode from "vscode";
+
+function areArraysEqual(lhs: T[], rhs: T[]): boolean {
+ if (lhs.length !== rhs.length) {
+return false;
+ }
+ for (let i = 0; i < lhs.length; i++) {
+if (lhs[i
ashgti wrote:
#130186 should fix the failure.
https://github.com/llvm/llvm-project/pull/129964
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,12 +1,12 @@
-//===-- Protocol.cpp
--===//
+//===-- ProtocolBase.cpp
--===//
ashgti wrote:
I used the names of the categories from the spec for the files,
@@ -162,4 +162,13 @@ GetEnvironmentFromArguments(const llvm::json::Object
&arguments) {
return envs;
}
+llvm::Error takeError(const lldb::SBError &error) {
ashgti wrote:
Done.
https://github.com/llvm/llvm-project/pull/130090
__
@@ -663,58 +671,64 @@ void DAP::SetTarget(const lldb::SBTarget target) {
}
bool DAP::HandleObject(const protocol::Message &M) {
- // FIXME: Directly handle `Message` instead of serializing to JSON.
- llvm::json::Value v = toJSON(M);
- llvm::json::Object object = *v.getAsObj
@@ -248,6 +246,7 @@ struct DAP {
// Serialize the JSON value into a string and send the JSON packet to
// the "out" stream.
void SendJSON(const llvm::json::Value &json);
+ void Send(const protocol::Message &message);
ashgti wrote:
Done.
https://github.
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/130090
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/135684
>From cab7671780bde4d4e2e137f10ced6b5fe504 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 14 Apr 2025 13:22:31 -0700
Subject: [PATCH 1/2] [lldb-dap] Imporve error reporting if a command's
arguments
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/136210
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/136642
This updates the 'next' request to use well structured types. While working on
this I also simplified the 'RequestHandler' implementation to better handle
void responses by allowing requests to return a 'llvm::E
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/136210
Reverse requests do have a 'seq' set still from VSCode. I incorrectly
interpreted
https://github.com/microsoft/vscode/blob/dede7bb4b7e9c9ec69155a243bb84037a40588fe/src/vs/workbench/contrib/debug/common/abstractD
@@ -322,6 +323,186 @@ enum SteppingGranularity : unsigned {
bool fromJSON(const llvm::json::Value &, SteppingGranularity &,
llvm::json::Path);
+/// Information about a breakpoint created in `setBreakpoints`,
+/// `setFunctionBreakpoints`, `setInstructionBreakpoin
@@ -322,6 +323,186 @@ enum SteppingGranularity : unsigned {
bool fromJSON(const llvm::json::Value &, SteppingGranularity &,
llvm::json::Path);
+/// Information about a breakpoint created in `setBreakpoints`,
+/// `setFunctionBreakpoints`, `setInstructionBreakpoin
@@ -43,6 +43,32 @@ bool fromJSON(const json::Value &Params, Source &S,
json::Path P) {
O.map("sourceReference", S.sourceReference);
}
+static llvm::json::Value ToString(PresentationHint hint) {
ashgti wrote:
toJSON?
Then on line 67 you don't need t
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/137723
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/137071
Migrates the 'stepIn' request handler to have well structured types instead of
raw json values.
I also noticed in the 'next' request handler we were not passing the 'RunMode'
flag. Updated the 'next' request ha
@@ -8,72 +8,37 @@
#include "DAP.h"
#include "EventHelper.h"
-#include "JSONUtils.h"
+#include "Protocol/ProtocolTypes.h"
#include "RequestHandler.h"
+#include "llvm/Support/Error.h"
+
+using namespace llvm;
+using namespace lldb_dap::protocol;
namespace lldb_dap {
-// "N
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/137026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -8,72 +8,37 @@
#include "DAP.h"
#include "EventHelper.h"
-#include "JSONUtils.h"
+#include "Protocol/ProtocolTypes.h"
#include "RequestHandler.h"
+#include "llvm/Support/Error.h"
+
+using namespace llvm;
+using namespace lldb_dap::protocol;
namespace lldb_dap {
-// "N
ashgti wrote:
I updated my branch with main and updated the launch handler to return an
`llvm::Error` to simplify the body.
https://github.com/llvm/llvm-project/pull/133624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/136486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,64 @@
+"""
+Test lldb-dap stack trace containing x86 assembly
+"""
+
+import lldbdap_testcase
+from lldbsuite.test.decorators import skipUnlessArch, skipUnlessPlatform
+from lldbsuite.test.lldbtest import line_number
+
+
+class TestDAP_stacktrace_x86(lldbdap_testcase.DA
https://github.com/ashgti approved this pull request.
Awesome!
https://github.com/llvm/llvm-project/pull/137426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/137485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/136642
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/137911
>From a43b90dba56bd411b09257d47e3a3091faa09efd Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 29 Apr 2025 17:36:46 -0700
Subject: [PATCH 1/2] [lldb-dap] Migrate attach to typed RequestHandler.
This upda
https://github.com/ashgti approved this pull request.
LGTM, that’s helpful for making sure we’re consistent at least
https://github.com/llvm/llvm-project/pull/137900
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -235,4 +235,15 @@ std::string GetStringValue(const lldb::SBStructuredData
&data) {
return str;
}
+ScopeSyncMode::ScopeSyncMode(lldb::SBDebugger &debugger)
+: m_debugger(debugger) {
+ assert(m_debugger.GetAsync() && "Debugger not in asynchronous mode!");
ashgti wrote:
We could block the DAP queue until we get the stop event before we send the
`initialized` event maybe.
https://github.com/llvm/llvm-project/blob/d7f096e3fe611ae2cc7403c3cf2f88255a47b61d/lldb/tools/lldb-dap/Handler/LaunchRequestHandler.cpp#L70-L77
is where I am thinking we can wai
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/137911
This updates the `attach` request to the typed
`RequestHandler`.
Added a few more overlapping configurations to
`lldb_dap::protocol::Configuration` that are shared between launching and
attaching.
There may b
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/133624
>From 3240fe49515e5f59c5b9ff9c02423b77504d8a43 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 28 Mar 2025 14:02:53 -0700
Subject: [PATCH 1/6] [lldb-dap] Refactoring lldb-dap 'launch' request to use
type
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/135638
This enum was not fully specified.
>From 1fe129959d425d8f298e111d73cfa88e429e3cfc Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 14 Apr 2025 09:07:48 -0700
Subject: [PATCH] [lldb-dap] Fix win32 build.
ashgti wrote:
PR #135638 should fix the build failure.
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/133624
>From 3240fe49515e5f59c5b9ff9c02423b77504d8a43 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 28 Mar 2025 14:02:53 -0700
Subject: [PATCH 1/8] [lldb-dap] Refactoring lldb-dap 'launch' request to use
type
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/135638
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -9,127 +9,66 @@
#include "DAP.h"
#include "EventHelper.h"
#include "JSONUtils.h"
+#include "Protocol/ProtocolRequests.h"
#include "RequestHandler.h"
#include "llvm/Support/FileSystem.h"
namespace lldb_dap {
-// "LaunchRequest": {
-// "allOf": [ { "$ref": "#/definiti
@@ -33,15 +35,12 @@ MakeArgv(const llvm::ArrayRef &strs) {
return argv;
}
-static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj,
- llvm::StringRef key, lldb::LaunchFlags mask) {
- if (const auto opt_value = GetBoolean(obj,
ashgti wrote:
This should fix https://lab.llvm.org/buildbot/#/builders/197/builds/3983
https://github.com/llvm/llvm-project/pull/135638
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/135872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
Does attach normally only check the basename of the executable? Or is it
supposed to match the entire path?
I see a comment in `TestDAP_attach.test_by_name` that mentions making the path
more unique, so I'm wondering if something else has c
https://github.com/ashgti approved this pull request.
Looks great!
https://github.com/llvm/llvm-project/pull/137803
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -417,8 +424,11 @@ struct DAP {
lldb::SBMutex GetAPIMutex() const { return target.GetAPIMutex(); }
private:
- std::mutex m_queue_mutex;
+ /// Queue for all incoming messages.
std::deque m_queue;
+ /// Dedicated queue for launching and attaching.
+ std::deque m_launc
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
@@ -938,15 +954,30 @@ llvm::Error DAP::Loop() {
StopEventHandlers();
});
- while (!disconnecting || !m_queue.empty()) {
+ while (true) {
std::unique_lock lock(m_queue_mutex);
-m_queue_cv.wait(lock, [&] { return disconnecting || !m_queue.empty(); });
+m_que
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
@@ -893,10 +893,23 @@ llvm::Error DAP::Loop() {
return errWrapper;
}
+ // The launch sequence is special and we need to carefully handle
+ // packets in the right order. The launch and attach requests cannot
+ // be answered unt
@@ -161,20 +161,22 @@ static void EventThreadFunction(DAP &dap) {
case lldb::eStateSuspended:
break;
case lldb::eStateStopped:
-// We launch and attach in synchronous mode then the first stop
-// event will not be delivere
ashgti wrote:
To clarify the DAP flow a little, see 'Launch Sequencing' in
https://microsoft.github.io/debug-adapter-protocol/overview
Once the DAP server send the response to the `initialize` request the following
happen in parallel:
* The `initialized` event triggers the client sending `set
ashgti wrote:
> Technically the response of launch/attach should be the end of the chain.
Thats not how its implemented in VS Code at least:
* `initialize` is sent then `launch` or `attach`
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/debug/browser/debugService.ts#L
https://github.com/ashgti approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/137920
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/138601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/138557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/137911
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/137113
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -180,44 +184,53 @@ void StackTraceRequestHandler::operator()(
llvm::json::Object body;
lldb::SBFormat frame_format = dap.frame_format;
+ bool include_all = false;
ashgti wrote:
Should this default to `dap.configuration.displayExtendedBacktrace` and th
@@ -117,6 +118,9 @@ static void EventThreadFunction(DAP &dap) {
lldb::SBEvent event;
lldb::SBListener listener = dap.debugger.GetListener();
dap.broadcaster.AddListener(listener, eBroadcastBitStopEventThread);
+ dap.debugger.GetBroadcaster().AddListener(
+ listener,
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/137280
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -8,72 +8,37 @@
#include "DAP.h"
#include "EventHelper.h"
-#include "JSONUtils.h"
+#include "Protocol/ProtocolTypes.h"
#include "RequestHandler.h"
+#include "llvm/Support/Error.h"
+
+using namespace llvm;
+using namespace lldb_dap::protocol;
namespace lldb_dap {
-// "N
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/137071
>From f4f2fea5cebbce550de0e0c3facaac894b9f40b8 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 23 Apr 2025 15:01:53 -0700
Subject: [PATCH 1/2] [lldb-dap] Migrate 'stepIn' request to well structured
types
@@ -672,21 +670,17 @@ DAP::CreateTargetFromArguments(const llvm::json::Object
&arguments,
// enough information to determine correct arch and platform (or ELF can be
// omitted at all), so it is good to leave the user an apportunity to specify
// those. Any of those thre
@@ -9,127 +9,69 @@
#include "DAP.h"
#include "EventHelper.h"
#include "JSONUtils.h"
+#include "Protocol/ProtocolRequests.h"
#include "RequestHandler.h"
+#include "llvm/Support/Error.h"
#include "llvm/Support/FileSystem.h"
+using namespace llvm;
+using namespace lldb_dap::pr
@@ -9,127 +9,69 @@
#include "DAP.h"
#include "EventHelper.h"
#include "JSONUtils.h"
+#include "Protocol/ProtocolRequests.h"
#include "RequestHandler.h"
+#include "llvm/Support/Error.h"
#include "llvm/Support/FileSystem.h"
+using namespace llvm;
+using namespace lldb_dap::pr
@@ -37,14 +39,12 @@ MakeArgv(const llvm::ArrayRef &strs) {
return argv;
}
-static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj,
- llvm::StringRef key, lldb::LaunchFlags mask) {
- if (const auto opt_value = GetBoolean(obj,
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()(
llvm::json::Array stack_frames;
llvm::json::Object body;
+ lldb::SBFormat frame_format = dap.frame_format;
+
+ if (const auto *format = arguments->getObject("format")) {
+const bool parameters = GetBool
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()(
llvm::json::Array stack_frames;
llvm::json::Object body;
+ lldb::SBFormat frame_format = dap.frame_format;
+
+ if (const auto *format = arguments->getObject("format")) {
ashgti wrote:
Anot
@@ -178,14 +179,45 @@ void StackTraceRequestHandler::operator()(
llvm::json::Array stack_frames;
llvm::json::Object body;
+ lldb::SBFormat frame_format = dap.frame_format;
+
+ if (const auto *format = arguments->getObject("format")) {
+const bool parameters = GetBool
@@ -37,14 +39,12 @@ MakeArgv(const llvm::ArrayRef &strs) {
return argv;
}
-static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj,
- llvm::StringRef key, lldb::LaunchFlags mask) {
- if (const auto opt_value = GetBoolean(obj,
@@ -37,14 +39,12 @@ MakeArgv(const llvm::ArrayRef &strs) {
return argv;
}
-static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj,
- llvm::StringRef key, lldb::LaunchFlags mask) {
- if (const auto opt_value = GetBoolean(obj,
https://github.com/ashgti reopened
https://github.com/llvm/llvm-project/pull/137371
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/137388
When building with MSVC 2019 using `std::future` causes a compile
time build error.
```
C:\Program Files (x86)\Microsoft Visual
Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\include\future(196): error
C22
401 - 500 of 1123 matches
Mail list logo
