[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 539182. ashgti marked an inline comment as done. ashgti added a comment. Apply clang-format and split out some parts of this into smaller commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https:

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti marked 2 inline comments as done. ashgti added inline comments. Comment at: lldb/tools/lldb-vscode/Options.td:20-38 +def port: S<"port">, MetaVarName<"">, HelpText<"Communicate with the lldb-vscode tool over the defined port.">; def: Separate<["-"], "p">, Alias,

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When the process is contiuned using an lldb command expression the thread state in VS Code is never informed and will be out

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti updated this revision to Diff 539185. ashgti added a comment. Herald added a subscriber: JDevlieghere. Applying clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 Files: lldb/tools/lld

[Lldb-commits] [PATCH] D154990: [lldb-vsocde] Cleaning up the usage of the Separate helper in Options.td.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154990 Files: lldb/tools/lldb-vscode/Options.td I

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti updated this revision to Diff 539302. ashgti added a comment. Removing the focus_tid invalidation on the continue event, that was incorrectly setting the focus_tid to 0 for all continue events. Instead allow the existing logic in the SendThreadStoppedEvent to infer the correct focus_tid u

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti updated this revision to Diff 539304. ashgti added a comment. Applying clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/lldb-

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti marked an inline comment as done. ashgti added a comment. In D154030#4491470 , @rastogishubham wrote: > I am reverting the change for now, I apologize for any inconvenience Thanks for reverting that, I'll take a look at the tests and double check

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new flag and lldb runtime command to allow users to manage the behavior of the lldb-vscode evaluate repl request.

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 540216. ashgti added a comment. Applying formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/ https://reviews.llvm.org/D155248 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vsc

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 540219. ashgti added a comment. Adjusting the startDebugging test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/ https://reviews.llvm.org/D155248 Files: lldb/packages/Python/lldbsuite/test/tools/l

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti added a reviewer: wallace. ashgti added a comment. Hi wallace, this is a second attempt at this change set including updates to existing tests to check the behavior changes. LMKWYT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/ h

[Lldb-commits] [PATCH] D155248: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 541728. ashgti added a comment. Updating patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155248/new/ https://reviews.llvm.org/D155248 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.p

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti updated this revision to Diff 544017. ashgti added a comment. Adding back the 'threadCausedFocus' field, that is used in tests to verify behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 F

[Lldb-commits] [PATCH] D156465: [lldb-vscode] Adding support for displaying backtraces.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Apple platforms when debugging with libBacktraceRecording.dylib backtraces are stored as part of the thread stack. This ch

[Lldb-commits] [PATCH] D156465: [lldb-vscode] Adding support for displaying backtraces.

ashgti updated this revision to Diff 544946. ashgti edited the summary of this revision. ashgti added a comment. Applying clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156465/new/ https://reviews.llvm.org/D156465 Files: lldb/tools/

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of creating psuedo source files for each stack frame this change adopts the new DAP “disassemble” request, allowing c

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti updated this revision to Diff 544957. ashgti added a comment. Herald added a subscriber: JDevlieghere. Minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493 Files: lldb/tools/lldb-vscode/JSO

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti updated this revision to Diff 544977. ashgti added a comment. Fixing a test and removing dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493 Files: lldb/test/API/tools/lldb-vscode/coreFile

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti updated this revision to Diff 544982. ashgti added a comment. Adding new tests to cover the behavior of the disassemble request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493 Files: lldb/packag

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti updated this revision to Diff 545278. ashgti added a comment. Adjusting the unit test to only check 2 frames instead of 3 and adjusted the assertions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D15649

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti added a comment. Do you have any additional information about the failure? The link looks like a timeout, so I'm not sure where things are timing out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D15649

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti created this revision. Herald added a project: All. ashgti updated this revision to Diff 533349. ashgti added a comment. ashgti published this revision for review. ashgti added reviewers: wallace, ivanhernandez13. ashgti added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieg

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 533440. ashgti marked 3 inline comments as done. ashgti added a comment. Adding documentation to the lldb-vscode/README.md. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/ https://reviews.llvm.org/D153

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti added a comment. In D153447#4439359 , @wallace wrote: > Please write an entry about this in the documentation of lldb-vscode Updated with some additional documentation in the lldb-vscode/README.md Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 533804. ashgti added a comment. Enhancing the test coverage and fixing an issue when a reverse request is invoked a request from a DAP request handler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 533806. ashgti added a comment. Cleaning up the runInTerminal test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/ https://reviews.llvm.org/D153447 Files: lldb/packages/Python/lldbsuite/test/tools/

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti requested review of this revision. ashgti added a comment. Hi @wallace I updated the tests and discovered a deadlock with my implementation of the SendReverseRequest. I refactored the function and added some additional tests to cover this more thoroughly. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 535072. ashgti added a comment. Removing a dead comment that is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/ https://reviews.llvm.org/D153447 Files: lldb/packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D154025: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [lldb-vscode] Adding support for column break points. [lldb-vscode] Creating a new flag for adjusting the behavior of evaluat

[Lldb-commits] [PATCH] D154026: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154026 Files: lldb/tools/lldb-vscode/JSONUtils.cpp Index

[Lldb-commits] [PATCH] D154028: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154028 Files: lldb/tools/lldb-vscode/README.md lldb/tool

[Lldb-commits] [PATCH] D154029: [lldb-vscode] Adding support for column break points.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154029 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti created this revision. Herald added a project: All. ashgti requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new flag and lldb runtime command to allow users to manage the behavior of the lldb-vscode evaluate repl request.

[Lldb-commits] [PATCH] D154026: [lldb-vscode] Adjusting CreateSource to detect compiler generated frames.

ashgti added reviewers: ivanhernandez13, wallace. ashgti added a comment. A small fix for displaying compiler-generated frames. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154026/new/ https://reviews.llvm.org/D154026

[Lldb-commits] [PATCH] D154028: [lldb-vscode] Prior to running the launchCommands during a launch request set the launch info so the configured launch information is accessible by the launch commands.

ashgti added a reviewer: wallace. ashgti added a comment. A small improvement to allow launchCommands to access the configured launch info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154028/new/ https://reviews.llvm.org/D154028 ___

[Lldb-commits] [PATCH] D154029: [lldb-vscode] Adding support for column break points.

ashgti added reviewers: wallace, ivanhernandez13. ashgti added a comment. Adding column information to breakpoints, including the ability to set column inline breakpoints from VS Code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154029/new/ http

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535580. ashgti added a comment. Small tweak to the auto expression mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535590. ashgti added a comment. Another tweak to the auto mode behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535591. ashgti added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/lldb-vscode/JSON

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535592. ashgti added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/lldb-vscode/JSONU

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 535864. ashgti added a comment. Fixing stale comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/ https://reviews.llvm.org/D153447 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vs

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 535911. ashgti added a comment. Adding ` as an escape hatch in auto mode to ensure lldb commands can always be run directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 536031. ashgti added a comment. Pull + Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/lldb-vscode/J

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti added a reviewer: wallace. ashgti added a comment. Hi wallace, I created to improve the repl behavior of lldb-vscode allowing users to more easily run lldb commands. I started https://discourse.llvm.org/t/rfc-lldb-vscode-evaluate-repl-behavior-and-improvements/71667 as well to outline s

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 537496. ashgti marked 4 inline comments as done. ashgti added a comment. Updating the behavior of auto mode to try to evalute local variables over lldb commands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.h:239 +/// useful to ensure the same column provided by the setBreakpoints request +/// are returned to the IDE as a fallback. /// DavidSpickett wrote: > Appears that this got cla

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 537536. ashgti added a comment. Uploading latest diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.cpp lldb/tools/lldb-v

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

ashgti updated this revision to Diff 537538. ashgti added a comment. Removing a log statement that is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 Files: lldb/tools/lldb-vscode/JSONUtils.