johannes updated this revision to Diff 233856.
johannes edited the summary of this revision.
johannes added a comment.
typo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71487/new/
https://reviews.llvm.org/D71487
Files:
lldb/source/Expression/IR
johannes created this revision.
johannes added reviewers: spyffe, clayborg, jasonmolenda.
Herald added a subscriber: aprantl.
Herald added a project: LLDB.
johannes updated this revision to Diff 233856.
johannes edited the summary of this revision.
johannes added a comment.
typo
Fixes PR41237 -
johannes updated this revision to Diff 234134.
johannes retitled this revision from "[LLDB] Fix address computation for member
function linked with lld" to "[LLDB] Fix address computation for inline
function".
johannes edited the summary of this revision.
johannes added a comment.
different appr
johannes added a comment.
Thanks for the very useful feedback! Now I can finally see why this is
happening.
Below is the relevant excerpt of the input DWARF:
one of the DW_AT_low_pc attributes is NULL, which does not happen when I link
with GNU ld.
clang lldb/test/Shell/Expr/Inputs/function-
johannes updated this revision to Diff 234736.
johannes added a comment.
- Use `addr.IsSectionOffset()` as suggested.
- Add test that links two copies of a compilation unit and makes sure that lldb
only resolves it once.
The fix seems to work when linking an executable, but it does not when crea
johannes updated this revision to Diff 234795.
johannes edited the summary of this revision.
johannes added a comment.
check if the function's section is executable
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71487/new/
https://reviews.llvm.org/D
johannes marked an inline comment as done.
johannes added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2285
-if (addr.IsValid()) {
+if (addr.IsSectionOffset()) {
sc_list.Append(sc);
clayborg wrote:
> Check
This revision was automatically updated to reflect the committed changes.
Closed by commit rG92211bf0f15b: [LLDB] Fix address computation for inline
function (authored by johannes).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71487/new/
https://re
johannes added a comment.
I'm having some troubles fixing this build failure:
http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/1866/
`ninja check-lldb-api` fails but when I try to execute the offending test
locally with a command equivalent to the one in the buildbot log, I get below
