[Lldb-commits] [lldb] 852a4bd - Change the Sanitizer report breakpoint callbacks to asynchronous.

Author: Jim Ingham Date: 2022-10-03T18:10:28-07:00 New Revision: 852a4bdb25d145884f61cd812e66611e65fd2dd9 URL: https://github.com/llvm/llvm-project/commit/852a4bdb25d145884f61cd812e66611e65fd2dd9 DIFF: https://github.com/llvm/llvm-project/commit/852a4bdb25d145884f61cd812e66611e65fd2dd9.diff LO

[Lldb-commits] [lldb] 2c43cd8 - Turn off the warning that the undefined behavior I am using in

Author: Jim Ingham Date: 2022-10-04T11:38:32-07:00 New Revision: 2c43cd883c20b603bc7d9461bfa2591e80a36a3b URL: https://github.com/llvm/llvm-project/commit/2c43cd883c20b603bc7d9461bfa2591e80a36a3b DIFF: https://github.com/llvm/llvm-project/commit/2c43cd883c20b603bc7d9461bfa2591e80a36a3b.diff LO

Re: [Lldb-commits] [lldb] d765664 - [lldb] Add matching based on Python callbacks for data formatters.

Jorge, It's great to see you worked your way through this change! Something in our mail pipeline is dropping all my lldb-commits and review comment notifications. Still haven't figured out who is doing that, so I didn't get a chance to look over the final version. The code looks fine, but nob

[Lldb-commits] [lldb] 3b70e8b - Move the second instance of TestUniqueTypes.py to a unique file

Author: Jim Ingham Date: 2022-11-08T16:59:02-08:00 New Revision: 3b70e8b012f0f51eb0e2abeb38ee6c8914b90f9c URL: https://github.com/llvm/llvm-project/commit/3b70e8b012f0f51eb0e2abeb38ee6c8914b90f9c DIFF: https://github.com/llvm/llvm-project/commit/3b70e8b012f0f51eb0e2abeb38ee6c8914b90f9c.diff LO

[Lldb-commits] [lldb] b565e7f - Don't try to create Expressions when the process is running.

Author: Jim Ingham Date: 2022-11-09T10:07:09-08:00 New Revision: b565e7f0c4cb1768f6c43499aed95adb8cc4f04a URL: https://github.com/llvm/llvm-project/commit/b565e7f0c4cb1768f6c43499aed95adb8cc4f04a DIFF: https://github.com/llvm/llvm-project/commit/b565e7f0c4cb1768f6c43499aed95adb8cc4f04a.diff LO

[Lldb-commits] [lldb] d518ed4 - Handle aliasing a non-top-level command.

Author: Jim Ingham Date: 2022-11-09T10:11:16-08:00 New Revision: d518ed42ae85786c371fd4578f72ab7eb286cb30 URL: https://github.com/llvm/llvm-project/commit/d518ed42ae85786c371fd4578f72ab7eb286cb30 DIFF: https://github.com/llvm/llvm-project/commit/d518ed42ae85786c371fd4578f72ab7eb286cb30.diff LO

[Lldb-commits] [lldb] 353f265 - Apparently I moved the wrong one to "2", then Jason moved the right

Author: Jim Ingham Date: 2022-11-10T15:23:51-08:00 New Revision: 353f265283e9ab209b544ab6818f3bd6ca071873 URL: https://github.com/llvm/llvm-project/commit/353f265283e9ab209b544ab6818f3bd6ca071873 DIFF: https://github.com/llvm/llvm-project/commit/353f265283e9ab209b544ab6818f3bd6ca071873.diff LO

[Lldb-commits] [lldb] 0ec24e1 - Only use major version in the clang resource directory for standalone builds.

Author: Jim Ingham Date: 2022-11-16T16:00:26-08:00 New Revision: 0ec24e1f956616c54f38e104b482dec9309a93fa URL: https://github.com/llvm/llvm-project/commit/0ec24e1f956616c54f38e104b482dec9309a93fa DIFF: https://github.com/llvm/llvm-project/commit/0ec24e1f956616c54f38e104b482dec9309a93fa.diff LO

[Lldb-commits] [lldb] 658f6ed - Make ignore counts work as "after stop" modifiers so they play nicely with conditions

Author: Jim Ingham Date: 2021-06-01T18:22:27-07:00 New Revision: 658f6ed1523b0e61ddee494ce1691f29a701c317 URL: https://github.com/llvm/llvm-project/commit/658f6ed1523b0e61ddee494ce1691f29a701c317 DIFF: https://github.com/llvm/llvm-project/commit/658f6ed1523b0e61ddee494ce1691f29a701c317.diff LO

Re: [Lldb-commits] [lldb] e05b03c - [lldb] Set return status to failed when adding a command error

Hey, David, This commit seems to have caused a new failure in TestRegisters.py, e.g.: http://green.lab.llvm.org/green/blue/organizations/jenkins/lldb-cmake/detail/lldb-cmake/32693/pipeline/ Do you have time to take a look? Jim > On Jun 8, 2021, at 1:41 AM, David Spickett via lldb-commits >

Re: [Lldb-commits] [lldb] e05b03c - [lldb] Set return status to failed when adding a command error

Thanks! Jim > On Jun 9, 2021, at 1:44 AM, David Spickett wrote: > > I figured something would fail. I've reverted and will reland with fixed > tests. > > On Tue, 8 Jun 2021 at 22:17, Jim Ingham wrote: >> >> Hey, David, >> >> This commit seems to have caused a new failure in TestRegisters.p

lldb-commits@lists.llvm.org

Author: Jim Ingham Date: 2021-06-15T14:34:02-07:00 New Revision: cfb96d845a684a5c567823dbe2aa4392937ee979 URL: https://github.com/llvm/llvm-project/commit/cfb96d845a684a5c567823dbe2aa4392937ee979 DIFF: https://github.com/llvm/llvm-project/commit/cfb96d845a684a5c567823dbe2aa4392937ee979.diff LO

[Lldb-commits] [lldb] 479c357 - Missed a Windows use of ValidForThisThread in the changes for

Author: Jim Ingham Date: 2021-06-15T15:43:53-07:00 New Revision: 479c3577fb825c0c7933b49ac0dd944c4aae22bf URL: https://github.com/llvm/llvm-project/commit/479c3577fb825c0c7933b49ac0dd944c4aae22bf DIFF: https://github.com/llvm/llvm-project/commit/479c3577fb825c0c7933b49ac0dd944c4aae22bf.diff LO

[Lldb-commits] [lldb] 80b2da4 - Don't depend on the "run" alias doing shell expanding.

Author: Jim Ingham Date: 2021-06-15T16:37:46-07:00 New Revision: 80b2da42d28466341b9512599aac354c178c39f8 URL: https://github.com/llvm/llvm-project/commit/80b2da42d28466341b9512599aac354c178c39f8 DIFF: https://github.com/llvm/llvm-project/commit/80b2da42d28466341b9512599aac354c178c39f8.diff LO

Re: [Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

I wonder if instead of doing: // Use our target to get a shared pointer to ourselves... if (m_finalize_called && !PrivateStateThreadIsValid()) BroadcastEvent(event_sp); else m_private_state_broadcaster.BroadcastEvent(event_sp); -> m_private_state_broadcaster.Broadcast

[Lldb-commits] [lldb] 4eabb12 - Add support for the NSMutableDictionary variant: "__NSFrozenDictionaryM"

Author: Jim Ingham Date: 2021-06-25T14:59:26-07:00 New Revision: 4eabb12057616f360b2329f63c0379eced3135b4 URL: https://github.com/llvm/llvm-project/commit/4eabb12057616f360b2329f63c0379eced3135b4 DIFF: https://github.com/llvm/llvm-project/commit/4eabb12057616f360b2329f63c0379eced3135b4.diff LO

Re: [Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

Scripts can actually do work when they get imported (not just register commands) and you might for instance `command script import` a module that's going to do some work & present output in a breakpoint command or stop hook. But breakpoint commands and stop hooks are not interactive. So I'm a

Re: [Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

> On Jul 8, 2021, at 12:25 PM, Alex Langford via Phabricator > wrote: > > bulbazord added a comment. > > In D105215#2850988 , @jingham wrote: > >> In D105215#2850821 , @bulbazord >> wrote: >> >>> I kind of

Re: [Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

> On Jul 10, 2021, at 6:18 AM, Andy Yankovsky via Phabricator > wrote: > > werat added a comment. > > Thanks for the explanation! But at this point I feel I'm a bit confused about > how it all _supposed_ to work in the current design :) > > If I understand correctly, there are four "types" o

[Lldb-commits] [lldb] 379f24f - Revert "Revert "Reset the wakeup timeout when we re-enter the continue wait.""

Author: Jim Ingham Date: 2021-07-12T14:20:49-07:00 New Revision: 379f24ffde03d1730f1e8332574865277a5478fe URL: https://github.com/llvm/llvm-project/commit/379f24ffde03d1730f1e8332574865277a5478fe DIFF: https://github.com/llvm/llvm-project/commit/379f24ffde03d1730f1e8332574865277a5478fe.diff LO

[Lldb-commits] [lldb] 6eb576d - Add a mutex to guard access to the ThreadPlanStack class

Author: Jim Ingham Date: 2021-07-16T15:40:58-07:00 New Revision: 6eb576dcff45fa53e8ceb30c7648b903c1413e05 URL: https://github.com/llvm/llvm-project/commit/6eb576dcff45fa53e8ceb30c7648b903c1413e05 DIFF: https://github.com/llvm/llvm-project/commit/6eb576dcff45fa53e8ceb30c7648b903c1413e05.diff LO

[Lldb-commits] [lldb] 2656af9 - Don't use !eStateRunning when you mean eStateStopped in DestroyImpl.

Author: Jim Ingham Date: 2021-07-19T14:30:04-07:00 New Revision: 2656af95eb8e67364db7b8dc4a95c3b65c286b2d URL: https://github.com/llvm/llvm-project/commit/2656af95eb8e67364db7b8dc4a95c3b65c286b2d DIFF: https://github.com/llvm/llvm-project/commit/2656af95eb8e67364db7b8dc4a95c3b65c286b2d.diff LO

[Lldb-commits] [lldb] bcce8e0 - Fix the logic so stop-hooks get run after a breakpoint that ran an expression

Author: Jim Ingham Date: 2021-07-22T15:06:41-07:00 New Revision: bcce8e0fccc1d6c2f18ade0ffa7039fb705bade2 URL: https://github.com/llvm/llvm-project/commit/bcce8e0fccc1d6c2f18ade0ffa7039fb705bade2 DIFF: https://github.com/llvm/llvm-project/commit/bcce8e0fccc1d6c2f18ade0ffa7039fb705bade2.diff LO

Re: [Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

Mostly I was reacting to your saying the "fully qualified name" idea was too much of a C++ specific thing and didn't belong in the Language abstraction. That doesn't seem to me right. Swift has module names & class namespaces, etc. And you might want to dial up all methods with some base name

[Lldb-commits] [lldb] 0018c71 - Fix "break delete --disabled" with no arguments.

Author: Jim Ingham Date: 2021-07-27T13:38:09-07:00 New Revision: 0018c7123be3e090ba546fb730ed316fa2567655 URL: https://github.com/llvm/llvm-project/commit/0018c7123be3e090ba546fb730ed316fa2567655 DIFF: https://github.com/llvm/llvm-project/commit/0018c7123be3e090ba546fb730ed316fa2567655.diff LO

[Lldb-commits] [lldb] 910353c - When calculating the "currently selected thread" in

Author: Jim Ingham Date: 2021-07-27T13:38:09-07:00 New Revision: 910353c1048e5efac64b639a65b4d968aba3aa81 URL: https://github.com/llvm/llvm-project/commit/910353c1048e5efac64b639a65b4d968aba3aa81 DIFF: https://github.com/llvm/llvm-project/commit/910353c1048e5efac64b639a65b4d968aba3aa81.diff LO

[Lldb-commits] [lldb] 6952928 - Add a test for top-level expressions using "expr --top-level".

Author: Jim Ingham Date: 2021-07-27T13:38:09-07:00 New Revision: 69529286ce2dcd90563bca97537ce570c6d115b4 URL: https://github.com/llvm/llvm-project/commit/69529286ce2dcd90563bca97537ce570c6d115b4 DIFF: https://github.com/llvm/llvm-project/commit/69529286ce2dcd90563bca97537ce570c6d115b4.diff LO

[Lldb-commits] [lldb] 3c45476 - Fix a thinko in the parsing of substitutions in CommandObjectRegexCommand.

Author: Jim Ingham Date: 2021-07-27T18:58:56-07:00 New Revision: 3c4547692368239fca21ec294a5a406ea5a44889 URL: https://github.com/llvm/llvm-project/commit/3c4547692368239fca21ec294a5a406ea5a44889 DIFF: https://github.com/llvm/llvm-project/commit/3c4547692368239fca21ec294a5a406ea5a44889.diff LO

Re: [Lldb-commits] [lldb] 5839976 - [nfc][trace] use formatv instead of the old Printf

It would be cleaner to use CommandReturnObject::AppendErrorWithFormatv. Jim > On Jul 29, 2021, at 7:05 PM, Walter Erquinigo via lldb-commits > wrote: > > > Author: Walter Erquinigo > Date: 2021-07-29T19:04:59-07:00 > New Revision: 5839976976bc018b674f45f56f8a13707b870443 > > URL: > https:/

[Lldb-commits] [lldb] f362b05 - Add a "current" token to the ThreadID option to break set/modify.

Author: Jim Ingham Date: 2021-08-06T15:29:55-07:00 New Revision: f362b05d0dcd176348f19a63f8b7f4d4c0498bba URL: https://github.com/llvm/llvm-project/commit/f362b05d0dcd176348f19a63f8b7f4d4c0498bba DIFF: https://github.com/llvm/llvm-project/commit/f362b05d0dcd176348f19a63f8b7f4d4c0498bba.diff LO

[Lldb-commits] [lldb] bfeb281 - Use LC_DYLD_EXPORTS_TRIE to locate the dyld trie structure if present

Author: Jim Ingham Date: 2021-08-06T16:38:34-07:00 New Revision: bfeb281fbd8e348edfadf5052e9266e13b832171 URL: https://github.com/llvm/llvm-project/commit/bfeb281fbd8e348edfadf5052e9266e13b832171 DIFF: https://github.com/llvm/llvm-project/commit/bfeb281fbd8e348edfadf5052e9266e13b832171.diff LO

Re: [Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

Sure, thanks for the context! Actually, the posix_spawn usage is only in the darwin Host code, probably because for posix_spawn to work for debugging you need a couple of non-standard flags that were added on Darwin for us (the CoreOS folks really wanted us to use posix_spawn). So you probably

Re: [Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

> On Aug 24, 2021, at 11:57 AM, Roman Podoliaka via Phabricator > wrote: > > malor added a comment. > > In D108510#2961332 , @jingham wrote: > >> One of the key reasons to use "frame recognizers" is to provide argument >> values to functions that do

Re: [Lldb-commits] New feature suggestion: Tacking variable update

From what I can tell, you are suggesting using instruction single stepping and printing out the variable value if it has changed. Is that right? That seems much more expensive than watchpoints, and it isn't clear to me what the benefits would be. I would be interested to hear more about the

Re: [Lldb-commits] New feature suggestion: Tacking variable update

el. But if you want this as a pervasive feature, that would be the way to implement it. Jim > On Aug 31, 2021, at 10:50 AM, Jim Ingham via lldb-commits > wrote: > > From what I can tell, you are suggesting using instruction single stepping > and printing out the variable val

[Lldb-commits] [lldb] d62a343 - Add a test for adding and removing Listeners from a BroadcasterManager.

Author: Jim Ingham Date: 2020-02-07T17:54:25-08:00 New Revision: d62a343db23b7e8c3b5f2a0284bcacc10141a49e URL: https://github.com/llvm/llvm-project/commit/d62a343db23b7e8c3b5f2a0284bcacc10141a49e DIFF: https://github.com/llvm/llvm-project/commit/d62a343db23b7e8c3b5f2a0284bcacc10141a49e.diff LO

[Lldb-commits] [lldb] 4570f2c - Add a test for debugserver handling threads suspended from within a program.

Author: Jim Ingham Date: 2020-02-13T15:48:38-08:00 New Revision: 4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2 URL: https://github.com/llvm/llvm-project/commit/4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2 DIFF: https://github.com/llvm/llvm-project/commit/4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2.diff LO

Re: [Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

Yes, I don't think you have to solve this problem to make the suggested change. I think a lot of folks would appreciate the effort it would take to make names in backtraces more readable. Sometimes, particularly when you use function objects and iterators in combination, the names are insane

Re: [Lldb-commits] [PATCH] D75004: Fix a race between lldb's packet timeout and killing the profile thread

I don’t understand your suggestion. The point of this change was to get the profile loop to exit without waiting the full sleep time. That time is generally pretty long (1 second or thereabouts) and so if you have the main debugserver thread wait on the profile thread’s timeout before replying

[Lldb-commits] [lldb] 3cd13c4 - Fix a race between lldb's packet timeout and the profile thread's usleep.

Author: Jim Ingham Date: 2020-02-25T11:17:08-08:00 New Revision: 3cd13c4624b5900c884b691b72d0ca053433f6fe URL: https://github.com/llvm/llvm-project/commit/3cd13c4624b5900c884b691b72d0ca053433f6fe DIFF: https://github.com/llvm/llvm-project/commit/3cd13c4624b5900c884b691b72d0ca053433f6fe.diff LO

Re: [Lldb-commits] [lldb] e98ef0a - [lldb] Fix several LLDB_LOGs with wrong indices in ClangASTSource.cpp

We should really have a low-frequency bot that just runs the whole testsuite with all the logs turned on and make sure that doesn't crash... Jim > On Mar 4, 2020, at 10:56 AM, Raphael “Teemperor” Isemann via lldb-commits > wrote: > > Yeah this whole thing is a disaster and it’s puzzling that

Re: [Lldb-commits] [lldb] 6385c2a - [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.

Yes, I’m working on a fix. Can you use regular expressions or globs in FileCheck matching? It means if you ever add a test that makes an expression above this test in the file, you have to go renumber everything. That's kind of annoying even if the numbering was still working, and you aren’t

[Lldb-commits] [lldb] 67d67eb - Internal expressions shouldn't increment the result variable numbering.

Author: Jim Ingham Date: 2020-03-23T13:30:37-07:00 New Revision: 67d67ebe8f2535c5de75c62820f7713f87d07307 URL: https://github.com/llvm/llvm-project/commit/67d67ebe8f2535c5de75c62820f7713f87d07307 DIFF: https://github.com/llvm/llvm-project/commit/67d67ebe8f2535c5de75c62820f7713f87d07307.diff LO

[Lldb-commits] [lldb] 2c1c57a - Make ThreadPlanTracers use TID & Process rather than Thread *.

Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 2c1c57a1df8187870df114af666bacbd413699f7 URL: https://github.com/llvm/llvm-project/commit/2c1c57a1df8187870df114af666bacbd413699f7 DIFF: https://github.com/llvm/llvm-project/commit/2c1c57a1df8187870df114af666bacbd413699f7.diff LO

[Lldb-commits] [lldb] 61e8e68 - Move thread plan stacks into the Process, indexed by TID.

Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 61e8e6882de7c89933d3cc4c4d44719679e4b4f0 URL: https://github.com/llvm/llvm-project/commit/61e8e6882de7c89933d3cc4c4d44719679e4b4f0 DIFF: https://github.com/llvm/llvm-project/commit/61e8e6882de7c89933d3cc4c4d44719679e4b4f0.diff LO

[Lldb-commits] [lldb] 1893065 - Allow the ThreadPlanStackMap to hold the thread plans for threads

Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 1893065d7bf5c41fbd0dbbee0a39933d3a99806b URL: https://github.com/llvm/llvm-project/commit/1893065d7bf5c41fbd0dbbee0a39933d3a99806b DIFF: https://github.com/llvm/llvm-project/commit/1893065d7bf5c41fbd0dbbee0a39933d3a99806b.diff LO

[Lldb-commits] [lldb] e4598dc - Make ThreadPlans use TID and Process, rather than Thread *.

Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: e4598dc04a1f582e18b6721ae8ad15cad3ddd48b URL: https://github.com/llvm/llvm-project/commit/e4598dc04a1f582e18b6721ae8ad15cad3ddd48b DIFF: https://github.com/llvm/llvm-project/commit/e4598dc04a1f582e18b6721ae8ad15cad3ddd48b.diff LO

[Lldb-commits] [lldb] 2d658c5 - Disable two new tests on Windows. They are failing but the logs are not helpful.

Author: Jim Ingham Date: 2020-04-03T17:14:56-07:00 New Revision: 2d658c56d57c4b355635b2bab38ba97a598c7393 URL: https://github.com/llvm/llvm-project/commit/2d658c56d57c4b355635b2bab38ba97a598c7393 DIFF: https://github.com/llvm/llvm-project/commit/2d658c56d57c4b355635b2bab38ba97a598c7393.diff LO

[Lldb-commits] [lldb] 48ba745 - This test is failing on the Ubuntu bot but the bot log doesn't

Author: Jim Ingham Date: 2020-04-03T18:04:02-07:00 New Revision: 48ba745eacf883080152fe16b5b1305657d001ca URL: https://github.com/llvm/llvm-project/commit/48ba745eacf883080152fe16b5b1305657d001ca DIFF: https://github.com/llvm/llvm-project/commit/48ba745eacf883080152fe16b5b1305657d001ca.diff LO

[Lldb-commits] [lldb] 3270748 - The thread plan list test is failing at least on Ubuntu Linux.

Author: Jim Ingham Date: 2020-04-03T20:06:11-07:00 New Revision: 327074812707d41f492a0e23940430422a9cd237 URL: https://github.com/llvm/llvm-project/commit/327074812707d41f492a0e23940430422a9cd237 DIFF: https://github.com/llvm/llvm-project/commit/327074812707d41f492a0e23940430422a9cd237.diff LO

Re: [Lldb-commits] [lldb] b6cd964 - Fix typo in xfail decorator for lldb thread plan list tests

Yes. Now that I think about it a little more, I’m a bit surprised that on most platforms we do have to step in & back out again to step over this function. That’s what we always used to do, but the work Greg & Co. did a little while back added the assumption that call’s return to the PC direct

Re: [Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

Then only time that I can find where I customized the string based on the incoming full command was for “source list” because I needed to know whether the listing was going forward or backward, so I needed to write that into the “keep doing what you were doing” command. That could have also bee

Re: [Lldb-commits] [lldb] 3775be2 - Target: correct the return value for `GetImageAddrFromToken`

This should be easy to test. If you have a running process, and haven’t called “process load” then: (lldb) process unload 12345 Should return the error: failed to unload image: invalid image token But instead on x86_64 it returns the error: failed to unload image: expression failed: "dlclose

[Lldb-commits] [lldb] 71c4da8 - Don't assume that stepping out of a function will land on the next line.

Author: Jim Ingham Date: 2021-03-18T17:44:17-07:00 New Revision: 71c4da83b67a485f0cfacbce8b46eaa497df900e URL: https://github.com/llvm/llvm-project/commit/71c4da83b67a485f0cfacbce8b46eaa497df900e DIFF: https://github.com/llvm/llvm-project/commit/71c4da83b67a485f0cfacbce8b46eaa497df900e.diff LO

[Lldb-commits] [lldb] 9406d43 - Make the stop-on-sharedlibrary-events setting work.

Author: Jim Ingham Date: 2021-03-19T12:02:16-07:00 New Revision: 9406d43138811ac4dfd0ab31434f65a649bc882e URL: https://github.com/llvm/llvm-project/commit/9406d43138811ac4dfd0ab31434f65a649bc882e DIFF: https://github.com/llvm/llvm-project/commit/9406d43138811ac4dfd0ab31434f65a649bc882e.diff LO

[Lldb-commits] [lldb] a8d62fc - Skip all the tests for Windows.

Author: Jim Ingham Date: 2021-03-19T12:05:16-07:00 New Revision: a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff URL: https://github.com/llvm/llvm-project/commit/a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff DIFF: https://github.com/llvm/llvm-project/commit/a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff.diff LO

[Lldb-commits] [lldb] e8e07b3 - Revert "Skip all the tests for Windows."

Author: Jim Ingham Date: 2021-03-19T12:38:23-07:00 New Revision: e8e07b3a5e6032edeed559db448402094cff31bf URL: https://github.com/llvm/llvm-project/commit/e8e07b3a5e6032edeed559db448402094cff31bf DIFF: https://github.com/llvm/llvm-project/commit/e8e07b3a5e6032edeed559db448402094cff31bf.diff LO

[Lldb-commits] [lldb] 9d081a7 - Revert "Make the stop-on-sharedlibrary-events setting work."

Author: Jim Ingham Date: 2021-03-19T12:38:41-07:00 New Revision: 9d081a7ffe5c2f9575f77bedd6cbf4385287aeec URL: https://github.com/llvm/llvm-project/commit/9d081a7ffe5c2f9575f77bedd6cbf4385287aeec DIFF: https://github.com/llvm/llvm-project/commit/9d081a7ffe5c2f9575f77bedd6cbf4385287aeec.diff LO

[Lldb-commits] [lldb] c8faa8c - Make the stop-on-sharedlibrary-events setting work.

Author: Jim Ingham Date: 2021-03-24T11:15:11-07:00 New Revision: c8faa8c2669c1867ef6ac33466f219a39d5faaa7 URL: https://github.com/llvm/llvm-project/commit/c8faa8c2669c1867ef6ac33466f219a39d5faaa7 DIFF: https://github.com/llvm/llvm-project/commit/c8faa8c2669c1867ef6ac33466f219a39d5faaa7.diff LO

[Lldb-commits] [lldb] 3fd7d0d - Disable the tests except on Darwin.

Author: Jim Ingham Date: 2021-03-24T12:19:18-07:00 New Revision: 3fd7d0d281a9b1dc7a8352cbd29178cbfacc73f1 URL: https://github.com/llvm/llvm-project/commit/3fd7d0d281a9b1dc7a8352cbd29178cbfacc73f1 DIFF: https://github.com/llvm/llvm-project/commit/3fd7d0d281a9b1dc7a8352cbd29178cbfacc73f1.diff LO

[Lldb-commits] [lldb] 4d9039c - Add support for fetching signed values from tagged pointers.

Author: Jim Ingham Date: 2021-04-01T10:59:25-07:00 New Revision: 4d9039c8dc2d1f0be1b5ee486d5a83b1614b038a URL: https://github.com/llvm/llvm-project/commit/4d9039c8dc2d1f0be1b5ee486d5a83b1614b038a DIFF: https://github.com/llvm/llvm-project/commit/4d9039c8dc2d1f0be1b5ee486d5a83b1614b038a.diff LO

[Lldb-commits] [lldb] be0ced0 - Revert "Revert "Add support for fetching signed values from tagged pointers.""

Author: Jim Ingham Date: 2021-04-05T18:18:26-07:00 New Revision: be0ced03ba9bfab6fcb1fd2c263a33bc6a359cd8 URL: https://github.com/llvm/llvm-project/commit/be0ced03ba9bfab6fcb1fd2c263a33bc6a359cd8 DIFF: https://github.com/llvm/llvm-project/commit/be0ced03ba9bfab6fcb1fd2c263a33bc6a359cd8.diff LO

Re: [Lldb-commits] [PATCH] D101627: [lldb] More tests for DumpDataExtractor

I would resist this change. It's unnecessarily disruptive, would again break git archeology, and really have no significant benefit. I also think the lldb conventions for naming things are much clearer than the llvm ones. Knowing that something is a ivar by looking at the name is a real times

[Lldb-commits] [lldb] 60ad0fd - Clarify the help for "breakpoint command add" and "watchpoint command add".

Author: Jim Ingham Date: 2021-05-03T17:22:43-07:00 New Revision: 60ad0fd3c8bf18dc1a307b97e9e3eb21dd5e4cfb URL: https://github.com/llvm/llvm-project/commit/60ad0fd3c8bf18dc1a307b97e9e3eb21dd5e4cfb DIFF: https://github.com/llvm/llvm-project/commit/60ad0fd3c8bf18dc1a307b97e9e3eb21dd5e4cfb.diff LO

[Lldb-commits] [lldb] 72ba78c - When SendContinuePacketAndWaitForResponse returns eStateInvalid, don't fetch more packets.

Author: Jim Ingham Date: 2021-05-06T14:11:42-07:00 New Revision: 72ba78c29e923cb6e5d89eb5ea8180bf723188be URL: https://github.com/llvm/llvm-project/commit/72ba78c29e923cb6e5d89eb5ea8180bf723188be DIFF: https://github.com/llvm/llvm-project/commit/72ba78c29e923cb6e5d89eb5ea8180bf723188be.diff LO

[Lldb-commits] [lldb] 9558b60 - Add an "interrupt timeout" to Process, and pipe that through the

Author: Jim Ingham Date: 2021-05-11T11:57:08-07:00 New Revision: 9558b602b22cb7d681757c5f56d941e39a9d9d19 URL: https://github.com/llvm/llvm-project/commit/9558b602b22cb7d681757c5f56d941e39a9d9d19 DIFF: https://github.com/llvm/llvm-project/commit/9558b602b22cb7d681757c5f56d941e39a9d9d19.diff LO

[Lldb-commits] [lldb] 0f2eb7e - This test is failing on Linux, skip while I investigate.

Author: Jim Ingham Date: 2021-05-11T18:13:56-07:00 New Revision: 0f2eb7e6e5dc2c1b5d1080160733b3a49e00c99c URL: https://github.com/llvm/llvm-project/commit/0f2eb7e6e5dc2c1b5d1080160733b3a49e00c99c DIFF: https://github.com/llvm/llvm-project/commit/0f2eb7e6e5dc2c1b5d1080160733b3a49e00c99c.diff LO

[Lldb-commits] [lldb] 10c309a - Removing test...

Author: Jim Ingham Date: 2021-05-11T18:27:37-07:00 New Revision: 10c309ad81e2be156ab44a83ee56cddea20637cc URL: https://github.com/llvm/llvm-project/commit/10c309ad81e2be156ab44a83ee56cddea20637cc DIFF: https://github.com/llvm/llvm-project/commit/10c309ad81e2be156ab44a83ee56cddea20637cc.diff LO

[Lldb-commits] [lldb] bd5751f - Reset the wakeup timeout when we re-enter the continue wait.

Author: Jim Ingham Date: 2021-05-17T10:49:47-07:00 New Revision: bd5751f3d249ec0798060bd98c07272174c52af0 URL: https://github.com/llvm/llvm-project/commit/bd5751f3d249ec0798060bd98c07272174c52af0 DIFF: https://github.com/llvm/llvm-project/commit/bd5751f3d249ec0798060bd98c07272174c52af0.diff LO

[Lldb-commits] [lldb] 82a3883 - Revert "Reset the wakeup timeout when we re-enter the continue wait."

Author: Jim Ingham Date: 2021-05-17T15:37:26-07:00 New Revision: 82a38837150099288a1262391ef43e1fd69ffde4 URL: https://github.com/llvm/llvm-project/commit/82a38837150099288a1262391ef43e1fd69ffde4 DIFF: https://github.com/llvm/llvm-project/commit/82a38837150099288a1262391ef43e1fd69ffde4.diff LO

[Lldb-commits] [lldb] 8d6aa68 - Remove the "bool" return from OptionValue::Clear and its subclasses.

Author: Jim Ingham Date: 2020-07-21T11:32:55-07:00 New Revision: 8d6aa688eeffea4b9151d1a208ed619ca50c823a URL: https://github.com/llvm/llvm-project/commit/8d6aa688eeffea4b9151d1a208ed619ca50c823a DIFF: https://github.com/llvm/llvm-project/commit/8d6aa688eeffea4b9151d1a208ed619ca50c823a.diff LO

[Lldb-commits] [lldb] 08063f8 - "|" used when "||" was meant in SBTarget::FindFunctions

Author: Jim Ingham Date: 2020-08-05T19:02:00-07:00 New Revision: 08063f85a7eadb1e54d0a03e0307bf15319513e8 URL: https://github.com/llvm/llvm-project/commit/08063f85a7eadb1e54d0a03e0307bf15319513e8 DIFF: https://github.com/llvm/llvm-project/commit/08063f85a7eadb1e54d0a03e0307bf15319513e8.diff LO

[Lldb-commits] [lldb] 1c1ffa6 - GetPath() returns a std::string temporary. You can't reference just the c_str.

Author: Jim Ingham Date: 2020-08-05T19:12:15-07:00 New Revision: 1c1ffa6a300a60c81be41a3e08a4e9da7499adc1 URL: https://github.com/llvm/llvm-project/commit/1c1ffa6a300a60c81be41a3e08a4e9da7499adc1 DIFF: https://github.com/llvm/llvm-project/commit/1c1ffa6a300a60c81be41a3e08a4e9da7499adc1.diff LO

[Lldb-commits] [lldb] d3dfd8c - Add a setting to force stepping to always run all threads.

Author: Jim Ingham Date: 2020-08-07T14:47:31-07:00 New Revision: d3dfd8cec44072302818c34193d898903dbaef8f URL: https://github.com/llvm/llvm-project/commit/d3dfd8cec44072302818c34193d898903dbaef8f DIFF: https://github.com/llvm/llvm-project/commit/d3dfd8cec44072302818c34193d898903dbaef8f.diff LO

[Lldb-commits] [lldb] b6db0a5 - Add python enumerators for SBTypeEnumMemberList, and some tests for this API.

Author: Jim Ingham Date: 2020-08-14T09:57:46-07:00 New Revision: b6db0a544df1f28e7fa53b74e19839e55e63c8c9 URL: https://github.com/llvm/llvm-project/commit/b6db0a544df1f28e7fa53b74e19839e55e63c8c9 DIFF: https://github.com/llvm/llvm-project/commit/b6db0a544df1f28e7fa53b74e19839e55e63c8c9.diff LO

[Lldb-commits] [lldb] f723d19 - Add '<' meta command to read in code from external file

Author: Patrick Beard Date: 2020-09-16T11:36:54-07:00 New Revision: f723d193e2c92ea6903e3debfee32b13354808bc URL: https://github.com/llvm/llvm-project/commit/f723d193e2c92ea6903e3debfee32b13354808bc DIFF: https://github.com/llvm/llvm-project/commit/f723d193e2c92ea6903e3debfee32b13354808bc.diff

[Lldb-commits] [lldb] 94b0d83 - Fix reporting the lack of global variables in "target var".

Author: Jim Ingham Date: 2020-09-21T17:29:40-07:00 New Revision: 94b0d836a105116220052313df5a58473f706cdf URL: https://github.com/llvm/llvm-project/commit/94b0d836a105116220052313df5a58473f706cdf DIFF: https://github.com/llvm/llvm-project/commit/94b0d836a105116220052313df5a58473f706cdf.diff LO

[Lldb-commits] [lldb] 3726ac4 - Add `breakpoint delete --disabled`: deletes all disabled breakpoints.

Author: Jim Ingham Date: 2020-09-23T11:35:11-07:00 New Revision: 3726ac41e9e00d2f6f87779b68f91ea264223c8a URL: https://github.com/llvm/llvm-project/commit/3726ac41e9e00d2f6f87779b68f91ea264223c8a DIFF: https://github.com/llvm/llvm-project/commit/3726ac41e9e00d2f6f87779b68f91ea264223c8a.diff LO

[Lldb-commits] [lldb] b65966c - Add the ability to write target stop-hooks using the ScriptInterpreter.

Author: Jim Ingham Date: 2020-09-25T15:44:55-07:00 New Revision: b65966cff65bfb66de59621347ffd97238d3f645 URL: https://github.com/llvm/llvm-project/commit/b65966cff65bfb66de59621347ffd97238d3f645 DIFF: https://github.com/llvm/llvm-project/commit/b65966cff65bfb66de59621347ffd97238d3f645.diff LO

[Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

Author: Jim Ingham Date: 2020-09-29T12:01:14-07:00 New Revision: 1b1d9815987a753f2f3524cfad050b85972dae5b URL: https://github.com/llvm/llvm-project/commit/1b1d9815987a753f2f3524cfad050b85972dae5b DIFF: https://github.com/llvm/llvm-project/commit/1b1d9815987a753f2f3524cfad050b85972dae5b.diff LO

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/9484/steps/test/logs/stdio > http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/9504/steps/test/logs/stdio > http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/9505/steps/test/logs/stdio > > On 29/09/2020 21:01,

Re: [Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

We should probably outlaw the shared pointer from weak pointer constructor in lldb. It looks like the only safe way to use it is in a try/catch block (or by preflighting the weak pointer with lock which renders it pretty much pointless.) Jim > On Sep 30, 2020, at 6:02 AM, Pavel Labath via Pha

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

I also used to get e-mails when a test failed and I was on the changes list. But I haven’t gotten any failure e-mails. Does that only happen for some of the bots (or has that stopped working) or should I look to my filters? Jim > On Sep 30, 2020, at 10:40 AM, Jim Ingham via lldb-comm

[Lldb-commits] [lldb] afaeb6a - Fix crash in SBStructuredData::GetDescription() when there's no StructuredDataPlugin.

Author: Jim Ingham Date: 2020-09-30T11:48:54-07:00 New Revision: afaeb6af79a4278249ef9114755e5685d0b35984 URL: https://github.com/llvm/llvm-project/commit/afaeb6af79a4278249ef9114755e5685d0b35984 DIFF: https://github.com/llvm/llvm-project/commit/afaeb6af79a4278249ef9114755e5685d0b35984.diff LO

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

The test doesn’t seem to be flakey in the “run it a bunch of times and it will eventually fail” type flakey. I ran the test 200 times on my machine and didn’t get a failure. Another weird fact is that there are two ways to auto-continue from a stop-hook, either pass the —auto-continue flag whe

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

Thanks for the info… We’re running in sync mode, so for Continue to return before the process is all the way stopped, Process::ResumeSynchronous() must be bobbling the case where a stop event that resumes the process comes in. The only way I can see that happening is if Process::PrivateResume

Re: [Lldb-commits] [PATCH] D88516: [lldb] Add a "design" section to the documentation.

Architecture is more specific to the structural aspect of a thing, whereas Design is more general. For instance, the rules for the SB API don’t really seem like a description of an Architecture, but more some general principles for doing the thing. Jim > On Oct 1, 2020, at 4:25 PM, Adrian Pra

[Lldb-commits] [lldb] be66987 - Fix raciness in the StopHook check for "has the target run".

Author: Jim Ingham Date: 2020-10-05T15:44:28-07:00 New Revision: be66987e2047636d9ed9d2a4d88b762d59ae88f2 URL: https://github.com/llvm/llvm-project/commit/be66987e2047636d9ed9d2a4d88b762d59ae88f2 DIFF: https://github.com/llvm/llvm-project/commit/be66987e2047636d9ed9d2a4d88b762d59ae88f2.diff LO

Re: [Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

> On Oct 6, 2020, at 8:40 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In D88840#2314587 , @rupprecht wrote: > >> In D88840#2313331 , @kastiglione >> wrote: >> >>

[Lldb-commits] [lldb] 81b11c9 - Fix a macOS build break caused by 3dfb94986170.

Author: Jim Ingham Date: 2020-10-07T15:01:27-07:00 New Revision: 81b11c91070f3a969b64b2c2e6011b02450fa75f URL: https://github.com/llvm/llvm-project/commit/81b11c91070f3a969b64b2c2e6011b02450fa75f DIFF: https://github.com/llvm/llvm-project/commit/81b11c91070f3a969b64b2c2e6011b02450fa75f.diff LO

[Lldb-commits] [lldb] a68ffb1 - Change the default handling of SIGCONT to nosuppress/nostop/notify

Author: Jim Ingham Date: 2020-10-08T15:24:19-07:00 New Revision: a68ffb19d392c6d52f6e42925217a77b4cd71cee URL: https://github.com/llvm/llvm-project/commit/a68ffb19d392c6d52f6e42925217a77b4cd71cee DIFF: https://github.com/llvm/llvm-project/commit/a68ffb19d392c6d52f6e42925217a77b4cd71cee.diff LO

[Lldb-commits] [lldb] 6754caa - Add an SB API to get the SBTarget from an SBBreakpoint

Author: Jim Ingham Date: 2020-10-15T14:28:44-07:00 New Revision: 6754caa9bf21a759c4080a797f23e2b7a77a71e1 URL: https://github.com/llvm/llvm-project/commit/6754caa9bf21a759c4080a797f23e2b7a77a71e1 DIFF: https://github.com/llvm/llvm-project/commit/6754caa9bf21a759c4080a797f23e2b7a77a71e1.diff LO

[Lldb-commits] [lldb] r373135 - Give an error when StepUsingScriptedThreadPlan is passed a bad classname.

Author: jingham Date: Fri Sep 27 17:53:45 2019 New Revision: 373135 URL: http://llvm.org/viewvc/llvm-project?rev=373135&view=rev Log: Give an error when StepUsingScriptedThreadPlan is passed a bad classname. Differential Revision: https://reviews.llvm.org/D68173 Modified: lldb/trunk/include/

[Lldb-commits] [lldb] r373280 - Allow the internal-state-thread free access to the TargetAPI mutex.

Author: jingham Date: Mon Sep 30 17:47:25 2019 New Revision: 373280 URL: http://llvm.org/viewvc/llvm-project?rev=373280&view=rev Log: Allow the internal-state-thread free access to the TargetAPI mutex. It is always doing work on behalf of another thread that presumably has the mutex, so if it is

Re: [Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

debugserver doesn't use llvm classes, it's its own stand-alone thing. So debugserver wasn't included in Jonas' changes. Jim > On Oct 1, 2019, at 3:11 PM, Alex Cameron via Phabricator > wrote: > > tetsuo-cpp added a comment. > > In D68179#1690073 , @

[Lldb-commits] [lldb] r373673 - Break out the Python class & key/value options into a separate OptionGroup.

Author: jingham Date: Thu Oct 3 15:18:51 2019 New Revision: 373673 URL: http://llvm.org/viewvc/llvm-project?rev=373673&view=rev Log: Break out the Python class & key/value options into a separate OptionGroup. Use this in the scripted breakpoint command. Added some tests for parsing the key/valu

[Lldb-commits] [lldb] r373675 - Pass an SBStructuredData to scripted ThreadPlans on use.

Author: jingham Date: Thu Oct 3 15:50:18 2019 New Revision: 373675 URL: http://llvm.org/viewvc/llvm-project?rev=373675&view=rev Log: Pass an SBStructuredData to scripted ThreadPlans on use. This will allow us to write reusable scripted ThreadPlans, since you can use key/value pairs with known ke

[Lldb-commits] [lldb] r373677 - Forgot to change the header guards on OptionGroupPythonClassWithDict.

Author: jingham Date: Thu Oct 3 16:32:42 2019 New Revision: 373677 URL: http://llvm.org/viewvc/llvm-project?rev=373677&view=rev Log: Forgot to change the header guards on OptionGroupPythonClassWithDict. I think that's what is confusing the modules build on the bots. Modified: lldb/trunk/inc

[Lldb-commits] [lldb] r373679 - Python3 doesn't seem to allow you to tell whether an object is a class

Author: jingham Date: Thu Oct 3 16:57:34 2019 New Revision: 373679 URL: http://llvm.org/viewvc/llvm-project?rev=373679&view=rev Log: Python3 doesn't seem to allow you to tell whether an object is a class PyClass_Check and everything it relied on seems gone from Python3.7. So I won't check wheth

[Lldb-commits] [lldb] r374226 - Revert "[lldb] Calculate relative path for symbol links"

Author: jingham Date: Wed Oct 9 13:56:43 2019 New Revision: 374226 URL: http://llvm.org/viewvc/llvm-project?rev=374226&view=rev Log: Revert "[lldb] Calculate relative path for symbol links" This reverts commit 958091c209d0a92e38b9cb27fb77a0ff7da11853. This commit incorrectly sets the _lldb.so s

<    6   7   8   9   10   11   12   13   >