jmajors created this revision.
Herald added a subscriber: mgorny.
This is a new C++ test framework based on Google Test, and one working
example test.
The intention is to replace the existing tests in
packages/Python/lldbsuite/test/tools/lldb-server/ with this suite
and use this framework for all
jmajors marked 43 inline comments as done.
jmajors added a comment.
Every comment should either be marked done, with an accompanying code change,
or have a reply comment.
Comment at: unittests/CMakeLists.txt:57
add_subdirectory(Breakpoint)
+add_subdirectory(tools)
add_subdir
jmajors updated this revision to Diff 98673.
jmajors marked an inline comment as done.
jmajors added a comment.
Made changes based on feedback.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unitt
jmajors marked 2 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
zturner wrote:
> This will work on MSVC and presumably clang. I'm not
jmajors updated this revision to Diff 98675.
jmajors added a comment.
Feedback changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tools/lldb-server/inferior/thread_inferior.cpp
un
jmajors marked 5 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:200
+
+ return std::stoul(big_endian, nullptr, 16);
+}
krytarowski wrote:
> Throws exceptions.
I didn't change this, because
jmajors updated this revision to Diff 98691.
jmajors marked an inline comment as done.
jmajors added a comment.
More feedback changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tool
jmajors marked an inline comment as done.
jmajors added a comment.
I cleaned up the includes.
https://reviews.llvm.org/D32930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jmajors updated this revision to Diff 98702.
jmajors added a comment.
Cleaned up the includes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tools/lldb-server/inferior/thread_inferior.c
jmajors marked 17 inline comments as done.
jmajors added a comment.
More feedback changes.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
krytarowski wrote:
> jmajors wrote:
> > zturner wro
jmajors updated this revision to Diff 98826.
jmajors marked an inline comment as done.
jmajors added a comment.
Feedback changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tools/lld
jmajors marked 6 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:25-30
+ elements["pid"].getAsInteger(16, pid);
+ elements["parent-pid"].getAsInteger(16, parent_pid);
+ elements["real-uid"].getAsInteger(1
jmajors updated this revision to Diff 98858.
jmajors marked an inline comment as done.
jmajors added a comment.
More feedback changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tool
jmajors marked 7 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:142
+llvm::support::endianness endian) {
+ auto stop_reply = std::shared_ptr(new StopReply());
+
labath wrote:
> jmajors
jmajors updated this revision to Diff 98869.
jmajors marked 2 inline comments as done.
jmajors added a comment.
Changed shared_ptr returns to Expected>.
Some other error processing additions.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
un
jmajors updated this revision to Diff 99365.
jmajors marked 15 inline comments as done.
jmajors added a comment.
Moved asserts to the TEST(), where they'll actually do something.
Made TestClient members warn if their return values go unused.
https://reviews.llvm.org/D32930
Files:
unittests/CM
jmajors marked 7 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:10
+
+#include
+#include
labath wrote:
> Do you still need these includes?
Yes. I'm using a stringstream to convert integer
jmajors updated this revision to Diff 99491.
jmajors marked an inline comment as done.
jmajors added a comment.
More CL feedback.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tools/lld
jmajors marked 12 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.h:52
+
+ unsigned long ReadRegister(unsigned long register_id) const;
+
labath wrote:
> tberghammer wrote:
> > "unsigned long"
jmajors updated this revision to Diff 99644.
jmajors marked an inline comment as done.
jmajors added a comment.
More feedback changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tool
jmajors updated this revision to Diff 99788.
jmajors marked 11 inline comments as done.
jmajors added a comment.
CR feedback.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tools/lldb-se
jmajors added a comment.
Addressed more feedback.
https://reviews.llvm.org/D32930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jmajors updated this revision to Diff 100151.
jmajors added a comment.
Added m_ prefix to member variables.
Converted lldb-server start to single thread.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.t
jmajors updated this revision to Diff 100178.
jmajors added a comment.
Format changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tools/lldb-server/inferior/thread_inferior.cpp
uni
jmajors updated this revision to Diff 100287.
jmajors added a comment.
Make inferior break more portable.
Restrict tests to running on Linux, BSD, or Android systems.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server
jmajors updated this revision to Diff 100288.
jmajors marked an inline comment as done.
jmajors added a comment.
Made directory test more portable.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
u
jmajors created this revision.
jmajors added a reviewer: labath.
jmajors added a subscriber: lldb-commits.
Herald added a subscriber: danalbert.
To prevent costly calls to the server to get the PC for every thread,
add all the thread's PCs to the jstopinfo message. This also makes the
Linux/Androi
jmajors accepted this revision.
jmajors added a comment.
This revision is now accepted and ready to land.
Do we have any plans to put something like cpplint into effect?
https://reviews.llvm.org/D30234
___
lldb-commits mailing list
lldb-commits@list
jmajors created this revision.
It does not change members or call non-const members.
HostInfo::GetArchitecture() returns a const object ref (maybe others?),
which can't access the non-const function.
https://reviews.llvm.org/D30515
Files:
include/lldb/Core/ArchSpec.h
source/Core/ArchSpec.cp
29 matches
Mail list logo
