[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu created this revision. jasonliu added reviewers: hubert.reinterpretcast, sfertile, chandlerc, apaprocki. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, dexonsmith, aheejin, hiraditya, javed.absar. Herald added projects: clang, LLDB, LLVM. This patch adds an XCOFF tri

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189387. jasonliu added a comment. Address some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/C

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 3 inline comments as done. jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1470 + case Triple::XCOFF: +// TODO: Falling through for XCOFF format for now. +break; JDevlieghere wrote: > This is confusing, you s

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; JDevlieghere wrote: > See previous comme

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189514. jasonliu added a comment. Address comments in last revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/BackendUtil.cpp clang

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189713. jasonliu added a comment. Share the same "unsupported error" message with WASM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/Back

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355989: Add XCOFF triple object format type for AIX (authored by jasonliu, committed by ). Herald added a subscriber: kris