https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/96724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@DavidSpickett We'll be fine with 32b size_t. Directories in minidumps have to
all have their offsets be 32b addressable, so if you were to fill the directory
list up to the `size_t` max, it would be a corrupted minidump
https://github.com/llvm/llvm-project/pull/96564
__
Jlalond wrote:
@petrhosek Is there a way you can help @kevinfrei validate this on Fuschia?
https://github.com/llvm/llvm-project/pull/96802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/97470
Currently, LLDB assumes all minidumps will have unique sections. This is
intuitive because almost all of the minidump sections are themselves lists.
Exceptions including Signals are unique in that they are all i
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 7e41ca79a09d67ff7bb76a9d95dda4e7ccfdba8b Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 2 Jul 2024 12:41:02 -0700
Subject: [PATCH 1/3] Add support to read multiple exception streams in
minidumps
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/97470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From e8d1f3a7f978bd3c5767f0b0cacea60146a257f7 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 2 Jul 2024 12:41:02 -0700
Subject: [PATCH 1/4] Add support to read multiple exception streams in
minidumps
https://github.com/Jlalond ready_for_review
https://github.com/llvm/llvm-project/pull/97470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,39 @@
+--- !minidump
+Streams:
+ - Type:ThreadList
+Threads:
+ - Thread Id: 0x1B4F23
+Context:
0B00100033
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/97470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From dc4730dcff31c2c9212d2ce5412ecb8a9f4d83c0 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 2 Jul 2024 12:41:02 -0700
Subject: [PATCH 1/5] Add support to read multiple exception streams in
minidumps
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/97470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@jeffreytan81 I think the callout for multiple exception is a good question. I
made a C# testbed to see what would happen if I had multiple simultaneous
exceptions. [Gist
here](https://gist.github.com/Jlalond/467bc990f10fbb75cc9ca7db897a7beb). When
manually collecting a minidum
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From dc4730dcff31c2c9212d2ce5412ecb8a9f4d83c0 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 2 Jul 2024 12:41:02 -0700
Subject: [PATCH 1/6] Add support to read multiple exception streams in
minidumps
Jlalond wrote:
> > @jeffreytan81 I think the callout for multiple exception is a good
> > question. I made a C# testbed to see what would happen if I had multiple
> > simultaneous exceptions. [Gist
> > here](https://gist.github.com/Jlalond/467bc990f10fbb75cc9ca7db897a7beb).
> > When manually
@@ -82,15 +82,24 @@ class MinidumpFile : public Binary {
return getListStream(minidump::StreamType::ThreadList);
}
- /// Returns the contents of the Exception stream. An error is returned if
the
- /// file does not contain this stream, or the stream is smaller than t
@@ -109,7 +109,7 @@ class ProcessMinidump : public PostMortemProcess {
private:
lldb::DataBufferSP m_core_data;
llvm::ArrayRef m_thread_list;
- const minidump::ExceptionStream *m_active_exception;
+ std::unordered_map m_exceptions_by_tid;
Jlalond wrote:
@@ -82,15 +82,24 @@ class MinidumpFile : public Binary {
return getListStream(minidump::StreamType::ThreadList);
}
- /// Returns the contents of the Exception stream. An error is returned if
the
- /// file does not contain this stream, or the stream is smaller than t
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 8647eccd35085ab80f978fabb78b016915c5524f Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 2 Jul 2024 12:41:02 -0700
Subject: [PATCH 1/7] Add support to read multiple exception streams in
minidumps
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/97470
>From 8647eccd35085ab80f978fabb78b016915c5524f Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 2 Jul 2024 12:41:02 -0700
Subject: [PATCH 1/8] Add support to read multiple exception streams in
minidumps
Jlalond wrote:
> > None of the SB API methods return any STL types/containers, like the
> > std::optionals returned in this PR. I worry if this will make the bridging
> > to other languages more complicated, but it's never something I've thought
> > about before. @jimingham @bulbazord @claybor
https://github.com/Jlalond unassigned
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond unassigned
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond unassigned
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -191,9 +191,7 @@ class PluginManager {
GetObjectFileCreateMemoryCallbackForPluginName(llvm::StringRef name);
static Status SaveCore(const lldb::ProcessSP &process_sp,
- const FileSpec &outfile,
- lldb::SaveCoreStyle &core_
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/98403
>From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 9 Jul 2024 13:30:46 -0700
Subject: [PATCH 1/4] Create CoreDumpOption class, and SB equivalent
---
lldb/incl
@@ -1222,7 +1223,19 @@ lldb::SBError SBProcess::SaveCore(const char *file_name)
{
lldb::SBError SBProcess::SaveCore(const char *file_name,
const char *flavor,
SaveCoreStyle core_style) {
- LLDB_INSTRUMENT_VA(
@@ -1271,13 +1271,13 @@ class CommandObjectProcessSaveCore : public
CommandObjectParsed {
switch (short_option) {
case 'p':
-m_requested_plugin_name = option_arg.str();
+m_core_dump_options.SetCoreDumpPluginName(option_arg.data());
@@ -0,0 +1,45 @@
+//===-- CoreDumpOptions.cpp -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -106,12 +106,19 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP
&module_sp,
FileSpec dsym_fspec =
PluginManager::LocateExecutableSymbolFile(module_spec, search_paths);
if (!dsym_fspec || IsDwpSymbolFile(module_sp, dsym_fspec)) {
-// If we have a stripp
Jlalond wrote:
[Most recent commit on this](b97d59c78ac0e25e1af15608f711b0f7a3f5b1bd) on this
sisyphean patch LGTM. I did leave a nit for wording on the comment but view it
as optional.
https://github.com/llvm/llvm-project/pull/99362
___
lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/98403
>From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 9 Jul 2024 13:30:46 -0700
Subject: [PATCH 1/5] Create CoreDumpOption class, and SB equivalent
---
lldb/incl
@@ -1271,13 +1271,13 @@ class CommandObjectProcessSaveCore : public
CommandObjectParsed {
switch (short_option) {
case 'p':
-m_requested_plugin_name = option_arg.str();
+m_core_dump_options.SetPluginName(option_arg.data());
Jlalond
@@ -355,11 +355,9 @@ size_t ObjectFilePECOFF::GetModuleSpecifications(
}
bool ObjectFilePECOFF::SaveCore(const lldb::ProcessSP &process_sp,
-const lldb_private::FileSpec &outfile,
-lldb::SaveCoreStyle &core_style,
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/98403
>From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 9 Jul 2024 13:30:46 -0700
Subject: [PATCH 1/6] Create CoreDumpOption class, and SB equivalent
---
lldb/incl
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/98403
>From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 9 Jul 2024 13:30:46 -0700
Subject: [PATCH 1/7] Create CoreDumpOption class, and SB equivalent
---
lldb/incl
@@ -132,8 +132,13 @@ def test_save_linux_mini_dump(self):
stacks_to_sp_map,
)
+options = lldb.SBCoreDumpOptions()
+core_sb_stack_spec = lldb.SBFileSpec(core_sb_stack)
+options.SetOutputFile(core_sb_stack_spec)
+
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
Reverted locally and still got consistent failures. @jimingham should I file an
issue here?
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
Jlalond wrote:
> Were those the same failures that were showing up on the buildbots? If not it
> could just be that there's an issue with your build configuration.
>
> In this case, the fix was pretty simple (see
> [a27037b](https://github.com/llvm/llvm-project/commit/a27037becd1bdea568e2f970d
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/99692
In #98403 some of the tests were transitioned to the new
`SBProcess::SaveCore(SBSaveCoreOptions)` API, but were not detected in testing.
This patch addresses that.
>From f4c7fcb17855dc5f4f51dce791e05adfff0666e6
Jlalond wrote:
@luporl FYI this fixes the test
https://github.com/llvm/llvm-project/pull/99692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
Addressed Windows issue in #99692
https://github.com/llvm/llvm-project/pull/98403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@labath Would you mind looking at this? Simple fix that got missed because it's
a Window's only test
https://github.com/llvm/llvm-project/pull/99692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/99692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/100443
In #98403 I enabled the SBSaveCoreOptions object, which allows users via the
scripting API to define what they want saved into their core file. As the first
option I've added a threadlist, so users can scan and
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 1/5] Implemplement a thread list that is currently unused for
SB
@@ -53,6 +53,30 @@ class LLDB_API SBSaveCoreOptions {
/// \return The output file spec.
SBFileSpec GetOutputFile() const;
+ /// Add a thread to save in the core file.
+ ///
+ /// \param thread_id The thread ID to save.
+ void AddThread(lldb::tid_t thread_id);
-
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
Jlalond wrote:
Ah, good catch. Originally I was u
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
+}
+
+bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) {
+ if (
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 1/6] Implemplement a thread list that is currently unused for
SB
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 1/7] Implemplement a thread list that is currently unused for
SB
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 1/7] Implemplement a thread list that is currently unused for
SB
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
+}
+
+bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) {
+ if (
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 1/8] Implemplement a thread list that is currently unused for
SB
@@ -75,6 +77,18 @@ lldb::SaveCoreStyle SBSaveCoreOptions::GetStyle() const {
return m_opaque_up->GetStyle();
}
+SBError SBSaveCoreOptions::SetProcess(lldb::SBProcess process) {
+ return m_opaque_up->SetProcess(process.GetSP());
+}
+
+SBError SBSaveCoreOptions::AddThread(lld
Jlalond wrote:
> Stepping back a bit, do we gain anything in `SaveCoreOptions` by having
> `m_process_sp` be optional? Is there a distinction between an empty ProcessSP
> and no ProcessSP object?
No, this was mostly a mistake on my part. I wanted to describe process as
optional but required f
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) {
+ Status error;
+ if (!process_sp) {
+ClearProcessSpecificData();
+m_process_sp = std::nullopt;
+return error;
+ }
+
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) {
+ Status error;
+ if (!process_sp) {
+ClearProcessSpecificData();
+m_process_sp = std::nullopt;
+return error;
+ }
+
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) {
+ Status error;
+ if (!process_sp) {
+ClearProcessSpecificData();
+m_process_sp = std::nullopt;
+return error;
+ }
+
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 1/9] Implemplement a thread list that is currently unused for
SB
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 01/10] Implemplement a thread list that is currently unused
for
https://github.com/Jlalond ready_for_review
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@labath Would you mind if I added you as a reviewer for the `Obj2Yaml` changes
for minidump?
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
> Sounds good. Could you split off the lldb parts to a separate review though?
@labath I think we need both, in order to fix `SBProcess` to return all memory
regions we need the LLDB change, which enables us to test if the yaml2obj
generates correctly
https://github.com/llvm/ll
@@ -154,3 +155,17 @@ MinidumpFile::create(MemoryBufferRef Source) {
return std::unique_ptr(
new MinidumpFile(Source, Hdr, *ExpectedStreams, std::move(StreamMap)));
}
+
+Expected> MinidumpFile::getMemory64List() const {
+ Expected MemoryList64 =
getMemoryList64Header()
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/101272
This PR adds support for `obj2yaml` and `yaml2obj` to generate minidumps that
have a Memory64List stream. This is a prerequisite to #101086.
Worth noting
- const dropped on minidumps so we could cache a MemoryD
@@ -356,6 +370,13 @@ void yaml::MappingContextTraits::mapping(
IO.mapRequired("Content", Content);
}
+void yaml::MappingContextTraits::mapping(
+IO &IO, MemoryDescriptor_64 &Memory, BinaryRef &Content) {
+ mapRequiredHex(IO, "Start of Memory Range", Memory.StartOfMemory
@@ -550,7 +588,7 @@ Stream::create(const Directory &StreamDesc, const
object::MinidumpFile &File) {
llvm_unreachable("Unhandled stream kind!");
}
-Expected Object::create(const object::MinidumpFile &File) {
+Expected Object::create(object::MinidumpFile &File) {
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 1/3] Squash 64b-memory-regions-minidump and take only
llvm-chang
@@ -336,3 +336,52 @@ TEST(MinidumpYAML, ExceptionStream_ExtraParameter) {
0xab, 0xad, 0xca, 0xfe}),
*ExpectedContext);
}
+
+TEST(MinidumpYAML, MemoryRegion_64bit) {
+ SmallString<0> Storage;
+ auto ExpectedFile = toBinary(Storage, R"
@@ -550,7 +588,7 @@ Stream::create(const Directory &StreamDesc, const
object::MinidumpFile &File) {
llvm_unreachable("Unhandled stream kind!");
}
-Expected Object::create(const object::MinidumpFile &File) {
+Expected Object::create(object::MinidumpFile &File) {
@@ -136,6 +136,22 @@ static size_t layout(BlobAllocator &File,
MinidumpYAML::ExceptionStream &S) {
return DataEnd;
}
+static size_t layout(BlobAllocator &File, MinidumpYAML::Memory64ListStream &S)
{
+ size_t BaseRVA = File.tell() + sizeof(minidump::Memory64ListHeader);
--
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 1/5] Squash 64b-memory-regions-minidump and take only
llvm-chang
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 1/7] Squash 64b-memory-regions-minidump and take only
llvm-chang
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 1/8] Squash 64b-memory-regions-minidump and take only
llvm-chang
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/101272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -9,6 +9,8 @@
#include "lldb/API/SBSaveCoreOptions.h"
#include "lldb/API/SBError.h"
#include "lldb/API/SBFileSpec.h"
+#include "lldb/API/SBProcess.h"
+#include "lldb/API/SBThread.h"
Jlalond wrote:
They're actually not right now, all the SB classes are forwar
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 01/12] Implemplement a thread list that is currently unused
for
@@ -9,6 +9,8 @@
#include "lldb/API/SBSaveCoreOptions.h"
#include "lldb/API/SBError.h"
#include "lldb/API/SBFileSpec.h"
+#include "lldb/API/SBProcess.h"
+#include "lldb/API/SBThread.h"
Jlalond wrote:
Followed up offline, Greg was correct and it was proper to mo
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 01/13] Implemplement a thread list that is currently unused
for
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 01/14] Implemplement a thread list that is currently unused
for
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/100443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@Michael137 ack, I'll make a fix
https://github.com/llvm/llvm-project/pull/100443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@Michael137 Has Green Dragon been down for awhile? I did break this test, but
it looks like it was about [a month
ago](https://github.com/llvm/llvm-project/commit/47d80ec1802d70082c8fd32b4396c98db2c4dba2#diff-96c5fb7a96b37c4401faaef482eaf8d4e1ecd38d49a1ff8eb96d361b0dfa24b9R6442).
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/101770
In #100443, Mach-o and Minidump now only call process API's that take a
`SaveCoreOption` as the container for the style and information if a thread
should be included in the core or not. This introduced a bug w
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101770
>From 11f8323bb40a537161c76b89d564c9ae96888d01 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 2 Aug 2024 15:44:17 -0700
Subject: [PATCH 1/4] Create copies in both minidump and mach-o so we can set a
de
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101770
>From 11f8323bb40a537161c76b89d564c9ae96888d01 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 2 Aug 2024 15:44:17 -0700
Subject: [PATCH 1/4] Create copies in both minidump and mach-o so we can set a
de
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/101770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101770
>From 11f8323bb40a537161c76b89d564c9ae96888d01 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 2 Aug 2024 15:44:17 -0700
Subject: [PATCH 1/4] Create copies in both minidump and mach-o so we can set a
de
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/101770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@hokein Thank you for reverting it, I'll look into what I missed :)
https://github.com/llvm/llvm-project/pull/101770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -336,3 +336,52 @@ TEST(MinidumpYAML, ExceptionStream_ExtraParameter) {
0xab, 0xad, 0xca, 0xfe}),
*ExpectedContext);
}
+
+TEST(MinidumpYAML, MemoryRegion_64bit) {
+ SmallString<0> Storage;
+ auto ExpectedFile = toBinary(Storage, R"
@@ -373,7 +373,6 @@ void yaml::MappingContextTraits::mapping(
void yaml::MappingContextTraits::mapping(
IO &IO, MemoryDescriptor_64 &Memory, BinaryRef &Content) {
mapRequiredHex(IO, "Start of Memory Range", Memory.StartOfMemoryRange);
- mapRequiredHex(IO, "Data Size", Me
Jlalond wrote:
> I see you ended up not using the fallible_iterator thing in the end. I'm sort
> of ok with that, though I think it'd be better to do it that way, as we
> wouldn't need the upfront array bounds check and we could return partial data
> where it made sense,
@labath for this I ne
1 - 100 of 639 matches
Mail list logo
