[Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

2016-04-07 Thread Jackson Davis via lldb-commits
jacdavis created this revision. jacdavis added reviewers: lldb-commits, abidh. -thread-info in lldbmi does not conform to protocol. Should end with current thread id as described here: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Thread-Commands.html#GDB_002fMI-Thread-Commands When pri

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

2016-04-07 Thread Jackson Davis via lldb-commits
jacdavis updated this revision to Diff 52991. jacdavis added a comment. Updated to use C++ 11 threads. Clang-format tried to format the diff in the llvm style. Since this is all lldb code, is that actually what is expected? None of the braces matched etc http://reviews.llvm.org/D18880 Fil

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

2016-04-07 Thread Jackson Davis via lldb-commits
Great, thanks. I'll rerun in the morning. I realized I also left the pthread linker option on in the test. Sent from my Windows Phone From: Zachary Turner Sent: ‎4/‎7/‎2016 6:21 PM To: Jackson Davis;

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

2016-04-08 Thread Jackson Davis via lldb-commits
jacdavis updated this revision to Diff 53028. jacdavis added a comment. Ran formatting tool with lldb format. pthread linker option is still required for C++11 threads so left it in. New test still disabled for windows. http://reviews.llvm.org/D18880 Files: Makefile TestMiThreadInfo.py t

Re: [Lldb-commits] [PATCH] D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id

2016-04-08 Thread Jackson Davis via lldb-commits
jacdavis updated this revision to Diff 53031. jacdavis added a comment. last diff missed lldb-mi changes http://reviews.llvm.org/D18880 Files: packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/Makefile packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/TestMiThreadInfo.py packa