[Lldb-commits] [PATCH] D141626: [lldb-vscode] Include the return value in 'local' variables

ivanhernandez13 created this revision. Herald added a project: All. ivanhernandez13 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This provides a convenient way for the user to easily inspect a functions return value after stepping out o

[Lldb-commits] [PATCH] D141633: [lldb-vscode] Use SBFrame.GetDisplayFunctionName() instead of SBFrame.GetFunctionName()

ivanhernandez13 created this revision. Herald added a project: All. ivanhernandez13 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change replaces calls to SBFrame.GetFunctionName() with SBFrame.GetDisplayFunctionName() which can retu

[Lldb-commits] [PATCH] D141637: [lldb-vscode] Fix an issue where lldb-vscode tries to display a source file for generated code

ivanhernandez13 created this revision. Herald added a project: All. ivanhernandez13 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. According to https://github.com/llvm/llvm-project/blob/fbcefff9d0a3f5e97270ef8e7b8e0f2afc33dc1c/lldb/source/

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ivanhernandez13 accepted this revision. ivanhernandez13 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:569 + +// llvm::Error VSCode::Loop() { +// std::condition_variable cv; Dead code? Rep

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ivanhernandez13 added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:251-252 /// \return - /// A \a PacketStatus object indicating the sucess or failure of the - /// request. - PacketStatus SendReverseRequest(llvm::json::Object request, -

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This change will bring lldb-vscode in line with how several other llvm tools process command line arguments. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7479

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 added a comment. Assuming this looks good, can I get some pointers on how and where I should add a test for this? I based this change on the one for the LLDB driver (https://reviews.llvm.org/D54692) which added lldb/trunk/lit/Driver/TestCommands.test. Should I look into adding

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 updated this revision to Diff 245442. ivanhernandez13 marked 2 inline comments as done. ivanhernandez13 added a comment. - Rename opts to options to be consistent with the lldb driver and add a test case around setting an invalid port. Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 added a comment. I added the test file but atm the two existing arguments (--wait-for-debugger and --port) will cause lldb-vscode to hang and await some sort of action from an external process causing the test runner to hang. I added a single test case for handling an invalid po

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 updated this revision to Diff 245517. ivanhernandez13 added a comment. - Update ldb-vscode options test to simply look for the expected flags when passing the --help option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 updated this revision to Diff 245523. ivanhernandez13 added a comment. - Add missing newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/ https://reviews.llvm.org/D74798 Files: lldb/test/Shell/VSCode/TestOptions.test

[Lldb-commits] [PATCH] D74798: [lldb-vscode] Use libOption with tablegen to parse command line options.

ivanhernandez13 added a comment. Thanks for the guidance! When there are no additional concerns, would someone mind committing this change for me? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74798/new/ https://review

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

ivanhernandez13 created this revision. ivanhernandez13 added a reviewer: clayborg. ivanhernandez13 added a project: LLDB. Herald added a subscriber: lldb-commits. lldb-vscode can receive 'evaluate' requests in multiple modes, one of which is 'repl' which indicates the expression to evaluate was t

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

ivanhernandez13 added a comment. clayborg - I see the issue that this change would introduce and I’m not certain of a solution. Also, I’m not sure I understand what we get from keeping track of the selected thread. Isn’t the issue that the behavior is dependent on what thread is selected, and w

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

ivanhernandez13 added a comment. Yep you're right, Xcode doesn't have that capability. Unfortunately there is no standard way of doing this. Lanza filed a feature request to add a standard way to the DAP. Also looks like he looked into how other extensions do this: > vscode-cpptools - Prefix t

[Lldb-commits] [PATCH] D71824: Add the 'start' and 'length' to the completions response. This will fix an issue where applying a completion 'foo.bar' to 'po foo.b' inserts the entire completion result

ivanhernandez13 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71824 Files: lldb/tools/lldb-vscode/lldb-vscode.cpp Index: lldb/tools/lldb-vscode/lldb-vscode.cpp