[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

aheejin added inline comments. Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:256 + WASM_SEC_TAG = 13, // Tag declarations + WASM_SEC_LAST_KNOWN = 14,// Update this when adding new sections }; - Does this pass clang-format? Because we don't have a spa

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

aheejin added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -// name and objcopy won't be

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

aheejin accepted this revision. aheejin added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -

[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt

aheejin added a comment. This broke `-sBUILD_SHARED_LIBS=ON` build: ld.lld: error: undefined symbol: llvm::errs() >>> referenced by Instrument.cpp:162 (/usr/local/google/home/aheejin/llvm-git/lldb/tools/lldb-instr/Instrument.cpp:162) >>> tools/lldb/tools/lldb-instr/CMakeFile

[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt

aheejin added a comment. Friendly ping 😅 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142241/new/ https://reviews.llvm.org/D142241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

aheejin created this revision. aheejin added reviewers: jingham, JDevlieghere. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit e12a950d90f88aeddaa97d

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

aheejin added a comment. Thanks for the info. I asked questions in https://github.com/llvm/llvm-project/issues/60314 but they were not answered either. What should I do with this CL? Can you at least let me know why this wouldn't work given that there are many files like this? Repository: r

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4125a37806a: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery" (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145181/n

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

aheejin added a comment. Thanks for the investigation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145181/new/ https://reviews.llvm.org/D145181 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin created this revision. aheejin added reviewers: tlively, sbc100. Herald added subscribers: wingo, ecnelises, rupprecht, sunfish, hiraditya, jgravelle-google, dschuff. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. aheejin requested review of this revision. Herald ad

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin planned changes to this revision. aheejin added a comment. Herald added a subscriber: JDevlieghere. Oh, forgot to fix comments... will fix soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin updated this revision to Diff 352570. aheejin added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423 Files: lld/include/lld/Common/LLVM.h lld/test/wasm/Inputs/event-se

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin updated this revision to Diff 352571. aheejin added a comment. Typo fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423 Files: lld/include/lld/Common/LLVM.h lld/test/wasm/Inputs/event-sectio

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin updated this revision to Diff 352590. aheejin added a comment. clang-tidy fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423 Files: lld/include/lld/Common/LLVM.h lld/test/wasm/Inputs/event-se

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin updated this revision to Diff 352903. aheejin edited the summary of this revision. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423 Files: lld/include/ll

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d891d44f33f: [WebAssembly] Rename event to tag (authored by aheejin). Changed prior to commit: https://reviews.llvm.org/D104423?vs=352903&id=3529