[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-07 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert created this revision. gmittert added reviewers: compnerd, kwk. Herald added subscribers: lldb-commits, JDevlieghere, mgorny. Herald added a project: LLDB. When building standalone, since llvm-strip is a symlink, it is created using add_custom_command/add_custom_target which cannot be exp

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-08 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert updated this revision to Diff 223903. gmittert added a comment. Alright, rebased and added a comment to it Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: lit/CMakeLists.txt Index: lit/CMakeLists.txt

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-08 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert added a comment. Thanks! Can someone commit this for me? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-09 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert updated this revision to Diff 224147. gmittert added a comment. Updated/Rebased for the rename of lit->test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

2019-10-09 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert updated this revision to Diff 224148. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.txt ===

[Lldb-commits] [PATCH] D66448: Include "windows" Instead of "Windows"

2019-08-19 Thread Gwen Mittertreiner via Phabricator via lldb-commits
gmittert created this revision. gmittert added reviewers: xiaobai, JDevlieghere, labath, asmith. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The actual include directory is `lldb/Host/windows` not `lldb/Host/Windows` which breaks on case sensitive file systems Reposito

[Lldb-commits] [PATCH] D66445: Explicitly Cast Constants to DWORD

2019-08-22 Thread Gwen Mittertreiner via Phabricator via lldb-commits
jmittert added a comment. I believe it's using the one in ntstatus.h 10.0.16299.0\shared\ntstatus.h #define STATUS_BREAKPOINT((NTSTATUS)0x8003L)// winnt And `NTSTATUS` is defined as a `LONG` in powerbase.h 10.0.16299.0\um\powerbase.h #define NTSTATUS LONG which