clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So the main issue is to fix the:
uint32_t
SymbolFilePDB::ResolveSymbolContext(const lldb_private::FileSpec &file_spec,
uint32_t line, bool check_inlines,
clayborg accepted this revision.
clayborg added a comment.
The HostInfoBase::Initialize() and HostInfoBase::Terminate() might be good
places for your PDB calls like ::CoUninitialize(); to be placed...
http://reviews.llvm.org/D17420
___
lldb-commits
clayborg added a comment.
There are problems with the source file IDs you are using as they currently
must be indexes into the compile unit's support files. See inline comments for
more details.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:146
@@ +145,3 @@
+
+
clayborg added a comment.
General things to know about SymbolFiles:
- We use SymbolContext objects to refer to a specific symbol context: module,
compile unit, function, deepest block, line entry and symbol.
- A load address should produce 1 symbol context. Never more.
- A file address can produ
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
DWARF already has support for this using location lists. I would rather see
this done by having the DWARF parser modify the DWARF expression to be a
location list based. I don't
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We should probably make it such that if a section has the type
eSectionTypeAbsoluteAddress that we do the right thing inside the following
functions:
Section::GetLoadBaseAddress
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So your LineTable::Entry objects that you create are still invalid since you
didn't implement the support files.
All comments became unaligned but you did comment that:
> In Com
clayborg added a comment.
I would rather do this by modifying the expression locations if at all
possible. I would like to not having to modify each variable to contain a
RangeList as this is extra data per variable. I would be fine if we just add a
new enumeration to the DWARFExpression like S
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine to me.
http://reviews.llvm.org/D17501
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
clayborg resigned from this revision.
clayborg edited reviewers, added: jingham; removed: clayborg.
clayborg added a comment.
Looks good to me, but I think Jim Ingham should have a look in case he has
anything to add since Jim is the master or stepping.
Repository:
rL LLVM
http://reviews.llv
clayborg added a comment.
In http://reviews.llvm.org/D17449#359717, @tberghammer wrote:
> We have 2 (+1) independent dimension here:
>
> 1. List of ranges where the variable is in scope
> 2. List of ranges where the variable is available
> 3. Format of the location list (it is more of an implemen
clayborg added a comment.
In http://reviews.llvm.org/D17449#359874, @tberghammer wrote:
> I can live with that but I still think the scope information belongs to the
> variable and not to the DWARF expression representing it's location. As far
> as I see keeping the information inside the varia
Author: gclayton
Date: Wed Feb 24 14:47:13 2016
New Revision: 261768
URL: http://llvm.org/viewvc/llvm-project?rev=261768&view=rev
Log:
Removed unused functions.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachTask.h
lldb/trunk/tools/debugserver/source/MacOSX/MachTask.mm
Modifie
Author: gclayton
Date: Wed Feb 24 18:56:47 2016
New Revision: 261812
URL: http://llvm.org/viewvc/llvm-project?rev=261812&view=rev
Log:
Fix "target modules add -s " to work if the file doesn't exist
locally on the current machine.
Modified:
lldb/trunk/source/Commands/CommandObjectTarget.cp
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D17604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D17616
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: gclayton
Date: Thu Feb 25 19:20:20 2016
New Revision: 261950
URL: http://llvm.org/viewvc/llvm-project?rev=261950&view=rev
Log:
Fix all of the unannotated switch cases to annotate the fall through or do the
right thing and break.
Modified:
lldb/trunk/source/Core/ArchSpec.cpp
lldb
Author: gclayton
Date: Fri Feb 26 11:36:44 2016
New Revision: 262040
URL: http://llvm.org/viewvc/llvm-project?rev=262040&view=rev
Log:
The IOHandlerProcessSTDIO is the _only_ IOHandler that gets pushed and popped
from functions that are run due to something that is NOT input from the user.
All o
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
Sean should be the one to OK this.
http://reviews.llvm.org/D17618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
Author: gclayton
Date: Fri Feb 26 13:38:18 2016
New Revision: 262053
URL: http://llvm.org/viewvc/llvm-project?rev=262053&view=rev
Log:
Make sure the Target, Process and Thread GetGlobalProperties() static methods
are thread safe.
Modified:
lldb/trunk/source/Target/Process.cpp
lldb/tru
Author: gclayton
Date: Fri Feb 26 13:41:49 2016
New Revision: 262055
URL: http://llvm.org/viewvc/llvm-project?rev=262055&view=rev
Log:
Make sure to #include for the std::atomic that was recently
added.
Modified:
lldb/trunk/source/Target/Process.cpp
Modified: lldb/trunk/source/Target/Proce
> On Feb 26, 2016, at 2:49 PM, Zachary Turner wrote:
>
>
>
> On Thu, Feb 18, 2016 at 6:16 PM Greg Clayton wrote:
>
> > Just to make sure I understand, is it safe to say that:
> >
> > If check_inlines is false, sc_list should return with exactly 1
> > SymbolContext with m_comp_unit set to th
Author: gclayton
Date: Fri Feb 26 17:20:08 2016
New Revision: 262090
URL: http://llvm.org/viewvc/llvm-project?rev=262090&view=rev
Log:
Make LLDB safer to use with respect to the global destructor chain.
Modified:
lldb/trunk/source/Target/Process.cpp
lldb/trunk/source/Target/Target.cpp
> On Feb 26, 2016, at 3:22 PM, Zachary Turner wrote:
>
>
>
> On Fri, Feb 26, 2016 at 3:16 PM Greg Clayton wrote:
>
> > On Feb 26, 2016, at 2:49 PM, Zachary Turner wrote:
>
> > I'm coming back around to this now. What happens if check_inlines is
> > False, but the FileSpec is a header fil
> On Feb 26, 2016, at 3:33 PM, Zachary Turner wrote:
>
> Ok, so back to check_inlines. I realized after I hit send that the
> explanation I had written out is exactly what I thought I had to do for
> check_inlines == true.
>
> I guess a concrete example would make it clearer. If I have th
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will let Sean review this one as the expression parser is his area of
expertise.
http://reviews.llvm.org/D17719
___
lldb-commits mailing list
l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good to me, commit when you know this will work with MSVC versions you
need. All other platforms will be good to go.
http://reviews.llvm.org/D17710
__
clayborg added a comment.
As long as both long and short options are still supported? Can you still type
any of:
- --arch=x86_64
- --arch x86_64
- -arch=x86_64
- -arch x86_64
- -ax86_64
- -a x86_64
Are we able to track which options can be used with other options with the llvm
solution? I didn
clayborg added a comment.
In http://reviews.llvm.org/D17724#364454, @zturner wrote:
> long and short options are supported, but the one I'm not sure about is the
> case where you use a short option with no space. Your example "-ax86_64"
> might not work. It might, just that it should be teste
You shouldn't have to do any of this. There should be a 1 to 1 mapping between
a Module and a SymbolVendor which has a single SymbolFile. My guess is that you
should just return:
kAllAbilities
for SymbolFilePDB::CalculateAbilities (). Try that and let me know how this
goes. These abilities are
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
One general comment is the use of "auto". Although it makes the code shorter,
it does make it quite a bit less readable. I will leave the decision to you
since this is your code,
You don't add plug-in specify unique_ptr and shared_ptr definitions. You would
put these in SymbolFilePDB.h only.
> On Mar 1, 2016, at 10:51 AM, Jim Ingham wrote:
>
> There's an lldb-private-forward.h that you can use for this purpose if you
> wish.
>
> Jim
>
>> On Mar 1, 2016, at 10:32 AM,
You could add a test to that grabs functions bounds, once you implement
functions, and then lookup each address inside of a function and make sure each
one has a file and line. This might fall down for complex examples, but we also
ran into the Swift compiler saying a function went from 0x1000-0
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So this is nice that you cleaned up this one place where we can use LLVM's
option parsing stuff, but it now makes the driver inconsistent with the rest of
LLDB. It also makes it
clayborg added a comment.
Our current consistent way of parsing options is to use getopt_long()
everywhere.
http://reviews.llvm.org/D17724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
You are right. I am slowly seeing that PDB was designed well to be consumed as
a user would want to, not compressed to the point of obfuscation and very
difficult to extract data from like
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
As long as you don't mind your last line entry potentially being really large
because it isn't terminated?
(lldb) target create
D:\src\llvm\tools\lldb\unittests\SymbolFile\PDB
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I guess you already tackled the termination entry! That is exactly what I
wanted to see... Sounds like line tables are done!
http://reviews.llvm.org/D17363
clayborg added a comment.
The empty line signifies that the previous entry was a termination entry.
http://reviews.llvm.org/D17363
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This is already fixed. Update your sources and let us know if things are
working.
> On Mar 2, 2016, at 5:10 PM, Ying Chen wrote:
>
> chying added a subscriber: chying.
> chying added a comment.
>
> Seems this patch breaks OSX build. I guess the new files were not added to
> xcode project file
clayborg added a subscriber: clayborg.
clayborg added a comment.
This is already fixed. Update your sources and let us know if things are
working.
http://reviews.llvm.org/D17363
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
clayborg added a comment.
Feel free to check this in a branch if you want to keep it around for when you
later work on this so you don't lose the changes?
http://reviews.llvm.org/D17724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
> On Mar 3, 2016, at 12:33 PM, Jim Ingham wrote:
>
>
>> On Mar 2, 2016, at 10:18 AM, Greg Clayton wrote:
>>
>> So this is nice that you cleaned up this one place where we can use LLVM's
>> option parsing stuff, but it now makes the driver inconsistent with the rest
>> of LLDB. It also make
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D17897
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
ObjectFilePECOFF::GetEntryPointAddress() is not implemented correctly. See
inlined comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:8
clayborg added a comment.
lldb_private::Address is a section offset address class. We use section offset
addresses everywhere. We also have the notion of three types of addresses: file
address, load address and host address.
File addresses are virtual addresses as they are found in the object f
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D18008
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/expression_path/TestExpressionPath.py:44-46
@@ +43,4 @@
+
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine to me.
Repository:
rL LLVM
http://reviews.llvm.org/D18005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D18044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D18050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg created this revision.
clayborg added a reviewer: zturner.
clayborg added a subscriber: lldb-commits.
After the Python 3 fixes the interactive python interpreter stopped working in
Xcode. The issue was the python interpreter tried to adopt the top IOHandler
file handles, but it failed d
Author: gclayton
Date: Thu Mar 10 14:49:32 2016
New Revision: 263161
URL: http://llvm.org/viewvc/llvm-project?rev=263161&view=rev
Log:
Fixed the python interpreter so that it correctly inherits the top IOHandler's
files instead of always using stdin/out/err.
Removed lldb_private::File::Duplicate
clayborg closed this revision.
clayborg added a comment.
Submitted with SVN revision 263161.
http://reviews.llvm.org/D18057
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will let Sean Callanan review this one as the expression parser is his area.
Repository:
rL LLVM
http://reviews.llvm.org/D17957
___
lldb-comm
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D18082
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg accepted this revision.
clayborg added a comment.
Looks good.
http://reviews.llvm.org/D18075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
Comment at:
packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8
@@ +7,2 @@
+clean::
+ rm -rf $(wildcard *.o *.d *.dSYM)
Maybe we can have a standard clean rule in the main makefiles:
stand
Author: gclayton
Date: Tue Mar 15 16:58:28 2016
New Revision: 263593
URL: http://llvm.org/viewvc/llvm-project?rev=263593&view=rev
Log:
Don't crash if the TypeSP is empty.
Modified:
lldb/trunk/include/lldb/Symbol/Type.h
Modified: lldb/trunk/include/lldb/Symbol/Type.h
URL:
http://llvm.org/vi
Author: gclayton
Date: Tue Mar 15 17:43:26 2016
New Revision: 263601
URL: http://llvm.org/viewvc/llvm-project?rev=263601&view=rev
Log:
Fix ClangASTContext::GetFunctionArgumentAtIndex() to not water down the type to
the canonical type before handing the type out for the function type.
Modified:
Author: gclayton
Date: Tue Mar 15 17:44:07 2016
New Revision: 263602
URL: http://llvm.org/viewvc/llvm-project?rev=263602&view=rev
Log:
Only try to load the OS plug-in after a shared library load if we don't already
have one.
Modified:
lldb/trunk/source/Target/Process.cpp
Modified: lldb/t
Author: gclayton
Date: Fri Mar 18 15:53:35 2016
New Revision: 263830
URL: http://llvm.org/viewvc/llvm-project?rev=263830&view=rev
Log:
Added a break statement that was needed. Caught by clang's unannotated case
fall through warning.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebuggerHandleE
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks great, thanks for catching and fixing this. Can we add a test for this so
we don't regress?
http://reviews.llvm.org/D18228
_
Author: gclayton
Date: Fri Mar 18 15:33:49 2016
New Revision: 263824
URL: http://llvm.org/viewvc/llvm-project?rev=263824&view=rev
Log:
Fixed a bug where DW_AT_start_scope would fall through to DW_AT_artificial in
SymbolFileDWARF::ParseVariableDIE(). This was caught by the clang warning that
catc
clayborg requested changes to this revision.
This revision now requires changes to proceed.
Comment at: source/Host/common/File.cpp:48
@@ -47,3 +47,3 @@
}
-else if (options & File::eOpenOptionWrite)
+else
{
This change isn't neede
clayborg added a comment.
Just to be clear in the code we should set the write flag and not make any
assumptions. So then the first diff isn't needed and only PythonDataObjects.cpp
needs to change.
http://reviews.llvm.org/D18228
___
lldb-commits m
clayborg resigned from this revision.
clayborg edited reviewers, added: spyffe; removed: clayborg.
clayborg added a comment.
Sean Callanan would have more expertise in this area.
1. List Item
http://reviews.llvm.org/D18059
___
lldb-commits mailing
Author: gclayton
Date: Fri Mar 18 15:36:30 2016
New Revision: 263826
URL: http://llvm.org/viewvc/llvm-project?rev=263826&view=rev
Log:
Fixed an case fall through that wasn't meant to happen. Caught by clang's
unannotated case fall through warning.
Modified:
lldb/trunk/source/Plugins/SymbolFi
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D17970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
I need to speak with you about this and I do have objections. I made a ton of
comments inline and as I started to understand what you were trying to do many
objections changed, but I still have them. There is a ton of stuff in there and
I would like to speak with you o
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. One other alternative is to get the type from the program if it
exists in the debug info and explore the struct using ValueObject. This would
get you out of the fixed alignment
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D18335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
No, this fixed the problem of printing the "(lldb) " prompt first, then being
asked to print async text, then not refreshing the prompt. Not to say there
won't still be a race, but this particular problem is what we are fixing.
http://reviews.llvm.org/D18335
__
clayborg added a comment.
It would be nice to clear the line though. What _should_ happen is the "(lldb)
" prompt is cleared by clearing text to the start of where the prompt was
printed, then display the async text and refresh the prompt. So this fix is a
bit hacky in that it isn't trying to s
clayborg added a comment.
this could still be the same bug. So if this doesn't fix things for you on
windows, then this bug isn't quite fixed. Ted, are you seeing the same thing?
amccarth, can you attach some output to see what you are seeing?
http://reviews.llvm.org/D18335
clayborg added a comment.
Seems like it would be nice to get the prompt clearing working...
http://reviews.llvm.org/D18335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
After our last conversation I must have missed that both Go and Java need to be
able to provide custom DWARF parsing. Any language, and any TypeSystem, should
be able to provide
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
One thing to note: don't use Process::DoReadMemory(), it doesn't cache data and
it will always result in a read memory packet going to GDB server if you are
using lldb-server and
clayborg added a comment.
No. Keep GetDWARFParser() on TypeSystem and all that code as is. You shouldn't
need to add GetPDBParser() to TypeSystem as you should get a type system for
language from within your SymbolFilePDB (with a language like C or C++) and
then make a PDBParser with a referenc
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp:110-119
@@ -80,3 +109,12 @@
-} // anonymous namespace end
+template
+
clayborg added a comment.
I
In http://reviews.llvm.org/D18381#381457, @zturner wrote:
> I guess my point was just that it seems a little weird to treat DWARF
> specially. It's just another debug info format (albeit one that most
> compilers support), so by baking into the supposedly generic i
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for all the fixes.
http://reviews.llvm.org/D18379
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few things in inlined comments, but this is very close.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParser.h:36
@@ -35,3 +35,3 @@
virtual bool
-
clayborg added a comment.
I will need to run the MacOSX test suite on this before I can give it the OK. I
won't be able to do this today, but might be able to get to it tomorrow. If you
can run the MacOSX test suite, let me know.
http://reviews.llvm.org/D18381
__
clayborg added a comment.
Sounds good. This code is very tricky and we need to find a way to control this
so that these issues never happen. When we do this, it will hopefully fix these
kinds of issues for everyone. Thanks for taking the extra time to look into it
and at least you have made the
You you building with Xcode? You should be building by checking out lldb at the
top level, then typing:
% xcodebuild -configuration Debug
> On Mar 24, 2016, at 12:31 PM, Zachary Turner wrote:
>
> Having trouble building on OSX.
>
> ERROR:root:Unable to find swig executable: 'module' object h
I usually select "desktop" as the target. Is this patch up to date? If so, I
can apply and compile it and let you know what the results are.
> On Mar 24, 2016, at 2:21 PM, Zachary Turner wrote:
>
> Yes I was doing it from inside the IDE though. I selected lldb-tool, 64-bit,
> and hit Product
Author: gclayton
Date: Thu Mar 24 16:46:47 2016
New Revision: 264346
URL: http://llvm.org/viewvc/llvm-project?rev=264346&view=rev
Log:
Get rid of a global constructor that was causing a warning on MacOSX and make
the Timer safe to use after the main threads global destructor chain is called.
Mo
Author: gclayton
Date: Thu Mar 24 16:48:10 2016
New Revision: 264347
URL: http://llvm.org/viewvc/llvm-project?rev=264347&view=rev
Log:
Get rid of two global constructors by making things static variables in the
only function that uses these variables.
Modified:
lldb/trunk/source/Plugins/La
Author: gclayton
Date: Thu Mar 24 16:49:22 2016
New Revision: 264348
URL: http://llvm.org/viewvc/llvm-project?rev=264348&view=rev
Log:
Get rid of a global constructor and also make this code safe to use after the
global destructor chain has been run on the main thread.
Modified:
lldb/trunk/
clayborg added a comment.
What does some sample output of this look like? I can't remember what
module->Dump(...) does.
http://reviews.llvm.org/D18464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
You might need to set your workspace settings for the lldb.xcworkspace as
follows:
File -> Workspace Settings...
Derived Data: Workspace-relative Location
and use the value "build" for it
Then click the "Advanced..." button and select "Legacy".
The test suite automatically looks in the lldb
Author: gclayton
Date: Thu Mar 24 18:50:03 2016
New Revision: 264361
URL: http://llvm.org/viewvc/llvm-project?rev=264361&view=rev
Log:
Ignore global constructor warning in clang.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/source
clayborg requested changes to this revision.
clayborg added a comment.
Seems like we need to just add the following to the API:
void
SetImmediateOutputFile (FILE *fh, bool transfer_ownership);
void
SetImmediateErrorFile (FILE *fh, bool transfer_ownership);
This should solve our proble
Will do.
> On Mar 24, 2016, at 3:30 PM, Zachary Turner wrote:
>
> Is there any way you could try it out for me? It still doesn't build
> successfully from the IDE with those steps.
>
> The patch should apply cleanly at tip. Later this week I can try to nuke my
> whole lldb directory and s
clayborg added a comment.
We don't necessarily need to expose this new API to swig. We get to pick and
choose what we expose to Python in the SBCommandReturnObject.i file. So leave
the .i file as is and use %rename to specify "transfer_ownership = true". Will
that work?
http://reviews.llvm.or
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would prefer to do this with overloading if possible. See inlined comments.
Comment at: include/lldb/API/SBCommandReturnObject.h:87-91
@@ -86,7 +86,7 @@
clayborg accepted this revision.
clayborg added a comment.
Looks good. Thanks for taking the time to get this working right.
http://reviews.llvm.org/D18459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: gclayton
Date: Tue Mar 29 12:36:38 2016
New Revision: 264753
URL: http://llvm.org/viewvc/llvm-project?rev=264753&view=rev
Log:
Don't try to call getTypeSize() on a class if it isn't complete as clang will
assert and kill the process.
Modified:
lldb/trunk/source/Symbol/ClangASTContext
Author: gclayton
Date: Tue Mar 29 13:22:07 2016
New Revision: 264762
URL: http://llvm.org/viewvc/llvm-project?rev=264762&view=rev
Log:
When creating typedefs, don't call Type::GetName() since that might recursively
call
"lldb_private::Type::ResolveClangType(lldb_private::Type::ResolveStateTag)"
701 - 800 of 3323 matches
Mail list logo
