@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/71772
>From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 8 Nov 2023 21:14:49 -0800
Subject: [PATCH] Centralize the code that figures out which memory ranges to
save
clayborg wrote:
I addressed most of the feedback. Alex let me know if you still really want
llvm::Error and llvm::Expected to be used as I can add that if you think it is
required. I also ran clang format.
https://github.com/llvm/llvm-project/pull/71772
clayborg wrote:
@jasonmolenda I was wondering if we should modify
`GetCoreFileSaveRangesDirtyOnly(...)` to try and add all dirty pages and see if
any regions have the dirty page info, but if no memory region infos have the
dirty pages information, then fall back to adding all memory regions wi
clayborg wrote:
@bulbazord let me know if you require any changes after reading my inline
comments.
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
So this hardcodes the frame display to only be the function name, or function
name with args. Do we want to allow users to specify a frame format in the
lldb-vscode settings? We could have two settings: one to enable the featur
@@ -1232,6 +1234,32 @@ const char *SBFrame::GetFunctionName() const {
return name;
}
+void SBFrame::GetDisplayFunctionNameWithArgs(SBStream &output) {
+ Stream &strm = output.ref();
+
+ std::unique_lock lock;
+ ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
+
+ Stack
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,8 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "symbollocatordebuginfod" in {
+ def URLs: Property<"urls", "String">,
+Global,
+DefaultStringValue<"">,
+Desc<"A space-separated, ordered list of Debuginfod server URLs to
@@ -4,7 +4,7 @@ let Definition = "modulelist" in {
def EnableExternalLookup: Property<"enable-external-lookup", "Boolean">,
Global,
DefaultTrue,
-Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-f
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -4180,7 +4180,6 @@ TargetProperties::TargetProperties(Target *target)
ePropertyInheritTCC, [this] { InheritTCCValueChangedCallback(); });
m_collection_sp->SetValueChangedCallback(
ePropertyDisableSTDIO, [this] { DisableSTDIOValueChangedCallback(); });
-
-
@@ -46,6 +46,10 @@ bool canUseDebuginfod();
/// environment variable.
SmallVector getDefaultDebuginfodUrls();
+/// Sets the list of debuginfod server URLs to query. This overrides the
+/// environment variable DEBUGINFOD_URLS.
clayborg wrote:
Should this over
@@ -62,15 +66,25 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
See inline comment
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
clayborg wrote:
DataExtractor objects don't always have shared buffers. I am guessing in this
case it does have them, but you might throw in a `lldbassert(...)` just in case
clayborg wrote:
A great future patch would be to have StructuredData backed by the llvm::json
stuff instead of our own custom version of this a JSON style object hiearchy
https://github.com/llvm/llvm-project/pull/71961
___
lldb-commits mailing list
ll
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
clayborg wrote:
Fine with me!
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.ll
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
clayborg wrote:
> These asserts might not always pass? I don't know if it's guaranteed that if
> one of those sections is present, then the rest of them are as well.
You ca
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/71772
>From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 8 Nov 2023 21:14:49 -0800
Subject: [PATCH 1/2] Centralize the code that figures out which memory ranges
to s
https://github.com/clayborg commented:
LGTM
https://github.com/llvm/llvm-project/pull/71984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
LGTM
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -601,8 +602,8 @@ SBValue SBFrame::FindValue(const char *name, ValueType
value_type,
stop_if_block_is_inlined_function,
[frame](Variable *v) { return v->IsInScope(frame); },
&variable_list);
- if (value_type == eValueT
@@ -255,6 +255,11 @@
"type":
"string",
"description":
"The escape prefix to use for executing regular LLDB commands in the Debug
Console, instead of p
@@ -324,8 +325,29 @@ class StackFrame : public ExecutionContextScope,
///C string with the assembly instructions for this function.
const char *Disassemble();
+ /// Print a description of this frame using the provided frame format.
+ ///
+ /// \param[out] strm
+ //
@@ -947,6 +950,33 @@ SBValue SBFrame::FindRegister(const char *name) {
return result;
}
+bool SBFrame::GetDescriptionWithFormat(const SBFormat &format, SBStream
&output,
+ const char *default_value) {
clayborg wrote:
r
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -193,6 +193,27 @@ class LLDB_API SBFrame {
bool GetDescription(lldb::SBStream &description);
+ /// Similar to \a GetDescription() but the format of the description can be
+ /// configured via the \p format parameter. See
+ /// https://lldb.llvm.org/use/formatting.html
@@ -0,0 +1,50 @@
+//===-- SBFormat.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -814,9 +815,11 @@ SBValueList SBFrame::GetVariables(const
lldb::SBVariablesOptions &options) {
if (num_variables) {
size_t num_produced = 0;
for (const VariableSP &variable_sp : *variable_list) {
- if (INTERRUPT_REQUESTED(dbg,
@@ -1779,18 +1779,36 @@ void
StackFrame::CalculateExecutionContext(ExecutionContext &exe_ctx) {
exe_ctx.SetContext(shared_from_this());
}
+bool StackFrame::DumpUsingFormat(Stream &strm,
+ const FormatEntity::Entry *format,
+
@@ -785,11 +785,18 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame) {
int64_t frame_id = MakeDAPFrameID(frame);
object.try_emplace("id", frame_id);
- // `function_name` can be a nullptr, which throws an error when assigned to
an
- // `std::string`.
- const c
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/71921
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -184,6 +184,8 @@ class LLDB_API SBTarget {
SBProcess LoadCore(const char *core_file);
SBProcess LoadCore(const char *core_file, lldb::SBError &error);
+ SBProcess LoadCore(SBFile &file);
clayborg wrote:
Just add the error to your function call:
```
SB
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/71772
>From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 8 Nov 2023 21:14:49 -0800
Subject: [PATCH 1/3] Centralize the code that figures out which memory ranges
to s
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/71772
>From f1bd931ff434012888b0b87a75daaf6ba99102c0 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 8 Nov 2023 21:14:49 -0800
Subject: [PATCH 1/3] Centralize the code that figures out which memory ranges
to s
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> Hello @clayborg ! Looks like this patch broke lldb-aarch64-windows bot:
> https://lab.llvm.org/buildbot/#/builders/219/builds/6868 Could you please
> look at this ?
@antmox
I looked at this and I didn't touch anything related to native windows core
file saving. If this is
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/72109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
Does anyone have access to a native windows arm64 build of LLDB that could help
look at this?
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/clayborg requested changes to this pull request.
Just need to not use `llvm::errs()` or `llvm::outs()` in lldb DAP, use
DAP::SendOutput(OutputType::Console, ...)` to ensure that the users sees this.
https://github.com/llvm/llvm-project/pull/71843
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -824,4 +824,15 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger
debugger,
return true;
}
+void DAP::SetFrameFormat(llvm::StringRef format) {
+ if (format.empty())
+return;
+ lldb::SBError error;
+ g_dap.frame_format = lldb::SBFormat::Parse(format.data(),
@@ -0,0 +1,69 @@
+
+//===-- SBFormat.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,47 @@
+//===-- SBFormat.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/clayborg requested changes to this pull request.
One last request: test the SBFormat API in a stand alone test in
`lldb/test/api/sbformat` so we can see if the errors work and the "operator
bool" works as expected:
```
format = lldb.SBFormat()
self.assertFalse(format)
err = l
https://github.com/clayborg approved this pull request.
Thanks for all of the changes. Looks great!
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
@@ -839,4 +839,19 @@ void DAP::SetFrameFormat(llvm::StringRef format) {
}
}
+void DAP::SetThreadFormat(llvm::StringRef format) {
+ if (format.empty())
+return;
+ lldb::SBError error;
+ g_dap.thread_format = lldb::SBFormat(format.data(), error);
claybo
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/72196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
On simple change and this is good to go.
https://github.com/llvm/llvm-project/pull/72196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/72196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/72292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id = thread.GetStopReasonD
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/72292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> @clayborg I will try to reproduce on the buildbot windows machine. build
> ongoing
If you end up being able to reproduce, if you can send the minidump file that
was produced I should be able to look at it to make sure it was not produced by
the core file saver. But if this i
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id = thread.GetStopReasonD
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/72236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
LGTM. I didn't mean to accept the patch when it was using `PRIo32`
https://github.com/llvm/llvm-project/pull/72292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
clayborg wrote:
> [core_dmps.tar.gz](https://github.com/llvm/llvm-project/files/13355872/core_dmps.tar.gz)
> here is an archive with the 2 core.dmp files
It does indeed seem like my new core file creation code is being triggered on
windows. I am working on a fix that adds ARM64 support to the
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/72315
This patch adds support for saving minidumps with the arm64 architecture. It
also will cause unsupported architectures to emit an error where before this
patch it would emit a minidump with partial information.
clayborg wrote:
> [antmox](/antmox)
https://github.com/llvm/llvm-project/pull/72315
A new PR to fix this issue. Is there any way you can test this to see if this
works?
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
ll
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/72315
>From dd4dd79853566049874f49d1290217f5abde23fd Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 14 Nov 2023 13:53:25 -0800
Subject: [PATCH 1/2] Add support for arm64 registers in minidump core file
saving
clayborg wrote:
> LGTM. minidump tests are now OK on linaro-armv8-windows-msvc machine.
Feel free to accept this patch then and I can get it merged!
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
lldb-commits@lists.llvm
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
@antmox Hopefully this clears up the issue on the build bot! Thanks for testing
this for me.
https://github.com/llvm/llvm-project/pull/72315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
@@ -244,9 +245,38 @@ SBProcess SBTarget::LoadCore(const char *core_file,
lldb::SBError &error) {
TargetSP target_sp(GetSP());
if (target_sp) {
FileSpec filespec(core_file);
-FileSystem::Instance().Resolve(filespec);
+auto file = FileSystem::Instance().Open(
+
@@ -627,7 +628,7 @@ class Target : public std::enable_shared_from_this,
// used.
const lldb::ProcessSP &CreateProcess(lldb::ListenerSP listener_sp,
llvm::StringRef plugin_name,
- const FileSpec *cr
@@ -3174,8 +3174,17 @@ class TargetCreateFormDelegate : public FormDelegate {
core_file_directory_spec.SetDirectory(core_file_spec.GetDirectory());
target_sp->AppendExecutableSearchPaths(core_file_directory_spec);
-ProcessSP process_sp(target_sp->CreateProcess(
-
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/71769
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71769
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -194,11 +194,12 @@ void ProcessGDBRemote::Terminate() {
PluginManager::UnregisterPlugin(ProcessGDBRemote::CreateInstance);
}
-lldb::ProcessSP ProcessGDBRemote::CreateInstance(
-lldb::TargetSP target_sp, ListenerSP listener_sp,
-const FileSpec *crash_file_path, boo
@@ -427,8 +427,17 @@ class CommandObjectTargetCreate : public
CommandObjectParsed {
core_file_dir.SetDirectory(core_file.GetDirectory());
target_sp->AppendExecutableSearchPaths(core_file_dir);
+auto file = FileSystem::Instance().Open(
+core
@@ -102,10 +102,10 @@ void ProcessKDP::Terminate() {
lldb::ProcessSP ProcessKDP::CreateInstance(TargetSP target_sp,
ListenerSP listener_sp,
- const FileSpec *crash_file_path,
+
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
@@ -46,6 +46,10 @@ bool canUseDebuginfod();
/// environment variable.
SmallVector getDefaultDebuginfodUrls();
+/// Sets the list of debuginfod server URLs to query. This overrides the
+/// environment variable DEBUGINFOD_URLS.
+void setDefaultDebuginfodUrls(SmallVector URLs);
https://github.com/clayborg commented:
Looks good, a few suggestions in `llvm/lib/Debuginfod/Debuginfod.cpp`. I will
let Jonas comment if the settings are done the right way in the plug-in
manager. Plug-in code looks fine.
https://github.com/llvm/llvm-project/pull/70996
___
@@ -47,6 +47,10 @@ namespace llvm {
using llvm::object::BuildIDRef;
+SmallVector DebuginfodUrls;
clayborg wrote:
Maybe make this `std::optional< SmallVector >` and get rid of
`DebuginfodUrlsSet` below? We might want a std::mutex here to protect
multi-threa
clayborg wrote:
I am not sure how this actually works? We pass in a SBFile and then get the
FileSpec from it and then somehow that allows us to open a file that doesn't
actually exist on disk? Or does this work _because_ the `fd` we had is actually
backed by some file on disk? In that case we
https://github.com/clayborg commented:
Looks good to me from a code perspective as long as this works.
It would be nice to add a test for Darwin only. Luckily this is easy to test to
ensure it works.
https://github.com/llvm/llvm-project/pull/72565
__
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/72565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -799,7 +799,33 @@ DNBProcessAttachWait(RNBContext *ctx, const char
*waitfor_process_name,
break;
}
- ::usleep(waitfor_interval); // Sleep for WAITFOR_INTERVAL, then poll
again
+ // Now we're going to wait a while before polling again. But we also
Author: Greg Clayton
Date: 2022-08-25T14:48:04-07:00
New Revision: 613336da8ce16bd2e998e77e02eaf5866ad7e311
URL:
https://github.com/llvm/llvm-project/commit/613336da8ce16bd2e998e77e02eaf5866ad7e311
DIFF:
https://github.com/llvm/llvm-project/commit/613336da8ce16bd2e998e77e02eaf5866ad7e311.diff
Author: Greg Clayton
Date: 2022-09-09T16:14:46-07:00
New Revision: 9af089f5179d52c6561ec27532880edcfb6253af
URL:
https://github.com/llvm/llvm-project/commit/9af089f5179d52c6561ec27532880edcfb6253af
DIFF:
https://github.com/llvm/llvm-project/commit/9af089f5179d52c6561ec27532880edcfb6253af.diff
Author: Greg Clayton
Date: 2022-09-12T13:59:05-07:00
New Revision: 4763200ec95ce6514403176017f29b87757b292a
URL:
https://github.com/llvm/llvm-project/commit/4763200ec95ce6514403176017f29b87757b292a
DIFF:
https://github.com/llvm/llvm-project/commit/4763200ec95ce6514403176017f29b87757b292a.diff
Author: Greg Clayton
Date: 2022-09-12T16:53:19-07:00
New Revision: 376c7bd92aff0e4256b2842400936a9b29343045
URL:
https://github.com/llvm/llvm-project/commit/376c7bd92aff0e4256b2842400936a9b29343045
DIFF:
https://github.com/llvm/llvm-project/commit/376c7bd92aff0e4256b2842400936a9b29343045.diff
Author: Greg Clayton
Date: 2022-09-22T11:35:20-07:00
New Revision: ccb47b41e4936d1d44dfbaf5aac028280c216932
URL:
https://github.com/llvm/llvm-project/commit/ccb47b41e4936d1d44dfbaf5aac028280c216932
DIFF:
https://github.com/llvm/llvm-project/commit/ccb47b41e4936d1d44dfbaf5aac028280c216932.diff
Author: Greg Clayton
Date: 2022-09-28T15:38:02-07:00
New Revision: 15f83ab77502cb2bd405a091cf419536e1d41381
URL:
https://github.com/llvm/llvm-project/commit/15f83ab77502cb2bd405a091cf419536e1d41381
DIFF:
https://github.com/llvm/llvm-project/commit/15f83ab77502cb2bd405a091cf419536e1d41381.diff
Author: Greg Clayton
Date: 2022-09-28T15:39:54-07:00
New Revision: 8f8935139adf44584634d4bacd35e3eee3f648a5
URL:
https://github.com/llvm/llvm-project/commit/8f8935139adf44584634d4bacd35e3eee3f648a5
DIFF:
https://github.com/llvm/llvm-project/commit/8f8935139adf44584634d4bacd35e3eee3f648a5.diff
Author: Greg Clayton
Date: 2022-09-29T10:54:31-07:00
New Revision: b3a0bed5fb8766dcf27583ab1f73edc6e7232657
URL:
https://github.com/llvm/llvm-project/commit/b3a0bed5fb8766dcf27583ab1f73edc6e7232657
DIFF:
https://github.com/llvm/llvm-project/commit/b3a0bed5fb8766dcf27583ab1f73edc6e7232657.diff
2801 - 2900 of 3324 matches
Mail list logo
