clayborg wrote:
Any chance we can get this in?
https://github.com/llvm/llvm-project/pull/81067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
What is the status of this PR? I think we will want this to make sure we don't
spam too many individual progress events. It can also be adpated for the new
categories after it goes in.
https://github.com/llvm/llvm-project/pull/75769
_
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/81564
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,31 @@
+"""
+Make sure that the concurrent vfork() from multiple threads works correctly.
+"""
+
+
+import lldb
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+
+
+class TestConcurrentVFork(Test
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/81564
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,31 @@
+"""
+Make sure that the concurrent vfork() from multiple threads works correctly.
+"""
+
+
+import lldb
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+
+
+class TestConcurrentVFork(Test
@@ -0,0 +1,31 @@
+"""
+Make sure that the concurrent vfork() from multiple threads works correctly.
+"""
+
+
+import lldb
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+
+
+class TestConcurrentVFork(Test
@@ -0,0 +1,45 @@
+#include
+#include
+#include
+#include
+
clayborg wrote:
Might be a good idea to create a global `std::vector` and a mutex to
protect it. And any child processes that get forked get added to this vector.
So maybe add:
```
std::mutex g_chil
@@ -120,15 +120,25 @@ bool NativeThreadLinux::GetStopReason(ThreadStopInfo
&stop_info,
case eStateCrashed:
case eStateExited:
case eStateSuspended:
- case eStateUnloaded:
+ case eStateUnloaded: {
if (log)
LogThreadStopInfo(*log, m_stop_info, "m_stop_info in
@@ -5681,7 +5684,10 @@ void ProcessGDBRemote::DidVForkDone() {
void ProcessGDBRemote::DidExec() {
// If we are following children, vfork is finished by exec (rather than
// vforkdone that is submitted for parent).
- if (GetFollowForkMode() == eFollowChild)
-m_vfork_in_
@@ -0,0 +1,45 @@
+#include
+#include
+#include
+#include
+
+int call_vfork() {
+ printf("Before vfork\n");
+
+ pid_t child_pid = vfork();
+
+ if (child_pid == -1) {
+// Error handling
+perror("vfork");
+return 1;
+ } else if (child_pid == 0) {
+// This code
@@ -5670,8 +5673,8 @@ void ProcessGDBRemote::DidVFork(lldb::pid_t child_pid,
lldb::tid_t child_tid) {
}
void ProcessGDBRemote::DidVForkDone() {
- assert(m_vfork_in_progress);
- m_vfork_in_progress = false;
+ --m_vfork_in_progress;
+ assert(m_vfork_in_progress >= 0);
-
@@ -301,7 +301,8 @@ class ProcessGDBRemote : public Process,
using FlashRange = FlashRangeVector::Entry;
FlashRangeVector m_erased_flash_ranges;
- bool m_vfork_in_progress;
+ // Number of vfork in process.
+ int m_vfork_in_progress;
clayborg wrote:
Do
@@ -0,0 +1,45 @@
+#include
+#include
+#include
+#include
+
+int call_vfork() {
+ printf("Before vfork\n");
+
+ pid_t child_pid = vfork();
+
+ if (child_pid == -1) {
+// Error handling
+perror("vfork");
+return 1;
+ } else if (child_pid == 0) {
+// This code
@@ -1666,33 +1646,52 @@ class CommandObjectProcessHandle : public
CommandObjectParsed {
// the user's options.
ProcessSP process_sp = target.GetProcessSP();
-int stop_action = -1; // -1 means leave the current setting alone
-int pass_action = -1; // -1 mea
clayborg wrote:
> > This uses `DataExtractor::GetMaxU64` which already does this under the
> > hood. What does this do that isn't already being done? It may help if you
> > add a test case to show what you are trying to fix.
>
> @clayborg @bulbazord The problem with GetMaxU64 is that it always
clayborg wrote:
What code is taking a scalar and then trying to byte swap it after it has been
created?
https://github.com/llvm/llvm-project/pull/81451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object &request) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool is_duplica
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object &request) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool is_duplica
@@ -561,6 +561,46 @@ void EventThreadFunction() {
}
}
+lldb::SBValue FindVariable(uint64_t variablesReference, llvm::StringRef name) {
+ lldb::SBValue variable;
+ if (lldb::SBValueList *top_scope = GetTopLevelScope(variablesReference)) {
+bool is_duplicated_variable_na
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object &request) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool is_duplica
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object &request) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool is_duplica
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const
llvm::json::Object &request) {
body.try_emplace("description", error_cstr && error_cstr[0]
? std::string(error_cstr)
: "evalu
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const
llvm::json::Object &request) {
body.try_emplace("description", error_cstr && error_cstr[0]
? std::string(error_cstr)
: "evalu
@@ -2757,13 +2769,18 @@ void request_dataBreakpointInfo(const
llvm::json::Object &request) {
body.try_emplace("description", error_cstr && error_cstr[0]
? std::string(error_cstr)
: "evalu
https://github.com/clayborg approved this pull request.
Looks good!
https://github.com/llvm/llvm-project/pull/81319
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1666,33 +1646,52 @@ class CommandObjectProcessHandle : public
CommandObjectParsed {
// the user's options.
ProcessSP process_sp = target.GetProcessSP();
-int stop_action = -1; // -1 means leave the current setting alone
-int pass_action = -1; // -1 mea
clayborg wrote:
> > I am fine with telling people what to do and giving them a golden path to
> > what is easiest for our debuggers. And I will suggest to everyone that they
> > use `.debug` and `.dwp`, but if we want to only support this, this leaves
> > the downloading of the `.debug` file r
@@ -24,6 +24,9 @@ class LLDB_API SBStatisticsOptions {
void SetSummaryOnly(bool b);
bool GetSummaryOnly();
+
+ void SetForceLoading(bool b);
clayborg wrote:
Need headerdoc for these.
https://github.com/llvm/llvm-project/pull/81706
@@ -24,6 +24,9 @@ class LLDB_API SBStatisticsOptions {
void SetSummaryOnly(bool b);
bool GetSummaryOnly();
+
+ void SetForceLoading(bool b);
+ bool GetForceLoading();
clayborg wrote:
The `SetForceLoading` name doesn't clearly indicate to us what we ar
@@ -186,7 +186,19 @@ class SymbolFileDWARF : public SymbolFileCommon {
GetMangledNamesForFunction(const std::string &scope_qualified_name,
std::vector &mangled_names) override;
- uint64_t GetDebugInfoSize() override;
+ /// Get total currently l
@@ -132,6 +132,7 @@ struct ConstStringStats {
struct StatisticsOptions {
bool summary_only = false;
+ bool force_loading = false;
clayborg wrote:
Maybe `load_all_debug_info` is more clear?
https://github.com/llvm/llvm-project/pull/81706
__
@@ -391,7 +392,14 @@ class SymbolFile : public PluginInterface {
/// entire file should be returned. The default implementation of this
/// function will iterate over all sections in a module and add up their
/// debug info only section byte sizes.
- virtual uint64_t Get
@@ -1419,6 +1419,10 @@ let Command = "statistics dump" in {
def statistics_dump_all: Option<"all-targets", "a">, Group<1>,
Desc<"Include statistics for all targets.">;
def statistics_dump_summary: Option<"summary", "s">, Group<1>,
-Desc<"Dump only high-level summary
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/81067
>From 3c2f6039cf0e253d78b5193098b311028daaea72 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 7 Feb 2024 16:43:50 -0800
Subject: [PATCH 1/5] Add more ways to find the .dwp file.
When using split DWARF w
clayborg wrote:
> > I am fine with telling people what to do and giving them a golden path to
> > what is easiest for our debuggers. And I will suggest to everyone that they
> > use `.debug` and `.dwp`, but if we want to only support this, this leaves
> > the downloading of the `.debug` file r
clayborg wrote:
I am fine with this patch if we fix the Scalar class to obey the bit width as
suggested above. I do worry though that other Scalar values in the expression
might get set to 64 bit values all of the time and cause problems with DWARF
expressions. Do you have a code snippet of wh
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/81319
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -119,6 +120,32 @@ class Progress {
bool m_complete = false;
};
+/// A class used to group progress reports by category. This is done by using a
+/// map that maintains a refcount of each category of progress reports that
have
+/// come in. Keeping track of progress repor
@@ -66,3 +67,37 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+ProgressManager &ProgressManager::InstanceImpl() {
+ static std::once_flag g_once_flag;
+ static ProgressManager *g_progress_manager = nullptr;
+ std::call_once(g_once_
@@ -66,3 +67,41 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+ProgressManager &ProgressManager::InstanceImpl() {
+ static std::once_flag g_once_flag;
+ static ProgressManager *g_progress_manager = nullptr;
+ std::call_once(g_once_
https://github.com/clayborg commented:
Just remove `static ProgressManager &InstanceImpl();` and inline the code into
`static ProgressManager &Instance();` and this is good to go.
https://github.com/llvm/llvm-project/pull/81319
___
lldb-commits mailin
@@ -186,7 +186,19 @@ class SymbolFileDWARF : public SymbolFileCommon {
GetMangledNamesForFunction(const std::string &scope_qualified_name,
std::vector &mangled_names) override;
- uint64_t GetDebugInfoSize() override;
+ /// Get total currently l
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
You can remove the headerdoc in the SymbolFileDWARF.h file and this is good to
go.
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/81706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
Needs a test and this will be good to go.
https://github.com/llvm/llvm-project/pull/82051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
Is there a website or something that details how to correctly save symbols for
split DWARF? Is there an existing tool people use? If the answer is no, I would
like to support all variations for now. I am happy to emit a warning with a URL
for best practices when it comes to emi
https://github.com/clayborg approved this pull request.
Looks good. Always good to have a test.
https://github.com/llvm/llvm-project/pull/82051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest
&request) {
}
}
+void
+CommandObject::HandleArgumentCompletion(CompletionRequest &request,
+ OptionElementVector &opt_element_vector) {
+ size_t num_arg_entries = GetNumAr
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/82085
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest
&request) {
}
}
+void
+CommandObject::HandleArgumentCompletion(CompletionRequest &request,
+ OptionElementVector &opt_element_vector) {
+ size_t num_arg_entries = GetNumAr
https://github.com/clayborg commented:
Good fix. Just a few comments
https://github.com/llvm/llvm-project/pull/82085
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -305,6 +305,42 @@ void CommandObject::HandleCompletion(CompletionRequest
&request) {
}
}
+void
+CommandObject::HandleArgumentCompletion(CompletionRequest &request,
+ OptionElementVector &opt_element_vector) {
+ size_t num_arg_entries = GetNumAr
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/82098
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/81067
>From 3c2f6039cf0e253d78b5193098b311028daaea72 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 7 Feb 2024 16:43:50 -0800
Subject: [PATCH 1/6] Add more ways to find the .dwp file.
When using split DWARF w
Author: Greg Clayton
Date: 2022-04-05T15:14:36-07:00
New Revision: b6087ba769c612c031b84e6673c438fe44a46c6a
URL:
https://github.com/llvm/llvm-project/commit/b6087ba769c612c031b84e6673c438fe44a46c6a
DIFF:
https://github.com/llvm/llvm-project/commit/b6087ba769c612c031b84e6673c438fe44a46c6a.diff
Author: Greg Clayton
Date: 2022-04-29T11:31:47-07:00
New Revision: 268089b6ac4bca2c87b272a61d7dcc6ad3e752e4
URL:
https://github.com/llvm/llvm-project/commit/268089b6ac4bca2c87b272a61d7dcc6ad3e752e4
DIFF:
https://github.com/llvm/llvm-project/commit/268089b6ac4bca2c87b272a61d7dcc6ad3e752e4.diff
Author: Greg Clayton
Date: 2022-05-09T16:07:40-07:00
New Revision: 879a47a55ffb94976cbac1d191ef53be135d86a7
URL:
https://github.com/llvm/llvm-project/commit/879a47a55ffb94976cbac1d191ef53be135d86a7
DIFF:
https://github.com/llvm/llvm-project/commit/879a47a55ffb94976cbac1d191ef53be135d86a7.diff
Author: Greg Clayton
Date: 2022-05-11T16:17:57-07:00
New Revision: 91d5bfdb7996b353097c886128fc984e310f7122
URL:
https://github.com/llvm/llvm-project/commit/91d5bfdb7996b353097c886128fc984e310f7122
DIFF:
https://github.com/llvm/llvm-project/commit/91d5bfdb7996b353097c886128fc984e310f7122.diff
Author: Greg Clayton
Date: 2021-10-21T12:14:21-07:00
New Revision: d7b338537cf360568474d31c2be86110ac22dc32
URL:
https://github.com/llvm/llvm-project/commit/d7b338537cf360568474d31c2be86110ac22dc32
DIFF:
https://github.com/llvm/llvm-project/commit/d7b338537cf360568474d31c2be86110ac22dc32.diff
Author: Greg Clayton
Date: 2021-10-21T14:21:36-07:00
New Revision: 910838f07da7872d2b7cca5b07d64ea9915b6767
URL:
https://github.com/llvm/llvm-project/commit/910838f07da7872d2b7cca5b07d64ea9915b6767
DIFF:
https://github.com/llvm/llvm-project/commit/910838f07da7872d2b7cca5b07d64ea9915b6767.diff
Author: Greg Clayton
Date: 2021-10-25T11:50:02-07:00
New Revision: c571988e9d576f78c00e45fc730f68953c45ea3a
URL:
https://github.com/llvm/llvm-project/commit/c571988e9d576f78c00e45fc730f68953c45ea3a
DIFF:
https://github.com/llvm/llvm-project/commit/c571988e9d576f78c00e45fc730f68953c45ea3a.diff
Author: Greg Clayton
Date: 2021-10-26T15:09:31-07:00
New Revision: 2887d9fd864c9302608ecd7ff58b28ad181ede9d
URL:
https://github.com/llvm/llvm-project/commit/2887d9fd864c9302608ecd7ff58b28ad181ede9d
DIFF:
https://github.com/llvm/llvm-project/commit/2887d9fd864c9302608ecd7ff58b28ad181ede9d.diff
Author: Greg Clayton
Date: 2021-10-27T16:50:11-07:00
New Revision: fb2549683260b137f1bd62a5145ddff6d2403e64
URL:
https://github.com/llvm/llvm-project/commit/fb2549683260b137f1bd62a5145ddff6d2403e64
DIFF:
https://github.com/llvm/llvm-project/commit/fb2549683260b137f1bd62a5145ddff6d2403e64.diff
Author: Greg Clayton
Date: 2021-10-27T22:31:14-07:00
New Revision: 130055647922ffa9dd9abd5a838727773f73c48a
URL:
https://github.com/llvm/llvm-project/commit/130055647922ffa9dd9abd5a838727773f73c48a
DIFF:
https://github.com/llvm/llvm-project/commit/130055647922ffa9dd9abd5a838727773f73c48a.diff
Author: Greg Clayton
Date: 2021-11-15T18:59:09-08:00
New Revision: dbd36e1e9f16059f1be1d15f8549a6e538906679
URL:
https://github.com/llvm/llvm-project/commit/dbd36e1e9f16059f1be1d15f8549a6e538906679
DIFF:
https://github.com/llvm/llvm-project/commit/dbd36e1e9f16059f1be1d15f8549a6e538906679.diff
Author: Greg Clayton
Date: 2021-11-17T15:14:01-08:00
New Revision: 951b107eedab1829f18049443f03339dbb0db165
URL:
https://github.com/llvm/llvm-project/commit/951b107eedab1829f18049443f03339dbb0db165
DIFF:
https://github.com/llvm/llvm-project/commit/951b107eedab1829f18049443f03339dbb0db165.diff
Author: Greg Clayton
Date: 2021-11-17T18:07:28-08:00
New Revision: a68ccda203aad2cc4fd386d5e893237f09fa1ffb
URL:
https://github.com/llvm/llvm-project/commit/a68ccda203aad2cc4fd386d5e893237f09fa1ffb
DIFF:
https://github.com/llvm/llvm-project/commit/a68ccda203aad2cc4fd386d5e893237f09fa1ffb.diff
Author: Greg Clayton
Date: 2021-11-30T13:54:32-08:00
New Revision: 7e6df41f655e51c984b92bbd9c19a6fb851f35d4
URL:
https://github.com/llvm/llvm-project/commit/7e6df41f655e51c984b92bbd9c19a6fb851f35d4
DIFF:
https://github.com/llvm/llvm-project/commit/7e6df41f655e51c984b92bbd9c19a6fb851f35d4.diff
Author: Greg Clayton
Date: 2021-12-02T15:47:15-08:00
New Revision: 266a66c915cbbc36b1a3887963eb97f32306c7e4
URL:
https://github.com/llvm/llvm-project/commit/266a66c915cbbc36b1a3887963eb97f32306c7e4
DIFF:
https://github.com/llvm/llvm-project/commit/266a66c915cbbc36b1a3887963eb97f32306c7e4.diff
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/67841
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
Most plug-ins inside of lldb either have their own namespace or none. If there
is a larger patch that will go into open source that exposes the lldb_private
namespace, then this would be applicable. In that case we would need a
liblldb_private.so which co
clayborg wrote:
So no plug-ins currently exist in the lldb_private namespace. I would rather
not have all plug-in code end up in the lldb_private namespace either if people
want access to these unsafe APIs outside of lldb. Maybe we should be creating a
lldb_plugins namespace, and each plugin w
clayborg wrote:
I didn't realize there was already a cmake option for exporting the
lldb_private namespace when I made my first comments. For this option to truly
be useful, I would prefer to have a liblldb_private.so/LLDBPrivate.framework
that we would create and then have the liblldb.so/LLDB
clayborg wrote:
But the above comments are my personal opinion. I would love to hear from other
developers on what they would like to see.
https://github.com/llvm/llvm-project/pull/67851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
clayborg wrote:
> I think I am on the same page with Greg for not exposing these symbols for
> not shoving everything into `lldb_private`. Perhaps instead of `lldb_plugin`
> we can name it something like `lldb_private::plugin` instead? Not a huge
> difference, but keeping the top-level private
https://github.com/clayborg commented:
I think all review comments have been taken into account. Anything else needed?
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/clayborg approved this pull request.
Looks good!
https://github.com/llvm/llvm-project/pull/68231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -8,18 +8,21 @@
#include "CommandOptionsProcessLaunch.h"
+#include "lldb/Core/Module.h"
#include "lldb/Host/FileSystem.h"
#include "lldb/Host/HostInfo.h"
#include "lldb/Host/OptionParser.h"
#include "lldb/Interprete
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/clayborg commented:
Just remove the includes that are no longer needed and this is good to go!
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
https://github.com/clayborg commented:
I have no issues with putting this into a namespace either. Just a question in
my inline comment
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,7 +18,9 @@
#include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h"
#include
+namespace lldb_plugin::dwarf {
clayborg wrote:
Do we do this anywhere else? Should this be split into:
```
namespace lldb_plugin {
namespace dwarf {
```
Not sure if there i
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/clayborg approved this pull request.
I will trust this info is correct!
https://github.com/llvm/llvm-project/pull/68234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/clayborg commented:
Should we have a top level "lldb_plugin" namespace instead of
"lldb_private::plugin"? It would be easier to be able to export only a single
plug-in interface if needed if we did this
https://github.com/llvm/llvm-project/pull/68150
clayborg wrote:
very nice! Thanks for doing all of our suggested improvements, great patch. I
would love to see a new API in SBTarget that exposes this feature:
```
lldb::SBBreakpoint lldb::SBTarget::CreateBreakpointAtUserEntry();
```
https://github.com/llvm/llvm-project/pull/67019
https://github.com/clayborg commented:
LGTM, anyone else have any objections?
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> I am not a big fan of having a specialized name `separate-debug-info` to dump
> external debug info. Ideally, I would like a single/centralized command for
> end users to see/check symbols/debug info status for a target including all
> possible situations.
>
> How about we r
@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated
with the program
}
```
+### Connect to a Remote Debug Server
+
+This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is
+debugging the program `/tmp/a.out` and listening locally o
@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated
with the program
}
```
+### Connect to a Remote Debug Server
+
+This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is
+debugging the program `/tmp/a.out` and listening locally o
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> (aside: isn't the SBAPI meant to be the thing to use if you want to script
> stuff, rather than having formatted output/scraping that? - but sounds like
> the output has converged on a table rather than JSON anyway? So maybe a moot
> point)
The reason we use StructuredData i
@@ -19,6 +19,21 @@ def getFormatted(self, format, expr):
self.assertTrue(result.Succeeded(), result.GetError())
return result.GetOutput()
+@no_debug_info_test
+@skipIfWindows
+def testAllPlatforms(self):
+self.build()
+lldbutil.run_t
@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif
- virtual void DumpValue(lldb::opaque_compiler_type_t type,
- ExecutionContext *exe_ctx, Stream &s,
- l
@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif
- virtual void DumpValue(lldb::opaque_compiler_type_t type,
- ExecutionContext *exe_ctx, Stream &s,
- l
https://github.com/clayborg commented:
Looks fine to me, but anyone at Apple might need to comment to make sure it
doesn't take away something needed for Swift.
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits
https://github.com/clayborg commented:
We should add a test. Should be easy to access the "_M_index" child and set its
value to something invalid and then make sure the summary is "".
https://github.com/llvm/llvm-project/pull/69253
___
lldb-commits ma
2601 - 2700 of 3324 matches
Mail list logo
