Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg added a comment. In http://reviews.llvm.org/D12079#242998, @jaydeep wrote: > In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > > > So DumpAddress() in FormatEntity.cpp is a generic "dump any address by > > describing it". You can't just change the code to suit your needs for

Re: [Lldb-commits] [PATCH] D12755: Improve the arm/aarch64 mapping symbol handling

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12755 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. see inlined comments. Comment at: source/Symbol/LineTable.cpp:107-117 @@ -106,3 +106,13 @@ if (!entries.empty() && entries.back().file_addr == file_addr) +

[Lldb-commits] [lldb] r247329 - A little more cleanup in the build script that creates a list of archive directories to make things more clear.

Author: gclayton Date: Thu Sep 10 14:46:25 2015 New Revision: 247329 URL: http://llvm.org/viewvc/llvm-project?rev=247329&view=rev Log: A little more cleanup in the build script that creates a list of archive directories to make things more clear. Modified: lldb/trunk/scripts/build-llvm.pl

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So a few themes I would like to get fixed: - Don't parse everything in DWARF in case we ever need it (like parsing all namespaces and their contained variables, parse and cache a

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. In http://reviews.llvm.org/D12658#243863, @paulherman wrote: > I agree with most of your comments and will fix them. > > One thing I noticed is that Block::GetDeclContext() does not do the right > thing (see inline comment). Yep, we only ever needed the function decl

Re: [Lldb-commits] [PATCH] D12831: Add JUnit/XUnit-formatted output to the lldb test run system

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12794: [MIPS] Add support for DT_MIPS_RLD_MAP_REL

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D12804: Fix several issues around dwo symbol file handling

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just can't check for zero in SymbolFileDWARF, other than that it looks good. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2242-2248 @@ -22

Re: [Lldb-commits] [PATCH] D12804: Fix several issues around dwo symbol file handling

clayborg added a comment. I meant can't check for zero function start address in DWARFASTParserClang.cpp. http://reviews.llvm.org/D12804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

Re: [Lldb-commits] [PATCH] D12804: Fix several issues around dwo symbol file handling

clayborg added a comment. I should clarify: mach-o files do have functions at zero and these are legal DWARF and we need to read this DWARF correctly. We might be able to ask the SymbolFile's ObjectFile about this address and if it can be a valid function address using: AddressClass ObjectFi

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So let me try to understand. When we are asked during expressions to lookup some mangled named for "std::string::length()", it doesn't exist in GCC binaries. So we want to then f

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So everywhere that we want to display a code address for MicroMIPS needs to now add code that creates a callable address? I still say that Address::Dump() is what should be modif

Re: [Lldb-commits] [PATCH] D12849: Add support for DW_OP_GNU_const_index to dwarf expression

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12849 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. In http://reviews.llvm.org/D12658#243953, @paulherman wrote: > I believe that the approach of CompilerDeclContext::FindDecls could be > better. But then this kind of forces CompilerDeclContext to inherit > CompilerDecl (a function is both a DeclContext and a Decl) and

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. In http://reviews.llvm.org/D12658#244710, @paulherman wrote: > [WIP] Search variables based on clang::DeclContext and clang::Decl tree > > This revision fixes some of the comments. There are some things I'm not sure > about. The problem is that at some point there will

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I believe you have addressed all of my concerns. Read through my previous comments and make sure, and if so, this is good to go. Nice patch, thanks for working through the abtracting issue

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Yes, it would be nice to not have to get a variable's decl right up front. Maybe the Variable::GetDecl() could register this mapping if/when the variable decl is made the first t

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. In http://reviews.llvm.org/D12658#245547, @paulherman wrote: > Are you suggesting that the DeclLinkToObject is moved inside the GetDecl call > and I only remove that? Yes, actually you can probably move it into SymbolFileDWARF::GetDeclForUID(). there should be a cach

[Lldb-commits] [lldb] r247630 - Remove include that isn't needed.

Author: gclayton Date: Mon Sep 14 17:56:46 2015 New Revision: 247630 URL: http://llvm.org/viewvc/llvm-project?rev=247630&view=rev Log: Remove include that isn't needed. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/DW

[Lldb-commits] [lldb] r247631 - Fix the Xcode project to compile Cocoa.cpp instead of Coca.cpp.

Author: gclayton Date: Mon Sep 14 17:57:25 2015 New Revision: 247631 URL: http://llvm.org/viewvc/llvm-project?rev=247631&view=rev Log: Fix the Xcode project to compile Cocoa.cpp instead of Coca.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/proj

[Lldb-commits] [lldb] r247638 - Darwin has a debug info format that stores module types in stand alone files and it uses some of the DWO attributes. Don't assert in SymbolFileDWARFDwo, just return nul

Author: gclayton Date: Mon Sep 14 18:34:26 2015 New Revision: 247638 URL: http://llvm.org/viewvc/llvm-project?rev=247638&view=rev Log: Darwin has a debug info format that stores module types in stand alone files and it uses some of the DWO attributes. Don't assert in SymbolFileDWARFDwo, just ret

[Lldb-commits] [lldb] r247641 - Avoid a crash in the test suite where if we have a ObjC "id" type and we ask it for the PointeeType() we would get a CompilerType with a valid TypeSystem, but invalid o

Author: gclayton Date: Mon Sep 14 18:55:01 2015 New Revision: 247641 URL: http://llvm.org/viewvc/llvm-project?rev=247641&view=rev Log: Avoid a crash in the test suite where if we have a ObjC "id" type and we ask it for the PointeeType() we would get a CompilerType with a valid TypeSystem, but in

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. So I don't like it in ParseVariableDIE() because it means we must create the decl right away for the variable when parsing it. ParseVariableDIE is used to parse all variables everywhere and we don't need the CompilerDecl in order to display the Variable, so we don't ne

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. We only really need variable to inherit from std::shared_from_this if we have any classes or API that use a "Variable *" as ivars or parameters. If we do, feel free to make it inherit from shared_from_this, but I would like to avoid it if possible to save on space. Als

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. One last change to make line table parsing more efficient by not having to check the arch for every line table entry. Comment at: source/Plugins/SymbolFile/DWAR

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

clayborg added a comment. Maybe we can try still removing duplicates, but remembering the first index where we had a duplicate line entry. If we don't get a prologue end, then we got back to the index we remembered for the first duplicate and if it is valid, modify that entry to say "prologue_e

Re: [Lldb-commits] [PATCH] D12880: Add support for the DWARFLocationList used by split-dwarf

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Looks good, we just need to relocate the DWARF expression printing stuff over into DWARFExpression as static functions. Comment at: source/Plugins/SymbolFile/DW

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

clayborg accepted this revision. clayborg added a comment. I would rather not see a warning. If you don't have sources I don't really want to see: warning: couldn't find foo.c 0x1000: add r1, r2, r3 Repository: rL LLVM http://reviews.llvm.org/D12877 _

Re: [Lldb-commits] [PATCH] D5871: Add an OperatingSystem plugin to support goroutines

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We have the notion of hard coded section types. See lldb::SectionType in lldb-enumerations.h. You could always add your Go section to this section list and then find the section

Re: [Lldb-commits] [PATCH] D5871: Add an OperatingSystem plugin to support goroutines

clayborg added a comment. Moving to SectionType is even more efficient than searching for symbols by name, so please switch to that. Repository: rL LLVM http://reviews.llvm.org/D5871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as my inlined comment doesn't point out an error, then this is good to go! Good stuff. Comment at: source/Symbol/Variable.cpp:250-258 @@ -233,1 +249,11

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

clayborg added a comment. Maybe we can enable mixed mode display where it intersperses the source file and line in the disassembly when/if there is source info, but no source file? Repository: rL LLVM http://reviews.llvm.org/D12877 ___ lldb-comm

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

clayborg requested changes to this revision. clayborg added a comment. Ok, so Jim and I agreed verbally on the solution. If we have source, but we don't have the source file itself, then we should print the line table entry out. This can be done with: if (num_lines == 0) { const bool

Re: [Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

clayborg added a comment. Blech... Ok, one more try: does GCC always emit the same line and file with the same address? If so we could do: { // GCC don't use the is_prologue_end flag to mark the first instruction after the prologue. // Instead of it it is issueing a line table ent

Re: [Lldb-commits] [PATCH] D12890: Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader breakpoint optional.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Comment at: source/Core/PluginManager.cpp:2628 @@ -2627,3 +2627,3 @@ static lldb::OptionValuePropertiesSP GetDebuggerPropertyForPluginsOldStyle (Debugger &de

[Lldb-commits] [lldb] r247754 - Fix the MacOSX build.

Author: gclayton Date: Tue Sep 15 18:59:41 2015 New Revision: 247754 URL: http://llvm.org/viewvc/llvm-project?rev=247754&view=rev Log: Fix the MacOSX build. Modified: lldb/trunk/include/lldb/Symbol/CompilerDeclContext.h Modified: lldb/trunk/include/lldb/Symbol/CompilerDeclContext.h URL: ht

[Lldb-commits] [lldb] r247753 - Avoid a missing override warning.

Author: gclayton Date: Tue Sep 15 18:59:25 2015 New Revision: 247753 URL: http://llvm.org/viewvc/llvm-project?rev=247753&view=rev Log: Avoid a missing override warning. Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h URL:

[Lldb-commits] [lldb] r247756 - Fix Xcode project by adding CompilerDecl.cpp and .h.

Author: gclayton Date: Tue Sep 15 19:03:14 2015 New Revision: 247756 URL: http://llvm.org/viewvc/llvm-project?rev=247756&view=rev Log: Fix Xcode project by adding CompilerDecl.cpp and .h. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a subscriber: clayborg. clayborg added a comment. I am seeing line 89 fail on MacOSX from your new TestCppNsImport.py: test_result = frame.EvaluateExpression("imported") self.assertTrue(test_result.IsValid() and test_result.GetValueAsSigned() == 99, "imported = 99") Ours is p

[Lldb-commits] [lldb] r247764 - Fix MacOSX since "imported" and "Imported::imported" are ambiguous. Test that we can read the global when specified with the global namespace and test that we can read

Author: gclayton Date: Tue Sep 15 19:42:50 2015 New Revision: 247764 URL: http://llvm.org/viewvc/llvm-project?rev=247764&view=rev Log: Fix MacOSX since "imported" and "Imported::imported" are ambiguous. Test that we can read the global when specified with the global namespace and test that we ca

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

clayborg added a comment. Ah, the test_with_dsym_and_run_command() wasn't marked as fail... I fixed the test with: % svn commit Sendingtest/lang/cpp/nsimport/TestCppNsImport.py Transmitting file data . Committed revision 247764. Feel free to correct it. I would also say that we might wa

Re: [Lldb-commits] [PATCH] D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces

clayborg added a comment. If you can explain the need for ParseDeclsForContext() as mentioned in the inlined comment that would help me understand this change better. Also, Sean suggested that we might be able to fix all of this in another way that might make it easier on everyone: don't do any

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few more little things with respect to not calling accessors multiple times in if statements and this will be good to go. Comment at: source/Core/Address.cpp:

Re: [Lldb-commits] [PATCH] D12897: Add using directives to the clang::DeclContext and fix decls for variables inside namespaces

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for the explanation and it makes sense. Looks good. http://reviews.llvm.org/D12897 ___ lldb-commits mailing list lldb-commits@lists.ll

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

clayborg added a comment. If "qfThreadInfo" responds with OK, it seems to imply "this is a supported packet, but I have no threads to report". So it seems like we should assume that there are no threads in this case. If we got $#00 back, then it would mean that qfThreadInfo ins't supported. So

[Lldb-commits] [lldb] r247823 - Add newline at end of file to avoid compiler warning.

Author: gclayton Date: Wed Sep 16 13:05:08 2015 New Revision: 247823 URL: http://llvm.org/viewvc/llvm-project?rev=247823&view=rev Log: Add newline at end of file to avoid compiler warning. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp Modified: lldb/trunk/sourc

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

clayborg added a comment. Sean is the best person to answer your questions. I will ping him and have him comment. http://reviews.llvm.org/D12809 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D5871: Add an OperatingSystem plugin to support goroutines

clayborg accepted this revision. clayborg added a comment. Looks good then. I know there are things that are wrong with the current OS plug-ins, so lets just work on improving them to be as useful as possible as I am sure there will be things that need fixing. Eventual goals could be to allow s

Re: [Lldb-commits] [PATCH] D12936: Groundwork for better tracking of renderscript allocations and scripts.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. A few suggestions to move things over into RenderScriptRuntime.cpp and to possibly use std::unique_ptr, but they are just suggestions. Comment at: source/Plugins/Languag

[Lldb-commits] [lldb] r247953 - TypeSystem is now a plugin interface and removed any "ClangASTContext &Class::GetClangASTContext()" functions.

Author: gclayton Date: Thu Sep 17 17:23:34 2015 New Revision: 247953 URL: http://llvm.org/viewvc/llvm-project?rev=247953&view=rev Log: TypeSystem is now a plugin interface and removed any "ClangASTContext &Class::GetClangASTContext()" functions. This cleans up type systems to be more pluggable.

Re: [Lldb-commits] [PATCH] D12954: Reduce inclusion of clang headers.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Very nice. http://reviews.llvm.org/D12954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [Lldb-commits] [PATCH] D12954: Reduce inclusion of clang headers.

clayborg added a comment. It would be great if there were an automated tool that could detect when any #include wasn't needed for both headers and implementation files. http://reviews.llvm.org/D12954 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D12971: Remove unused modules from module cache

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Flow looks good, take care of Zachs issues and this is good to go. http://reviews.llvm.org/D12971 ___ lldb-commits mailing list lldb-commits@

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

clayborg added a comment. To work around it you might be able to call SBProcess::Halt() first? Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

clayborg added a comment. You should be able to just call Destroy(), we shouldn't crash. We will need to fix the core it allow this since people can/will call this. Repository: rL LLVM http://reviews.llvm.org/D12968 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12983: Adds parallel worker queue index to test events

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! http://reviews.llvm.org/D12983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

clayborg requested changes to this revision. This revision now requires changes to proceed. Comment at: include/lldb/Host/FileSpec.h:516 @@ -514,1 +515,3 @@ +FileSpec +GetSymbolicLinkTarget () const; rename to ResolveSymbolicLink? Comme

Re: [Lldb-commits] [PATCH] D12984: Resolve symlinks when looking for the LLDB shlib

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12987: test events: announce worker count in new initialize event

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D12987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] r248072 - Added a curses based way to see the test suite running. Works only where curses is implemented. Try it out with:

Author: gclayton Date: Fri Sep 18 19:39:09 2015 New Revision: 248072 URL: http://llvm.org/viewvc/llvm-project?rev=248072&view=rev Log: Added a curses based way to see the test suite running. Works only where curses is implemented. Try it out with: ./dotest.py --results-formatter=test_results.Cur

Re: [Lldb-commits] [PATCH] D13018: Further reduction of Clang-related header inclusion.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13020: Rename GetChildClangTypeAtIndex to GetChildCompilerTypeAtIndex

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13022: Use fcntl.h to retrieve the O_CREAT and O_RDRW constants.

clayborg accepted this revision. clayborg added a comment. Looks good. http://reviews.llvm.org/D13022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248179 - Fixed up the curses test results formatter to:

Author: gclayton Date: Mon Sep 21 12:25:01 2015 New Revision: 248179 URL: http://llvm.org/viewvc/llvm-project?rev=248179&view=rev Log: Fixed up the curses test results formatter to: - rename "Failures" window to "Completed Tests" - Remove the extra lock that I incorrectly added to the ResultsForma

Re: [Lldb-commits] [PATCH] D13028: [RFC] Merge dsym and dwarf test cases

clayborg added a comment. I like the idea. One question I have is if tests should opt in to multi-debug, or if tests should opt out. This solution does the opt out method. Would it be better to opt in? With something like: @debug_info_test def test_stuff(self): # ... I am fine with e

Re: [Lldb-commits] [PATCH] D13028: [RFC] Merge dsym and dwarf test cases

clayborg added a comment. Also if the compiler doesn't support the different modes do we avoid mutating the classes? Or if we disable the extra DWARF in .o file mode (be it DWO or Apple) do we avoid mutating the classes? http://reviews.llvm.org/D13028 ___

[Lldb-commits] [lldb] r248232 - Split the curses stuff out into a separate file so that we can import curses and lldbcurses at the module level.

Author: gclayton Date: Mon Sep 21 19:35:20 2015 New Revision: 248232 URL: http://llvm.org/viewvc/llvm-project?rev=248232&view=rev Log: Split the curses stuff out into a separate file so that we can import curses and lldbcurses at the module level. Added key press handling and a first responder s

[Lldb-commits] [lldb] r248285 - Add missing file that contains the curses test suite code. To run with curses you now execute:

Author: gclayton Date: Tue Sep 22 11:29:15 2015 New Revision: 248285 URL: http://llvm.org/viewvc/llvm-project?rev=248285&view=rev Log: Add missing file that contains the curses test suite code. To run with curses you now execute: % ./dotest.py --results-formatter=curses_results.Curses --result

Re: [Lldb-commits] [PATCH] D13039: Rename clang_type_t to opaque_t.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. We should switch all of TypeSystem's methods over to use this instead of "void *" as well in a future commit. http://reviews.llvm.org/D13039 ___

[Lldb-commits] [lldb] r248290 - Allow TAB key to switch first responder when tests are running or completed.

Author: gclayton Date: Tue Sep 22 12:18:15 2015 New Revision: 248290 URL: http://llvm.org/viewvc/llvm-project?rev=248290&view=rev Log: Allow TAB key to switch first responder when tests are running or completed. Typing the shortcut key ('.' for 'pass', 'e' for 'error', etc) will toggle the visib

Re: [Lldb-commits] [PATCH] D13060: Use opaque_compiler_type_t in place of void*.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. For the failing test cases, just check this stuff in and we should take care or marking any needed tests and expected fail. Is there a way to mark a test such that the "dwarf i

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You can't use std::string in the public API. Use lldb::SBStream as noted in inlined comments. Comment at: include/lldb/API/SBValue.h:132-133 @@ -131,1 +131,4 @@

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

clayborg added a comment. As Enrico stated. there is already a SBStream based way to get the summary in "const char * SBValueGetSummary (lldb::SBStream& stream, lldb::SBTypeSummaryOptions& options);" so no need to add anything as I had suggested. http://reviews.llvm.org/D13058

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We have the same problem with base classes where if we have a class that has a DW_TAG_inheritance tag that points to a forward declaration for a class, then we start and end the

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

clayborg added a comment. Emitting a warning is a good idea as well if the compiler is clang and how to fix it (something like "please specify -fno-limit-debug-info ...") http://reviews.llvm.org/D13066 ___ lldb-commits mailing list lldb-commits@lis

Re: [Lldb-commits] [PATCH] D13066: Make DWARFASTParserClang::ParseChildMembers return a bool.

clayborg added a comment. We also need to make sure that if the class is specified anywhere else within the current binary (in another .o file), that we find that class definition and use it in place of the forward declaration. So if you can make another test with the same source file, and anot

Re: [Lldb-commits] [lldb] r247953 - TypeSystem is now a plugin interface and removed any "ClangASTContext &Class::GetClangASTContext()" functions.

self.do_sbvalue_cast(self.exe_name) > File > "D:\src\llvm\tools\lldb\test\lang\cpp\dynamic-value\TestCppValueCast.py", > line 99, in do_sbvalue_cast > > self.assertTrue(tellerA.GetChildMemberWithName('m_base_val').GetValueAsUnsigned(error, > 0) == 20) > Assert

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as the test suite if happy. http://reviews.llvm.org/D13066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

Re: [Lldb-commits] [PATCH] D13094: LLDB-MI: Fix assignment operator in CMIUtilString

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13096: Handle OMPArraySection in ClangASTContext::GetEncoding

clayborg added a comment. You need to add more diffs to take care of the extra enums or does this patch include those already? http://reviews.llvm.org/D13096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D13102: Rename clang_type -> compiler_type for variables.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. If you are going to hijack you do need to do it before you call Halt(). Repository: rL LLVM http://reviews.llvm.org/D12968 ___ l

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. We need to get Sean Callanan as a reviewer on this. Jim is out for a few weeks, so Sean will need to OK this. Repository: rL LLVM http://reviews.llvm.org/D13073 _

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

clayborg added a subscriber: clayborg. clayborg added a comment. Even though clang isn't done this way for historical reason, I would like to see the Go expression parser files (.cpp and .h) over into "source/Plugins/ExpressionParser/Go". The following files should be moved: include/lldb/Expr

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

clayborg added a comment. I see you moved the JIT code over into ClangUserExpression. I was wondering if all languages might not want to generate llvm IR and then let the JIT make code from the llvm IR? This is the reason were originally left the IR in the UserExpression. IR is very generic and

[Lldb-commits] [lldb] r248450 - Added the ability to register key callbacks for much easier key handling. Also added the elapsed time display to the status bar.

Author: gclayton Date: Wed Sep 23 19:19:42 2015 New Revision: 248450 URL: http://llvm.org/viewvc/llvm-project?rev=248450&view=rev Log: Added the ability to register key callbacks for much easier key handling. Also added the elapsed time display to the status bar. Modified: lldb/trunk/test/c

[Lldb-commits] [lldb] r248513 - Don't enter interactive loop when finished running the test suite.

Author: gclayton Date: Thu Sep 24 11:37:41 2015 New Revision: 248513 URL: http://llvm.org/viewvc/llvm-project?rev=248513&view=rev Log: Don't enter interactive loop when finished running the test suite. Modified: lldb/trunk/test/curses_results.py Modified: lldb/trunk/test/curses_results.py U

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

clayborg added a comment. Each shared library is an object that can be shared between multiple targets. We do not want to injecting types from another shared library into the static notion of what a type is within a shared library. Why? What if one target in lldb loads liba.so which has a forwa

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/94785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/94785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

@@ -287,7 +287,7 @@ Status PlatformAndroid::DownloadModuleSlice(const FileSpec &src_file_spec, static constexpr llvm::StringLiteral k_zip_separator("!/"); size_t pos = source_file.find(k_zip_separator); if (pos != std::string::npos) -source_file = source_file.substr(

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

@@ -90,17 +90,9 @@ void InstrumentationRuntimeASanLibsanitizers::Activate() { if (!process_sp) return; - lldb::ModuleSP module_sp = GetRuntimeModuleSP(); - Breakpoint *breakpoint = ReportRetriever::SetupBreakpoint( - module_sp, process_sp, ConstString("sanitizer

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/94794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/94794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add format eFormatEnumWithValues to ensure raw enum value is always shown (PR #90059)

clayborg wrote: Sorry for the delay, I am still wondering if we just want to have the value objects for enums return the text name as the value, and have the summary show the value as an appropriate integer if the format is eFormatEnum. When you display registers bitfields do you have a ValueO

[Lldb-commits] [lldb] Fix the test to deal with non-deterministic output. (PR #96800)

https://github.com/clayborg created https://github.com/llvm/llvm-project/pull/96800 When we check for the "struct CustomType" in the NODWP, we can just make sure that we have both types showing up, the next tests will validate the types are correct. Also added a "-DAG" to the integer and float

<    6   7   8   9   10   11   12   13   14   15   >