https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/135866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Closing in favor of the stack of patches here:
[[lldb][nfc] Factor out code from ThreadPlanStepOut ctor
#136159](https://github.com/llvm/llvm-project/pull/136159)
[[lldb][nfc] Split the constructor of ThreadPlanStepOut
#136160](https://github.com/llvm/llvm-project/pull/13
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/135296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/135296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/135296
This reapplies commit 232525f06942adb3b9977632e38dcd5f08c0642d.
The original commit triggered a sanitizer failure when Target was destroyed. In
Target::Destroy, `DeleteCurrentProcess` was called, but i
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/135296
>From b24dc5da70443eb15819c6134ddd38c84f86a5e5 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Wed, 9 Apr 2025 07:38:13 -0700
Subject: [PATCH] Reland "[lldb] Clear thread-creation breakpoi
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/135296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/135637
>From 0383630d48f60cf25d241deda909737869b65998 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 14 Apr 2025 08:56:55 -0700
Subject: [PATCH] [lldb] Override Should{Select,Show} in StopR
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/135869
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
>then it would queue up a ThreadPlanStepOut that would go to that frame.
To elaborate on this, today there is no constructor for StepOut that allows one
to specify a target frame. This is also something we would need to create for
that to work, right?
https://github.com
felipepiovezan wrote:
It's worth mentioning that the LLVM convention (as opposed to what is done in
the swift fork) is to avoid force-pushing.
Instead, you'd always add a new fixup commit (`git commit --fixup`) and squash
them when merging (note that, for llvm, github will force you into squas
felipepiovezan wrote:
> That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe it's
> not working?
There is only one constructor for step out, and it always skips those frames.
So, yes, even in `QueueThreadPlanForStepOutNoShouldStop` we will skip over
frames.
https://github.
felipepiovezan wrote:
> The `frame_idx` parameter is the frame you step out to.
I don't think this is quite true, that parameter indicates where we step out
_from_. I know this distinction may look unimportant at first, but it is
exactly that distinction that gives the constructor space to ski
felipepiovezan wrote:
> > That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe
> > it's not working?
>
> There is only one constructor for step out, and it always skips those frames.
> So, yes, even in `QueueThreadPlanForStepOutNoShouldStop` we will skip over
> frames.
In
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/135866
ThreadPlanStepOut always skips over Hidden/Artificial frames when computing its
destination frame, without providing any customization of this behavior. This
is problematic for some plans like StepThroug
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/135866
>From 3804a622a92ed541e4ee1a40298442e78b687507 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 15 Apr 2025 10:20:41 -0700
Subject: [PATCH] [lldb][nfc] Add customization flags for Thre
Author: Felipe de Azevedo Piovezan
Date: 2025-04-28T14:08:14-07:00
New Revision: b73169ad3edc56fe2b4f5bd3d5259310168da50c
URL:
https://github.com/llvm/llvm-project/commit/b73169ad3edc56fe2b4f5bd3d5259310168da50c
DIFF:
https://github.com/llvm/llvm-project/commit/b73169ad3edc56fe2b4f5bd3d52593101
https://github.com/felipepiovezan approved this pull request.
Nice!
https://github.com/llvm/llvm-project/pull/137712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2025-04-29T12:38:51-07:00
New Revision: f784fa727543463b86511f7e5797174422cbeeaf
URL:
https://github.com/llvm/llvm-project/commit/f784fa727543463b86511f7e5797174422cbeeaf
DIFF:
https://github.com/llvm/llvm-project/commit/f784fa727543463b86511f7e579717442
felipepiovezan wrote:
Hi, this test is _still_ failing on the macOS bots:
https://ci.swift.org/view/all/job/llvm.org/job/lldb-cmake/11728/execution/node/111/log/
```
/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake/lldb-build/tools/lldb/unittests/Host/./HostTests
--gtest_filter=HostTest.G
felipepiovezan wrote:
Could you please disable/revert if the fix is not easy?
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2025-04-29T07:18:22-07:00
New Revision: 55b4e5e5154550ba981af08ca9bd1e3da00e6fea
URL:
https://github.com/llvm/llvm-project/commit/55b4e5e5154550ba981af08ca9bd1e3da00e6fea
DIFF:
https://github.com/llvm/llvm-project/commit/55b4e5e5154550ba981af08ca9bd1e3da
felipepiovezan wrote:
@eronnen I believe this is breaking the macOS bots, on the test
TestFoundationDisassembly.py
```
17:54:59 FAIL: test_foundation_disasm
(TestFoundationDisassembly.FoundationDisassembleTestCase)
17:54:59 Do 'disassemble -n func' on each and every 'Code' symbol entry
f
felipepiovezan wrote:
I'm going to revert this for now, as I see your commit access is still pending
(hopefully soon!)
https://github.com/llvm/llvm-project/pull/137512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
Author: Felipe de Azevedo Piovezan
Date: 2025-05-01T18:27:34-07:00
New Revision: 2cae14fdc62a07252ad1c2c2b11678c4539416a6
URL:
https://github.com/llvm/llvm-project/commit/2cae14fdc62a07252ad1c2c2b11678c4539416a6
DIFF:
https://github.com/llvm/llvm-project/commit/2cae14fdc62a07252ad1c2c2b11678c45
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/136160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2025-05-06T18:20:25-07:00
New Revision: a1238911f43c1d46cc7d4e72e2a16c3c9a157d9a
URL:
https://github.com/llvm/llvm-project/commit/a1238911f43c1d46cc7d4e72e2a16c3c9a157d9a
DIFF:
https://github.com/llvm/llvm-project/commit/a1238911f43c1d46cc7d4e72e2a16c3c9
felipepiovezan wrote:
Btw I think this is causing an asan failure:
https://green.lab.llvm.org/job/lldb-cmake-sanitized/1671/
```
2025-05-07T19:03:57.557Z] ==73219==ERROR: AddressSanitizer:
stack-buffer-overflow on address 0x0001070cf5b8 at pc 0x0001056051c0 bp
0x00016b0a3730 sp 0x00016b0a2ee0
felipepiovezan wrote:
Pushed your suggestion
> Lol, I think its this:
>
> https://github.com/llvm/llvm-project/blob/6babd63a4bbc094bee4ef8e75f95dccd32325c15/lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp#L718-L721
>
> I'm done for this week, but could someone try if changing
felipepiovezan wrote:
@eronnen this is breaking the incremental green dragon bots.
Could you revert while you look at this please?
https://ci.swift.org/view/all/job/llvm.org/job/as-lldb-cmake/25425/changes#41321416815d74a4a7fd15c78fcfa5af457625bb
```
[2025-05-08T12:15:32.021Z]
==
Author: Felipe de Azevedo Piovezan
Date: 2025-05-08T07:27:09-07:00
New Revision: bbafa5214e8d5d5daf7cf428780500b13a7d6cbb
URL:
https://github.com/llvm/llvm-project/commit/bbafa5214e8d5d5daf7cf428780500b13a7d6cbb
DIFF:
https://github.com/llvm/llvm-project/commit/bbafa5214e8d5d5daf7cf428780500b13
@@ -44,6 +44,48 @@ def step_out_with_scripted_plan(self, name):
stop_desc = thread.GetStopDescription(1000)
self.assertIn("Stepping out from", stop_desc, "Got right description")
+def run_until_branch_instruction(self):
+self.build()
+(targe
Author: Felipe de Azevedo Piovezan
Date: 2025-05-08T08:11:17-07:00
New Revision: cb0b9614f8ca7ffcd5f091b1c9990adfd6cb7e33
URL:
https://github.com/llvm/llvm-project/commit/cb0b9614f8ca7ffcd5f091b1c9990adfd6cb7e33
DIFF:
https://github.com/llvm/llvm-project/commit/cb0b9614f8ca7ffcd5f091b1c9990adfd
felipepiovezan wrote:
To fix the bots, I've disabled your new test in all non x86 archs, feel free to
update if you want to do something else
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Author: Felipe de Azevedo Piovezan
Date: 2025-05-08T13:14:40-07:00
New Revision: 28156539a9df3fa0d9db47c405c0006fcee9f77f
URL:
https://github.com/llvm/llvm-project/commit/28156539a9df3fa0d9db47c405c0006fcee9f77f
DIFF:
https://github.com/llvm/llvm-project/commit/28156539a9df3fa0d9db47c405c0006fc
felipepiovezan wrote:
@eronnen my fix does not seem to have worked
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Ah there were _two_ tests here. I've disabled the other one too.
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
felipepiovezan wrote:
28156539a9df 20250508 fpiove.. [lldb] Disable test using GetControlFlowKind on
arm (HEAD, llvm/main)
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
felipepiovezan wrote:
It may be a coincidence, but a DAP test failed in green dragon right after this
patch was applied:
https://ci.swift.org/view/all/job/llvm.org/job/as-lldb-cmake/25465/console
TestDAP_repl_mode_detection.py
DAP tasks have been flaky though, so maybe unrelated, I don't full
https://github.com/felipepiovezan approved this pull request.
Fingers crossed this will give us enough info!
https://github.com/llvm/llvm-project/pull/139166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/felipepiovezan approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/139301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
501 - 541 of 541 matches
Mail list logo
