Author: Felipe de Azevedo Piovezan
Date: 2023-06-21T13:25:10-04:00
New Revision: 1704c8d1047d75e0f17736de146281d68fe7b203
URL:
https://github.com/llvm/llvm-project/commit/1704c8d1047d75e0f17736de146281d68fe7b203
DIFF:
https://github.com/llvm/llvm-project/commit/1704c8d1047d75e0f17736de146281d68
Author: Felipe de Azevedo Piovezan
Date: 2023-06-27T18:09:40-04:00
New Revision: ab674234c440ed27302f58eeccc612c83b32c43f
URL:
https://github.com/llvm/llvm-project/commit/ab674234c440ed27302f58eeccc612c83b32c43f
DIFF:
https://github.com/llvm/llvm-project/commit/ab674234c440ed27302f58eeccc612c83
Author: Felipe de Azevedo Piovezan
Date: 2023-06-28T08:31:02-04:00
New Revision: 4d5c9ad9c3d7ed84efa1307ec158829b95badc6f
URL:
https://github.com/llvm/llvm-project/commit/4d5c9ad9c3d7ed84efa1307ec158829b95badc6f
DIFF:
https://github.com/llvm/llvm-project/commit/4d5c9ad9c3d7ed84efa1307ec158829b9
Author: Felipe de Azevedo Piovezan
Date: 2023-06-28T09:19:14-04:00
New Revision: e12c701ff0405880045f0330fb6ff94e31ec5c47
URL:
https://github.com/llvm/llvm-project/commit/e12c701ff0405880045f0330fb6ff94e31ec5c47
DIFF:
https://github.com/llvm/llvm-project/commit/e12c701ff0405880045f0330fb6ff94e3
Author: Felipe de Azevedo Piovezan
Date: 2023-06-28T10:05:36-04:00
New Revision: 8e71d14972b48df8c5b701a9aec19af3194f9a5e
URL:
https://github.com/llvm/llvm-project/commit/8e71d14972b48df8c5b701a9aec19af3194f9a5e
DIFF:
https://github.com/llvm/llvm-project/commit/8e71d14972b48df8c5b701a9aec19af31
Author: Felipe de Azevedo Piovezan
Date: 2023-07-03T08:35:55-04:00
New Revision: 379b59d1b0f3e1ddc421f706e9de65e52acad0cb
URL:
https://github.com/llvm/llvm-project/commit/379b59d1b0f3e1ddc421f706e9de65e52acad0cb
DIFF:
https://github.com/llvm/llvm-project/commit/379b59d1b0f3e1ddc421f706e9de65e52
Author: Felipe de Azevedo Piovezan
Date: 2023-07-03T08:36:57-04:00
New Revision: f292ca136240a9c694aa280ad7fd0b961930804a
URL:
https://github.com/llvm/llvm-project/commit/f292ca136240a9c694aa280ad7fd0b961930804a
DIFF:
https://github.com/llvm/llvm-project/commit/f292ca136240a9c694aa280ad7fd0b961
Author: Felipe de Azevedo Piovezan
Date: 2023-07-03T17:12:06-04:00
New Revision: f470ab734c9bae9464faf6cff6530beb32ea44ba
URL:
https://github.com/llvm/llvm-project/commit/f470ab734c9bae9464faf6cff6530beb32ea44ba
DIFF:
https://github.com/llvm/llvm-project/commit/f470ab734c9bae9464faf6cff6530beb3
Author: Felipe de Azevedo Piovezan
Date: 2023-07-06T08:20:31-04:00
New Revision: 7cea22c0be95834317c920c21839cdd4c80fbdd8
URL:
https://github.com/llvm/llvm-project/commit/7cea22c0be95834317c920c21839cdd4c80fbdd8
DIFF:
https://github.com/llvm/llvm-project/commit/7cea22c0be95834317c920c21839cdd4c
felipepiovezan wrote:
https://github.com/llvm/llvm-project/pull/68231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
felipepiovezan wrote:
this must have felt good to fix!
https://github.com/llvm/llvm-project/pull/68231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
The code is not something I am familiar with, but I did notice that the PR
title and the commit title are quite different. Not sure which one is better,
but it is generally nice to have them match (in particular it is nice to add
the `[lldb]` tag to the commit title to ma
@@ -172,8 +172,18 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
{
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
-ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, ev
@@ -172,8 +172,18 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command,
{
auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope();
ValueObjectSP valobj_sp;
-ExpressionResults expr_result =
-target.EvaluateExpression(expr, exe_scope, valobj_sp, ev
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/69531
The method DWARFDebugInfoEntry::Extract needs to skip over all the data in the
debug_info / debug_types section for each DIE. It had the logic to do so
hardcoded inside a loop, when it already exists in a
felipepiovezan wrote:
> Please manually verify all cases are handled in the
> DWARFFormValue::SkipValue() function to ensure we are not losing
> functionality. LGTM.
Yup, I've compared the two functions twice, so I'm fairly confident they are
identical :)
https://github.com/llvm/llvm-projec
@@ -73,137 +69,18 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor
&data,
m_tag = abbrevDecl->getTag();
m_has_children = abbrevDecl->hasChildren();
// Skip all data in the .debug_info or .debug_types for the attributes
- dw_form_t form;
for (const auto &
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/69531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/69531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
> The correct fix seems to also store the underlying storage along with the
> accelerator tables in AppleDWARFIndex.
This was my initial reaction as well. Is there some blocker to doing this?
https://github.com/llvm/llvm-project/pull/71828
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
felipepiovezan wrote:
@clayborg what do you think about moving ownership of the data to inside the
AppleAcceleratorTable class?
https://github.com/llvm/llvm-project/pull/71
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
LGTM! really like the `_idx` suffix of the new induction variable and its bounds
https://github.com/llvm/llvm-project/pull/71984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/felipepiovezan approved this pull request.
LGTM! I will keep an eye on the bots once we merge this to make sure we don't
see the test failure anymore
https://github.com/llvm/llvm-project/pull/71997
___
lldb-commits mailing list
lldb
https://github.com/felipepiovezan approved this pull request.
LGTM. I'm ok postponing the lifetime change to a separate task
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
Author: Felipe de Azevedo Piovezan
Date: 2022-08-25T06:39:01-04:00
New Revision: 14d5ae2038b58830f0565980e20fe0bfd683fb54
URL:
https://github.com/llvm/llvm-project/commit/14d5ae2038b58830f0565980e20fe0bfd683fb54
DIFF:
https://github.com/llvm/llvm-project/commit/14d5ae2038b58830f0565980e20fe0bfd
Author: Felipe de Azevedo Piovezan
Date: 2022-08-25T06:46:04-04:00
New Revision: baeb17cdfa4bba8985ebb9809edf7eb82c636bc4
URL:
https://github.com/llvm/llvm-project/commit/baeb17cdfa4bba8985ebb9809edf7eb82c636bc4
DIFF:
https://github.com/llvm/llvm-project/commit/baeb17cdfa4bba8985ebb9809edf7eb82
Author: Felipe de Azevedo Piovezan
Date: 2022-08-26T06:52:40-04:00
New Revision: bb26ebb4d18c1877cc6fd17aa803609abeb95096
URL:
https://github.com/llvm/llvm-project/commit/bb26ebb4d18c1877cc6fd17aa803609abeb95096
DIFF:
https://github.com/llvm/llvm-project/commit/bb26ebb4d18c1877cc6fd17aa803609ab
Author: Felipe de Azevedo Piovezan
Date: 2022-09-08T13:42:56-04:00
New Revision: c38eeecbc7d929c9601f2189214a7a90d3982a47
URL:
https://github.com/llvm/llvm-project/commit/c38eeecbc7d929c9601f2189214a7a90d3982a47
DIFF:
https://github.com/llvm/llvm-project/commit/c38eeecbc7d929c9601f2189214a7a90d
Author: Felipe de Azevedo Piovezan
Date: 2022-09-08T14:38:08-04:00
New Revision: 9a41f6e7080e7ca6274a460e9e32ba616fa46249
URL:
https://github.com/llvm/llvm-project/commit/9a41f6e7080e7ca6274a460e9e32ba616fa46249
DIFF:
https://github.com/llvm/llvm-project/commit/9a41f6e7080e7ca6274a460e9e32ba616
Author: Felipe de Azevedo Piovezan
Date: 2022-09-12T12:34:11-04:00
New Revision: fc04749957f17f42b1eab538fa3e68857034facb
URL:
https://github.com/llvm/llvm-project/commit/fc04749957f17f42b1eab538fa3e68857034facb
DIFF:
https://github.com/llvm/llvm-project/commit/fc04749957f17f42b1eab538fa3e68857
Author: Felipe de Azevedo Piovezan
Date: 2022-09-12T15:32:25-04:00
New Revision: 67c73d88de0e6b095a5eca46016277e4ac66d52d
URL:
https://github.com/llvm/llvm-project/commit/67c73d88de0e6b095a5eca46016277e4ac66d52d
DIFF:
https://github.com/llvm/llvm-project/commit/67c73d88de0e6b095a5eca46016277e4a
Author: Felipe de Azevedo Piovezan
Date: 2022-09-19T12:56:12-04:00
New Revision: 974958749827bc4fb88b67feab4bcd7536f70456
URL:
https://github.com/llvm/llvm-project/commit/974958749827bc4fb88b67feab4bcd7536f70456
DIFF:
https://github.com/llvm/llvm-project/commit/974958749827bc4fb88b67feab4bcd753
Author: Felipe de Azevedo Piovezan
Date: 2022-09-26T13:27:51-04:00
New Revision: 10a35632d55bb05004fe3d0c2d4432bb74897ee7
URL:
https://github.com/llvm/llvm-project/commit/10a35632d55bb05004fe3d0c2d4432bb74897ee7
DIFF:
https://github.com/llvm/llvm-project/commit/10a35632d55bb05004fe3d0c2d4432bb7
Author: Felipe de Azevedo Piovezan
Date: 2022-10-18T13:48:26-04:00
New Revision: 3c1d8e06d4a995f8d421ede3cf9240bbddc43441
URL:
https://github.com/llvm/llvm-project/commit/3c1d8e06d4a995f8d421ede3cf9240bbddc43441
DIFF:
https://github.com/llvm/llvm-project/commit/3c1d8e06d4a995f8d421ede3cf9240bbd
Author: Felipe de Azevedo Piovezan
Date: 2022-10-18T13:49:19-04:00
New Revision: 58a25ebb8622ee27034f0c103a9067acda7f6300
URL:
https://github.com/llvm/llvm-project/commit/58a25ebb8622ee27034f0c103a9067acda7f6300
DIFF:
https://github.com/llvm/llvm-project/commit/58a25ebb8622ee27034f0c103a9067acd
Author: Felipe de Azevedo Piovezan
Date: 2022-10-18T13:50:31-04:00
New Revision: f477412685fe6bac49d3d080ba91896c28e62116
URL:
https://github.com/llvm/llvm-project/commit/f477412685fe6bac49d3d080ba91896c28e62116
DIFF:
https://github.com/llvm/llvm-project/commit/f477412685fe6bac49d3d080ba91896c2
Author: Felipe de Azevedo Piovezan
Date: 2022-10-18T13:59:29-04:00
New Revision: 3dfc39db582b57151c889dd0dbf3d841d0e724c4
URL:
https://github.com/llvm/llvm-project/commit/3dfc39db582b57151c889dd0dbf3d841d0e724c4
DIFF:
https://github.com/llvm/llvm-project/commit/3dfc39db582b57151c889dd0dbf3d841d
Author: Felipe de Azevedo Piovezan
Date: 2022-10-24T16:27:10Z
New Revision: 73200d155a5882f5bda918596abdc143c991cf0f
URL:
https://github.com/llvm/llvm-project/commit/73200d155a5882f5bda918596abdc143c991cf0f
DIFF:
https://github.com/llvm/llvm-project/commit/73200d155a5882f5bda918596abdc143c991cf
Author: Felipe de Azevedo Piovezan
Date: 2022-10-24T12:39:48-04:00
New Revision: c413df064e85623003ae624835177d19a23fffe9
URL:
https://github.com/llvm/llvm-project/commit/c413df064e85623003ae624835177d19a23fffe9
DIFF:
https://github.com/llvm/llvm-project/commit/c413df064e85623003ae624835177d19a
Author: Felipe de Azevedo Piovezan
Date: 2022-11-01T14:09:33-07:00
New Revision: 9c9afbb76f82004efef4bb1be843661f8d89bcaa
URL:
https://github.com/llvm/llvm-project/commit/9c9afbb76f82004efef4bb1be843661f8d89bcaa
DIFF:
https://github.com/llvm/llvm-project/commit/9c9afbb76f82004efef4bb1be843661f8
@@ -565,6 +565,48 @@ void DebugNamesDWARFIndex::GetTypesWithQuery(
m_fallback.GetTypesWithQuery(query, callback);
}
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+ConstString name, const CompilerDeclContext &parent_decl_ctx,
+llvm::function_ref callback) {
+
felipepiovezan wrote:
> > > > > do we have in mind any other languages that will implement this?
> > > >
> > > >
> > > > I suspect any language wanting to implement this notion of function
> > > > splitting (e.g. all the users of corosplitter) and virtual frames could
> > > > have a use for t
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/112720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/112720
>From 231afe21bc48b3530dc11bc50a24085043807917 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 17 Oct 2024 06:00:31 -0700
Subject: [PATCH] [lldb] Introduce Language::AreEqualForFrameC
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
felipepiovezan wrote:
> > > do we have in mind any other languages that will implement this?
> >
> >
> > I suspect any language wanting to implement this notion of function
> > splitting (e.g. all the users of corosplitter) and virtual frames could
> > have a use for this
>
> We already have
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/110726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/113968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Hi @vogelsgesang , the test you added on this PR breaks the LLDB matrix bot, in
particular it breaks the 15 & 17 clang tests. Could you add a `skipIf`
annotation if this test is only supposed to pass when working with newer
versions of libcxx/clang?
https://green.lab.llv
felipepiovezan wrote:
> Sorry to clarify. I think based on @felipepiovezan comment here: [#108870
> (comment)](https://github.com/llvm/llvm-project/pull/108870#issuecomment-281588)
>
> On Clang 17 we compile fine, just the assertion fails to find the expected
> function name (because of th
Author: Felipe de Azevedo Piovezan
Date: 2024-11-01T08:55:23-07:00
New Revision: d6a150137773bd1d104aa5a1847863a5138f14d9
URL:
https://github.com/llvm/llvm-project/commit/d6a150137773bd1d104aa5a1847863a5138f14d9
DIFF:
https://github.com/llvm/llvm-project/commit/d6a150137773bd1d104aa5a1847863a51
felipepiovezan wrote:
It's interesting that the 17.0 bot is still not happy:
```
File
"/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py",
line 321, in check_value
test_base.assertEqual(
AssertionError: '"Hello"' !=
felipepiovezan wrote:
> > It's interesting that the 17.0 bot is still not happy:
> > ```
> >
> > File
> > "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py",
> > line 321, in check_value
> >
> > test_base.assertEqu
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/113968
This memory type is currently not handled, but it makes sense to mark it as a
heap allocation in requests asking for memory region info.
>From 55d3e6002d05e71750daca208a93aa308dbb7512 Mon Sep 17 00:00:00
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
Awesome, thank you!
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
@vogelsgesang since I don't know if our timezones align, I am going to take the
liberty to click the merge button here to see if we can get the bots green
again!
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
+retur
https://github.com/felipepiovezan approved this pull request.
As someone who was just recently learning about these parts of the codebase,
this renaming will definitely make things easier! Thanks for creating this
patch!
https://github.com/llvm/llvm-project/pull/109611
https://github.com/felipepiovezan commented:
good catch!
https://github.com/llvm/llvm-project/pull/109751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame
until it reaches line 100
in this frame or stops if it leaves the current frame. This is a pretty close
equivalent to GDB's ``until`` command.
+One other useful thing to note about the lldb stepping co
https://github.com/felipepiovezan approved this pull request.
LGTM! I learned something new reading this!
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
@@ -444,6 +492,98 @@ void DebugNamesDWARFIndex::GetNamespaces(
m_fallback.GetNamespaces(name, callback);
}
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ Progress progress("Get
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
+retur
https://github.com/felipepiovezan approved this pull request.
Excited to see more of this being done!
https://github.com/llvm/llvm-project/pull/110058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -7,65 +7,45 @@
//===--===//
#include "DWARFDebugAranges.h"
-#include "DWARFDebugArangeSet.h"
#include "DWARFUnit.h"
#include "LogChannelDWARF.h"
#include "lldb/Utility/Log.h"
#include "lldb/Utility/Tim
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/110726
This is similar to 9fe455fd0c7d, but for FA locations instead of register
locations.
This is useful for unwind plans that cannot create abstract unwind rules, but
instead must inspect the state of the pr
@@ -2088,6 +2088,12 @@ bool RegisterContextUnwind::ReadFrameAddress(
UnwindLogMsg("No suitable CFA found");
break;
}
+ case UnwindPlan::Row::FAValue::isConstant: {
+address = fa.GetConstant();
+address = abi_sp->FixCodeAddress(address);
felip
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/110726
>From a23540f5a793d7c9bb115f06a5af0266f8cfb038 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 24 Sep 2024 09:26:29 -0700
Subject: [PATCH 1/2] [lldb] Add isConstant mode for FA locati
@@ -2088,6 +2088,12 @@ bool RegisterContextUnwind::ReadFrameAddress(
UnwindLogMsg("No suitable CFA found");
break;
}
+ case UnwindPlan::Row::FAValue::isConstant: {
+address = fa.GetConstant();
+address = abi_sp->FixCodeAddress(address);
felip
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
+retur
@@ -444,6 +492,98 @@ void DebugNamesDWARFIndex::GetNamespaces(
m_fallback.GetNamespaces(name, callback);
}
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+ConstString name, llvm::ArrayRef parent_names,
+llvm::function_ref callback) {
+ Progress progress("Get
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
https://github.com/felipepiovezan commented:
Very cool work! I've left some high level thoughts and questions inline.
Focused only on the namespace bit for now, and didn't do a _code_ review, just
algorithm ideas
https://github.com/llvm/llvm-project/pull/108907
@@ -402,6 +420,36 @@ bool DebugNamesDWARFIndex::SameParentChain(
return true;
}
+bool DebugNamesDWARFIndex::WithinParentChain(
+llvm::ArrayRef query_parent_names,
+llvm::ArrayRef parent_chain) const {
+ if (parent_chain.size() < query_parent_names.size())
--
@@ -374,25 +377,40 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryATName(
+llvm::StringRef query_name, const DebugNames::Entry &entry) const {
+ auto maybe_dieoffset = en
@@ -2088,6 +2088,13 @@ bool RegisterContextUnwind::ReadFrameAddress(
UnwindLogMsg("No suitable CFA found");
break;
}
+ case UnwindPlan::Row::FAValue::isConstant: {
+address = fa.GetConstant();
+if (abi_sp)
+ address = abi_sp->FixCodeAddress(address);
---
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/110726
>From a23540f5a793d7c9bb115f06a5af0266f8cfb038 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 24 Sep 2024 09:26:29 -0700
Subject: [PATCH 1/3] [lldb] Add isConstant mode for FA locati
https://github.com/felipepiovezan approved this pull request.
This LGTM! Thanks a lot of fixing it.
Your comments match my observations and I tested this patch with a test case
where we stop on every instruction of a few functions and assert we can unwind
correctly.
https://github.com/llvm/llv
felipepiovezan wrote:
Thanks for finding those, there are many places in LLDB doing repeated work
like this!
https://github.com/llvm/llvm-project/pull/112655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
felipepiovezan wrote:
An example usage can be found here:
https://github.com/swiftlang/llvm-project/pull/9441
https://github.com/llvm/llvm-project/pull/112720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/112720
This allows languages to provide an opinion on whether two symbol contexts are
equivalent (i.e. belong to the same function).
It is useful to drive the comparisons done by stepping plans that need to
en
@@ -363,6 +363,14 @@ class Language : public PluginInterface {
return false;
}
+ /// Returns a boolean indicating whether two symbol contexts correspond to
+ /// the same function. If the plugin has no opinion, it should return
nullopt.
+ virtual std::optional
+ Are
felipepiovezan wrote:
> do we have in mind any other languages that will implement this?
I suspect any language wanting to implement this notion of function splitting
(e.g. all the users of corosplitter) and virtual frames could have a use for
this
https://github.com/llvm/llvm-project/pull/1
@@ -130,6 +131,25 @@ void RenderDiagnosticDetails(Stream &stream,
}
stream << '\n';
+ // Reverse the order within groups of diagnostics that are on the same
column.
+ auto group = [](const std::vector &details) {
+uint16_t column = 0;
+std::vector result, group;
301 - 400 of 517 matches
Mail list logo
