@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath(
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (std::pair idx : idxs) {
root = root->GetChildAtIndex(idx.first, idx.second);
i
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/74523
The function FindDefinitionTypeForDWARFDeclContext loops over all DIEs
corresponding to types with a certain name and compares the context of each
found DIE with the context of a target DIE. However, the
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/74523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2023-12-06T14:35:34-08:00
New Revision: 71be8f3c23497e28c86f1135f564b16106d8d6fb
URL:
https://github.com/llvm/llvm-project/commit/71be8f3c23497e28c86f1135f564b16106d8d6fb
DIFF:
https://github.com/llvm/llvm-project/commit/71be8f3c23497e28c86f1135f564b1610
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/74773
There was duplicated (and complex) code querying whether tags were type-like
tags (i.e. class or struct); this has been factored out into a helper function.
There was also a comment about not comparing id
@@ -2947,29 +2951,18 @@ TypeSP
SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE(
m_index->GetCompleteObjCClass(
type_name, must_be_implementation, [&](DWARFDIE type_die) {
-bool try_resolving_type = false;
-
// Don't try and resolve the DIE we ar
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/74773
>From 9f38564875620a44a982a50492d87ee431baffcd Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 13:41:44 -0800
Subject: [PATCH 1/2] [SymbolFileDWARF][NFC] Remove duplicated c
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/74788
This commit factors out the logic building each component of a qualified name
into its own function so that it may be reused by a future commit, while also
simplifying the logic of assembling these pieces
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/74788
>From c10c3f03383cf8015ce014330f40d9089ff64fcf Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 15:45:05 -0800
Subject: [PATCH] [lldb][NFC] Simplify DWARRFDeclContext::GetQua
@@ -3128,36 +3121,11 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
if (type_system &&
!type_system->SupportsLanguage(GetLanguage(*type_die.GetCU(
return true;
- bool try_resolving_type = false;
- // Don
@@ -130,6 +130,10 @@ class PluginProperties : public Properties {
}
};
+bool IsTypeTag(llvm::dwarf::Tag Tag) {
felipepiovezan wrote:
I'll rename it.
Regarding static, this function as well as most functions defined above it, are
in an anonymous namespace
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,6 +130,10 @@ class PluginProperties : public Properties {
}
};
+bool IsTypeTag(llvm::dwarf::Tag Tag) {
felipepiovezan wrote:
Do you prefer if I take it out of the namespace and make it static? In
llvm-project/llvm I would have done because of the p
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -56,10 +56,10 @@ namespace Foo = A::B; // namespace alias
using Foo::myfunc; // using declaration
-using namespace Foo;// using directive
+//removing namespace foo; for quality naming
felipepiovezan wrote:
Hi @jeevanghimire, please note that t
@@ -34,7 +34,7 @@ namespace A {
int myfunc (int a);
int myfunc2(int a)
{
- return a + 2;
+return a + 2; //just changing tab not much
felipepiovezan wrote:
In general, we don't add diffs that are unrelated to
https://github.com/felipepiovezan requested changes to this pull request.
Hi @jeevanghimire, thank you for the PR! I believe the original issue was not
about changing LLVM test inputs, but rather about changing clang-tidy to warn
about this kind of patterns.
Please see my rationale in a previo
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/74773
>From 9f38564875620a44a982a50492d87ee431baffcd Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 13:41:44 -0800
Subject: [PATCH 1/3] [SymbolFileDWARF][NFC] Remove duplicated c
@@ -130,6 +130,10 @@ class PluginProperties : public Properties {
}
};
+bool IsTypeTag(llvm::dwarf::Tag Tag) {
felipepiovezan wrote:
In the interest of expediency, I've moved it out of the anonymous namespace and
made it static
https://github.com/llvm/llv
felipepiovezan wrote:
I am really struggling to handle the scope of the changes here, IIUC there are
a handful of changes that could be split into separate commits and merged
independently of each other: there is some code being moved around, new
GetCompilerContext APIs, the new query, the rep
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/74788
>From 5a5309c1c81fadb0378f1fa821798471f00f9b29 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 15:45:05 -0800
Subject: [PATCH] [lldb][NFC] Simplify DWARRFDeclContext::GetQua
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/74788
>From 19452a77fbaa8376686ae9fcdb6c675621f515d8 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 15:45:05 -0800
Subject: [PATCH] [lldb][NFC] Simplify DWARRFDeclContext::GetQua
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/74788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Clicking merge on @PortalPete 's behalf
https://github.com/llvm/llvm-project/pull/74414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/74414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/75365
The commits are meant to be looked at one at a time
>From ece936d56a22dad7f604d6610d02a9a59bac0345 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 11 Dec 2023 12:42:40 -0300
Subject:
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/75365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/76030
If adding a user commands fails because a command with the same name already
exists, we only say that "force replace is not set" without telling the user
_how_ to set it. There are two ways to do so; this
@@ -161,6 +161,17 @@ def cleanup():
)
self.expect("my_command", substrs=["a.out"])
+# Test that without --overwrite we are not allowed to redefine the
command.
+self.expect(
+"command script add my_command --class welcome.Targetname
@@ -1160,7 +1160,9 @@ Status CommandInterpreter::AddUserCommand(llvm::StringRef
name,
if (UserCommandExists(name)) {
if (!can_replace) {
- result.SetErrorString("user command exists and force replace not set");
+ result.SetErrorString(
+ "user command
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/76030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/76030
>From a9a1cbc1ac42b2eb66dac8a60aa9d8f54df291c3 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 18 Dec 2023 11:26:41 -0300
Subject: [PATCH 1/2] [lldb] Add actionable feedback when overw
felipepiovezan wrote:
Address review comments
https://github.com/llvm/llvm-project/pull/76030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -161,6 +161,19 @@ def cleanup():
)
self.expect("my_command", substrs=["a.out"])
+# Test that without --overwrite we are not allowed to redefine the
command.
+self.expect(
+"command script add my_command --class welcome.Targetname
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/76030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/76111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,8 +48,17 @@ std::string DiagnosticManager::GetString(char separator) {
std::string ret;
for (const auto &diagnostic : Diagnostics()) {
-ret.append(StringForSeverity(diagnostic->GetSeverity()));
-ret.append(std::string(diagnostic->GetMessage()));
+std::st
https://github.com/felipepiovezan commented:
I'll leave the approval to others, but I left a coding suggestion.
It would be a lot nicer if we could tell the producer of those messages to not
include the severity, but I think this is way out of scope here. The
"severity" inside the message
@@ -48,8 +48,17 @@ std::string DiagnosticManager::GetString(char separator) {
std::string ret;
for (const auto &diagnostic : Diagnostics()) {
-ret.append(StringForSeverity(diagnostic->GetSeverity()));
-ret.append(std::string(diagnostic->GetMessage()));
+std::st
@@ -48,8 +48,17 @@ std::string DiagnosticManager::GetString(char separator) {
std::string ret;
for (const auto &diagnostic : Diagnostics()) {
-ret.append(StringForSeverity(diagnostic->GetSeverity()));
-ret.append(std::string(diagnostic->GetMessage()));
+std::st
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/76111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/75365
>From 1fafdee241e98c469a3a06e29d4a375bd8af1ca0 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 11 Dec 2023 12:42:40 -0300
Subject: [PATCH 1/9] [lldb][[DWARFDeclContext] Add function to
@@ -17,6 +17,89 @@
namespace lldb_private {
class Stream;
+/// Wraps either a FileSpec that represents a local file or a source
+/// file whose contents is known (for example because it can be
+/// reconstructed from debug info), but that hasn't been written to a
+/// file yet
@@ -235,6 +233,53 @@ ParseSupportFilesFromPrologue(const lldb::ModuleSP &module,
for (size_t idx = first_file_idx; idx <= last_file_idx; ++idx) {
std::string remapped_file;
if (auto file_path = GetFileByIndex(prologue, idx, compile_dir, style)) {
+ auto entry = p
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/76974
This function has no mutable behavior
>From e3504ef67116945613bdfc36f0844d799097c2f8 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 4 Jan 2024 13:25:33 -0300
Subject: [PATCH] [lldb][
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/76977
This moves the functionally of finding a DIE based on a fully qualified name
from SymbolFileDWARF into DWARFIndex itself, so that specializations of
DWARFIndex can implement faster versions of this query.
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/76977
>From b828fb2a9e6317ee8f355ce88334cc33bb1b36ee Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 4 Jan 2024 12:44:43 -0300
Subject: [PATCH] [lldb][DWARFIndex][nfc] Factor out fully quali
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/76974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/76977
>From b828fb2a9e6317ee8f355ce88334cc33bb1b36ee Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 4 Jan 2024 12:44:43 -0300
Subject: [PATCH 1/2] [lldb][DWARFIndex][nfc] Factor out fully q
felipepiovezan wrote:
Thanks for the review @clayborg
Just to let you know, I decided to make a helper function so that derived
classes can share part of this implementation (you can see the diff by looking
only at the fixup commit)
https://github.com/llvm/llvm-project/pull/76977
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/75365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -102,6 +110,12 @@ class DWARFIndex {
}
void ReportInvalidDIERef(DIERef ref, llvm::StringRef name) const;
+
+ /// Implementation of `GetFullyQualifiedType` to check a single entry,
+ /// shareable with derived classes.
felipepiovezan wrote:
I'm glad y
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/77121
https://discourse.llvm.org/t/rfc-improve-dwarf-5-debug-names-type-lookup-parsing-speed/74151
>From 8ec587dc14144f14d3d86a41901a261f75d1ae9b Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date:
https://github.com/felipepiovezan converted_to_draft
https://github.com/llvm/llvm-project/pull/77121
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/77121
>From 8ec587dc14144f14d3d86a41901a261f75d1ae9b Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Wed, 3 Jan 2024 11:19:04 -0300
Subject: [PATCH 1/7] [AccelTable][nfc] Add helper function to c
https://github.com/felipepiovezan approved this pull request.
Nice catch!
https://github.com/llvm/llvm-project/pull/77166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
LGTM!
I see that we still have `FindAndReplaceIDRanges` referencing
CommandReturnObject; out of curiosity, have you had a chance to look into
removing that one (if it makes sense)? I see that `CommandReturnObject` is
neither `#incl
https://github.com/felipepiovezan commented:
Btw this reminds me a lot of accelerator tables & finding the parents of
functions there.
Because the declaration is never placed in the accelerator table (and the
declaration is what has the scope), we are never able to find the parent of
functions
@@ -855,6 +855,23 @@ void Module::FindFunctions(ConstString name,
}
}
+void Module::FindFunctions(llvm::ArrayRef compiler_ctx,
+ FunctionNameType name_type_mask,
+ const ModuleFunctionSearchOptions &options,
+
@@ -855,6 +855,23 @@ void Module::FindFunctions(ConstString name,
}
}
+void Module::FindFunctions(llvm::ArrayRef compiler_ctx,
+ FunctionNameType name_type_mask,
+ const ModuleFunctionSearchOptions &options,
+
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/77157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -375,16 +375,21 @@ std::vector DWARFDIE::GetDeclContextDIEs()
const {
std::vector DWARFDIE::GetDeclContext() const {
std::vector context;
- const dw_tag_t tag = Tag();
- if (tag == DW_TAG_compile_unit || tag == DW_TAG_partial_unit)
-return context;
DWARFDIE pare
@@ -855,6 +855,23 @@ void Module::FindFunctions(ConstString name,
}
}
+void Module::FindFunctions(llvm::ArrayRef compiler_ctx,
+ FunctionNameType name_type_mask,
+ const ModuleFunctionSearchOptions &options,
+
@@ -404,7 +409,7 @@ std::vector
DWARFDIE::GetDeclContext() const {
push_ctx(CompilerContextKind::Enum, GetName());
break;
case DW_TAG_subprogram:
-push_ctx(CompilerContextKind::Function, GetPubname());
+push_ctx(CompilerContextKind::Function, GetName());
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/76977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/77349
This functionality will support the efforts to implement the IDX_Parent
attribute of accelerator table entries, and it will allow us to more easily
compare each of the names in a DIE parent chain hierarch
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/77349
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the name `A::B::C`, this methods returns `{"A",
+ /// "B", "C"}`
+ llvm::SmallVec
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/77349
>From 1b444a334fdfd5c88e263e9804cffbd7574a670b Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 11 Dec 2023 12:42:40 -0300
Subject: [PATCH 1/2] [lldb][[DWARFDeclContext] Add function to
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
@@ -2574,11 +2574,12 @@ void SymbolFileDWARF::FindFunctions(const
Module::LookupInfo &lookup_info,
Module::LookupInfo no_tp_lookup_info(lookup_info);
no_tp_lookup_info.SetLookupName(ConstString(name_no_template_params));
- m_index->GetFunctions(no_tp_lookup_i
https://github.com/felipepiovezan approved this pull request.
LGTM! Thanks for trying out my suggestions!
https://github.com/llvm/llvm-project/pull/76111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/77121
>From b1ae660f7a7e719ff116463dd74766d7acc9207f Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 11 Dec 2023 12:42:40 -0300
Subject: [PATCH 1/5] [lldb][[DWARFDeclContext] Add function to
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/77596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -68,6 +68,11 @@ class DWARFDeclContext {
const char *GetQualifiedName() const;
+ /// Returns a vector of string, one string per entry in the fully qualified
+ /// name. For example, for the DeclContext `A::B::C`, this methods returns
+ /// `{"C", "B", "A"}`
+ llvm::S
Author: Felipe de Azevedo Piovezan
Date: 2023-07-06T17:14:14-04:00
New Revision: 2c3bb6a5902791dd7a32bf1639255ea0c0366d43
URL:
https://github.com/llvm/llvm-project/commit/2c3bb6a5902791dd7a32bf1639255ea0c0366d43
DIFF:
https://github.com/llvm/llvm-project/commit/2c3bb6a5902791dd7a32bf1639255ea0c
Author: Felipe de Azevedo Piovezan
Date: 2023-07-06T17:15:06-04:00
New Revision: 032de3ee0d3575557f25fb2d78b9423f3f50
URL:
https://github.com/llvm/llvm-project/commit/032de3ee0d3575557f25fb2d78b9423f3f50
DIFF:
https://github.com/llvm/llvm-project/commit/032de3ee0d3575557f25fb2d78b94
Author: Felipe de Azevedo Piovezan
Date: 2023-07-07T08:44:59-04:00
New Revision: dc04b18ad7e45c67df4b8b3a756257eb62447970
URL:
https://github.com/llvm/llvm-project/commit/dc04b18ad7e45c67df4b8b3a756257eb62447970
DIFF:
https://github.com/llvm/llvm-project/commit/dc04b18ad7e45c67df4b8b3a756257eb6
Author: Felipe de Azevedo Piovezan
Date: 2023-07-08T09:16:11-04:00
New Revision: cec33fc87c0c0094b0d627031ff756b2d1f905eb
URL:
https://github.com/llvm/llvm-project/commit/cec33fc87c0c0094b0d627031ff756b2d1f905eb
DIFF:
https://github.com/llvm/llvm-project/commit/cec33fc87c0c0094b0d627031ff756b2d
Author: Felipe de Azevedo Piovezan
Date: 2023-07-10T10:10:15-04:00
New Revision: 6890ad3f41c51ba9008c26f5b23397d5e0bc2aad
URL:
https://github.com/llvm/llvm-project/commit/6890ad3f41c51ba9008c26f5b23397d5e0bc2aad
DIFF:
https://github.com/llvm/llvm-project/commit/6890ad3f41c51ba9008c26f5b23397d5e
Author: Felipe de Azevedo Piovezan
Date: 2023-07-13T08:27:29-04:00
New Revision: 85c2e420c87c20af6a7e1699a7317d8adc51b5ff
URL:
https://github.com/llvm/llvm-project/commit/85c2e420c87c20af6a7e1699a7317d8adc51b5ff
DIFF:
https://github.com/llvm/llvm-project/commit/85c2e420c87c20af6a7e1699a7317d8ad
Author: Felipe de Azevedo Piovezan
Date: 2023-07-19T09:14:02-04:00
New Revision: 8bc97a3ee4f411e583a13e0966239848080d753d
URL:
https://github.com/llvm/llvm-project/commit/8bc97a3ee4f411e583a13e0966239848080d753d
DIFF:
https://github.com/llvm/llvm-project/commit/8bc97a3ee4f411e583a13e09662398480
Author: Felipe de Azevedo Piovezan
Date: 2023-07-19T09:15:48-04:00
New Revision: 00c60496775b611d92bae5a69d4e6794ecad4084
URL:
https://github.com/llvm/llvm-project/commit/00c60496775b611d92bae5a69d4e6794ecad4084
DIFF:
https://github.com/llvm/llvm-project/commit/00c60496775b611d92bae5a69d4e6794e
Author: Felipe de Azevedo Piovezan
Date: 2023-07-19T17:11:21-04:00
New Revision: 8b19d13fde6e32c8815f3f4e3f629208b0f1d0e9
URL:
https://github.com/llvm/llvm-project/commit/8b19d13fde6e32c8815f3f4e3f629208b0f1d0e9
DIFF:
https://github.com/llvm/llvm-project/commit/8b19d13fde6e32c8815f3f4e3f629208b
felipepiovezan wrote:
> > This LGTM!
> > I don't think I can see far enough ahead on what you are planning here, but
> > I was just wondering if the ultimate goal is to have the
> > `option_arg.getAsT` return an `Expected`. In this case, wouldn't all
> > these arguments (short option, long opt
felipepiovezan wrote:
Juuust to make sure, was this discussed before? This seems akin to running
clang-format on the entire project, which last time we talked about still faced
opposition:
https://discourse.llvm.org/t/rfc-clang-format-all-the-things/76614/11
https://github.com/llvm/llvm-proje
felipepiovezan wrote:
> > This seems akin to running clang-format on the entire project, which last
> > time we talked about still faced opposition
>
> My impression (I admit I haven't reviewed the whole thread lately) is that
> the opposition has mostly to do with how clang-format mangles som
https://github.com/felipepiovezan approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/83908
Some languages may create artificial functions that have no real user code,
even though there is line table information for them. One such case is with
coroutine code that receives the CoroSplitter transf
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/83925
According to the git log (d9442afba1bd6), this test has never been
enabled/disabled, it was checked in without being called anywhere. But it
passes and it is useful, so this commit enables it.
>From 009f
felipepiovezan wrote:
@JDevlieghere I believe you were the last one to touch this test, so I'll let
you approve this :D
https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
felipepiovezan wrote:
> Also, are these 100% uninteresting line table entries? At present, there's no
> way to get lldb to not filter them out, so they either really need to be
> totally uninteresting, or we need a setting to turn them back on again.
They should be 100% uninteresting, but I ag
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
101 - 200 of 517 matches
Mail list logo
