Re: [Lldb-commits] [PATCH] D13247: RenderScript command for printing allocation information

2015-10-06 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL249380: RenderScript command for printing allocation information (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D13247?vs=35968&id=36587#toc Repository: rL LLVM http:/

[Lldb-commits] [lldb] r249380 - RenderScript command for printing allocation information

2015-10-06 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Oct 6 03:42:32 2015 New Revision: 249380 URL: http://llvm.org/viewvc/llvm-project?rev=249380&view=rev Log: RenderScript command for printing allocation information This patch adds a new command 'language renderscript allocation list' for printing the details of a

[Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

2015-10-13 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus, ADodds. EwanCrawford set the repository for this revision to rL LLVM. This patch adds the command 'language renderscript allocation dump ' for printing the

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

2015-10-13 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. Hi Bruce, I'm mapping rs types to data formatters in the struct `RenderScriptRuntime::AllocationDetails::RSTypeToFormat` on line RenderScriptRuntime.cpp:259. Then using a `DataExtractor` to print using those formats on RenderScriptRuntime.cpp:1830 Is there anoth

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

2015-10-14 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250281: RenderScript command for printing allocation contents (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D13699?vs=37251&id=37324#toc Repository: rL LLVM http://rev

[Lldb-commits] [lldb] r250281 - RenderScript command for printing allocation contents

2015-10-14 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Oct 14 04:02:20 2015 New Revision: 250281 URL: http://llvm.org/viewvc/llvm-project?rev=250281&view=rev Log: RenderScript command for printing allocation contents This patch adds the command 'language renderscript allocation dump ' for printing the contents of a RS

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

2015-10-14 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. Hi Pavel, Thanks for letting me know, I'll look into it now. Repository: rL LLVM http://reviews.llvm.org/D13699 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

2015-10-14 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. No bother, thanks for reverting Repository: rL LLVM http://reviews.llvm.org/D13699 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13730: Resubmit: RenderScript command for printing allocation contents

2015-10-14 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: granata.enrico, clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus, labath. EwanCrawford set the repository for this revision to rL LLVM. Previous patch http://reviews.llvm.org/D13699 broke TestDataFormatter

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

2015-10-15 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. Unfortunately there isn't a user-visible variable for the allocation. Information regarding the allocation as a whole is maintained by the runtime. Within a RS kernel invocation the user only has access to the raw data at a specific cell in the allocation, which is

[Lldb-commits] [lldb] r250499 - Resubmit: RenderScript command for printing allocation contents

2015-10-16 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Fri Oct 16 03:28:47 2015 New Revision: 250499 URL: http://llvm.org/viewvc/llvm-project?rev=250499&view=rev Log: Resubmit: RenderScript command for printing allocation contents Previous commit r250281 broke TestDataFormatterSmartArray.py Resolved in in this patch by ad

Re: [Lldb-commits] [PATCH] D13730: Resubmit: RenderScript command for printing allocation contents

2015-10-16 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250499: Resubmit: RenderScript command for printing allocation contents (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D13730?vs=37356&id=37562#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

2015-10-20 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus. EwanCrawford set the repository for this revision to rL LLVM. Patch adds command 'language renderscript allocation save' to store the contents of an alloca

[Lldb-commits] [lldb] r250886 - [RenderScript] New commands to save/load RS allocations to file.

2015-10-21 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Oct 21 03:50:42 2015 New Revision: 250886 URL: http://llvm.org/viewvc/llvm-project?rev=250886&view=rev Log: [RenderScript] New commands to save/load RS allocations to file. Patch adds command 'language renderscript allocation save' to store the contents of an alloc

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

2015-10-21 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250886: [RenderScript] New commands to save/load RS allocations to file. (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D13903?vs=37889&id=37972#toc Repository: rL LLVM

[Lldb-commits] [lldb] r250891 - [RenderScript] Fix out of bounds warning.

2015-10-21 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Oct 21 05:27:10 2015 New Revision: 250891 URL: http://llvm.org/viewvc/llvm-project?rev=250891&view=rev Log: [RenderScript] Fix out of bounds warning. Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

2015-10-21 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. Thanks for spotting, comitted a quick fix Repository: rL LLVM http://reviews.llvm.org/D13903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r251003 - [RenderScript] Support for mips64 runtime hook

2015-10-22 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Oct 22 04:01:05 2015 New Revision: 251003 URL: http://llvm.org/viewvc/llvm-project?rev=251003&view=rev Log: [RenderScript] Support for mips64 runtime hook Previously we could not hook the RS runtime on mips64 architectures. Patch implements ABI specific code for in

[Lldb-commits] [lldb] r251293 - [RenderScript] Add option to break on a specific kernel invocation

2015-10-26 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Mon Oct 26 09:04:37 2015 New Revision: 251293 URL: http://llvm.org/viewvc/llvm-project?rev=251293&view=rev Log: [RenderScript] Add option to break on a specific kernel invocation Adds option -c to the 'language renderscript kernel breakpoint set' command. Breaks onl

[Lldb-commits] [lldb] r254294 - [RS] Support RenderScript struct allocations

2015-11-30 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Mon Nov 30 04:29:49 2015 New Revision: 254294 URL: http://llvm.org/viewvc/llvm-project?rev=254294&view=rev Log: [RS] Support RenderScript struct allocations This patch adds functionality for dumping allocations of struct elements. This involves: + Jitting the runt

Re: [Lldb-commits] [PATCH] D15092: Fix hang in global static initialization

2015-12-01 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. Thanks for fixing this Adrian Repository: rL LLVM http://reviews.llvm.org/D15092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D15116: Fix for evaluating a function with an ambiguous symbol

2015-12-01 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added a reviewer: spyffe. EwanCrawford added a subscriber: lldb-commits. EwanCrawford set the repository for this revision to rL LLVM. I came across a bug for calling functions using expression evaluation, where the function name also matches a sym

[Lldb-commits] [lldb] r254910 - [RenderScript] Mips64 allocations workaround

2015-12-07 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Mon Dec 7 07:50:32 2015 New Revision: 254910 URL: http://llvm.org/viewvc/llvm-project?rev=254910&view=rev Log: [RenderScript] Mips64 allocations workaround Workaround for Mips64 compiler bug by using function pointers to call functions for expression evaluation. This

[Lldb-commits] [lldb] r255121 - [RenderScript] Add hook for destroyed allocations

2015-12-09 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Dec 9 10:01:58 2015 New Revision: 255121 URL: http://llvm.org/viewvc/llvm-project?rev=255121&view=rev Log: [RenderScript] Add hook for destroyed allocations New hook for rsdAllocationDestroy() which is called when allocations are deleted. LLDB should be aware of t

[Lldb-commits] [lldb] r255238 - [RenderScript] Refactor condition deciding when to JIT RS runtime

2015-12-10 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Dec 10 04:20:39 2015 New Revision: 255238 URL: http://llvm.org/viewvc/llvm-project?rev=255238&view=rev Log: [RenderScript] Refactor condition deciding when to JIT RS runtime Patch creates a member function that decides when to JIT all the details about an allocatio

Re: [Lldb-commits] [PATCH] D15116: Fix for evaluating a function with an ambiguous symbol

2015-12-10 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. ping Repository: rL LLVM http://reviews.llvm.org/D15116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r255338 - [RenderScript] Support for amd64 RS hooks

2015-12-11 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Fri Dec 11 07:49:21 2015 New Revision: 255338 URL: http://llvm.org/viewvc/llvm-project?rev=255338&view=rev Log: [RenderScript] Support for amd64 RS hooks Adds support for reading a maximum of six integer arguments from a renderscript hook on X86_64. Author: Luke Drummo

Re: [Lldb-commits] [PATCH] D15116: Fix for evaluating a function with an ambiguous symbol

2016-07-12 Thread Ewan Crawford via lldb-commits
EwanCrawford abandoned this revision. EwanCrawford added a comment. Thanks for getting around to looking at this Sean, i'd forgotten about it. Unfortunately the patch seems to have gone stale as the test case no longer passes. So i'm just going to close the review for now. Repository: rL LLVM

[Lldb-commits] [PATCH] D15576: Inspect global static const variables

2015-12-16 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: tberghammer, clayborg. EwanCrawford added a subscriber: lldb-commits. EwanCrawford set the repository for this revision to rL LLVM. This patch adds support for printing global static const variables which are given a DW_AT_const_va

[Lldb-commits] [lldb] r255887 - Inspect DW_AT_const_value global static const variables

2015-12-17 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Dec 17 05:59:47 2015 New Revision: 255887 URL: http://llvm.org/viewvc/llvm-project?rev=255887&view=rev Log: Inspect DW_AT_const_value global static const variables This patch adds support for printing global static const variables which are given a DW_AT_const_valu

Re: [Lldb-commits] [PATCH] D15576: Inspect global static const variables

2015-12-17 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255887: Inspect DW_AT_const_value global static const variables (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D15576?vs=43017&id=43119#toc Repository: rL LLVM http://r

[Lldb-commits] [lldb] r255904 - [RenderScript] Support all RS allocation types

2015-12-17 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Dec 17 10:40:05 2015 New Revision: 255904 URL: http://llvm.org/viewvc/llvm-project?rev=255904&view=rev Log: [RenderScript] Support all RS allocation types Currently we can just inspect the details of the most common allocation types. This patch allows us to support

[Lldb-commits] [lldb] r256833 - Revert r256769

2016-01-05 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Jan 5 07:18:46 2016 New Revision: 256833 URL: http://llvm.org/viewvc/llvm-project?rev=256833&view=rev Log: Revert r256769 Reverts "Use correct format identifiers to print something meaningful." Original format specifiers were correct. Instead use void* casts to re

[Lldb-commits] [lldb] r256927 - Add LogDump methods to lldb_private::StringList.

2016-01-06 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Jan 6 05:06:30 2016 New Revision: 256927 URL: http://llvm.org/viewvc/llvm-project?rev=256927&view=rev Log: Add LogDump methods to lldb_private::StringList. This patch eases the printing of iterable string containers. Author: Luke Drummond Differential Revision: h

Re: [Lldb-commits] [PATCH] D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers

2016-01-06 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256927: Add LogDump methods to lldb_private::StringList. (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D15773?vs=44000&id=44104#toc Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D15948: Remove duplicate header added in http://reviews.llvm.org/rL256927

2016-01-07 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257061: Remove duplicate header added in r256927 (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D15948?vs=44205&id=44207#toc Repository: rL LLVM http://reviews.llvm.org

[Lldb-commits] [lldb] r257759 - Fix ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext

2016-01-14 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Jan 14 06:18:09 2016 New Revision: 257759 URL: http://llvm.org/viewvc/llvm-project?rev=257759&view=rev Log: Fix ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext Both llvm and clang have an ArrayType class, which can cause resolution to fai

Re: [Lldb-commits] [PATCH] D16155: possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext

2016-01-14 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257759: Fix ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D16155?vs=44788&id=44854#toc Reposit

[Lldb-commits] [lldb] r258038 - [RenderScript] Remove mips specific expressions

2016-01-18 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Mon Jan 18 03:16:02 2016 New Revision: 258038 URL: http://llvm.org/viewvc/llvm-project?rev=258038&view=rev Log: [RenderScript] Remove mips specific expressions Reverts earlier commit r254910, which used function pointers for jitted expressions to avoid a Mips64 compile

[Lldb-commits] [lldb] r258303 - [RenderScript] New command for viewing coordinate of current kernel invocation

2016-01-20 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Jan 20 06:03:29 2016 New Revision: 258303 URL: http://llvm.org/viewvc/llvm-project?rev=258303&view=rev Log: [RenderScript] New command for viewing coordinate of current kernel invocation Patch adds command 'language renderscript kernel coordinate' for printing the

[Lldb-commits] [lldb] r258800 - [RenderScript] Provide option to specify a single allocation to print

2016-01-26 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Jan 26 04:41:08 2016 New Revision: 258800 URL: http://llvm.org/viewvc/llvm-project?rev=258800&view=rev Log: [RenderScript] Provide option to specify a single allocation to print Patch replaces the 'renderscript allocation list' command flag --refresh, with a new op

[Lldb-commits] [lldb] r259181 - [RenderScript] Remove unused RS command

2016-01-29 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Fri Jan 29 04:11:03 2016 New Revision: 259181 URL: http://llvm.org/viewvc/llvm-project?rev=259181&view=rev Log: [RenderScript] Remove unused RS command Patch deletes the 'language renderscript module probe' command. This command was present in the initial commit to help

[Lldb-commits] [PATCH] D16766: [RenderScript] Use LLVM DWARF language enum

2016-02-01 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added a reviewer: clayborg. EwanCrawford added a subscriber: lldb-commits. EwanCrawford set the repository for this revision to rL LLVM. A DWARF language vender extension for RenderScript was added to LLVM in r259348(http://reviews.llvm.org/D16409)

Re: [Lldb-commits] [PATCH] D16766: [RenderScript] Use LLVM DWARF language enum

2016-02-02 Thread Ewan Crawford via lldb-commits
EwanCrawford updated this revision to Diff 46656. EwanCrawford added a comment. Thanks for taking a look, yes I want to use ClangASTContext. Although RenderScript is mostly just C99 checking for it in a function called `LanguageIsC` does seem off. I've put the comparison directly in ClangASTCont

Re: [Lldb-commits] [PATCH] D16766: [RenderScript] Use LLVM DWARF language enum

2016-02-03 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259634: [RenderScript] Use LLVM DWARF language enum (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D16766?vs=46656&id=46755#toc Repository: rL LLVM http://reviews.llvm.

[Lldb-commits] [lldb] r259634 - [RenderScript] Use LLVM DWARF language enum

2016-02-03 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Feb 3 03:17:03 2016 New Revision: 259634 URL: http://llvm.org/viewvc/llvm-project?rev=259634&view=rev Log: [RenderScript] Use LLVM DWARF language enum A DWARF language vender extension for RenderScript was added to LLVM in r259348(http://reviews.llvm.org/D16409) W

[Lldb-commits] [lldb] r259773 - [RenderScript] Add command for recalculating allocation details

2016-02-04 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Feb 4 03:44:23 2016 New Revision: 259773 URL: http://llvm.org/viewvc/llvm-project?rev=259773&view=rev Log: [RenderScript] Add command for recalculating allocation details Patch replaces the --refresh flag removed in r258800 with it's own command, 'language renders

[Lldb-commits] [lldb] r260372 - [RenderScript] Refactor allocation expressions

2016-02-10 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Feb 10 05:23:27 2016 New Revision: 260372 URL: http://llvm.org/viewvc/llvm-project?rev=260372&view=rev Log: [RenderScript] Refactor allocation expressions Patch refractors RS plugin code specifying how format strings are used to JIT the runtime. Author: Dean De L

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-16 Thread Ewan Crawford via lldb-commits
EwanCrawford added a subscriber: EwanCrawford. EwanCrawford added a comment. Hi Tamas, This commit causes a SIGBUS for me on Nexus 6 ARMv7 devices, specifically the g_thumb_breakpoint_opcode change. I can revert this locally but any advice on tracking the issue down further? Repository: rL L

[Lldb-commits] [PATCH] D17384: Fix OSX cmake build

2016-02-18 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: sivachandra, zturner, labath. EwanCrawford added a subscriber: lldb-commits. EwanCrawford set the repository for this revision to rL LLVM. Commit r260721(http://reviews.llvm.org/D17182) introduced the following error when building

[Lldb-commits] [lldb] r261227 - Fix OSX cmake build

2016-02-18 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Feb 18 11:01:40 2016 New Revision: 261227 URL: http://llvm.org/viewvc/llvm-project?rev=261227&view=rev Log: Fix OSX cmake build Commit r260721(http://reviews.llvm.org/D17182) introduced the following error when building for OSX using cmake: Undefined symbols for a

Re: [Lldb-commits] [PATCH] D17384: Fix OSX cmake build

2016-02-18 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261227: Fix OSX cmake build (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D17384?vs=48325&id=48336#toc Repository: rL LLVM http://reviews.llvm.org/D17384 Files: lldb

Re: [Lldb-commits] [PATCH] D17266: delete unused function in ClangExpressionParser`

2016-02-19 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261328: Delete unused function in ClangExpressionParser (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D17266?vs=47980&id=48484#toc Repository: rL LLVM http://reviews.l

[Lldb-commits] [lldb] r261328 - Delete unused function in ClangExpressionParser

2016-02-19 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Fri Feb 19 08:31:41 2016 New Revision: 261328 URL: http://llvm.org/viewvc/llvm-project?rev=261328&view=rev Log: Delete unused function in ClangExpressionParser [git 65dafa83] introduced the GetBuiltinIncludePath function copied from cfe/lib/Driver/CC1Options.cpp This

[Lldb-commits] [lldb] r261345 - refactor/cleanup ClangExpressionParser::Parse

2016-02-19 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Fri Feb 19 11:55:10 2016 New Revision: 261345 URL: http://llvm.org/viewvc/llvm-project?rev=261345&view=rev Log: refactor/cleanup ClangExpressionParser::Parse This patches does the following: + fix return type: ClangExpressionParser::Parse returns unsigned, but was act

Re: [Lldb-commits] [PATCH] D17273: refactor/cleanup ClangExpressionParser::Parse

2016-02-19 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261345: refactor/cleanup ClangExpressionParser::Parse (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D17273?vs=48002&id=48507#toc Repository: rL LLVM http://reviews.llv

[Lldb-commits] [lldb] r262920 - Use c_str() instead of GetCString() to fix build

2016-03-08 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Mar 8 04:03:23 2016 New Revision: 262920 URL: http://llvm.org/viewvc/llvm-project?rev=262920&view=rev Log: Use c_str() instead of GetCString() to fix build Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp Modified: lldb/trunk/source/Interpreter

[Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-08 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: spyffe, clayborg. EwanCrawford added a subscriber: lldb-commits. EwanCrawford set the repository for this revision to rL LLVM. Fixes bugzilla ticket https://llvm.org/bugs/show_bug.cgi?id=26694 Where we can currently pick the incorre

[Lldb-commits] [lldb] r263099 - Track expression language from one place in ClangExpressionParser

2016-03-10 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Mar 10 04:31:08 2016 New Revision: 263099 URL: http://llvm.org/viewvc/llvm-project?rev=263099&view=rev Log: Track expression language from one place in ClangExpressionParser The current expression language is currently tracked in a few places within the ClangExpres

Re: [Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

2016-03-10 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263099: Track expression language from one place in ClangExpressionParser (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D17719?vs=49531&id=50253#toc Repository: rL LLVM

[Lldb-commits] [lldb] r263107 - Revert "Track expression language from one place in ClangExpressionParser"

2016-03-10 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Mar 10 06:38:55 2016 New Revision: 263107 URL: http://llvm.org/viewvc/llvm-project?rev=263107&view=rev Log: Revert "Track expression language from one place in ClangExpressionParser" r263099 seems to have broken some OSX tests Modified: lldb/trunk/source/Plugin

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-11 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. friendly ping Repository: rL LLVM http://reviews.llvm.org/D17957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Ewan Crawford via lldb-commits
EwanCrawford updated this revision to Diff 50595. EwanCrawford added a comment. Thanks for taking a look Sean. I moved the mangling logic into `LanguageCPlusPlus` and created a new method for it. There was an existing function `FindEquivalentNames` that used `CPPRuntimeEquivalents`, but looked

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-14 Thread Ewan Crawford via lldb-commits
EwanCrawford added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile:8 @@ +7,2 @@ +clean:: + rm -rf $(wildcard *.o *.d *.dSYM) labath wrote: > clayborg wrote: > > Maybe we can have a standard c

[Lldb-commits] [lldb] r263544 - Fix expression evaluation for resolving anonymous aggregrate types with a typedefed name

2016-03-15 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Mar 15 04:50:16 2016 New Revision: 263544 URL: http://llvm.org/viewvc/llvm-project?rev=263544&view=rev Log: Fix expression evaluation for resolving anonymous aggregrate types with a typedefed name This fixes a recently reported a bug(https://llvm.org/bugs/show_bug

Re: [Lldb-commits] [PATCH] D17777: Add regression test for expressions calling functions taking anonymous struct typedef arguments

2016-03-15 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263547: Add regression test for expressions calling functions taking anonymous struct… (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D1?vs=49524&id=50719#toc Reposito

[Lldb-commits] [lldb] r263547 - Add regression test for expressions calling functions taking anonymous struct typedef arguments

2016-03-15 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Mar 15 08:02:11 2016 New Revision: 263547 URL: http://llvm.org/viewvc/llvm-project?rev=263547&view=rev Log: Add regression test for expressions calling functions taking anonymous struct typedef arguments This CL adds a regression test for the bug listed at https:/

Re: [Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

2016-03-21 Thread Ewan Crawford via lldb-commits
EwanCrawford updated this revision to Diff 51182. EwanCrawford added a comment. Rebased on tip Repository: rL LLVM http://reviews.llvm.org/D17957 Files: packages/Python/lldbsuite/test/expression_command/call-overloaded-c-fuction/Makefile packages/Python/lldbsuite/test/expression_comman

[Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

2015-08-26 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus, ADodds. EwanCrawford set the repository for this revision to rL LLVM. Currently the RS breakpoint command can only find a kernel if it's in an already load

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

2015-08-28 Thread Ewan Crawford via lldb-commits
EwanCrawford updated this revision to Diff 33425. EwanCrawford added a comment. Thanks for taking a look. Previously we just tried to find a way to leverage the existing BreakpointResovlerName, and SearchFilter. However your suggestion to create a new BreakpointResolver works a lot better, and

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

2015-09-02 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. Does this address your concerns Jim? Repository: rL LLVM http://reviews.llvm.org/D12360 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r246842 - RenderScript pending kernel breakpoints.

2015-09-04 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Fri Sep 4 03:56:52 2015 New Revision: 246842 URL: http://llvm.org/viewvc/llvm-project?rev=246842&view=rev Log: RenderScript pending kernel breakpoints. Currently the RS breakpoint command can only find a kernel if it's in an already loaded RS module. This patch allows

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

2015-09-04 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246842: RenderScript pending kernel breakpoints. (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D12360?vs=33425&id=34018#toc Repository: rL LLVM http://reviews.llvm.org

[Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

2015-09-09 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus, ADodds. EwanCrawford set the repository for this revision to rL LLVM. Patch adds a command to RenderScript plugin allowing users to automatically set break

[Lldb-commits] [lldb] r247262 - New RenderScript command to break on all kernels

2015-09-10 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Thu Sep 10 05:08:48 2015 New Revision: 247262 URL: http://llvm.org/viewvc/llvm-project?rev=247262&view=rev Log: New RenderScript command to break on all kernels Patch adds a command to RenderScript plugin allowing users to automatically set breakpoints on every RS kern

Re: [Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

2015-09-10 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247262: New RenderScript command to break on all kernels (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D12728?vs=34327&id=34424#toc Repository: rL LLVM http://reviews.

[Lldb-commits] [lldb] r247782 - Add names to RenderScript kernel breakpoints.

2015-09-16 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Wed Sep 16 05:02:57 2015 New Revision: 247782 URL: http://llvm.org/viewvc/llvm-project?rev=247782&view=rev Log: Add names to RenderScript kernel breakpoints. Use Breakpoint::AddName to mark all RenderScript kernel breakpoints with the name 'RenderScriptKernel'. Also up

Re: [Lldb-commits] [PATCH] D12936: Groundwork for better tracking of renderscript allocations and scripts.

2015-09-21 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248149: Groundwork for better tracking of renderscript allocations and scripts (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D12936?vs=34996&id=35224#toc Repository: rL

[Lldb-commits] [lldb] r248149 - Groundwork for better tracking of renderscript allocations and scripts

2015-09-21 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Mon Sep 21 05:53:18 2015 New Revision: 248149 URL: http://llvm.org/viewvc/llvm-project?rev=248149&view=rev Log: Groundwork for better tracking of renderscript allocations and scripts This patch adds some of the groundwork required for tracking the lifetime of scripts a

[Lldb-commits] [lldb] r248274 - RenderScript lookup bug fix

2015-09-22 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Sep 22 08:36:35 2015 New Revision: 248274 URL: http://llvm.org/viewvc/llvm-project?rev=248274&view=rev Log: RenderScript lookup bug fix After the std::move operation the unique pointer is null. So this statement always returns a null pointer. Also remove unnecess

[Lldb-commits] [PATCH] D13247: RenderScript command for printing allocation information

2015-09-29 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: jingham, clayborg. EwanCrawford added subscribers: lldb-commits, domipheus, ADodds, dean. EwanCrawford set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer. This patch adds a new