Eric accepted this revision.
Eric added a comment.
This revision is now accepted and ready to land.
LGTM. It would also be fine to not check the language.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139461/new/
https://reviews.llvm.org/D139461
_
Eric added a comment.
Thank you for helping me with this! Do you want me to merge these changes into
my own CL or do you want to check this in yourself?
Instead of echoing into .c files, can we write the tests as .c files? It seems
to be a common pattern to use a single source as two sources by
Eric added a comment.
Would it make sense to turn the split-optimized test back into an x86 only
test, or just leave it out of the change as it's not actually testing a code
path that this changed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100
Eric added a comment.
Is arm hardware necessary to test this, or can the test be modified to
cross-compile to arm to see what is going on? Is there a way to determine what
build target the test bot is using?
In any case the broken test doesn't exercise lldb at all so it could be
separated from
