[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -132,19 +56,14 @@ void DisassembleRequestHandler::operator()( } } - lldb::SBInstructionList insts = - dap.target.ReadInstructions(addr, inst_count, flavor_string.c_str()); + lldb::SBInstructionList insts = dap.target.ReadInstructions( + addr, args.instruct

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen deleted https://github.com/llvm/llvm-project/pull/140482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140482 >From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 23:51:58 +0200 Subject: [PATCH 1/4] [lldb-dap] Migrate disassemble request to structured handler

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-19 Thread Ely Ronnen via lldb-commits
eronnen wrote: Fixed comments https://github.com/llvm/llvm-project/pull/140482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,16 @@ +#include eronnen wrote: fixed, for some reason I'm getting a warning `ISO C requires a translation unit to contain at least one declarationclang(-Wempty-translation-unit)` but I can ignore https://github.com/llvm/llvm-project/pull/139969 ___

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,55 @@ +""" +Test lldb-dap setBreakpoints request +""" + + +import dap_server +import shutil +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import line_number +from lldbsuite.test import lldbutil +import lldbdap_testcase +import os + + +class Test

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run( } } - // The line entries are sorted by addresses, but we must return the list - // ordered by line / column position. - std::sort(locations.begin(), locations.end()); - locations.erase(llvm::unique(location

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run( } } - // The line entries are sorted by addresses, but we must return the list - // ordered by line / column position. - std::sort(locations.begin(), locations.end()); - locations.erase(llvm::unique(location

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -34,26 +36,22 @@ SourceRequestHandler::Run(const protocol::SourceArguments &args) const { return llvm::make_error( "invalid arguments, expected source.sourceReference to be set"); - lldb::SBProcess process = dap.target.GetProcess(); - // Upper 32 bits is the

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen deleted https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/140482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -452,6 +475,9 @@ struct DAP { std::mutex m_active_request_mutex; const protocol::Request *m_active_request; + + llvm::StringMap m_source_breakpoints; + llvm::DenseMap m_source_assembly_breakpoints; eronnen wrote: I think it should be pretty simplifie

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -33,13 +35,42 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap, m_line(breakpoint.line), m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {} -void SourceBreakpoint::SetBreakpoint(const llvm::StringRef source_path) { +void SourceBreakpoint::SetBreak

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -955,6 +955,13 @@ def request_setBreakpoints(self, file_path, line_array, data=None): """ (dir, base) = os.path.split(file_path) source_dict = {"name": base, "path": file_path} +return self.request_setBreakpoints_with_source(source_dict, lin

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -35,29 +36,34 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap, m_line(breakpoint.line), m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {} -void SourceBreakpoint::SetBreakpoint(const protocol::Source &source) { +llvm::Error SourceBreakpoint::SetB

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140486 >From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Tue, 20 May 2025 00:47:48 +0200 Subject: [PATCH 1/2] [lldb-dap] Fix disassemble request instruction offset handling

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen ready_for_review https://github.com/llvm/llvm-project/pull/140486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/140486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-19 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/140486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -948,13 +956,11 @@ def request_scopes(self, frameId): command_dict = {"command": "scopes", "type": "request", "arguments": args_dict} return self.send_recv(command_dict) -def request_setBreakpoints(self, file_path, line_array, data=None): +def reque

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-19 Thread Ely Ronnen via lldb-commits
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run( } } - // The line entries are sorted by addresses, but we must return the list - // ordered by line / column position. - std::sort(locations.begin(), locations.end()); - locations.erase(llvm::unique(location

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -19,19 +18,50 @@ namespace lldb_dap { llvm::Expected BreakpointLocationsRequestHandler::Run( const protocol::BreakpointLocationsArguments &args) const { - std::string path = args.source.path.value_or(""); uint32_t start_line = args.line; uint32_t start_column = ar

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run( } } - return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)}; + return response_breakpoints; +} + +std::vector +SetBreakpointsRequestHandler::SetAssemblyBreakpoints( +const protocol::Source

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -53,6 +54,8 @@ class LLDB_API SBFileSpec { uint32_t GetPath(char *dst_path, size_t dst_len) const; + bool GetPath(lldb::SBStream &dst_path) const; eronnen wrote: makes sense, I was trying to avoid the potential problem of the path being longer than `M

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -219,6 +221,9 @@ struct DAP { llvm::StringSet<> modules; /// @} + /// Number of lines of assembly code to show when no debug info is available. + uint32_t number_of_assembly_lines_for_nodebug = 32; eronnen wrote: :100: https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run( } } - return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)}; + return response_breakpoints; +} + +std::vector +SetBreakpointsRequestHandler::SetAssemblyBreakpoints( +const protocol::Source

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run( } } - return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)}; + return response_breakpoints; +} + +std::vector +SetBreakpointsRequestHandler::SetAssemblyBreakpoints( +const protocol::Source

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140482 >From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 23:51:58 +0200 Subject: [PATCH] [lldb-dap] Migrate disassemble request to structured handler ---

[Lldb-commits] [lldb] [lldb-dap] Migrate disassemble request to structured handler (PR #140482)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/140482 None >From b187a83605b9c50ea5dbe7674b755bc8706c2936 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 23:51:58 +0200 Subject: [PATCH] [lldb-dap] Migrate disassemble request to structured handler

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-18 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 01/10] support assembly in BreakpointLocationsRequestHandler --- .

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-25 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/141426 Refactor code revolving source objects such that most logics will be reused. The main change is to expose a single `CreateSource(addr, target)` that can return either a normal or an assembly source object, an

[Lldb-commits] [lldb] [lldb] add missing cmake build type argument (PR #141427)

2025-05-25 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/141427 None >From 12b61db385a595f1a9028c194322cb3d3c746f3c Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 25 May 2025 22:22:34 +0200 Subject: [PATCH] [lldb] add missing cmake build type argument --- lldb/utils

[Lldb-commits] [lldb] [lldb] add missing cmake build type argument (PR #141427)

2025-05-27 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/141427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Use the default disassembly flavour if none is provided. (PR #141424)

2025-05-25 Thread Ely Ronnen via lldb-commits
@@ -2039,7 +2039,17 @@ lldb::SBInstructionList SBTarget::ReadInstructions(lldb::SBAddress base_addr, const size_t bytes_read = target_sp->ReadMemory(*addr_ptr, data.GetBytes(), data.GetByteSize(), error, force_live_memory, &load_

[Lldb-commits] [lldb] [lldb][lldb-dap] Use the default disassembly flavour if none is provided. (PR #141424)

2025-05-25 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add missing cmake build type argument (PR #141427)

2025-05-25 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen approved this pull request. https://github.com/llvm/llvm-project/pull/141537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on arm 32 architecture (PR #141407)

2025-05-25 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/141407 The test fails because LLDB does not recognize any function which is not in the symbol table on armv7 >From 27159c6f52e18bf3b11553ce380449b38689154d Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 25 May

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on arm 32 architecture (PR #141407)

2025-05-25 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-25 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen approved this pull request. https://github.com/llvm/llvm-project/pull/141122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/3] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
@@ -250,14 +252,16 @@ protocol::Source CreateSource(const lldb::SBFileSpec &file); /// Create a "Source" JSON object as described in the debug adapter definition. /// -/// \param[in] line_entry -/// The LLDB line table to use when populating out the "Source" -/// obje

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
@@ -252,4 +252,11 @@ std::string GetSBFileSpecPath(const lldb::SBFileSpec &file_spec) { return path; } +lldb::SBLineEntry GetLineEntryForAddress(lldb::SBTarget &target, + lldb::SBAddress &address) { + lldb::SBSymbolContext sc = +

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
@@ -558,28 +558,38 @@ protocol::Source CreateAssemblySource(const lldb::SBTarget &target, return source; } -bool ShouldDisplayAssemblySource( -const lldb::SBLineEntry &line_entry, -lldb::StopDisassemblyType stop_disassembly_display) { - if (stop_disassembly_display

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
@@ -317,6 +317,8 @@ struct Source { std::optional presentationHint; // unsupported keys: origin, sources, adapterData, checksums + + bool IsAssemblySource() const { return sourceReference.value_or(0) != 0; } eronnen wrote: :100: https://github.com/llvm

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-27 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/2] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
eronnen wrote: Looking at the `SBTarget::ResolveSymbolContextForAddress()` implementation it won't apply source maps correctly because it doesn't set the target to the symbol context at any point. in order to apply the source maps you must have `sc.target_sp

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
eronnen wrote: Currently I don't think it can live in lldb-dap, because both setting the target and calculating the symbol context are private: ```cpp sc.target_sp = target.GetSP(); SymbolContextItem scope = static_cast(resolve_scope); if (m_opaque_up->IsVal

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-15 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From ae324862f516ebb5be3206485476b586b22488b7 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 1/4] support assembly in BreakpointLocationsRequestHandler --- ...

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-21 Thread Ely Ronnen via lldb-commits
@@ -422,8 +431,27 @@ def wait_for_breakpoint_events(self, timeout: Optional[float] = None): if not event: break breakpoint_events.append(event) + +self._update_verified_breakpoints( eronnen wrote: :100: https:

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-21 Thread Ely Ronnen via lldb-commits
@@ -1011,7 +1042,10 @@ def request_setFunctionBreakpoints(self, names, condition=None, hitCondition=Non "type": "request", "arguments": args_dict, } -return self.send_recv(command_dict) +response = self.send_recv(command_dict) +

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-21 Thread Ely Ronnen via lldb-commits
@@ -985,7 +1013,10 @@ def request_setBreakpoints(self, file_path, line_array, data=None): "type": "request", "arguments": args_dict, } -return self.send_recv(command_dict) +response = self.send_recv(command_dict) +breakpo

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-21 Thread Ely Ronnen via lldb-commits
eronnen wrote: @medismailben Unfortunately I dont own a mac so I can't really test but I think maybe this patch should fix it: https://github.com/llvm/llvm-project/pull/140975 https://github.com/llvm/llvm-project/pull/140486 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140470 >From 5c1d1854c3f93e081405e27fa0f14a3c02ef7cc7 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 20:56:47 +0200 Subject: [PATCH 1/6] [lldb-dap] Attempt to synchronously wait for breakpoints resol

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-22 Thread Ely Ronnen via lldb-commits
eronnen wrote: @medismailben I tested locally and now the test should be fixed https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-22 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-22 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140975 >From 419aa75b4f0d3fe54a3e08c8223906224bad2822 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Thu, 22 May 2025 02:44:31 +0200 Subject: [PATCH 1/3] [lldb-dap] attempt to fix test_disassemble --- lldb/test/API/

[Lldb-commits] [lldb] [lldb-dap] attempt to fix test_disassemble (PR #140975)

2025-05-22 Thread Ely Ronnen via lldb-commits
eronnen wrote: @medismailben can you share the cmake build arguments that you use for mac? https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-22 Thread Ely Ronnen via lldb-commits
eronnen wrote: I Haven't attempted, unfortunately I only own a x64 laptop, I can attempt to reproduce on a VM later https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-21 Thread Ely Ronnen via lldb-commits
@@ -136,6 +136,7 @@ def __init__( self.initialized = False self.frame_scopes = {} self.init_commands = init_commands +self.resolved_breakpoints = set([]) eronnen wrote: :100: https://github.com/llvm/llvm-project/pull/140470 __

[Lldb-commits] [lldb] [lldb] Change synthetic symbol names to have file address (PR #138416)

2025-05-22 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/138416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on windows (PR #141212)

2025-05-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/141212 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on windows (PR #141212)

2025-05-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/141212 https://lab.llvm.org/buildbot/#/builders/141/builds/8927/steps/6/logs/stdio >From 660eeaef30c2d99f0ed571029f4f7d6783a36789 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Fri, 23 May 2025 10:44:09 +0200 Subject

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/6] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/5] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Ely Ronnen via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/7] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const lldb::SBTarget &target, return source; } -bool ShouldDisplayAssemblySource( -const lldb::SBLineEntry &line_entry, -lldb::StopDisassemblyType stop_disassembly_display) { - if (stop_disassembly_display

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -139,15 +141,16 @@ static DisassembledInstruction ConvertSBInstructionToDisassembledInstruction( disassembled_inst.instruction = std::move(instruction); - auto line_entry = addr.GetLineEntry(); + auto source = CreateSource(addr, target); + auto line_entry = GetLineEn

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,17 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const lldb::SBTarget &target, return source; } -bool ShouldDisplayAssemblySource( -const lldb::SBLineEntry &line_entry, -lldb::StopDisassemblyType stop_disassembly_display) { - if (stop_disassembly_display

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
eronnen wrote: oh, yeah I can move it https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, Breakpoints. (PR #141983)

2025-05-30 Thread Ely Ronnen via lldb-commits
eronnen wrote: @ashgti If these tests still won't be stable in the bots maybe #140470 could further stabilize them https://github.com/llvm/llvm-project/pull/141983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/8] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen deleted https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-30 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix config value comparison (PR #142017)

2025-05-29 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/142017 Fix TypeSCript comparison (when defining an empty config string like `commandEscapePrefix=""` it would skip it) >From 8632a15c5fa4a11b1a108d9b763b9241b5a2bc41 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Th

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-29 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 4c20703077eb4bbee8cfeb59022dec89d8697d83 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb] Adding const modifier to SBAddress methods (PR #142275)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/142275 I don't know if adding `const` specifier is considered breaking the API, but if not it could be useful as it allows for `lldb-dap` to change some objects to `const &` >From 85e5ac0369b3d2cb263b82912af90762545c

[Lldb-commits] [lldb] [lldb] Adding const modifier to SBAddress methods (PR #142275)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/142275 >From 7d256c09cd9dbefb35fc852450b38943f5040777 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 31 May 2025 12:30:13 +0200 Subject: [PATCH] Adding const modifier to SBAddress methods --- lldb/include/lldb/

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/140470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140470 >From 87cf6aee70458b0e9bbc717ee9a5cf9b91b6242a Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 20:56:47 +0200 Subject: [PATCH 1/8] [lldb-dap] Attempt to synchronously wait for breakpoints resol

[Lldb-commits] [lldb] fix PATH_MAX missing in windows build (PR #142259)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/142259 None >From 8f7b6fc7f4bba8b6efe7912557d98c5e9fd634c3 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 31 May 2025 09:29:01 +0200 Subject: [PATCH] fix PATH_MAX missing in windows build --- lldb/tools/lldb-d

[Lldb-commits] [lldb] [lldb] Adding const modifier to SBAddress methods (PR #142275)

2025-05-31 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/142275 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2   3   4   >