@@ -0,0 +1,10 @@
+#include
+#include
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/136494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
eronnen wrote:
@da-viper Fixed your comments, also now that the `stop-disassembly-dispaly`
setting is not cached I merged the tests to one test and verified that the
assembly changes mid-run according to the settings
https://github.com/llvm/llvm-project/pull/136494
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/137384
* Fix broken tests that use commanEscapePrefix="", in my case
`TestDAP_stackTraceMissingModule.test_missingModule`
>From c496d0ec97db4a1bcb4717afb7427648e0c371ec Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/136494
>From caf6db4c4ef8caea027bb7909a723bf24ff881ad Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 20 Apr 2025 17:07:09 +0200
Subject: [PATCH] fallback to assembly when source code is not available
fix TestDAP
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/136755
Improves the lldb-dap disassembly by showing load addresses in disassembly,
same as in a regular LLDB `disassemble` command by default.
Before:
;
- bool GetDescription(lldb_private::Stream &description);
-
+ bool GetDescription(lldb_private::Stream &description, lldb::SBFrame *fr
@@ -54,6 +54,10 @@ class LLDB_API SBInstructionList {
bool GetDescription(lldb::SBStream &description);
+ // Writes assembly instructions to `description` with load addresses using
+ // `frame`.
+ bool GetDescription(lldb::SBStream &description, lldb::SBFrame &frame);
--
eronnen wrote:
@JDevlieghere Thanks for the review! updated the API to receive
`SBExecutionContext`
https://github.com/llvm/llvm-project/pull/136755
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
eronnen wrote:
@JDevlieghere Revoled comments and added the `test_expr_completion_max_results`
test
https://github.com/llvm/llvm-project/pull/135565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/135565
>From 79e1ae6ac953ab5d3e1eb3dae75745a01d7d7a56 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 13 Apr 2025 20:46:56 +0200
Subject: [PATCH 1/2] [lldb] returning command completions up to a maximum
- Adding
eronnen wrote:
I'm not sure whether this synthetic name style is preferred by everyone, so
that's why I made it a setting and not default.
The problem it's trying to solve is that stack traces from crashes may contain
unnamed symbols from binaries without debug info, and if these unnamed symbo
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137448
>From d0d8c7e24fd7ee37f4a3678537df1e28c8318d04 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 26 Apr 2025 10:25:21 +0200
Subject: [PATCH 1/6] adding breakpoints protocol types
---
lldb/tools/lldb-dap/Pro
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137448
>From d0d8c7e24fd7ee37f4a3678537df1e28c8318d04 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 26 Apr 2025 10:25:21 +0200
Subject: [PATCH 1/6] adding breakpoints protocol types
---
lldb/tools/lldb-dap/Pro
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137426
>From af461d8721557347b823a79bb85d043c59ab8220 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 26 Apr 2025 01:22:05 +0200
Subject: [PATCH 1/2] Migrating breakpointLocations request to use typed
RequestHand
eronnen wrote:
Nice!!
https://github.com/llvm/llvm-project/pull/137694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
>From b901b71abbaac768e67913cdbc15da2337c8bb03 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 30 Apr 2025 02:00:44 +0200
Subject: [PATCH 1/4] Expose QueueThreadPlanForStepSingleInstruction function
to SBT
eronnen wrote:
Removed the version without `SBError`, but I'm not sure what to do with it in
the python test because this function is not called in the test body, so we
can't assert it
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits
eronnen wrote:
Also note that all the other `QueueThreadPlanFor*` functions still have a
version without SBError :/
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
eronnen wrote:
@felipepiovezan Thanks for noticing, I'll try to fix it soon
https://github.com/llvm/llvm-project/pull/137512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eronnen wrote:
Aperrantly I missed that searching unnamed symbols is dependant on the symbol
index at
https://github.com/llvm/llvm-project/blob/main/lldb/source/Symbol/Symtab.cpp#L668,
so changing it will require a deeper change
https://github.com/llvm/llvm-project/pull/137512
___
eronnen wrote:
Aperrantly I missed that searching unnamed symbols is dependant on the symbol
index at
https://github.com/llvm/llvm-project/blob/main/lldb/source/Symbol/Symtab.cpp#L668,
so changing it will require a deeper change
https://github.com/llvm/llvm-project/pull/137512
___
eronnen wrote:
@felipepiovezan Hopefully this should fix the problem in the macOS tests
(https://github.com/llvm/llvm-project/pull/137512#issuecomment-2846104161)
though I don't know how to trigger these tests from the PR :|
https://github.com/llvm/llvm-project/pull/138416
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/138416
* Changes the default synthetic symbol names to contain their file address
This is a new PR after the first PR (#137512) was reverted because it didn't
update the way unnamed symbols were searched in the symbol
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/138416
>From 3ec9e1962940799ab291aaa8455e6f76da02af0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 27 Apr 2025 13:48:45 +0200
Subject: [PATCH 1/4] Change ___lldb_unnamed_symbol generated names to have the
file
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/136494
>From 11e5a1b7cd10f722455efdc49adc24ed277f3dfc Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 20 Apr 2025 17:07:09 +0200
Subject: [PATCH 1/4] fallback to assembly when source code is not available
---
ll
@@ -163,6 +163,25 @@ GetEnvironmentFromArguments(const llvm::json::Object
&arguments) {
return envs;
}
+std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) {
+ std::string stop_disassembly_display = "no-debuginfo"; // default value
+ lldb::SBCommandReturnObj
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/136494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen approved this pull request.
https://github.com/llvm/llvm-project/pull/138987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137426
>From 84638973a3592411025d5294d1f0e93dddba3bf7 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 26 Apr 2025 01:22:05 +0200
Subject: [PATCH] Migrating breakpointLocations request to use typed
RequestHandler
eronnen wrote:
@felipepiovezan thanks for the temp fix, I'll try to understand the problem
soon
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
eronnen wrote:
@slydiman Seems this worker is `aarch64` so this test should be disabled after
@felipepiovezan 's fix.
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
>From 998d59c6462326874d3fcd13f4cf92290c7bf5f9 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 30 Apr 2025 02:00:44 +0200
Subject: [PATCH 1/5] Expose QueueThreadPlanForStepSingleInstruction function
to SBT
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
>From 998d59c6462326874d3fcd13f4cf92290c7bf5f9 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 30 Apr 2025 02:00:44 +0200
Subject: [PATCH 1/5] Expose QueueThreadPlanForStepSingleInstruction function
to SBT
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/137448
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/137426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen approved this pull request.
https://github.com/llvm/llvm-project/pull/139397
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137426
>From da044f5d5391f679cfbba4afc69b46dc30dc8fff Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 26 Apr 2025 01:22:05 +0200
Subject: [PATCH] Migrating breakpointLocations request to use typed
RequestHandler
eronnen wrote:
@felipepiovezan Sorry for the trouble, do you know if there's a way for me to
run the CI on arm/aarch64 before merging the PR next time?
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/138416
>From 3ec9e1962940799ab291aaa8455e6f76da02af0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 27 Apr 2025 13:48:45 +0200
Subject: [PATCH 1/6] Change ___lldb_unnamed_symbol generated names to have the
file
eronnen wrote:
@JDevlieghere thanks for taking the time to test it! I attempted to fix it but
still not sure it's good :|
https://github.com/llvm/llvm-project/pull/138416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/139969
Enable breakpints from assembly sources
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSy
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From a705fec9e42d209ff64be3588ca74567d4319361 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 1/5] support assembly in BreakpointLocationsRequestHandler
---
...
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From a705fec9e42d209ff64be3588ca74567d4319361 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 1/6] support assembly in BreakpointLocationsRequestHandler
---
...
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 1/6] support assembly in BreakpointLocationsRequestHandler
---
...
https://github.com/eronnen ready_for_review
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -349,6 +349,10 @@ class LLDB_API SBTarget {
SBError SetLabel(const char *label);
+ uint32_t GetMinimumOpcodeByteSize() const;
+
+ uint32_t GetMaximumOpcodeByteSize() const;
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/140486
__
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140486
>From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 20 May 2025 00:47:48 +0200
Subject: [PATCH 1/4] [lldb-dap] Fix disassemble request instruction offset
handling
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140486
>From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 20 May 2025 00:47:48 +0200
Subject: [PATCH 1/3] [lldb-dap] Fix disassemble request instruction offset
handling
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
eronnen wrote:
@JDevlieghere I Tried to simplify the logics as much as I can in the way you
asked, handling the case of unfixed opcode size and disassembling backwards is
still a bit complex because there is the edge case where padding is needed, but
I hope it's readable enough now.
https://g
eronnen wrote:
@JDevlieghere Fixed comments, sorry for the trouble. I'll try to pay extra
attention next time :)
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
@@ -53,6 +54,8 @@ class LLDB_API SBFileSpec {
uint32_t GetPath(char *dst_path, size_t dst_len) const;
+ bool GetPath(lldb::SBStream &dst_path) const;
eronnen wrote:
moved to LLDBUtils
https://github.com/llvm/llvm-project/pull/139969
_
https://github.com/eronnen approved this pull request.
https://github.com/llvm/llvm-project/pull/140396
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 01/14] support assembly in BreakpointLocationsRequestHandler
---
.
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 01/13] support assembly in BreakpointLocationsRequestHandler
---
.
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 01/11] support assembly in BreakpointLocationsRequestHandler
---
.
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 01/12] support assembly in BreakpointLocationsRequestHandler
---
.
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/139969
>From d6325b3f6a8602fc96ad72acecfcccda1120614d Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 10 May 2025 20:45:17 +0200
Subject: [PATCH 01/15] support assembly in BreakpointLocationsRequestHandler
---
.
https://github.com/eronnen approved this pull request.
https://github.com/llvm/llvm-project/pull/140393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/140470
Attempt to improve tests by synchronously waiting for breakpoints to resolve.
Not sure if it will fix all the tests but I think it should make the tests more
stable
>From 0bb463172bdabe20e08f743107906bce424c4b
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 542fd2a828a2ed64b23b91c84e444f56e650ad20 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/2] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
@@ -60,7 +60,7 @@
namespace lldb_dap {
-typedef llvm::DenseMap, SourceBreakpoint>
+typedef std::map, SourceBreakpoint>
eronnen wrote:
changed to `std::map` because I'm not sure how to remove from the map while
iterating it with `DenseMap`
https://github.c
@@ -19,19 +18,50 @@ namespace lldb_dap {
llvm::Expected
BreakpointLocationsRequestHandler::Run(
const protocol::BreakpointLocationsArguments &args) const {
- std::string path = args.source.path.value_or("");
uint32_t start_line = args.line;
uint32_t start_column = ar
@@ -73,7 +87,64 @@ SetBreakpointsRequestHandler::Run(
}
}
- return protocol::SetBreakpointsResponseBody{std::move(response_breakpoints)};
+ return response_breakpoints;
+}
+
+std::vector
+SetBreakpointsRequestHandler::SetAssemblyBreakpoints(
+const protocol::Source
@@ -71,22 +101,26 @@ BreakpointLocationsRequestHandler::Run(
locations.emplace_back(line, column);
}
}
+}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/140852
Fix https://lab.llvm.org/buildbot/#/builders/141/builds/8867
>From cb69d50e158d9197b6e0fdb997de0086da1b8afa Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 08:09:23 +0200
Subject: [PATCH] add @
@@ -78,8 +84,40 @@ def set_function_breakpoints(self, functions,
condition=None, hitCondition=None)
breakpoint_ids = []
for breakpoint in breakpoints:
breakpoint_ids.append("%i" % (breakpoint["id"]))
+if wait_for_resolve:
+self.w
@@ -1187,15 +1187,17 @@ def request_locations(self, locationReference):
}
return self.send_recv(command_dict)
-def request_testGetTargetBreakpoints(self):
+def request_testGetTargetBreakpoints(self, only_resolved=False):
eronnen wrote:
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/3] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/4] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/5] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
@@ -62,9 +64,13 @@ def set_source_breakpoints(self, source_path, lines,
data=None):
breakpoint_ids = []
for breakpoint in breakpoints:
breakpoint_ids.append("%i" % (breakpoint["id"]))
+if wait_for_resolve:
+self.wait_for_breakpoi
@@ -45,20 +43,34 @@ def run_test_evaluate_expressions(
enableAutoVariableSummaries=enableAutoVariableSummaries,
)
source = "main.cpp"
-self.set_source_breakpoints(
-source,
-[
-line_number(source, "// b
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/140486
None
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/2] [lldb-dap] Migrate disassemble request to structured
han
@@ -627,6 +627,60 @@ struct InstructionBreakpoint {
bool fromJSON(const llvm::json::Value &, InstructionBreakpoint &,
llvm::json::Path);
+/// Properties of a single disassembled instruction, returned by `disassemble`
+/// request.
+struct DisassembledInstruction
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/140482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140482
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/2] [lldb-dap] Migrate disassemble request to structured
handler
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140482
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/3] [lldb-dap] Migrate disassemble request to structured
handler
@@ -627,6 +627,60 @@ struct InstructionBreakpoint {
bool fromJSON(const llvm::json::Value &, InstructionBreakpoint &,
llvm::json::Path);
+/// Properties of a single disassembled instruction, returned by `disassemble`
+/// request.
+struct DisassembledInstruction
@@ -78,8 +84,40 @@ def set_function_breakpoints(self, functions,
condition=None, hitCondition=None)
breakpoint_ids = []
for breakpoint in breakpoints:
breakpoint_ids.append("%i" % (breakpoint["id"]))
+if wait_for_resolve:
+self.w
@@ -782,4 +785,89 @@ bool fromJSON(const llvm::json::Value &Params,
InstructionBreakpoint &IB,
O.mapOptional("mode", IB.mode);
}
+bool fromJSON(const llvm::json::Value &Params,
+ DisassembledInstruction::PresentationHint &PH,
+ llvm::json::P
@@ -1187,15 +1187,17 @@ def request_locations(self, locationReference):
}
return self.send_recv(command_dict)
-def request_testGetTargetBreakpoints(self):
+def request_testGetTargetBreakpoints(self, only_resolved=False):
eronnen wrote:
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140482
>From 1014235896b79eb4ea05a6822714a66adaa691ac Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 23:51:58 +0200
Subject: [PATCH 1/3] [lldb-dap] Migrate disassemble request to structured
handler
101 - 200 of 308 matches
Mail list logo
