efriedma added a comment.
A couple notes skimming the changes:
1. If you're going to update URLs, please verify the new URLs are actually
valid.
2. Some of the "URLs" you're updating aren't actually URLs. For example, the
`xmlns` attribute in SVG files must be the exact string written in the
s
efriedma added inline comments.
Comment at: polly/lib/External/isl/interface/extract_interface.cc:590
delete Clang;
- llvm::llvm_shutdown();
nhaehnle wrote:
> Meinersbur wrote:
> > This file is imported from the upstream project
> > (https://repo
efriedma added inline comments.
Comment at: clang/lib/AST/ItaniumMangle.cpp:4579
+ if (CE->hasAPValueResult())
+mangleValueInTemplateArg(ParamType, CE->getResultAsAPValue(), false,
+ /*NeedExactType=*/true);
I'm not su
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf8499d5709e3: Emit the correct flags for the PROC CodeView
Debug Symbol (authored by dpaoliello, committed by efriedma).
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Changed prio
efriedma added inline comments.
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555
-Demangler D = Demangler(MangledName);
-MangledName = D.parseMangle(&Demangled);
+Demangler D(MangledName.data());
+const char *M = D.parseMangle(&Demangled);
Is
efriedma added a comment.
Looks right, generally.
Comment at: llvm/include/llvm-c/Core.h:163
+ * value of enum variants after the removal of LLVMVectorTypeKind
+ */
+ LLVMMetadataTypeKind = LLVMPointerTypeKind + 2, /**< Metadata */
The C API is officially
