[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

2022-07-08 Thread Douglas Yung via Phabricator via lldb-commits
dyung added subscribers: Orlando, dyung. dyung added a comment. Hi @zequanwu, your change is causing a test failure in the cross-project-test suite on the PS4 linux bot. Can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/217/builds/7945 a

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

2022-08-06 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. Your change is causing a build failure on the PS4 linux build bot using GCC 9.3. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/26186 FAILED: tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SignalHandlerCh

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

2022-08-07 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. We are seeing an additional failure on an internal linux bot due to the change to using C++17 by default when using GNU ld: [3/7] Generating GwpAsan-x86_64-Test FAILED: projects/compiler-rt/lib/gwp_asan/tests/GwpAsan-x86_64-Test cd /home/jenkins/j/w/workspace/opens

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

2023-04-25 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. Hi @mib, your change is causing a build failure on two build bots, can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/217/builds/20430 https://lab.llvm.org/buildbot/#/builders/243/builds/5438 Repository: rG LLVM Git

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

2023-04-25 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. In D145295#4297347 , @mib wrote: > In D145295#4297322 , @mib wrote: > >> In D145295#4297312 , @dyung wrote: >> >>> Hi @mib, your change is causing a

[Lldb-commits] [PATCH] D149397: Host: generalise `GetXcodeSDKPath`

2023-04-30 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. I’m also seeing this fail on 2 buildbots: https://lab.llvm.org/buildbot/#/builders/217/builds/20568 https://lab.llvm.org/buildbot/#/builders/243/builds/5576 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149397/new/ https://r

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-17 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. I'm not really sure where else to post this, but the pre-merge linux bot still seems to be running 3.18.4. https://buildkite.com/llvm-project/premerge-checks/builds/152678#018828d2-1837-4fc2-baec-fca595969219 CMake Error at CMakeLists.txt:3 (cmake_minimum_required):

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

2022-09-16 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. @Michael137, your change is causing cmake to fail on one of our bots: https://lab.llvm.org/buildbot/#/builders/217/builds/11819 CMake Error at cmake/modules/AddLLVM.cmake:1867 (add_custom_target): add_custom_target cannot create target "check-lldb-api-lang-cpp-gm

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

2022-09-16 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. In D133876#3796923 , @Michael137 wrote: > In D133876#3796847 , @dyung wrote: > >> @Michael137, your change is causing cmake to fail on one of our bots: >> >> https://lab.llvm.org/buildbot/#

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

2022-09-16 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. In D133876#3797145 , @Michael137 wrote: > In D133876#3797098 , @dyung wrote: > >> In D133876#3796923 , @Michael137 >> wrote: >> >>> In D133876#379

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

2022-11-19 Thread Douglas Yung via Phabricator via lldb-commits
dyung added a comment. This seems to have broken the cross-project-test buildbot as well: https://lab.llvm.org/buildbot/#/builders/217/builds/15302 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134033/new/ https://reviews.llvm.org/D134033 ___