[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff created this revision. dschuff added reviewers: aheejin, sbc100. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google. Herald added a reviewer: jhenderson. Herald added a project: All. dschuff requested review of this revision. Herald added subscrib

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -// name and objcopy won't be

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff updated this revision to Diff 434647. dschuff added a comment. - review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127164/new/ https://reviews.llvm.org/D127164 Files: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp l

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff added inline comments. Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:256 + WASM_SEC_TAG = 13, // Tag declarations + WASM_SEC_LAST_KNOWN = 14,// Update this when adding new sections }; aheejin wrote: > - Does this pass clang-format? Because we

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff updated this revision to Diff 434650. dschuff added a comment. - expand comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127164/new/ https://reviews.llvm.org/D127164 Files: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp ll

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -// name and objcopy won't be

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -// name and objcopy won't be

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae385e560a6: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC] (authored by dschuff). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D86090: Make DWARFExpression::GetLocationExpression public

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e266eaf132f: Make DWARFExpression::GetLocationExpression public (authored by Eric, committed by dschuff). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D82121: Set appropriate host defines for building under emscripten

dschuff created this revision. Herald added subscribers: llvm-commits, lldb-commits, aheejin, krytarowski. Herald added projects: LLDB, LLVM. Emscripten has emulations for several headers found on Linux, including spwan.h and endian.h Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[Lldb-commits] [PATCH] D82121: Set appropriate host defines for building under emscripten

dschuff added a reviewer: JDevlieghere. dschuff added a comment. Just taking a guess on a reviewer... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82121/new/ https://reviews.llvm.org/D82121 ___ lldb-c

[Lldb-commits] [PATCH] D82121: Set appropriate host defines for building under emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1709e5d90e6: Set appropriate host defines for building under emscripten (authored by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82121/new/ htt

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bafceced6a7: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging (authored by paolosev, committed by dschuff). Changed prior to commit: https://reviews.llvm.org/D71575?vs=238168&id=238391#toc R

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b3254dbf9f6: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging (authored by paolosev, committed by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec28da6d643: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging (authored by paolosev, committed by dschuff). Changed prior to commit: https://reviews.llvm.org/D72751?vs=242733&id=242754

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

dschuff added a comment. My bad, sorry about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

dschuff added a comment. fixed in rGf5f70d1c8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 ___