Author: davide
Date: Mon Sep 4 14:21:12 2017
New Revision: 312501
URL: http://llvm.org/viewvc/llvm-project?rev=312501&view=rev
Log:
[ABI] Rewrite RegisterIsCalleeSaved.
The goal of this patch is twofold:
First, it removes a wrong comment (at least, not correctly describing
what the function does
On Tue, Sep 5, 2017 at 1:23 PM, Jason Molenda wrote:
> Hi Davide, sorry I was offline for this discussion.
>
> I was a little curious about llvm::StringSwitch, I hadn't seen it before. Is
> it creating std::string's for all of these strings, then memcmp'ing the
> contents? Greg originally wrot
On Tue, Sep 5, 2017 at 2:03 PM, Jason Molenda wrote:
>
>
>> On Sep 5, 2017, at 1:34 PM, Davide Italiano wrote:
>>
>> On Tue, Sep 5, 2017 at 1:23 PM, Jason Molenda wrote:
>>> Hi Davide, sorry I was offline for this discussion.
>>>
>>> I was a little curious about llvm::StringSwitch, I hadn't seen
Author: davide
Date: Sat Sep 30 14:16:56 2017
New Revision: 314602
URL: http://llvm.org/viewvc/llvm-project?rev=314602&view=rev
Log:
[ExpressionParser] Prefer isa<> to dyn_cast<>. NFCI.
The result type is unused anyway.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressi
Author: davide
Date: Sat Sep 30 14:30:41 2017
New Revision: 314604
URL: http://llvm.org/viewvc/llvm-project?rev=314604&view=rev
Log:
[lldb-mi] Add a default case to placate GCC with -Werror.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp
Modified: lldb/trunk/tools/lldb-
Author: davide
Date: Sat Sep 30 14:52:31 2017
New Revision: 314606
URL: http://llvm.org/viewvc/llvm-project?rev=314606&view=rev
Log:
[lldb-mi] Fix a thinko in my previous commit.
Hopefully this should unbreak the Android buildbot.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebuggerHandleEve
Author: davide
Date: Sun Oct 8 17:11:49 2017
New Revision: 315199
URL: http://llvm.org/viewvc/llvm-project?rev=315199&view=rev
Log:
[SymbolFile/DWARF] Simplify two functions. NFCI.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
Modified: lldb/trunk/source/Plugins/SymbolFi
Author: davide
Date: Sun Oct 8 17:18:45 2017
New Revision: 315200
URL: http://llvm.org/viewvc/llvm-project?rev=315200&view=rev
Log:
[DWARFDIE] Rewrite `operator !=` using `operator ==`. NFCI.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
Modified: lldb/trunk/source/Plugi
Author: davide
Date: Mon Oct 23 10:51:22 2017
New Revision: 316355
URL: http://llvm.org/viewvc/llvm-project?rev=316355&view=rev
Log:
[lldbtest] Simplify removing an unneeded else. NFCI.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Python/lldbs
Author: davide
Date: Mon Oct 23 16:14:17 2017
New Revision: 316390
URL: http://llvm.org/viewvc/llvm-project?rev=316390&view=rev
Log:
[Symbol] Remove dead code. NFCI.
Modified:
lldb/trunk/source/Symbol/Symtab.cpp
Modified: lldb/trunk/source/Symbol/Symtab.cpp
URL:
http://llvm.org/viewvc/llvm-
Author: davide
Date: Mon Oct 23 16:17:53 2017
New Revision: 316393
URL: http://llvm.org/viewvc/llvm-project?rev=316393&view=rev
Log:
[lldbtests] Handle errors instead of crashing.
If you pass an invalid compiler/debugger path on the cmdline to `dotest.py`
this is what you get.
Traceback (mos
HI, I'm a little curious of what bot this breaks.
FWIW, I don't think the bot should rely on this behaviour, and more
importantly, I haven't received any failmail.
Thanks,
--
Davide
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
(and thanks for reverting, BTW :)
On Tue, Oct 24, 2017 at 9:10 AM, Davide Italiano wrote:
> HI, I'm a little curious of what bot this breaks.
> FWIW, I don't think the bot should rely on this behaviour, and more
> importantly, I haven't received any failmail.
>
> Thanks,
>
> --
> Davide
_
On Tue, Oct 24, 2017 at 9:12 AM, Zachary Turner via lldb-commits
wrote:
> I think there's something like lit.util.which(), or a similar function in
> lldb test utilities. Seems like we could solve this by writing the
> function:
>
> ```
> def is_exe(fpath):
>if not os.path.exists(fpath):
>
On Tue, Oct 24, 2017 at 9:25 AM, Pavel Labath wrote:
> The breaking build is this one: <
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14775>
>
> The blame email was sent (I know because I got it, as I also had a
> commit in the same build). Is it possible you overlooke
Fun fact, there are 13 implementations in tree of is_exe (and probably
which). Maybe we should try replacing all them with the one from lit?
Or is there some hidden dependency I'm missing?
[davide@cupiditate lldb]$ grep -R 'def is_exe' *
packages/Python/lldbsuite/test/dotest.py:def is_exe(fpath):
Reported https://bugs.llvm.org/show_bug.cgi?id=35061 so I don't forget.
On Tue, Oct 24, 2017 at 9:35 AM, Zachary Turner wrote:
> Actually there's fewer, I think `test/testcases` is a symlink. But there's
> more than one, for sure. We should standardize on the one in lldbutil.py
>
> On Tue, Oct
Author: davide
Date: Tue Oct 24 16:29:01 2017
New Revision: 316529
URL: http://llvm.org/viewvc/llvm-project?rev=316529&view=rev
Log:
[ExpressionParser] Garbage-collect dead code. NFCI.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp
Modified:
lldb/trunk/s
Author: davide
Date: Tue Oct 24 16:31:53 2017
New Revision: 316530
URL: http://llvm.org/viewvc/llvm-project?rev=316530&view=rev
Log:
[FreeBSD] Remove more dead code. NFCI.
Modified:
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
Modified: lldb/trunk/source/Plugins/Process/FreeB
On Thu, Oct 26, 2017 at 10:04 AM, Stephane Sezer via lldb-commits
wrote:
> Author: sas
> Date: Thu Oct 26 10:04:20 2017
> New Revision: 316673
>
> URL: http://llvm.org/viewvc/llvm-project?rev=316673&view=rev
> Log:
> Allow SysV-i386 ABI on everything other than Apple targets
>
> Summary:
> This ma
On Thu, Oct 26, 2017 at 12:39 PM, Stephane Sezer wrote:
> This changes nothing except for 32bit Windows, which used to not be able to
> benefit from ABISysV_i386 but can use it now. The ABI support is tested
> independently from Windows itself.
>
Sure, makes sense. I guess we should still be able
On Thu, Oct 26, 2017 at 3:04 PM, Jason Molenda wrote:
>
>
>> On Oct 26, 2017, at 10:24 AM, Davide Italiano via lldb-commits
>> wrote:
>>
>> On Thu, Oct 26, 2017 at 10:04 AM, Stephane Sezer via lldb-commits
>> wrote:
>>> Author: sas
>>> D
Author: davide
Date: Fri Oct 27 14:22:57 2017
New Revision: 316800
URL: http://llvm.org/viewvc/llvm-project?rev=316800&view=rev
Log:
[CMake] Build clang as dependency when using in-tree clang for tests.
Discussed with Zachary Turner and Pavel Labath on lldb-dev.
Let's hope this doesn't break anyt
On Tue, Oct 31, 2017 at 8:59 AM, Greg Clayton via lldb-commits
wrote:
> My takeaway is a bug was added that wasn't previously a bug. If code was
> designed to carefully use StringRef, then yes, it can be made safe. But we
> added StringRef support in all of LLDB and we didn't catch all of the
> po
Author: davide
Date: Wed Nov 1 16:46:21 2017
New Revision: 317143
URL: http://llvm.org/viewvc/llvm-project?rev=317143&view=rev
Log:
[Interpreter] Remove unused variable usage. NFCI.
Modified:
lldb/trunk/source/Interpreter/OptionValueDictionary.cpp
Modified: lldb/trunk/source/Interpreter/Opt
Author: davide
Date: Wed Nov 1 16:48:07 2017
New Revision: 317144
URL: http://llvm.org/viewvc/llvm-project?rev=317144&view=rev
Log:
[XML] Simplify lambda removing unused capture. NFCI.
Modified:
lldb/trunk/source/Host/common/XML.cpp
Modified: lldb/trunk/source/Host/common/XML.cpp
URL:
http
Author: davide
Date: Wed Nov 1 16:49:23 2017
New Revision: 317145
URL: http://llvm.org/viewvc/llvm-project?rev=317145&view=rev
Log:
[Core] Comparison for unsigned >= 0 is redundant. NFCI.
Modified:
lldb/trunk/source/Core/ArchSpec.cpp
Modified: lldb/trunk/source/Core/ArchSpec.cpp
URL:
http:
Author: davide
Date: Wed Jan 9 14:52:47 2019
New Revision: 350769
URL: http://llvm.org/viewvc/llvm-project?rev=350769&view=rev
Log:
[Python] Update PyString_FromString() to work for python 2 and 3.
Reviewers: aprantl, JDevlieghere, friss, zturner
Subscribers: lldb-commits
Differential Revision
Author: davide
Date: Wed Jan 9 17:15:18 2019
New Revision: 350788
URL: http://llvm.org/viewvc/llvm-project?rev=350788&view=rev
Log:
[Python] Update checkDsymForUUIDIsOn to be compatible with Python 3.
Summary:
In python 2, strings and bytes are the same, but they're not in
python 3, hence the re
Author: davide
Date: Thu Jan 17 13:57:33 2019
New Revision: 351486
URL: http://llvm.org/viewvc/llvm-project?rev=351486&view=rev
Log:
[lit] Make sure tests are actually skipped on darwin and windows.
Modified:
lldb/trunk/lit/Expr/TestIRMemoryMap.test
lldb/trunk/lit/Quit/TestQuitExitCode-30
Author: davide
Date: Thu Jan 24 12:55:12 2019
New Revision: 352103
URL: http://llvm.org/viewvc/llvm-project?rev=352103&view=rev
Log:
[Scalar] Clarify the constructor from APInt and document through a test.
I want to add 512-bits support but I first want to make sure I'm
not breaking anything obvi
Nice!
On Thu, Jan 24, 2019 at 7:01 PM Jason Molenda via lldb-commits
wrote:
>
> Author: jmolenda
> Date: Thu Jan 24 19:01:48 2019
> New Revision: 352158
>
> URL: http://llvm.org/viewvc/llvm-project?rev=352158&view=rev
> Log:
> Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress
> when
Author: davide
Date: Wed Jan 30 10:05:36 2019
New Revision: 352639
URL: http://llvm.org/viewvc/llvm-project?rev=352639&view=rev
Log:
[Scalar] Implement support for 512-bit values.
(useful, e.g. when reading 512-bits registers, a-la AVX-512).
Modified:
lldb/trunk/include/lldb/Utility/Scalar
Author: davide
Date: Wed Jan 30 10:24:16 2019
New Revision: 352641
URL: http://llvm.org/viewvc/llvm-project?rev=352641&view=rev
Log:
[Scalar] Hoist a duplicated (and sometimes wrong) comment.
Pointed out by Zachary and Adrian.
Modified:
lldb/trunk/source/Utility/Scalar.cpp
Modified: lldb/tr
Author: davide
Date: Wed Jan 30 10:40:05 2019
New Revision: 352643
URL: http://llvm.org/viewvc/llvm-project?rev=352643&view=rev
Log:
[Scalar] Remove partially wrong and unused functions.
I originally thought about fixing them, but hey, nobody is
using them anyway.
Modified:
lldb/trunk/includ
On Wed, Jan 30, 2019 at 10:53 AM Zachary Turner wrote:
>
> Oh I guess because one of them has const values? Oh well, ignore my
> suggestion then :)
>
I think so. Too bad, it would've been a nice cleanup :)
--
Davide
___
lldb-commits mailing list
lldb
Author: davide
Date: Wed Jan 30 16:11:33 2019
New Revision: 352701
URL: http://llvm.org/viewvc/llvm-project?rev=352701&view=rev
Log:
[Python] String(s) and bytes are two different entities in 3.7.
So, we need an explicit call to decode() here to let it work with
both interpreters. Fixes TestXMMRe
On Wed, Jan 30, 2019 at 4:11 PM Davide Italiano via lldb-commits
wrote:
>
> Author: davide
> Date: Wed Jan 30 16:11:33 2019
> New Revision: 352701
>
> URL: http://llvm.org/viewvc/llvm-project?rev=352701&view=rev
> Log:
> [Python] String(s) and bytes are two different
Author: davide
Date: Wed Jan 30 16:43:36 2019
New Revision: 352706
URL: http://llvm.org/viewvc/llvm-project?rev=352706&view=rev
Log:
[Python] Python 2 and Python 3 disagree on `/`.
One considers it integer division, the other doesn't.
Move to `//` (floor division) so that this test passes
indepen
Author: davide
Date: Wed Jan 30 17:01:53 2019
New Revision: 352709
URL: http://llvm.org/viewvc/llvm-project?rev=352709&view=rev
Log:
[Python] Fix gdb-remote and lldb-server utilities to work with Py3.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
Author: davide
Date: Wed Jan 30 17:17:47 2019
New Revision: 352710
URL: http://llvm.org/viewvc/llvm-project?rev=352710&view=rev
Log:
[testsuite] Fix TestAppleSimulator so that it works with Python 3.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
lldb/trunk/packages/Py
On Thu, Jan 31, 2019 at 10:48 AM Jonas Devlieghere via lldb-commits
wrote:
>
> Author: jdevlieghere
> Date: Thu Jan 31 10:48:17 2019
> New Revision: 352780
>
> URL: http://llvm.org/viewvc/llvm-project?rev=352780&view=rev
> Log:
> [unittest] Fix scalar unit test.
>
> The test was using ASSERT_EQ in
Author: davide
Date: Mon Feb 4 16:59:57 2019
New Revision: 353130
URL: http://llvm.org/viewvc/llvm-project?rev=353130&view=rev
Log:
[Python2 to Python 3] Fix print -> print().
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.p
Author: davide
Date: Tue Feb 5 09:30:53 2019
New Revision: 353191
URL: http://llvm.org/viewvc/llvm-project?rev=353191&view=rev
Log:
[Obj-C] Fix undefined behaviour(s) in the new NSTaggedDate formatter.
Type punning through a union -> no good.
double to uint64 to double again -> no good either.
Shafik, Zachary, I think you reported this a bit ago, but now I got
around to fix it (also because it was breaking something real).
Thanks,
--
Davide
On Tue, Feb 5, 2019 at 9:30 AM Davide Italiano via lldb-commits
wrote:
>
> Author: davide
> Date: Tue Feb 5 09:30:53 2019
>
it ago, but now I got
> around to fix it (also because it was breaking something real).
>
> Thanks,
>
> --
> Davide
>
> On Tue, Feb 5, 2019 at 9:30 AM Davide Italiano via lldb-commits
> wrote:
> >
> > Author: davide
> > Date: Tue Feb 5 09:30:53 20
Author: davide
Date: Tue Feb 5 14:24:53 2019
New Revision: 353226
URL: http://llvm.org/viewvc/llvm-project?rev=353226&view=rev
Log:
[Py3/TestAppleOSSimulator] Another byte<->str interoperability issue.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/TestAppleSimulatorO
Author: davide
Date: Wed Feb 6 13:48:01 2019
New Revision: 353345
URL: http://llvm.org/viewvc/llvm-project?rev=353345&view=rev
Log:
[testsuite] Convert a pexpect test to lit.
Summary:
Reviewers: JDevlieghere, friss, zturner, labath, jingham, serge-sans-paille
Subscribers: llvm-commits, lldb-co
Author: davide
Date: Tue Feb 12 14:57:57 2019
New Revision: 353894
URL: http://llvm.org/viewvc/llvm-project?rev=353894&view=rev
Log:
[testsuite] Convert TestSingleQuote to lit.
Nothing crazy, this is pretty mechanical.
Added:
lldb/trunk/lit/Driver/Inputs/hello.c
lldb/trunk/lit/Driver/Tes
Author: davide
Date: Tue Feb 12 15:02:53 2019
New Revision: 353896
URL: http://llvm.org/viewvc/llvm-project?rev=353896&view=rev
Log:
[testsuite] Add a comment explaining what this test does.
Modified:
lldb/trunk/lit/Driver/TestSingleQuote.test
Modified: lldb/trunk/lit/Driver/TestSingleQuote.
Author: davide
Date: Fri Feb 15 13:55:29 2019
New Revision: 354177
URL: http://llvm.org/viewvc/llvm-project?rev=354177&view=rev
Log:
Revert "Don't include UnixSignals.h from Host."
It broke the modules green dragon buildbot.
Modified:
lldb/trunk/include/lldb/Host/Host.h
lldb/trunk/includ
On Fri, Feb 15, 2019 at 4:12 PM Richard Smith via lldb-commits
wrote:
>
> Author: rsmith
> Date: Fri Feb 15 16:13:26 2019
> New Revision: 354185
>
> URL: http://llvm.org/viewvc/llvm-project?rev=354185&view=rev
> Log:
> Temporarily disable test:
>
> test/lang/cpp/class-template-parameter-pack/TestC
Author: davide
Date: Sat Feb 16 09:16:53 2019
New Revision: 354204
URL: http://llvm.org/viewvc/llvm-project?rev=354204&view=rev
Log:
[testsuite] Skip this test correctly also on macOS.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplat
Author: davide
Date: Mon Feb 18 13:53:02 2019
New Revision: 354286
URL: http://llvm.org/viewvc/llvm-project?rev=354286&view=rev
Log:
[Python3] Fix TestObjCMethods.py to work with py2 and 3.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods.py
Modified:
Author: davide
Date: Mon Feb 18 15:18:14 2019
New Revision: 354297
URL: http://llvm.org/viewvc/llvm-project?rev=354297&view=rev
Log:
[lldbtest] Fix some code to be compatible between py2 and py3.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Py
Author: davide
Date: Tue Feb 19 16:54:10 2019
New Revision: 354415
URL: http://llvm.org/viewvc/llvm-project?rev=354415&view=rev
Log:
[lldbtest] Remove some accidentally commented out code.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Python/ll
Author: davide
Date: Tue Feb 19 16:54:07 2019
New Revision: 354414
URL: http://llvm.org/viewvc/llvm-project?rev=354414&view=rev
Log:
[testsuite] Fix TestUnicodeString to work with Py2 and Py3.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbinline.py
Modified: lldb/trunk/packages/Pyt
This broke the bots, link:
http://green.lab.llvm.org/green/job/lldb-cmake/20047/
Can you please take a look and see what's needed to fix (and revert otherwise)?
Thanks
On Wed, Feb 20, 2019 at 6:30 AM Michal Gorny via lldb-commits
wrote:
>
> Author: mgorny
> Date: Wed Feb 20 06:31:06 2019
> New
The bot is now green, thanks for your fix!
On Wed, Feb 20, 2019 at 9:10 AM Michał Górny wrote:
>
> On Wed, 2019-02-20 at 08:39 -0800, Davide Italiano wrote:
> > This broke the bots, link:
> >
> > http://green.lab.llvm.org/green/job/lldb-cmake/20047/
> >
> > Can you please take a look and see what
Author: davide
Date: Wed Feb 20 10:27:29 2019
New Revision: 354494
URL: http://llvm.org/viewvc/llvm-project?rev=354494&view=rev
Log:
[lldb-mi] Remove a test that uses pexpect().
Summary:
Its functionality is entirely covered by exec-run.test (which
doesn't use pexpect)
Reviewers: serge-sans-pail
Author: davide
Date: Wed Feb 20 11:25:12 2019
New Revision: 354506
URL: http://llvm.org/viewvc/llvm-project?rev=354506&view=rev
Log:
[lldb-mi] Move TestMIPrompt away from pexpect().
Added:
lldb/trunk/lit/tools/lldb-mi/breakpoint/break-main.test
Removed:
lldb/trunk/packages/Python/lldbsuit
Author: davide
Date: Wed Feb 20 17:55:31 2019
New Revision: 354540
URL: http://llvm.org/viewvc/llvm-project?rev=354540&view=rev
Log:
Revert "[lldb-mi] Move TestMIPrompt away from pexpect()."
I see a test failing on the macOS bots. I can't reproduce
locally, so try to get the bots green before I c
Tatyana, this commit broke one of the bots:
Testing Time: 315.65s
Failing Tests (1):
LLDB :: Minidump/dump-all.test
Expected Passes: 1466
Unsupported Tests : 64
Unexpected Failures: 1
I'm a little confused if I look at it because it modifies heavily a
test bu
Link to the failure:
http://green.lab.llvm.org/green/job/lldb-cmake//20543/console
On Tue, Feb 26, 2019 at 8:04 AM Davide Italiano wrote:
>
> Tatyana, this commit broke one of the bots:
>
> Testing Time: 315.65s
>
> Failing Tests (1):
> LLDB :: Minidump/dump-all.test
>
>
lldb: unrecognized option `--C'
error: unknown or ambiguous option
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm/tools/lldb/lit/Minidump/dump-all.test:55:13:
error: CHECKCPU: expected string not found in input
this seems to be the issue. Can you give another shot at fixing this
or reverting?
Looks like it's green now.
Thanks!
On Tue, Feb 26, 2019 at 8:32 AM Tatyana Krasnukha
wrote:
>
> This was fixed with r354890 ->
> http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20544/
> Do you still have the issue?
>
> -Original Message-
> From: Davide Italiano
> Sent: Tuesda
On Thu, Feb 28, 2019 at 8:25 AM Raphael Isemann via lldb-commits
wrote:
>
> Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via
> lldb-commits :
> >
> > On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote:
> > > On 28/02/2019 02:37, Davide Italiano via Phabricator wrote:
> > >> davide
On Thu, Feb 28, 2019 at 10:31 AM Davide Italiano wrote:
>
> On Thu, Feb 28, 2019 at 8:25 AM Raphael Isemann via lldb-commits
> wrote:
> >
> > Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via
> > lldb-commits :
> > >
> > > On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote:
> > >
If I add:
diff --git a/lldb/source/Host/common/MainLoop.cpp
b/lldb/source/Host/common/MainLoop.cpp
index a4803936196..4fee76865ee 100644
--- a/lldb/source/Host/common/MainLoop.cpp
+++ b/lldb/source/Host/common/MainLoop.cpp
@@ -23,6 +23,8 @@
// (ppoll is present but not implemented properly). On w
On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano wrote:
>
> If I add:
>
> diff --git a/lldb/source/Host/common/MainLoop.cpp
> b/lldb/source/Host/common/MainLoop.cpp
> index a4803936196..4fee76865ee 100644
> --- a/lldb/source/Host/common/MainLoop.cpp
> +++ b/lldb/source/Host/common/MainLoop.cpp
> @
On Thu, Feb 28, 2019 at 11:21 AM Davide Italiano wrote:
>
> On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano
> wrote:
> >
> > If I add:
> >
> > diff --git a/lldb/source/Host/common/MainLoop.cpp
> > b/lldb/source/Host/common/MainLoop.cpp
> > index a4803936196..4fee76865ee 100644
> > --- a/lldb/so
Author: davide
Date: Mon Mar 4 16:37:40 2019
New Revision: 355353
URL: http://llvm.org/viewvc/llvm-project?rev=355353&view=rev
Log:
[Host] Fix the build (and the modules build).
-> Add a missing include to find the base class.
-> Add a missing out-of-line declaration for a member function.
Modi
Author: davide
Date: Mon Mar 4 16:47:15 2019
New Revision: 355356
URL: http://llvm.org/viewvc/llvm-project?rev=355356&view=rev
Log:
[lldbtest] Check against the correct name for libcxxabi (macOS).
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/
Author: davide
Date: Mon Mar 4 16:53:38 2019
New Revision: 355359
URL: http://llvm.org/viewvc/llvm-project?rev=355359&view=rev
Log:
[testsuite] Port crashlog and dependencies to Python 3.
Fixes three tests in the testsuite.
Modified:
lldb/trunk/examples/darwin/heap_find/heap.py
lldb/tru
Author: davide
Date: Mon Mar 4 17:34:47 2019
New Revision: 355364
URL: http://llvm.org/viewvc/llvm-project?rev=355364&view=rev
Log:
Revert "[testsuite] Port crashlog and dependencies to Python 3."
This revert the commit because it broke the bots. I need to find
a way that works with both version
This is unfortunate, because I think it's the correct path forward.
Stella, do you know why this is failing on Windows?
Thanks,
--
Davide
On Tue, Mar 5, 2019 at 7:26 AM Tatyana Krasnukha via lldb-commits
wrote:
>
> Author: tkrasnukha
> Date: Tue Mar 5 07:27:33 2019
> New Revision: 355406
>
>
I'm also at a loss trying to understand how this particular change
could've caused the tests to hang.
__VSCMD_PREINIT_PATH=C:\Program Files (x86)\Microsoft Visual
Studio\Shared\Python36_64\Scripts\;C:\Program Files (x86)\Microsoft
Visual
Studio\Shared\Python36_64\;C:\Windows\system32;C:\Windows
After the revert the testsuite doesn't hang anymore, so, it looks like
this was responsible. Stella, is the bot actually running python 3.6 ?
Can you make sure there's no python 3.7 installed somewhere in the
system that gets picked by accident?
On Tue, Mar 5, 2019 at 7:59 AM Davide Italiano wrot
On Tue, Mar 5, 2019 at 8:39 AM Stella Stamenova wrote:
>
> The bot is running 3.6.6 and it does not have python 3.7 installed (it does
> have python 2.7 which is needed to run Buildbot).
>
> The change that was pushed, though, did not only impact python 3.7:
>
> m_was_already_init
Author: davide
Date: Tue Mar 5 09:21:55 2019
New Revision: 355415
URL: http://llvm.org/viewvc/llvm-project?rev=355415&view=rev
Log:
Revert "[lldbtest] Check against the correct name for libcxxabi (macOS)."
This passes locally but breaks on the bots. Maybe an SDK difference.
Reverting while I inv
You should check whether log is enabled, I think.
On Tue, Mar 5, 2019 at 2:16 PM Jason Molenda via lldb-commits
wrote:
>
> Author: jmolenda
> Date: Tue Mar 5 14:17:47 2019
> New Revision: 355449
>
> URL: http://llvm.org/viewvc/llvm-project?rev=355449&view=rev
> Log:
> Revert logging addition to
Author: davide
Date: Wed Mar 6 14:54:11 2019
New Revision: 355562
URL: http://llvm.org/viewvc/llvm-project?rev=355562&view=rev
Log:
[testsuite] Port crashlog to python 3, second attempt.
Modified:
lldb/trunk/examples/darwin/heap_find/heap.py
lldb/trunk/examples/python/crashlog.py
lld
Author: davide
Date: Wed Mar 6 15:50:36 2019
New Revision: 355566
URL: http://llvm.org/viewvc/llvm-project?rev=355566&view=rev
Log:
[Python] Unbreak the recently modified tests for python 2.
Modified:
lldb/trunk/examples/darwin/heap_find/heap.py
lldb/trunk/examples/python/crashlog.py
Author: davide
Date: Thu Mar 7 09:45:53 2019
New Revision: 355612
URL: http://llvm.org/viewvc/llvm-project?rev=355612&view=rev
Log:
[testsuite] Drop characters that can't be decoded, restoring parity with Py2.
Tests that check the output of `memory find` may trip over
unreadable characters, and
Author: davide
Date: Thu Mar 7 10:05:18 2019
New Revision: 355615
URL: http://llvm.org/viewvc/llvm-project?rev=355615&view=rev
Log:
[testsuite] Spring cleaning: this tests `stty`, not `lldb`.
Removed:
lldb/trunk/packages/Python/lldbsuite/test/terminal/
__
Author: davide
Date: Thu Mar 7 13:33:43 2019
New Revision: 355640
URL: http://llvm.org/viewvc/llvm-project?rev=355640&view=rev
Log:
[testsuite] Recommit the TestTerminal directory.
Turns out this is actually testing that editline doesn't
screw up the terminal.
Added:
lldb/trunk/packages/Pyt
Author: davide
Date: Tue Mar 12 13:41:29 2019
New Revision: 355968
URL: http://llvm.org/viewvc/llvm-project?rev=355968&view=rev
Log:
[lldb-mi] Make this test more reliable. NFC.
Except that it will probably stop failing on and off on my machine.
Modified:
lldb/trunk/packages/Python/lldbsuit
Author: davide
Date: Tue Mar 12 13:41:36 2019
New Revision: 355969
URL: http://llvm.org/viewvc/llvm-project?rev=355969&view=rev
Log:
[lldb/thirdparty] Remove unneeded files, asked by Jonas.
Removed:
lldb/trunk/third_party/Python/module/pexpect-4.6/doc/
lldb/trunk/third_party/Python/module
Author: davide
Date: Tue Mar 12 17:48:32 2019
New Revision: 355999
URL: http://llvm.org/viewvc/llvm-project?rev=355999&view=rev
Log:
[test] Some unicode sequences can't be printed, and Py 3 is more picky.
Given this was under trace, it can just be removed. If somebody
ever needs to debug this tes
Author: davide
Date: Tue Mar 12 17:48:29 2019
New Revision: 355998
URL: http://llvm.org/viewvc/llvm-project?rev=355998&view=rev
Log:
[Python] Fix another batch of python 2/python 3 portability issues.
Modified:
lldb/trunk/examples/summaries/synth.py
lldb/trunk/packages/Python/lldbsuite/t
Author: davide
Date: Tue Mar 12 18:26:01 2019
New Revision: 356000
URL: http://llvm.org/viewvc/llvm-project?rev=356000&view=rev
Log:
[testsuite] Remove dead code in TestFormats.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/format/TestFormats.py
Modified:
lldb/trunk/p
Author: davide
Date: Tue Mar 12 19:44:32 2019
New Revision: 356002
URL: http://llvm.org/viewvc/llvm-project?rev=356002&view=rev
Log:
[testsuite] Remove other traces broken in python 3.
They can be reinstated in case somebody needs to debug
this test in the future.
Modified:
lldb/trunk/packag
Author: davide
Date: Tue Mar 12 19:47:51 2019
New Revision: 356003
URL: http://llvm.org/viewvc/llvm-project?rev=356003&view=rev
Log:
[TestBatchMode] We already log this output to a file.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py
Modified:
lldb/tr
Probably. I can try doing that.
On Wed, Mar 13, 2019 at 2:38 AM Pavel Labath via lldb-commits
wrote:
>
> On 13/03/2019 01:48, Davide Italiano via lldb-commits wrote:
> > Author: davide
> > Date: Tue Mar 12 17:48:29 2019
> > New Revision: 355998
> >
> > URL:
Author: davide
Date: Wed Mar 13 13:04:34 2019
New Revision: 356096
URL: http://llvm.org/viewvc/llvm-project?rev=356096&view=rev
Log:
[Python] Fix TestDataFormatterSmartArray to work across python versions.
Python 3 default encoding is utf-8, so taking random bytes and
interpreting them as a strin
Author: davide
Date: Thu Mar 14 10:23:08 2019
New Revision: 356171
URL: http://llvm.org/viewvc/llvm-project?rev=356171&view=rev
Log:
[Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.
While we don't have a bot, I'm testing by hand that this configuration
compiles. We'll probably set
On Thu, Mar 14, 2019 at 10:30 AM Zachary Turner wrote:
>
> Make sure to run the test suite after these kinds of changes. You might be
> surprised.
>
I tested both configurations of course :)
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Author: davide
Date: Thu Mar 14 10:41:29 2019
New Revision: 356176
URL: http://llvm.org/viewvc/llvm-project?rev=356176&view=rev
Log:
[DataFormatters] Delete unused code. Not even exposed in the API.
I stumbled upon this while removing LLDB_DISABLE_PYTHON when
not needed.
Modified:
lldb/trunk
Author: davide
Date: Thu Mar 14 15:12:59 2019
New Revision: 356210
URL: http://llvm.org/viewvc/llvm-project?rev=356210&view=rev
Log:
[ObjCLanguage] Remove LLDB_DISABLE_PYTHON markers from the formatters.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp
Modified: lldb/trunk/
Author: davide
Date: Thu Mar 14 17:45:57 2019
New Revision: 356225
URL: http://llvm.org/viewvc/llvm-project?rev=356225&view=rev
Log:
[DataFormatters] Remove LLDB_DISABLE_PYTHON from FormatManager.
And DataVisualization. One step closer.
Modified:
lldb/trunk/include/lldb/DataFormatters/DataVi
301 - 400 of 582 matches
Mail list logo
