On Tue, Feb 20, 2018 at 10:20 PM, Frederic Riss via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: friss
> Date: Tue Feb 20 22:20:03 2018
> New Revision: 325666
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325666&view=rev
> Log:
> Fix TestAppleTypesIsProduced after r324226
>
> Th
Author: davide
Date: Wed Feb 21 13:10:44 2018
New Revision: 325719
URL: http://llvm.org/viewvc/llvm-project?rev=325719&view=rev
Log:
[testsuite] Run lit tests as part of `check-lldb`.
Also, fix a missing dependency, as lit requires llvm-config
to run. This is becoming more and more important as w
Author: davide
Date: Thu Feb 22 17:33:20 2018
New Revision: 325851
URL: http://llvm.org/viewvc/llvm-project?rev=325851&view=rev
Log:
[testsuite] Throw away test/debug_info/apple_types.
This test was only testing that clang produced the correct informations
for __apple accelerated tables. So, it's
On Wed, Feb 21, 2018 at 10:52 AM, Davide Italiano wrote:
>
>
> On Tue, Feb 20, 2018 at 10:20 PM, Frederic Riss via lldb-commits
> wrote:
>>
>> Author: friss
>> Date: Tue Feb 20 22:20:03 2018
>> New Revision: 325666
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=325666&view=rev
>> Log:
>> Fix
Paul Robinson correctly pointed out this test was end-to-end so it
really didn't belong to clang.
After discussing with Adrian, I moved the test to the debuginfo-test
suite in rL325928.
We should be all set now.
Thanks,
--
Davide
On Thu, Feb 22, 2018 at 5:36 PM, Davide Italiano wrote:
> On Wed,
Thank you so much Jason!
On Mon, Mar 5, 2018 at 4:27 PM, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Mon Mar 5 16:27:41 2018
> New Revision: 326756
>
> URL: http://llvm.org/viewvc/llvm-project?rev=326756&view=rev
> Log:
> Upstreaming avx512 register support in debugserver.
Author: davide
Date: Wed Mar 7 10:06:12 2018
New Revision: 326919
URL: http://llvm.org/viewvc/llvm-project?rev=326919&view=rev
Log:
[lldbtestsuite] llvm-objcopy is now required to run the lit tests.
There's now a test using llvm-objcopy in lit/.
This doesn't fail on the bot(s) because `llvm-objc
On Fri, Feb 23, 2018 at 9:49 AM, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Fri Feb 23 09:49:26 2018
> New Revision: 325927
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325927&view=rev
> Log:
> Replace HashStringUsingDJB with llvm::djbHash
>
> Summary:
> The llvm function is
On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote:
> The hashing algorithm gives different values - at least for foobár - between
> the two implementations. So if you build with an older clang, and test with
> a new lldb, the type lookup fails.
>
This is not my case, I think? I'm building from
On Thu, Mar 8, 2018 at 10:46 AM, Jim Ingham wrote:
>
>
>> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote:
>>
>>
>>
>>
>> On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote:
>> On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote:
>> > The hashing algorithm gives different values - at least for foob
+ Jonas (who's going to fix this probably)
On Thu, Mar 8, 2018 at 4:34 PM, Vedant Kumar via lldb-commits
wrote:
> Author: vedantk
> Date: Thu Mar 8 16:34:43 2018
> New Revision: 327089
>
> URL: http://llvm.org/viewvc/llvm-project?rev=327089&view=rev
> Log:
> [test] Skip a test which sporadically
Author: davide
Date: Mon Mar 12 16:42:37 2018
New Revision: 327350
URL: http://llvm.org/viewvc/llvm-project?rev=327350&view=rev
Log:
[lit] `llvm-mc` is now a dependency to run tests.
Modified:
lldb/trunk/lit/CMakeLists.txt
Modified: lldb/trunk/lit/CMakeLists.txt
URL:
http://llvm.org/viewvc/
Author: davide
Date: Mon Mar 12 18:40:00 2018
New Revision: 327356
URL: http://llvm.org/viewvc/llvm-project?rev=327356&view=rev
Log:
[ExpressionParser] Fix crash when evaluating invalid expresssions.
Typical example, illformed comparisons (operator== where LHS and
RHS are not compatible). If a sy
On Mon, Mar 12, 2018 at 7:27 PM, Jason Molenda via lldb-commits
wrote:
> FWIW, we'll definitely get pushback about
>
>> Now you can't do in lldb anymore
>> (lldb) call _Zsomethingsomething(1,2,3)
>
>
> There are clever users of lldb, often working at assembly language level
> without any symbolic
On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits
wrote:
>
>
>> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits
>> wrote:
>>
>> Author: davide
>> Date: Mon Mar 12 18:40:00 2018
>> New Revision: 327356
>>
>> URL: h
Greg, Jason, would that work for you guys?
Thanks!
--
Davide
On Tue, Mar 13, 2018 at 10:25 AM, Davide Italiano wrote:
> On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits
> wrote:
>>
>>
>>> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits
&g
On Tue, Mar 13, 2018 at 10:57 AM, Greg Clayton wrote:
>
>
>> On Mar 13, 2018, at 10:37 AM, Davide Italiano via lldb-commits
>> wrote:
>>
>> An alternative proposed by Fred which is an OK middle ground IMHO is
>> that of not inserting a decl for the unma
On Tue, Mar 13, 2018 at 11:17 AM, Greg Clayton wrote:
> If you check the expression log, you will see the printf() function
> declaration and any others we add:
>
> (lldb) log enable lldb expr
> (lldb) 2+3
>
> ...
> #ifndef NULL
> #define NULL (__null)
> #endif
> #ifndef Nil
> #define Nil (__null
On Tue, Mar 13, 2018 at 10:56 AM, Greg Clayton wrote:
>
>
> On Mar 13, 2018, at 10:25 AM, Davide Italiano via lldb-commits
> wrote:
>
> On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits
> wrote:
>
>
>
> On Mar 12, 2018, at 6:40 PM, Davide I
Author: davide
Date: Tue Mar 13 13:26:38 2018
New Revision: 327445
URL: http://llvm.org/viewvc/llvm-project?rev=327445&view=rev
Log:
[DataFormatter] Remove dead code for the NSDictionary formatter.
I'm going to make changes in this area soon, so I figured I
could clean things a bit while I was ar
On Tue, Mar 13, 2018 at 2:43 PM, Jason Molenda wrote:
>
>
>> On Mar 13, 2018, at 11:51 AM, Davide Italiano via lldb-commits
>> wrote:
>>
>> We had the report of a crash where lldb was setting a conditional
>> breakpoint on an invalid condition (CGRect
Author: davide
Date: Wed Mar 14 16:09:36 2018
New Revision: 327587
URL: http://llvm.org/viewvc/llvm-project?rev=327587&view=rev
Log:
[DataFormatters] Implement summary for __NSDictionary0.
Before the patch:
(lldb) frame var emptyDictionary
(__NSDictionary0 *) emptyDictionary = 0x000100304420
Author: davide
Date: Wed Mar 14 17:07:05 2018
New Revision: 327592
URL: http://llvm.org/viewvc/llvm-project?rev=327592&view=rev
Log:
[Dictionary] Rewrite the test added in r327587 as an inline test.
Until we have a better story for putting commands and check lines
in the same file (they're curren
This is the most likely cause for the failures we're starting to see
on both our bots on greendragon.
Can you please take a look?
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5791/
Thanks!
--
Davide
On Thu, Mar 15, 2018 at 6:47 AM, Pavel Labath via lldb-commits
wrote:
> Author: lab
I don't seem to receive mails either (although I should).
Vedant is babysitting the bots this week. Vedant, are you receiving
blame mails or the mail notification is disabled altogether?
On Thu, Mar 15, 2018 at 8:06 AM, Pavel Labath wrote:
> Yes, it certainly looks that way. Taking a look now.
>
On Thu, Mar 15, 2018 at 8:28 AM, Pavel Labath wrote:
> Yea, this is strange. The bot does not even appear to be red. It's just
> yellow.
>
This is historical. We ought to change this. We just delayed this
because we wanted to be *really sure* things were green for a while.
Also, UNEXPECTED SUCCES
On Wed, Mar 14, 2018 at 1:52 AM, Pavel Labath wrote:
> I'm not familiar with all of the magic we do when we synthesize clang Decls,
> but I feel I should point out that we can't get out of business of
> sanity-checking the declarations we inject into clang. The reason for that
> is, even if we had
Author: davide
Date: Mon Mar 19 12:35:20 2018
New Revision: 327893
URL: http://llvm.org/viewvc/llvm-project?rev=327893&view=rev
Log:
[ClangASTContext] Remove dead code. NFCI.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
h
On Mon, Mar 19, 2018 at 4:15 PM, Jim Ingham via lldb-commits
wrote:
> Author: jingham
> Date: Mon Mar 19 16:15:06 2018
> New Revision: 327924
>
> URL: http://llvm.org/viewvc/llvm-project?rev=327924&view=rev
> Log:
> Modernize a test.
>
> Modified:
>
> lldb/trunk/packages/Python/lldbsuite/test
On Mon, Mar 19, 2018 at 6:38 PM, Jim Ingham wrote:
> Yes, I should have written this function much earlier. I've been trying to
> convert over to it every time a tests draws my attention (in this case 'cause
> I pointed it out for you to copy...)
>
> It is the way to make a test in the sample_t
Leonardo, this breaks the Mac OS X bot.
I'm going to revert this to get the bots green again, unless you have
a super quick fix (please let me know :)
On Tue, Mar 20, 2018 at 5:28 AM, Alexandre Yukio Yamashita via
Phabricator via lldb-commits wrote:
> alexandreyy added a comment.
>
> In https:/
I think I understand why this is failing:
AssertionError: False is not True : 'expression ((char**)environ)[0]'
returns expected result, got '(char *) $0 = 0x7ffeefbff753
"COMMAND_MODE=unix2003"'
Config=x86_64-/Users/davide/work/llvm-monorepo/build-release/bin/clang-7.0
but the test shows $1.
Author: davide
Date: Tue Mar 20 11:32:47 2018
New Revision: 328013
URL: http://llvm.org/viewvc/llvm-project?rev=328013&view=rev
Log:
[TestExpr] Fix a typo in a test, unbreaking the lldb Mac OS X bot.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/test/TestExprs2.py
M
Author: davide
Date: Tue Mar 20 12:46:32 2018
New Revision: 328025
URL: http://llvm.org/viewvc/llvm-project?rev=328025&view=rev
Log:
[ExpressionParser] Re-implement r327356 in a less disruptive way.
Instead of applying the sledgehammer of refusing to insert any
C++ symbol in the ASTContext, try t
Fixed in a nicer/cleaner way (that doesn't regress the current
behavior), thank you everybody for your excellent feedback!
davide@Davidinos-Mac-Pro ~/w/l/llvm-project-20170507> git llvm push
Pushing 1 commit:
8875fcce772 [ExpressionParser] Re-implement r327356 in a less disruptive way.
Sending
This apparently uncovered a crash in the linux build, looking now.
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake
Thanks,
--
Davide
On Tue, Mar 20, 2018 at 12:46 PM, Davide Italiano via lldb-commits
wrote:
> Author: davide
> Date: Tue Mar 20 12:46:32 2018
> New
Author: davide
Date: Tue Mar 20 16:47:47 2018
New Revision: 328062
URL: http://llvm.org/viewvc/llvm-project?rev=328062&view=rev
Log:
[Testsuite] Modernize this test to be run out-of-tree.
New tests should run the make syntax voodoo $@ and $<
instead of hardcoding the names. We should also documen
On Wed, Mar 21, 2018 at 2:43 AM, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Wed Mar 21 02:43:50 2018
> New Revision: 328083
>
> URL: http://llvm.org/viewvc/llvm-project?rev=328083&view=rev
> Log:
> Fix TestOperatorOverload for 32-bit builds
>
> - use more goodies from Makefile.r
Author: davide
Date: Thu Mar 22 17:14:41 2018
New Revision: 328278
URL: http://llvm.org/viewvc/llvm-project?rev=328278&view=rev
Log:
[CommandObjectFrame] Remove dead code.
Modified:
lldb/trunk/source/Commands/CommandObjectFrame.cpp
Modified: lldb/trunk/source/Commands/CommandObjectFrame.cpp
Author: davide
Date: Fri Mar 23 13:58:05 2018
New Revision: 328368
URL: http://llvm.org/viewvc/llvm-project?rev=328368&view=rev
Log:
[Command] Remove dead code for the syntax command.
I'm going to add a new commend so I figured I could do
some spring cleaning.
Removed:
lldb/trunk/source/Comm
Author: davide
Date: Fri Mar 23 14:04:34 2018
New Revision: 328370
URL: http://llvm.org/viewvc/llvm-project?rev=328370&view=rev
Log:
[Commands] Remove dead code for unused `args` command.
It wasn't even registered.
(lldb) apropos args
No commands found pertaining to 'args'. Try 'help' to see
a c
Author: davide
Date: Fri Mar 23 14:21:17 2018
New Revision: 328373
URL: http://llvm.org/viewvc/llvm-project?rev=328373&view=rev
Log:
[CMakeLists] Update file list after recent changes.
Modified:
lldb/trunk/source/Commands/CMakeLists.txt
Modified: lldb/trunk/source/Commands/CMakeLists.txt
URL
Author: davide
Date: Fri Mar 23 14:55:48 2018
New Revision: 328378
URL: http://llvm.org/viewvc/llvm-project?rev=328378&view=rev
Log:
[Commands] Add a (currently empty) `stats` command.
This one will be used to print statistics about lldb sessions
(including, e.g. number of expression evaluation s
This commit broke the Jenkins macOS x86-64 bots
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5943/testReport/junit/TestDisassembleBreakpoint/DisassemblyTestCase/test_dwarf/
Can you take a look? (if you can't, let me know).
Thanks,
--
Davide
On Mon, Mar 26, 2018 at 5:42 AM, Pavel Lab
Thanks, I'll take a look at the bots myself.
On Mon, Mar 26, 2018 at 8:24 AM, Pavel Labath wrote:
> I was also looking at this because it broke on our android bots. I have just
> committed r328504 to fix those, and I believe it will fix the issues you are
> seeing on osx (but I'll probably need t
Author: davide
Date: Tue Mar 27 11:37:54 2018
New Revision: 328649
URL: http://llvm.org/viewvc/llvm-project?rev=328649&view=rev
Log:
[Core] Correctly handle float division in Scalar.
Patch by Tom Tromey!
Differential Revision: https://reviews.llvm.org/D44693
Modified:
lldb/trunk/source/Cor
Author: davide
Date: Tue Mar 27 12:40:50 2018
New Revision: 328658
URL: http://llvm.org/viewvc/llvm-project?rev=328658&view=rev
Log:
Use the DWARF linkage name when importing C++ methods.
When importing C++ methods into clang AST nodes from the DWARF symbol
table, preserve the DW_AT_linkage_name
Author: davide
Date: Fri Mar 30 12:24:08 2018
New Revision: 328894
URL: http://llvm.org/viewvc/llvm-project?rev=328894&view=rev
Log:
[lldb-dotest] Don't swallow error exit codes.
Modified:
lldb/trunk/test/lldb-dotest.in
Modified: lldb/trunk/test/lldb-dotest.in
URL:
http://llvm.org/viewvc/ll
Author: davide
Date: Mon Apr 2 09:50:54 2018
New Revision: 328985
URL: http://llvm.org/viewvc/llvm-project?rev=328985&view=rev
Log:
[Core] Grab-bag of improvements for Scalar.
Remove Scalar::Cast.
It was noted on the list that this method is unused. So, this patch
removes it.
Fix Scalar::Promo
On Mon, Apr 2, 2018 at 10:20 AM, Greg Clayton via lldb-commits
wrote:
> Author: gclayton
> Date: Mon Apr 2 10:20:21 2018
> New Revision: 328990
>
> URL: http://llvm.org/viewvc/llvm-project?rev=328990&view=rev
> Log:
> Added a BSD archive tool.
>
> This is a combination stand alone BSD archive too
Now with the correct e-mail.
How is this different from llvm-objdump or llvm-readobj?
(also you might want to update your commit e-mail as reply-to seems to
still be set to your @apple address and bounces back).
Thanks,
--
Davide
On Mon, Apr 2, 2018 at 10:25 AM, Davide Italiano wrote:
> On Mon,
On Tue, Apr 3, 2018 at 7:24 AM, Greg Clayton wrote:
>
>
>> On Apr 2, 2018, at 10:27 AM, Davide Italiano wrote:
>>
>> Now with the correct e-mail.
>> How is this different from llvm-objdump or llvm-readobj?
>
> It was originally created for parsing .a files and getting the mod date as a
> hex num
On Thu, Apr 5, 2018 at 8:52 AM, Greg Clayton via lldb-commits
wrote:
> Author: gclayton
> Date: Thu Apr 5 08:52:39 2018
> New Revision: 329305
>
> URL: http://llvm.org/viewvc/llvm-project?rev=329305&view=rev
> Log:
> Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit
>
Author: davide
Date: Thu Apr 5 15:46:39 2018
New Revision: 329358
URL: http://llvm.org/viewvc/llvm-project?rev=329358&view=rev
Log:
[dotest] --skip-category should append and not override.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
Modified: lldb/trunk/packages/Python/l
On Fri, Apr 6, 2018 at 1:02 AM, Jan Kratochvil via Phabricator
wrote:
> jankratochvil added a comment.
>
> I disagree with this patch as `DWARFUnit` was a lightweight wrapper for
> `DWARFPartialUnit`. Now I will have to create some new lightweight
> superclass like `DWARFAbstractUnit`.
> My pat
On Fri, Apr 6, 2018 at 9:48 AM, Adrian Prantl wrote:
>
>
>> On Apr 6, 2018, at 9:32 AM, Davide Italiano wrote:
>>
>> On Fri, Apr 6, 2018 at 1:02 AM, Jan Kratochvil via Phabricator
>> wrote:
>>> jankratochvil added a comment.
>>>
>>> I disagree with this patch as `DWARFUnit` was a lightweight wra
Author: davide
Date: Fri Apr 6 10:17:20 2018
New Revision: 329426
URL: http://llvm.org/viewvc/llvm-project?rev=329426&view=rev
Log:
[lldb-server] Set a more generous timeout when testing gdbremote.
One of our downstream bot is struggling under load, but this
value should be enough for everyone.
On Fri, Apr 6, 2018 at 10:32 AM, Jan Kratochvil
wrote:
> Maybe LLDB should really reuse LLVM DWARFUnit first and I will implement DWZ
> already on top of LLVM's DWARFUnit? I have no idea myself now how complex task
> is the reuse of LLVM DWARFUnit. For the LLVM DWARFUnit reusal this Greg's
> commi
Author: davide
Date: Wed Apr 11 10:53:02 2018
New Revision: 329831
URL: http://llvm.org/viewvc/llvm-project?rev=329831&view=rev
Log:
[Target] Remove dead/commented out code. NFC.
Some spring cleaning before I touch this file more extensively.
Modified:
lldb/trunk/include/lldb/Target/Target.h
thanks!
On Fri, Apr 13, 2018 at 8:10 AM, Greg Clayton via Phabricator
wrote:
> clayborg marked 2 inline comments as done.
> clayborg added a comment.
>
> Didn't update the diffs, but I did fix the things Davide requested before
> submission
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.
Author: davide
Date: Fri Apr 13 11:02:39 2018
New Revision: 330043
URL: http://llvm.org/viewvc/llvm-project?rev=330043&view=rev
Log:
[Command] Implement `statistics` command.
This allows us to collect useful metrics about lldb debugging sessions.
I thought that an example would be better than a
Author: davide
Date: Fri Apr 13 11:37:14 2018
New Revision: 330047
URL: http://llvm.org/viewvc/llvm-project?rev=330047&view=rev
Log:
[Command] Simplify the code and make it less error prone. NFCI.
Pointed out by Jim.
Modified:
lldb/trunk/source/Commands/CommandObjectExpression.cpp
lldb/t
Author: davide
Date: Fri Apr 13 13:47:25 2018
New Revision: 330066
URL: http://llvm.org/viewvc/llvm-project?rev=330066&view=rev
Log:
[debugserver] Remove dead function call. NFCI.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.cpp
Modified: lldb/trunk/tools/debugserver/source/RNBRem
Oops. Sorry. Fixing this now.
On Fri, Apr 13, 2018 at 1:55 PM, Frédéric Riss via lldb-commits
wrote:
>
>
>> On Apr 13, 2018, at 1:47 PM, Davide Italiano via lldb-commits
>> wrote:
>>
>> Author: davide
>> Date: Fri Apr 13 13:47:25 2018
>> New Revision
Author: davide
Date: Fri Apr 13 14:26:32 2018
New Revision: 330071
URL: http://llvm.org/viewvc/llvm-project?rev=330071&view=rev
Log:
Revert "[debugserver] Remove dead function call. NFCI."
This reverts commit r330066 as it was wrong and the call was
not dead. Thanks to Fred for pointing this out.
1:55 PM, Frédéric Riss via lldb-commits
> wrote:
>>
>>
>>> On Apr 13, 2018, at 1:47 PM, Davide Italiano via lldb-commits
>>> wrote:
>>>
>>> Author: davide
>>> Date: Fri Apr 13 13:47:25 2018
>>> New Revision: 330066
>>>
Author: davide
Date: Mon Apr 16 11:25:57 2018
New Revision: 330147
URL: http://llvm.org/viewvc/llvm-project?rev=330147&view=rev
Log:
[Statistics] Move GetStatDescription to an header file.
In preparation for using it in the API.
Modified:
lldb/trunk/include/lldb/lldb-private-enumerations.h
On Mon, Apr 16, 2018 at 11:30 AM, Zachary Turner via lldb-commits
wrote:
> I think you need to mark this inline otherwise you're going to get multiple
> definitions no?
>
I'm pretty sure you're correct, although this didn't show up (probably
because it's used only in one place). Let me change it
Author: davide
Date: Mon Apr 16 12:07:14 2018
New Revision: 330149
URL: http://llvm.org/viewvc/llvm-project?rev=330149&view=rev
Log:
[lldb-private] Mark a function as inline to prevent multiple def errors.
Modified:
lldb/trunk/include/lldb/lldb-private-enumerations.h
Modified: lldb/trunk/inc
Author: davide
Date: Mon Apr 16 15:55:34 2018
New Revision: 330165
URL: http://llvm.org/viewvc/llvm-project?rev=330165&view=rev
Log:
[Commands] Expose statistics through the SBAPI.
The API is `SBStructuredData GetStatistics()`. This allows
the command to be used in scripts.
Added:
lldb/tru
Author: davide
Date: Mon Apr 16 16:59:01 2018
New Revision: 330170
URL: http://llvm.org/viewvc/llvm-project?rev=330170&view=rev
Log:
[Statistics] Relax the test output a little bit.
We don't really care about the order as this is a dictionary.
It should be more resilient to changes (adding/shuffl
Author: davide
Date: Thu Apr 19 17:44:33 2018
New Revision: 330385
URL: http://llvm.org/viewvc/llvm-project?rev=330385&view=rev
Log:
[DWARFASTParserClang] Remove dead code. NFCI.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified: lldb/trunk/source/Plugins/
Author: davide
Date: Mon Apr 23 10:06:55 2018
New Revision: 330617
URL: http://llvm.org/viewvc/llvm-project?rev=330617&view=rev
Log:
[CMake] Add the missing `dsymutil` dependency when running tests.
Modified:
lldb/trunk/lit/CMakeLists.txt
Modified: lldb/trunk/lit/CMakeLists.txt
URL:
http://
On Thu, Apr 26, 2018 at 6:57 PM, Jim Ingham via lldb-commits
wrote:
> Author: jingham
> Date: Thu Apr 26 18:57:40 2018
> New Revision: 331012
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331012&view=rev
> Log:
> Fix a thinko in the iteration over StructuredDataPlugin Create functions.
>
> The
On Mon, Apr 30, 2018 at 5:05 PM, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Mon Apr 30 17:05:54 2018
> New Revision: 331236
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331236&view=rev
> Log:
> Add logging when ArchSpec::SetArchitecture is given a cputype and
> cpusubtype
Author: davide
Date: Wed May 2 16:36:07 2018
New Revision: 331415
URL: http://llvm.org/viewvc/llvm-project?rev=331415&view=rev
Log:
[NSDictionary] Simplify the formatter. NFCI.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.cpp
Modified: lldb/trunk/source/Plugins/Language/Ob
On Wed, May 2, 2018 at 4:51 PM, Jason Molenda via lldb-commits
wrote:
> Is this really simpler? We could write it
>
> if (name == g_zero)
> return 0;
> else
> return UINT32_MAX;
>
> or we could do it that way, or it could be done the way it was originally
> written.
>
> tbh it seems like a s
On Wed, May 2, 2018 at 4:56 PM, Davide Italiano wrote:
> On Wed, May 2, 2018 at 4:51 PM, Jason Molenda via lldb-commits
> wrote:
>> Is this really simpler? We could write it
>>
>> if (name == g_zero)
>> return 0;
>> else
>> return UINT32_MAX;
>>
>> or we could do it that way, or it could be
On Fri, Apr 27, 2018 at 2:10 PM, Greg Clayton via lldb-commits
wrote:
> Author: gclayton
> Date: Fri Apr 27 14:10:07 2018
> New Revision: 331082
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331082&view=rev
> Log:
> Fix build bots after r331049 broke them.
>
I would like to apologize for commu
I would like to apologize for communicating this so late (mainly
because I worked on the swift bits which are a little behind and I
didn't update my checkout) but this commit completely broke debugging
in some cases (on MacOS).
Testcase:
#import
int main() {
id keys[1] = { @"abc" };
id valu
ping.
On Thu, May 3, 2018 at 3:08 PM, Davide Italiano wrote:
> I would like to apologize for communicating this so late (mainly
> because I worked on the swift bits which are a little behind and I
> didn't update my checkout) but this commit completely broke debugging
> in some cases (on MacOS).
On Fri, May 4, 2018 at 10:54 AM, Greg Clayton wrote:
> So it seems that if specify "./blah" as your program then this fails, but if
> you specify just "blah" then this succeeds. Looks like we need to resolve the
> path when creating a target with a local copy of the file. I will look into
> thi
Author: davide
Date: Fri Apr 14 17:04:05 2017
New Revision: 300373
URL: http://llvm.org/viewvc/llvm-project?rev=300373&view=rev
Log:
[Process/Utility] Remove dead code. NFCI.
Modified:
lldb/trunk/source/Plugins/Process/Utility/RegisterContextOpenBSD_x86_64.cpp
Modified:
lldb/trunk/source/Pl
Author: davide
Date: Fri Apr 14 17:27:28 2017
New Revision: 300375
URL: http://llvm.org/viewvc/llvm-project?rev=300375&view=rev
Log:
[ARM/Emulation] Remove an unneeded comparison and simplify. NFCI.
reg0 is always zero and comparison to an unsigned always yields
true.
Modified:
lldb/trunk/so
Author: davide
Date: Fri Apr 14 17:36:08 2017
New Revision: 300377
URL: http://llvm.org/viewvc/llvm-project?rev=300377&view=rev
Log:
[Interpreter] Make a static func a lambda and remove always_inline.
The attribute was fairly dubious as: a) we shouldn't tell the compiler
when to inline functions,
Author: davide
Date: Mon Apr 17 13:24:18 2017
New Revision: 300476
URL: http://llvm.org/viewvc/llvm-project?rev=300476&view=rev
Log:
[ClangASTContext] Placate `casts away qualifiers` warnings from GCC.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/
Author: davide
Date: Wed Apr 19 13:18:25 2017
New Revision: 300729
URL: http://llvm.org/viewvc/llvm-project?rev=300729&view=rev
Log:
[Utility/StringLexer] Remove dead code.
Differential Revision: https://reviews.llvm.org/D32148
Modified:
lldb/trunk/include/lldb/Utility/StringLexer.h
lld
On Wed, Apr 19, 2017 at 11:10 AM, Jim Ingham wrote:
> We've had a couple of cases of "dead" code which turned out to be the
> llvm.org side of generic behavior for which Swift was the only current
> specific implementation. So while I agree, little single functions that
> aren't used anywhere
Author: davide
Date: Thu Apr 20 09:45:33 2017
New Revision: 300845
URL: http://llvm.org/viewvc/llvm-project?rev=300845&view=rev
Log:
[Utility] Placate another GCC warning.
Differential Revision: https://reviews.llvm.org/D32137
Modified:
lldb/trunk/source/Plugins/Process/Utility/RegisterCont
Author: davide
Date: Thu Jun 8 18:49:56 2017
New Revision: 305035
URL: http://llvm.org/viewvc/llvm-project?rev=305035&view=rev
Log:
[VMRange] Simplify a couple of member functions. NFCI.
Modified:
lldb/trunk/source/Utility/VMRange.cpp
Modified: lldb/trunk/source/Utility/VMRange.cpp
URL:
ht
On Thu, Jun 8, 2017 at 4:55 PM, Zachary Turner wrote:
> Note that even simpler would be
>
> ```
> return llvm::find_if(col, in_range_predicate) != col.end();
> ```
>
> On Thu, Jun 8, 2017 at 4:50 PM Davide Italiano via lldb-commits
> wrote:
>>
>> Author: davide
>>
Author: davide
Date: Fri Jun 9 14:14:59 2017
New Revision: 305099
URL: http://llvm.org/viewvc/llvm-project?rev=305099&view=rev
Log:
[VMRange] Use llvm::find_if. Thanks to Zachary for the suggestion.
Modified:
lldb/trunk/source/Utility/VMRange.cpp
Modified: lldb/trunk/source/Utility/VMRange.
Author: davide
Date: Fri Jun 9 15:49:11 2017
New Revision: 305109
URL: http://llvm.org/viewvc/llvm-project?rev=305109&view=rev
Log:
[VMRange] Implement comparison operators using `==` and `<`.
Modified:
lldb/trunk/source/Utility/VMRange.cpp
Modified: lldb/trunk/source/Utility/VMRange.cpp
UR
Author: davide
Date: Fri Jun 9 16:01:55 2017
New Revision: 305111
URL: http://llvm.org/viewvc/llvm-project?rev=305111&view=rev
Log:
[VMRange] Remove unused FindRangeIndexThatContainsValue().
Modified:
lldb/trunk/include/lldb/Utility/VMRange.h
lldb/trunk/source/Utility/VMRange.cpp
Modifi
Author: davide
Date: Sat Aug 19 09:30:47 2017
New Revision: 311244
URL: http://llvm.org/viewvc/llvm-project?rev=311244&view=rev
Log:
[Plugins/ObjC] Remove unneded semicolon(s) to placate GCC -Wpedantic.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSArray.cpp
Modified: lldb/trunk/source
Author: davide
Date: Sat Aug 19 09:32:19 2017
New Revision: 311245
URL: http://llvm.org/viewvc/llvm-project?rev=311245&view=rev
Log:
[Plugins/ObjC] Remove more semicolons to placate -Wpedantic. NFCI.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/NSDictionary.cpp
Modified: lldb/trunk/sour
Author: davide
Date: Thu Aug 31 11:47:49 2017
New Revision: 312267
URL: http://llvm.org/viewvc/llvm-project?rev=312267&view=rev
Log:
[TypeSystem] Reduce code duplication merging two almost identical functions.
Modified:
lldb/trunk/source/Symbol/TypeSystem.cpp
Modified: lldb/trunk/source/Symb
Author: davide
Date: Sun Sep 3 12:24:58 2017
New Revision: 312453
URL: http://llvm.org/viewvc/llvm-project?rev=312453&view=rev
Log:
[Core/Value] Remove dead code that hasn't been touched in years. NFC.
Modified:
lldb/trunk/source/Core/Value.cpp
Modified: lldb/trunk/source/Core/Value.cpp
URL
Author: davide
Date: Sun Sep 3 12:27:56 2017
New Revision: 312454
URL: http://llvm.org/viewvc/llvm-project?rev=312454&view=rev
Log:
[Interpreter] Simplify else after return. NFCI.
Modified:
lldb/trunk/source/Interpreter/ScriptInterpreter.cpp
Modified: lldb/trunk/source/Interpreter/ScriptInt
Author: davide
Date: Sun Sep 3 13:53:24 2017
New Revision: 312457
URL: http://llvm.org/viewvc/llvm-project?rev=312457&view=rev
Log:
[UUID] Reimplement comparison operators more canonically. NFCI.
Modified:
lldb/trunk/source/Utility/UUID.cpp
Modified: lldb/trunk/source/Utility/UUID.cpp
URL:
201 - 300 of 582 matches
Mail list logo
