Author: davide
Date: Fri Nov 17 16:34:09 2017
New Revision: 318576
URL: http://llvm.org/viewvc/llvm-project?rev=318576&view=rev
Log:
[Core] Garbage collect dead code untouched in years. NFCI.
This sketching can be resurrected if anybody needs it, although
I doubt is relevant these days.
Modified
Author: davide
Date: Fri Nov 17 16:35:27 2017
New Revision: 318577
URL: http://llvm.org/viewvc/llvm-project?rev=318577&view=rev
Log:
[ABI/SysV] Remove more dead code. NFCI.
Modified:
lldb/trunk/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp
Modified: lldb/trunk/source/Plugins/ABI/SysV-x86
Author: davide
Date: Fri Nov 17 16:52:29 2017
New Revision: 318579
URL: http://llvm.org/viewvc/llvm-project?rev=318579&view=rev
Log:
[Module] Throw away some more commented code. NFCI.
Modified:
lldb/trunk/source/Core/Module.cpp
Modified: lldb/trunk/source/Core/Module.cpp
URL:
http://llvm.o
Author: davide
Date: Fri Nov 17 16:54:31 2017
New Revision: 318580
URL: http://llvm.org/viewvc/llvm-project?rev=318580&view=rev
Log:
[ABI] Remove dead code that was copy-pasted all around. NFCI.
Modified:
lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp
lldb/trunk/source/Plugins/ABI
On Wed, Nov 29, 2017 at 1:38 PM, Jim Ingham wrote:
> I'm a little confused by your response.
>
> My stated objection to command output dependent tests is and has always been
> that they make the test dependent on the details of command output. Over
> time doing so makes it hard to modify comman
On Thu, Nov 30, 2017 at 7:41 PM, Jim Ingham via lldb-commits
wrote:
> Author: jingham
> Date: Thu Nov 30 19:41:30 2017
> New Revision: 319516
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319516&view=rev
> Log:
> ClangASTContext::ParseClassTemplateDecl doesn't always succeed.
> When it does, it
On Fri, Dec 1, 2017 at 10:49 AM, Jim Ingham wrote:
> The failure shows that we don't yet support all template kinds in lldb, and
> that we don't have enough testing for a wide variety of C++ template types.
> Adrian found one instance of this failure, but it is in the Swift compiler so
> I nee
yes, that should work, and we should give it at least a shot :)
On Fri, Dec 1, 2017 at 11:01 AM, Zachary Turner wrote:
> As you said a smaller repro is needed, but I'm imagining a case where we can
> write a file containing some C++ code that uses a template that LLDB doesn't
> understand, compil
Also, FWIW, this is blatantly not the correct way of using assertions.
It should either be assert(false && "patatino") or the more canonical
llvm_unreachable("patatino").
Relying on the implicit conversion from string to bool seems risky
(and not really useful).
On Fri, Dec 1, 2017 at 3:29 PM, Ved
On Fri, Dec 1, 2017 at 3:53 PM, Vedant Kumar via lldb-commits
wrote:
> Author: vedantk
> Date: Fri Dec 1 15:53:01 2017
> New Revision: 319597
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319597&view=rev
> Log:
> Fix warning in DynamicLoaderDarwinKernel.cpp, NFC
>
> Modified:
>
> lldb/tru
Maybe we should remove this feature altogether?
On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits
wrote:
> Author: jingham
> Date: Fri Dec 1 16:11:18 2017
> New Revision: 319598
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319598&view=rev
> Log:
> Don't use llvm::EnablePrettyStackT
Author: davide
Date: Tue Dec 5 12:55:36 2017
New Revision: 319832
URL: http://llvm.org/viewvc/llvm-project?rev=319832&view=rev
Log:
[Darwin] Delete dead code. NFCI.
Modified:
lldb/trunk/source/Plugins/Process/Darwin/NativeProcessDarwin.h
Modified: lldb/trunk/source/Plugins/Process/Darwin/Na
I'll fix this now (my top priority :)
On Wed, Dec 6, 2017 at 9:44 AM, Adrian Prantl wrote:
>
>
>> On Dec 6, 2017, at 9:35 AM, Robinson, Paul wrote:
>>
>>> -Original Message-
>>> From: Pavel Labath [mailto:lab...@google.com]
>>> Sent: Wednesday, December 06, 2017 4:09 AM
>>> To: Jason Mol
Author: davide
Date: Thu Dec 7 09:05:56 2017
New Revision: 320060
URL: http://llvm.org/viewvc/llvm-project?rev=320060&view=rev
Log:
[Target] Remove commented out code. Found by inspection. NFCI.
Modified:
lldb/trunk/source/Target/RegisterContext.cpp
Modified: lldb/trunk/source/Target/Regist
Author: davide
Date: Thu Dec 7 10:06:06 2017
New Revision: 320067
URL: http://llvm.org/viewvc/llvm-project?rev=320067&view=rev
Log:
[SBBreakpointOptionCommon] Give this class an explicit destructor.
Modified:
lldb/trunk/source/API/SBBreakpointOptionCommon.cpp
lldb/trunk/source/API/SBBrea
Author: davide
Date: Thu Dec 7 10:06:06 2017
New Revision: 320066
URL: http://llvm.org/viewvc/llvm-project?rev=320066&view=rev
Log:
[SBBreakpoint] Outline some functions to prevent to be exported.
They're hidden, so all they cause is a linker warning.
ld: warning: cannot export hidden symbol
ll
On Thu, Dec 7, 2017 at 5:09 PM, Vedant Kumar via lldb-commits
wrote:
> Author: vedantk
> Date: Thu Dec 7 17:09:40 2017
> New Revision: 320127
>
> URL: http://llvm.org/viewvc/llvm-project?rev=320127&view=rev
> Log:
> [MachException] Avoid alignment UB, NFC
>
> Fix alignment UB in some Mach excepti
Author: davide
Date: Sun Dec 10 14:54:07 2017
New Revision: 320335
URL: http://llvm.org/viewvc/llvm-project?rev=320335&view=rev
Log:
[DataEncoder] Replace buggy versions of write functions.
They cause an ubsan error when ran through the testsuite (store
to misaligned address is UB). This commit k
Author: davide
Date: Sun Dec 10 15:33:33 2017
New Revision: 320337
URL: http://llvm.org/viewvc/llvm-project?rev=320337&view=rev
Log:
[MachException] Garbage collect unused and dead code.
Modified:
lldb/trunk/source/Plugins/Process/Darwin/MachException.cpp
Modified: lldb/trunk/source/Plugins/
Author: davide
Date: Sun Dec 10 15:49:23 2017
New Revision: 320338
URL: http://llvm.org/viewvc/llvm-project?rev=320338&view=rev
Log:
[DarwinLog] Remove other dead code. Found while reading this file.
Modified:
lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
Mo
On Fri, Dec 8, 2017 at 7:37 PM, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Fri Dec 8 19:37:09 2017
> New Revision: 320242
>
> URL: http://llvm.org/viewvc/llvm-project?rev=320242&view=rev
> Log:
> Change uses of strncpy in debugserver to strlcpy
> for better safety.
>
>
>
T
Testcase?
On Fri, Dec 8, 2017 at 7:06 PM, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Fri Dec 8 19:06:19 2017
> New Revision: 320240
>
> URL: http://llvm.org/viewvc/llvm-project?rev=320240&view=rev
> Log:
> Update PlatformDarwin::GetDeveloperDir to handle the two
> most comm
ping. Any luck trying to write a testcase?
This is a great opportunity to discuss whether is feasible and we can
improve the testing strategy here.
--
Davide
On Fri, Dec 1, 2017 at 11:02 AM, Davide Italiano wrote:
> yes, that should work, and we should give it at least a shot :)
>
> On Fri, Dec
Author: davide
Date: Sun Dec 10 21:09:35 2017
New Revision: 320341
URL: http://llvm.org/viewvc/llvm-project?rev=320341&view=rev
Log:
Revert "[DataEncoder] Replace buggy versions of write functions."
The commit exposes a bunch of failures in the LLDB testsuite that
I need to analyze more carefully
Author: davide
Date: Mon Dec 11 13:21:53 2017
New Revision: 320422
URL: http://llvm.org/viewvc/llvm-project?rev=320422&view=rev
Log:
[Testsuite] Rename this file from *m -> *mm.
Should hopefully bring the bots back.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/variadic_method
Author: davide
Date: Mon Dec 11 13:52:02 2017
New Revision: 320425
URL: http://llvm.org/viewvc/llvm-project?rev=320425&view=rev
Log:
[test-suite] Un'XFAIL a test that's not failing anymore.
This is the first of a series of commits aiming to improve
overall LLDB's hygiene. Feel free to shout at me
Author: davide
Date: Mon Dec 11 17:14:11 2017
New Revision: 320444
URL: http://llvm.org/viewvc/llvm-project?rev=320444&view=rev
Log:
[testsuite] Remove testing failures vestiges.
Some tests are failing on macOS when building with the in-tree
clang, and this is because they're conditional on the v
Author: davide
Date: Mon Dec 11 17:21:43 2017
New Revision: 320447
URL: http://llvm.org/viewvc/llvm-project?rev=320447&view=rev
Log:
Rollback [Testsuite] Rename this file from *m -> *mm.
After discussing this with Jim and Jason, I think my commit was
actually sweeping the issue under the carpet r
Author: davide
Date: Mon Dec 11 18:10:23 2017
New Revision: 320450
URL: http://llvm.org/viewvc/llvm-project?rev=320450&view=rev
Log:
[testsuite] Remove even more testing vestiges.
With this one, the number of unexpected successes for the LLDB
test suite when building with clang ToT goes down to 1
Author: davide
Date: Mon Dec 11 18:32:49 2017
New Revision: 320452
URL: http://llvm.org/viewvc/llvm-project?rev=320452&view=rev
Log:
[TestCppScope] This test now passes on Darwin.
I tested on x86-64 and Jason on embedded architectures.
This cleans up another couple of reported unexpected successe
Author: davide
Date: Mon Dec 11 18:52:01 2017
New Revision: 320454
URL: http://llvm.org/viewvc/llvm-project?rev=320454&view=rev
Log:
[TestModulesInlineFunctions] This test now passes.
Remove yet another spurious unexpected success.
Ack'ed by Jim Ingham.
Fixes PR25743.
Modified:
lldb/trunk/
Author: davide
Date: Tue Dec 12 17:41:17 2017
New Revision: 320541
URL: http://llvm.org/viewvc/llvm-project?rev=320541&view=rev
Log:
[IRExecutionUnit] Initialize uninititialized member variable.
Found by the ubsan build.
Modified:
lldb/trunk/include/lldb/Expression/IRExecutionUnit.h
Modif
Author: davide
Date: Tue Dec 12 17:41:16 2017
New Revision: 320540
URL: http://llvm.org/viewvc/llvm-project?rev=320540&view=rev
Log:
[DataEncoder] Replace buggy versions of write functions.
This fixes a previously introduced thinko, now that I have
a better idea of what's going on :)
Modified:
Author: davide
Date: Thu Dec 14 15:03:35 2017
New Revision: 320759
URL: http://llvm.org/viewvc/llvm-project?rev=320759&view=rev
Log:
[ClangASTContext] Remove dead stuff found fixing something else.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/Clan
Author: davide
Date: Thu Dec 14 15:11:15 2017
New Revision: 320761
URL: http://llvm.org/viewvc/llvm-project?rev=320761&view=rev
Log:
[ExpressionParser] Fix evaluation failures due to mismatch in C++ versions.
Clang recently switched to C++14 (with GNU extensions) as the default
dialect, but LLDB
Author: davide
Date: Thu Dec 14 16:00:17 2017
New Revision: 320769
URL: http://llvm.org/viewvc/llvm-project?rev=320769&view=rev
Log:
[ExpressionParser] Rollback C++98 as the standard for evaluating.
Some ubuntu bots are failing with this patch in, let me unblock
while I investigate.
Modified:
Author: davide
Date: Thu Dec 14 16:50:43 2017
New Revision: 320778
URL: http://llvm.org/viewvc/llvm-project?rev=320778&view=rev
Log:
[ExpressionParser] Fix evaluation failures due to mismatch in C++ versions.
Clang recently switched to C++14 (with GNU extensions) as the default
dialect, but LLDB
Author: davide
Date: Fri Dec 15 14:22:51 2017
New Revision: 320883
URL: http://llvm.org/viewvc/llvm-project?rev=320883&view=rev
Log:
[MacOSX/Queues] Relax an overly aggressive assertion in a test.
"Default" is a valid QoS for a thread on older versions of macOS,
like the one installed in the bot.
Author: davide
Date: Fri Dec 15 15:27:10 2017
New Revision: 320891
URL: http://llvm.org/viewvc/llvm-project?rev=320891&view=rev
Log:
[CMake] darwin-debug is an hard dependency for tests on macOS.
Fixes a few failured on the testsuite with CMake.
Modified:
lldb/trunk/test/CMakeLists.txt
Modi
Author: davide
Date: Sun Dec 17 10:58:27 2017
New Revision: 320952
URL: http://llvm.org/viewvc/llvm-project?rev=320952&view=rev
Log:
[testsuite] Un-XFAIL the global variables tests.
Differential Revision: https://reviews.llvm.org/D41312
Modified:
lldb/trunk/packages/Python/lldbsuite/test
The bot is still green, this was a test XFAILed a while ago but never
reenabled (an oversight)
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/3376/
On Sun, Dec 17, 2017 at 10:58 AM, Davide Italiano via lldb-commits
wrote:
> Author: davide
> Date: Sun Dec 17 10:58:27 2017
> New
On Tue, Dec 19, 2017 at 11:54 PM, Adrian Prantl via lldb-commits
wrote:
> Author: adrian
> Date: Tue Dec 19 14:54:37 2017
> New Revision: 321120
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321120&view=rev
> Log:
> Fix a couple of warnings (NFC)
>
Thanks for doing this!
--
Davide
___
Thank you Pavel.
I was really nervous about making this change but I agree it's for the best.
Thanks,
--
Davide
On Thu, Dec 21, 2017 at 3:40 PM, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Thu Dec 21 06:40:03 2017
> New Revision: 321271
>
> URL: http://llvm.org/viewvc/llvm-pro
ping?
On Mon, Dec 11, 2017 at 12:55 AM, Davide Italiano wrote:
> ping. Any luck trying to write a testcase?
> This is a great opportunity to discuss whether is feasible and we can
> improve the testing strategy here.
>
> --
> Davide
>
> On Fri, Dec 1, 2017 at 11:02 AM, Davide Italiano
> wrote:
Jason, any chance we can write a test case for this?
--
Davide
On Mon, Dec 11, 2017 at 12:52 AM, Davide Italiano wrote:
> Testcase?
>
> On Fri, Dec 8, 2017 at 7:06 PM, Jason Molenda via lldb-commits
> wrote:
>> Author: jmolenda
>> Date: Fri Dec 8 19:06:19 2017
>> New Revision: 320240
>>
>> URL
What's the number of failures on Linux x86/64 red hat currently?
Thanks,
--
Davide
On Thu, Dec 21, 2017 at 4:09 PM, Pavel Labath wrote:
> Yeah, purely renaming the variables would be a bit like hiding
> problems under the carpet. But, I think adding the new test makes up
> for that. This way, a
gt; but I haven’t had time to look at that yet.
>
>> On Dec 21, 2017, at 7:01 AM, Davide Italiano via lldb-commits
>> wrote:
>>
>> Jason, any chance we can write a test case for this?
>>
>> --
>> Davide
>>
>>> On Mon, Dec 11, 2017 at 12:
Author: davide
Date: Tue Jan 2 08:22:09 2018
New Revision: 321651
URL: http://llvm.org/viewvc/llvm-project?rev=321651&view=rev
Log:
[ARM64] Remove unused function. NFCI.
Modified:
lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
Modified:
lldb/trunk/source/Plugins/In
Author: davide
Date: Tue Jan 2 08:24:30 2018
New Revision: 321652
URL: http://llvm.org/viewvc/llvm-project?rev=321652&view=rev
Log:
[MacOSX-Kernel] Remove broken KDP_IMAGEPATH support.
Modified:
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
Modified: lldb/trunk/source
Author: davide
Date: Tue Jan 2 08:27:01 2018
New Revision: 321654
URL: http://llvm.org/viewvc/llvm-project?rev=321654&view=rev
Log:
[Core/Debugger] Remove some code that doesn't compile anymore.
Modified:
lldb/trunk/source/Core/Debugger.cpp
Modified: lldb/trunk/source/Core/Debugger.cpp
URL:
thanks!
On Thu, Jan 4, 2018 at 5:42 PM, Adrian Prantl via lldb-commits
wrote:
> Author: adrian
> Date: Thu Jan 4 08:42:05 2018
> New Revision: 321802
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321802&view=rev
> Log:
> Look for external types in all clang modules imported by the current sym
Author: davide
Date: Thu Jan 4 15:37:18 2018
New Revision: 321833
URL: http://llvm.org/viewvc/llvm-project?rev=321833&view=rev
Log:
[IRExecutionUnit] Remove broken/dead code.
Modified:
lldb/trunk/source/Expression/IRExecutionUnit.cpp
Modified: lldb/trunk/source/Expression/IRExecutionUnit.cp
Author: davide
Date: Thu Jan 4 18:50:24 2018
New Revision: 321856
URL: http://llvm.org/viewvc/llvm-project?rev=321856&view=rev
Log:
[ArchSpec] Don't consider Unknown MachO64 as invalid.
Even without a proper arch we can access line tables, etc..
Modified:
lldb/trunk/source/Utility/ArchSpe
de
On Thu, Jan 4, 2018 at 6:50 PM, Davide Italiano via lldb-commits
wrote:
> Author: davide
> Date: Thu Jan 4 18:50:24 2018
> New Revision: 321856
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321856&view=rev
> Log:
> [ArchSpec] Don't consider Unknown MachO64 as i
Author: davide
Date: Fri Jan 5 10:00:44 2018
New Revision: 321879
URL: http://llvm.org/viewvc/llvm-project?rev=321879&view=rev
Log:
[ArchSpec] Add a unittest to complement the change in r321856.
Modified:
lldb/trunk/unittests/Utility/ArchSpecTest.cpp
Modified: lldb/trunk/unittests/Utility
On Thu, Jan 4, 2018 at 6:54 PM Davide Italiano via lldb-commits
> wrote:
>>
>> @Pavel, is there an easy way of testing this? m_core is a protected
>> member of ArchSpec so we can't set it willy-nilly, but still I'd like
>> to have some regression testing for th
On Tue, Jan 9, 2018 at 5:02 AM, Pavel Labath wrote:
> The inheritance trick can be useful sometimes, but I don't think it's
> a good way to write tests in general (and it should not be necessary
> for this patch).
>
> I assume you ran into this while working on a real-world bug. How were
> the rel
Picking a random commit in the `Environment` series.
Hey Pavel, I'm currently seeing errors when building with Xcode
Ld build/DebugClang/lldb-server normal x86_64
cd /Users/davide/work/lldb
export MACOSX_DEPLOYMENT_TARGET=10.11
/Volumes/Xcode10A36a_m18A103_i16A160a_t16J145_w16R149_
Also, the upstream `lldb-xcode` bot is red
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/
On Wed, Jan 10, 2018 at 10:26 AM, Davide Italiano wrote:
> Picking a random commit in the `Environment` series.
> Hey Pavel, I'm currently seeing errors when building with Xcode
>
> Ld build/DebugC
Author: davide
Date: Wed Jan 10 10:53:00 2018
New Revision: 322208
URL: http://llvm.org/viewvc/llvm-project?rev=322208&view=rev
Log:
[XCodebuild] Catch up with recent changes (Environment.cpp).
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pb
I understand, but having components untested is not ideal :(
On Wed, Jan 10, 2018 at 2:09 PM, Jim Ingham wrote:
> The only hard part of writing any kind of test for this is actually getting a
> legitimate .app into the testsuite. Doesn't seem fair to ask Pavel to do
> that, since he doesn't wo
On Thu, Jan 11, 2018 at 2:01 AM, Pavel Labath via lldb-commits
wrote:
> On 10 January 2018 at 22:51, Greg Clayton wrote:
>> The right solution seems to be adding some sort of custom GNU ABI tag to the
>> DWARF. I know that won't help with existing binaries, but it sounds too
>> expensive to set
Author: davide
Date: Thu Jan 11 14:38:57 2018
New Revision: 322322
URL: http://llvm.org/viewvc/llvm-project?rev=322322&view=rev
Log:
[testsuite] Remove a broken test which tried to find App in bundles.
That never really worked, and the change associated isn't yet
committed, so, let's try to make
The test Jim committed broke the public bots, so I went ahead and reverted it.
Committing to https://llvm.org/svn/llvm-project/lldb/trunk ...
commit 87eb2de0885d646e71d5848c1fa699b784bf5d2b
Author: Davide Italiano
Date: Thu Jan 11 14:37:49 2018 -0800
[testsuite] Remove a broken test which
On Thu, Jan 11, 2018 at 5:16 PM, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Thu Jan 11 17:16:13 2018
> New Revision: 322339
>
> URL: http://llvm.org/viewvc/llvm-project?rev=322339&view=rev
> Log:
> When parsing the target.xml register file, if no architecture has
> been speci
This is great, thanks Jason!
On Tue, Jan 16, 2018 at 4:22 PM, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Tue Jan 16 16:22:27 2018
> New Revision: 322603
>
> URL: http://llvm.org/viewvc/llvm-project?rev=322603&view=rev
> Log:
> Remove the hardcoded macos deployment targets al
The bot started failing recently, and this commit seems the most likely culprit.
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4513/
Can you please take a look, Vedant?
Thanks,
--
Davide
On Thu, Jan 25, 2018 at 10:01 AM, Vedant Kumar via lldb-commits
wrote:
> Author: vedantk
> Date
I see, thanks.
It looks like this is illformed C++, I'll take a look.
Thanks,
--
Davide
On Thu, Jan 25, 2018 at 1:14 PM, Vedant Kumar wrote:
> The test passes locally, but the cmake job is failing in the exact same way
> as the Xcode one. Based on the error, it looks like the compiler invocatio
yes, sure, I think that's the right thing to do.
--
Davide
On Thu, Jan 25, 2018 at 1:16 PM, Vedant Kumar wrote:
> We *could* x-fail this test on older OS's, but ISTM that we don't need this
> test to printf at all, so let's just remove the #include?
>
> vedant
>
> On Jan 25, 2018, at 1:14 PM, Ve
Cheer on!
On Thu, Jan 25, 2018 at 2:04 PM, Vedant Kumar wrote:
> Green: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4760/console
>
> On Jan 25, 2018, at 1:22 PM, Vedant Kumar wrote:
>
> Done, r323467
>
> On Jan 25, 2018, at 1:20 PM, Davide Italiano wrote:
>
> yes, sure, I think that
Author: davide
Date: Fri Jan 26 13:46:10 2018
New Revision: 323566
URL: http://llvm.org/viewvc/llvm-project?rev=323566&view=rev
Log:
[lldbtestsuite] Don't crash on `None` input for is_exe().
Now the function returns `False`, and the caller can take the
appropriate action (in this case, for --exec
On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano wrote:
> On Thu, Jan 11, 2018 at 5:16 PM, Jason Molenda via lldb-commits
> wrote:
>> Author: jmolenda
>> Date: Thu Jan 11 17:16:13 2018
>> New Revision: 322339
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=322339&view=rev
>> Log:
>> When parsi
On Mon, Jan 29, 2018 at 9:42 AM, David Blaikie via lldb-commits
wrote:
> Any chance of using unique_ptr or other RAII/etc ownership to make this API
> safer by default?
>
I agree that would be a more robust way of dealing with the problem.
Thanks,
--
Davide
_
Author: davide
Date: Mon Jan 29 15:24:50 2018
New Revision: 323707
URL: http://llvm.org/viewvc/llvm-project?rev=323707&view=rev
Log:
[test-suite] UNXfail several tests that now pass locally.
Another step towards enabling unexpected successes as failures
by default.
Modified:
lldb/trunk/pack
Nice, I wanted to do the same.
--
Davide
On Tue, Jan 30, 2018 at 11:49 AM, Vedant Kumar via lldb-commits
wrote:
> Author: vedantk
> Date: Tue Jan 30 11:49:05 2018
> New Revision: 323809
>
> URL: http://llvm.org/viewvc/llvm-project?rev=323809&view=rev
> Log:
> PR25934: Skip EventAPITestCase. It s
On Tue, Jan 30, 2018 at 1:16 PM, Vedant Kumar via lldb-commits
wrote:
> Author: vedantk
> Date: Tue Jan 30 13:16:42 2018
> New Revision: 323817
>
> URL: http://llvm.org/viewvc/llvm-project?rev=323817&view=rev
> Log:
> XUnit Formatter: Handle UTF-8 decode errors on invalid XML
>
> Strings which con
On Tue, Jan 30, 2018 at 3:45 PM, Alexander Shaposhnikov via
lldb-commits wrote:
> Author: alexshap
> Date: Tue Jan 30 15:45:20 2018
> New Revision: 323832
>
> URL: http://llvm.org/viewvc/llvm-project?rev=323832&view=rev
> Log:
> [lldb] Enable debugging of binaries with mixed (splitted/regular) dwa
Author: davide
Date: Tue Jan 30 20:13:37 2018
New Revision: 323845
URL: http://llvm.org/viewvc/llvm-project?rev=323845&view=rev
Log:
Revert "[lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf"
It might have caused some instability on the bots.
Removed:
lldb/trunk/packag
I went ahead for now and reverted in the hope this makes the bot green (again).
Committing to https://llvm.org/svn/llvm-project/lldb/trunk ...
commit f5d7ce2552c2003379bdbe78737f12dd50832b0d
Author: Davide Italiano
Date: Tue Jan 30 20:14:32 2018 -0800
Revert "[lldb] Enable debugging of bin
yes, apologies. I'll recommit in a minute.
--
Davide
On Tue, Jan 30, 2018 at 9:47 PM, Александр Шапошников
wrote:
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4609/ (after the
> revert) - the same 4 failures or am I missing smth ?
>
> Thanks,
> Alexander
>
> On Tue, Jan 30, 2018 at
Author: davide
Date: Wed Jan 31 07:17:47 2018
New Revision: 323879
URL: http://llvm.org/viewvc/llvm-project?rev=323879&view=rev
Log:
[lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf
This recommits the patch, now that I verified that the bot instability
is due to something e
On Thu, Feb 1, 2018 at 2:18 PM, Adrian Prantl via lldb-commits
wrote:
> Author: adrian
> Date: Thu Feb 1 14:18:02 2018
> New Revision: 324019
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324019&view=rev
> Log:
> Create a marker for Spotlight to never index $BUILD_DIR.
>
> LLDB queries Spotlig
I'm afraid this still wasn't enough to placate the bots.
http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4647/
Can you please take another look?
--
Davide
On Thu, Feb 1, 2018 at 2:27 PM, Davide Italiano wrote:
> On Thu, Feb 1, 2018 at 2:18 PM, Adrian Prantl via lldb-commits
> wrote:
>>
Thank you for fixing this and adding a test!
On Mon, Feb 5, 2018 at 2:46 AM, Jan Kratochvil via lldb-commits
wrote:
> Author: jankratochvil
> Date: Mon Feb 5 02:46:56 2018
> New Revision: 324222
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324222&view=rev
> Log:
> Fix upper->lower case for /
On Mon, Feb 5, 2018 at 9:25 AM, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Mon Feb 5 09:25:40 2018
> New Revision: 324254
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324254&view=rev
> Log:
> Fix parsing of object files with "early" section headers
>
> ObjectFileELF::GetMod
On Fri, Feb 2, 2018 at 2:48 PM, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Fri Feb 2 14:48:45 2018
> New Revision: 324156
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324156&view=rev
> Log:
> Fix a copy of a fixed length, possibly non-nul terminated, string
> into a std:
On Mon, Jan 29, 2018 at 10:17 AM, Jason Molenda wrote:
>
>
>> On Jan 28, 2018, at 9:59 PM, Davide Italiano wrote:
>>
>> On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano
>> wrote:
>>> On Thu, Jan 11, 2018 at 5:16 PM, Jason Molenda via lldb-commits
>>> wrote:
Author: jmolenda
Date: Thu
On Mon, Feb 5, 2018 at 10:09 AM, Pavel Labath wrote:
> Committed as r324256. Thanks for keeping me honest.
>
> Going back to this, I noticed that I did not check-in the final tiny
> binary that I intended to, which happened because I was rushing to get
> the build-id test fixed, so I could get bac
Author: davide
Date: Mon Feb 5 14:31:59 2018
New Revision: 324280
URL: http://llvm.org/viewvc/llvm-project?rev=324280&view=rev
Log:
[lang/Objc] UNXFAIL a test. Nullability has been implemented in clang.
(a while ago).
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-
On Mon, Feb 5, 2018 at 3:10 PM, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Mon Feb 5 15:10:51 2018
> New Revision: 324287
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324287&view=rev
> Log:
> Fix the cputype comparison in
> GDBRemoteCommunicationServerCommon::Handle_qHo
Author: davide
Date: Mon Feb 5 15:51:57 2018
New Revision: 324293
URL: http://llvm.org/viewvc/llvm-project?rev=324293&view=rev
Log:
[testsuite] Skip a flakey test.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-incomplete/TestIncompleteModules.py
Modified:
lldb/trun
ping. I might consider reverting this and the other commits without
tests bay the end of the week unless we have a story for testing here.
It's been one month.
On Mon, Feb 5, 2018 at 9:44 AM, Davide Italiano wrote:
> On Mon, Jan 29, 2018 at 10:17 AM, Jason Molenda wrote:
>>
>>
>>> On Jan 28, 201
Thanks!
On Tue, Feb 6, 2018 at 1:04 PM, Adrian Prantl via lldb-commits
wrote:
> Author: adrian
> Date: Tue Feb 6 13:04:06 2018
> New Revision: 324400
>
> URL: http://llvm.org/viewvc/llvm-project?rev=324400&view=rev
> Log:
> Remove obsolete file
>
> Removed:
> lldb/trunk/packages/Python/lldbs
On Wed, Feb 7, 2018 at 8:20 PM, Adrian Prantl wrote:
>
>
> > On Feb 7, 2018, at 6:40 PM, Zachary Turner wrote:
>
> > and the command line in the log file doesn’t ever work for me'
>
> That's a bug. Can you show me an example where this breaks for you? I'd
> like to investigate this.
>
> -- adri
Author: davide
Date: Fri Feb 9 08:06:39 2018
New Revision: 324743
URL: http://llvm.org/viewvc/llvm-project?rev=324743&view=rev
Log:
[Testsuite] Remove leak tests, it's not useful anymore.
This only worked on MacOS, which now ships a newer version of
python without this bug. As such, we don't lea
Author: davide
Date: Fri Feb 9 11:35:07 2018
New Revision: 324768
URL: http://llvm.org/viewvc/llvm-project?rev=324768&view=rev
Log:
[lldb-mi] This test now passes consistently, unXFAIL it.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py
Modified:
l
pr` (unfortunately I can't think of a way to
> check that an FD is not leaked in a different way than with a
> full-scale integration test).
>
> On 9 February 2018 at 22:48, Vedant Kumar via lldb-commits
> wrote:
> > Nice!
> >
> > vedant
> >
> >
Author: davide
Date: Mon Feb 12 10:06:34 2018
New Revision: 324919
URL: http://llvm.org/viewvc/llvm-project?rev=324919&view=rev
Log:
[testsuite] Reintroduce test to check leaking.
It wasn't python leaking, it was lldb. Thanks to Pavel for the
explanation. Pointy-hat to me.
Added:
lldb/trunk
On Mon, Feb 19, 2018 at 9:23 AM, Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: labath
> Date: Mon Feb 19 09:23:13 2018
> New Revision: 325519
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325519&view=rev
> Log:
> Two more dosep-paralellization fallout fixes
>
> T
Author: davide
Date: Wed Feb 21 11:18:49 2018
New Revision: 325708
URL: http://llvm.org/viewvc/llvm-project?rev=325708&view=rev
Log:
[testsuite/decorators] Get rid of some `expectFlakey` variants.
These seem to be pretty much dead.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorato
101 - 200 of 582 matches
Mail list logo
