[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

davide added inline comments. Comment at: lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:25 +#include + shafik wrote: > Why? also should be `cstdlib` in C++. It's just something shuffled around, probably a side effect of clang-format. CHAN

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

davide added a comment. Greg & Pavel might have opinions on this patch. I'm not qualified to review it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81119/new/ https://reviews.llvm.org/D81119 ___ lldb

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. Danke shoen CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82394/new/ https://reviews.llvm.org/D82394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82394/new/ https://reviews.llvm.org/D82394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. commit 2276bb48be0175f96b1494ca67b7921f0d4e87d8 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Tue Jun 23 10:18:54 2020 -0700 [debugserver] Initial support for Apple Silicon. Set the correct os type in the arch tri

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide created this revision. davide added reviewers: jasonmolenda, aprantl, friss. jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. davide closed this revision. LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_f

[Lldb-commits] [PATCH] D82493: [Apple Silicon] Debugging of process under Rosetta is supported

davide created this revision. davide added reviewers: jasonmolenda, friss, aprantl. Remove this early exit. It's vestigial from the ppc -> Intel transition, but it doesn't apply anymore: https://reviews.llvm.org/D82493 Files: lldb/source/Host/macosx/objcxx/Host.mm Index: lldb/source/Host/m

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide closed this revision. davide added a comment. commit fd19ddb8f2a2b082f492fc59f7f360adf3495701 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jun 24 12:18:29 2020 -0700 [Apple Silicon] Initial support for Rosetta Translated proc

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide added a comment. In D82491#2112269 , @jasonmolenda wrote: > LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_flag & > P_TRANSLATED) as a boolean, but that's a style pref as much as anything. Fair, let me change that. CHANGES

[Lldb-commits] [PATCH] D82493: [Apple Silicon] Debugging of process under Rosetta is supported

davide accepted this revision. davide added a comment. commit b4fdddf971b191aa9a6643ab637b87bc1d686254 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jun 24 12:25:01 2020 -0700 [Apple Silicon] Debugging of process under Rosetta is supported.

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

davide created this revision. davide added reviewers: vsk, aprantl, jasonmolenda. Now that there are two implementations of debugserver, one for native and the other for Rosetta [on Apple Silicon], this is needed. https://reviews.llvm.org/D82804 Files: lldb/packages/Python/lldbsuite/test/dot

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide updated this revision to Diff 274253. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm lldb/source/Plugins/Process/gdb-remot

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Run a shell command. + /// \arg process_info The info structure for the process queried. Stale comment, I'll update CHANGES SINCE LAST

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide created this revision. davide added reviewers: aprantl, jasonmolenda. Nothing crazy here, just an organizational cleanup. https://reviews.llvm.org/D82813 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm lldb/source/Plugi

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3444 +size_t bufsize = sizeof(processInfo); +if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo, + &

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:366 -if args.server: +if args.server and not args.out_of_tree_debugserver: os.environ['LLDB_DEBUGSERVER_PATH'] = args.server ---

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. aprantl wrote: > Is

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

davide accepted this revision. davide added a comment. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82616/new/ https://reviews.llvm.org/D82616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424 +if (Host::IsProcessTranslated(process_info)) { + FileSpec rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide abandoned this revision. davide added a comment. Cleaning up my queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43048/new/ https://reviews.llvm.org/D43048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

davide added a comment. Aside from cosmetics, I'm not entirely sure this is the correct fix. Why are we calling this code _at all_ if the type is incomplete? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83327/new/ https://reviews.llvm.org/D83327

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

davide added a comment. In D83327#2136842 , @jingham wrote: > In D83327#2136814 , @davide wrote: > > > Aside from cosmetics, I'm not entirely sure this is the correct fix. Why > > are we calling this code _at all_

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

This revision was automatically updated to reflect the committed changes. davide marked an inline comment as done. Closed by commit rG5832473dcf4e: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed. (authored by davide). Herald added a project: LLDB. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

This revision was automatically updated to reflect the committed changes. davide marked an inline comment as done. Closed by commit rG5832473dcf4e: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed. (authored by davide). Herald added a project: LLDB. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

davide added a comment. This broke macOS: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22425/ I reverted it in: commit 27d52cd86a2cf82214b71519dffd450c54cf87ae (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jul 8 13:00:29 2020 -0700 Re

[Lldb-commits] [PATCH] D83582: Fix nesting of #ifdef

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83582/new/ https://reviews.llvm.org/D83582 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D83600: Add a decorator to skip tests when running under Rosetta

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Good, one minor suggestion. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:560 +return False +return platform.uname()[5] == "arm" and self.

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

davide created this revision. davide added a reviewer: teemperor. rdar://problem/65537147 https://reviews.llvm.org/D83796 Files: lldb/source/Plugins/Language/ObjC/NSArray.cpp lldb/source/Plugins/Language/ObjC/NSDictionary.cpp Index: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp ==

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f2d880a9329: [ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR… (authored by davide). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

davide added a comment. commit 6f4398d1b9950d48ead91b2b550792f2bbe4778e (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Nov 20 12:27:26 2019 -0800 [lldb] Fix NSURL data formatter truncation issue Remove hardcoded string prefix length a

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

davide accepted this revision. davide added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

davide added a comment. Hey Jordan, it looks like some of the changes to TestEditLine [or adjacent to it] broke the sanitized build on macOS. Can I ask you to take a look? Thanks http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/539/console Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

davide added a comment. In D70324#1755704 , @labath wrote: > [This is probably not the right patch, as the last run on that bot still > doesn't have this commit.] > > My understanding is that all pexpect tests are failing on that bot and are > skipped wi

[Lldb-commits] [PATCH] D69273: ValueObject: Fix a crash related to children address type computation

davide added a comment. We've been off all the past week. I'll circle back with Jim about this once I get to the office. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69273/new/ https://reviews.llvm.org/D69273 __

[Lldb-commits] [PATCH] D70983: [TypeCategory] Nothing passes down a list of languages.

davide created this revision. davide added reviewers: teemperor, jingham, friss. Herald added a project: LLDB. This should allow further simplifications, but it's a first step. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70983 Files: lldb/include/lldb/DataFormatters/TypeC

[Lldb-commits] [PATCH] D70983: [TypeCategory] Nothing passes down a list of languages.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15a172bebbc5: [TypeCategory] Nothing passes down a list of languages. (authored by davide). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70983/new/ https:/

[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70979/new/ https://reviews.llvm.org/D70979 ___ lldb-commit

[Lldb-commits] [PATCH] D70989: [TypeCategory] IsApplicable doesn't seem to apply.

davide created this revision. davide added reviewers: teemperor, friss, jingham. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70989 Files: lldb/include/lldb/DataFormatters/TypeCategory.h lldb/source/DataFormatters/TypeCategory.cpp Index: lldb

[Lldb-commits] [PATCH] D70989: [TypeCategory] IsApplicable doesn't seem to apply.

davide added a comment. Please don't merge this yet. I'm mostly trying to understand if this is dead code or not. @jingham , this is one of the places in generic code where we hardcode knowledge about the languages. Needless to say, it causes conflicts downstream and feels wrong anyway. After

[Lldb-commits] [PATCH] D70989: [TypeCategory] IsApplicable doesn't seem to apply.

davide abandoned this revision. davide added a comment. Nevermind, I found a better way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70989/new/ https://reviews.llvm.org/D70989 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject.

davide created this revision. davide added reviewers: jingham, teemperor, JDevlieghere, aprantl. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71236 Files: lldb/include/lldb/DataFormatters/FormatManager.h lldb/source/DataFormatters/FormatClasse

[Lldb-commits] [PATCH] D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc69dd2cfae3: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject. (authored by davide). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D712

[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()

davide created this revision. davide added reviewers: teemperor, JDevlieghere, aprantl, jingham. Herald added a subscriber: mgorny. Herald added a project: LLDB. JDevlieghere accepted this revision. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo https://rev

[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d955f29de7: [FormatManager] Add a unittest for GetCandidateLanguages() (authored by davide). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71299/new/ http

[Lldb-commits] [PATCH] D71305: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject.

davide created this revision. davide added reviewers: aprantl, teemperor. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71305 Files: lldb/include/lldb/DataFormatters/TypeCategory.h lldb/source/DataFormatters/TypeCategory.cpp Index: lldb/sourc

[Lldb-commits] [PATCH] D71305: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbcdcea4bf84: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject. (authored by davide). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71305/n

[Lldb-commits] [PATCH] D71297: Remove unsound caching in LanguageCategory

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71297/new/ https://reviews.llvm.org/D71297 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

davide added a comment. This one looks fine -- can you please check that this patch applied on swift still produces something reasonable for mixed obj-C/swift formatters? My guess is that it will, and you probably just need to update some tests. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

davide added a comment. In D71310#1778534 , @jingham wrote: > Adrian and I talked about this some more. Apparently the idea was that you > have some type Foo and you want to look for some error state in instances of > that type (Foo::a + Foo::b < 10).

[Lldb-commits] [PATCH] D71296: Replace redundant code in LanguageCategory with templates (NFC)

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, in the same vein as D71231 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71296/new/ https://reviews.llvm.org/D71296 ___

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

davide added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSException.cpp:107-109 + if (NSStringSummaryProvider(*reason_sp, reason_str_summary, options) && + !reason_str_summary.Empty()) { +stream.Printf("%s", reason_str_summary.GetData()); ---

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide created this revision. davide added reviewers: teemperor, aprantl, labath, friss, jingham. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71316 Files: lldb/source/DataFormatters/FormatManager.cpp lldb/unittests/DataFormatter/FormatManager

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide added a comment. This is not a bad idea after all. Let me see if I can cook something reasonable without getting burned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316 ___

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide added a comment. Ideally -- if we're able to make this a callback in the language plugins, we don't need this patch at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Did you test on swift? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71311/new/ https://reviews.llvm.org/D71311 ___

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71311/new/ https://reviews.llvm.org/D71311 __

[Lldb-commits] [PATCH] D71379: lldbutil: Forward ASan launch info to test inferiors

davide accepted this revision. davide added a comment. This looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71379/new/ https://reviews.llvm.org/D71379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D68679: [CMake] Add a cache for iOS.

davide abandoned this revision. davide added a comment. We don't need this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68679/new/ https://reviews.llvm.org/D68679 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. Raphael and Jim should look at the expression evaluator bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. In D72413#1812464 , @aprantl wrote: > Should we merge this like that, or is there a better way of doing this? We should merge it like this, IMHO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. @teemperor what do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

davide added a comment. In D72413#1813630 , @teemperor wrote: > The C++ expression parser will probably behave incredibly incorrectly without > a persistent state but before this patch it just crashed, so I think this is > good to go. Should we conside

[Lldb-commits] [PATCH] D72495: [lldb] Make CompleteTagDeclsScope completion order deterministic

davide accepted this revision. davide added a comment. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72495/new/ https://reviews.llvm.org/D72495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

davide added a comment. This is very good, go for it. Should we do the same for Swift? cc: @aprantl For the future, please CC: me directly on these kind of changes if you want my review, as I might miss them otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://r

[Lldb-commits] [PATCH] D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Looks great! Thanks Adrian. My understanding is that `DW_OP_piece` is still incomplete, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D728

[Lldb-commits] [PATCH] D73389: [lldb/Breakpoint] Include whether or not a breakpoint is a HW BP

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73389/new/ https://reviews.llvm.org/D73389 ___ lldb-commit

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, thanks for taking care of this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73913/new/ https://reviews.llvm.org/D73913 ___ lldb-

[Lldb-commits] [PATCH] D73913: [lldb/DataExtractor] Fix UB shift in GetMaxS64Bitfield

davide added a comment. In D73913#1855486 , @shafik wrote: > I wish I had caught that one when I did D70992 > , might be worth checking out more of the > code for similar issues. I guess this is why we have tooling =)

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

davide added a comment. `DWARFASTParserClang` looks to me the right layer to fix this. Why can't this be caught in the generic DWARF Parser? I also believe that it's better if `dwarfdump -verify` crashes on this, rather than lldb. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73921/new

[Lldb-commits] [PATCH] D73921: Assert that a subprogram should have a name when parsing DWARF

davide added a comment. DWARFASTParserClang looks to me the wrong layer to fix this. Why can't this be caught in the generic DWARF Parser? I also believe that it's better if dwarfdump -verify crashes on this, rather than lldb. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73921/new/ h

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it.

davide created this revision. davide added reviewers: jingham, friss, vsk. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73938 Files: lldb/source/Host/macosx/objcxx/Host.mm Index: lldb/source/Host/macosx/objcxx/Host.mm =

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide closed this revision. davide added a comment. Not relevant anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D73952: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType

davide added a comment. Good catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73952/new/ https://reviews.llvm.org/D73952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

<    1   2   3   4   5   6