[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

davide added a comment. I wanted to remove it a while ago, but Jason told me he found this useful, so I would wait for his opinion. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65469/new/ https://reviews.llvm.org/D65469

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

davide added a comment. Other than that, I have no objections. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65469/new/ https://reviews.llvm.org/D65469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

davide added a comment. Really on the lldb side, Jonas is the right person to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ lldb-commit

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

davide added a comment. [and Raphael for the clang vendor bits] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D65547: [Reproducers] Force replay in synchronous mode.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65547/new/ https://reviews.llvm.org/D65547 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D65781: [CompilerType] Remove an unused function.

davide created this revision. davide added reviewers: teemperor, JDevlieghere, xiaobai, compnerd, friss. Herald added a project: LLDB. This simplifies the interface, as I'm trying to understand how we can upstream swift support. rdar://problem/36377967 Repository: rG LLVM Github Monorepo htt

[Lldb-commits] [PATCH] D65781: [CompilerType] Remove an unused function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367946: [CompilerType] Remove an unused function. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D65782: [CompilerType] Simplify the interface a bit more..

davide created this revision. davide added reviewers: shafik, JDevlieghere, alex, compnerd, teemperor. Herald added a project: LLDB. .. removing IsMeaninglessWithoutTypeResolution(). I'm fairly confident this was introduced to support swift, where static types [without dynamic counterpart] don't c

[Lldb-commits] [PATCH] D65782: [CompilerType] Simplify the interface a bit more..

This revision was automatically updated to reflect the committed changes. Closed by commit rL367957: [CompilerType] Simplify the interface a bit more.. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D65782: [CompilerType] Simplify the interface a bit more..

davide added a comment. In D65782#1615959 , @alex wrote: > I was marked as a review on this, but I suspect you intended to get some > other Alex :-) yes, sorry. My bad. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65782

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. You might want to check with Argyrios, maybe file a rdar against SourceKit. Otherwise, this is fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D65872: [lldb][NFC] Check in test case for testing virtual function calls in pointers and references.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I seem to remember there was a bug where you run the expression twice and the second time it crashes/it's not evaluated correctly [at least this is what I remember talking to Lang ~18 months a

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

davide added a comment. I think this is definitely a good idea but Chandler or DBlaikie might want to take a look at this one too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65942/new/ https://reviews.llvm.org/D65942 ___ lldb-commits ma

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

davide added a comment. Did you manage to file a rdar for this issue? If so, can you put the link here for future archeology? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65874/new/ https://reviews.llvm.org/D65874 _

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

davide created this revision. davide added reviewers: xiaobai, compnerd. Herald added a project: LLDB. davide added a reviewer: aprantl. And not `zero`. This is the last API needed to be converted to an Optional. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66093 Files: ll

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

davide added a comment. More than error handling, this allows us to distinguish with a type with zero alignment (if possible at all?) and an error getting the alignment from ASTContext/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66093/new/ htt

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:803 + + size_t byte_align = (*opt_bit_align + 7) / 8; aprantl wrote: > does this also need to be 7ull? I'm going to move this to a fu

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368614: [Symbol] GetTypeBitAlign() should return None in case of failure. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66102/new/ https://reviews.llvm.org/D66102 ___

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

davide added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/stop-hooks/Makefile:4 +C_SOURCES := main.c +CFLAGS_EXTRAS += -std=c99 + Forgive my ignorance, but why you need this? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D66241: stop-hooks don't fire on "step-out"

davide added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/stop-hooks/Makefile:4 +C_SOURCES := main.c +CFLAGS_EXTRAS += -std=c99 + jingham wrote: > davide wrote: > > Forgive my ignorance, but why you need this? > That's how the dotes

[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

davide created this revision. davide added reviewers: jasonmolenda, friss. Herald added a project: LLDB. The former seems like it's not working on some platforms. All the other uses use `llvm::`, so, let's change for consistency. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

davide added a comment. I and Jason discussed this offline and he's fine with it, so, I'm going to land this now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66566/new/ https://reviews.llvm.org/D66566 _

[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369618: [lldb] Replace std::once_flag with llvm::once_flag. (authored by davide, committed by ). Herald added a project: L

[Lldb-commits] [PATCH] D66774: [dotest] Remove long running test "decorator" and re-enable tests.

davide added a comment. Herald added a subscriber: dexonsmith. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66774/new/ https://reviews.llvm.org/D66774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D66837: [dotest] Remove -q (quiet) flag.

davide added a comment. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66837/new/ https://reviews.llvm.org/D66837 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D66858: POSIX DYLD: add workaround for android L loader

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Thanks. I'm going to clean the diff downstream. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66858/new/ https://reviews.llvm.org/D66858 ___

[Lldb-commits] [PATCH] D66893: [dotest] Don't try to guess the llvm binary dir.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66893/new/ https://reviews.llvm.org/D66893 ___ lldb-commits

[Lldb-commits] [PATCH] D66915: [TSanRuntime] Upstream thread swift race detector.

davide created this revision. davide added a reviewer: kubamracek. Herald added a project: LLDB. This is self-contained, and doesn't need anything in the compiler to work. Mainly to reduce the diff between upstream and downstream. Patch by Kuba Mracek! Repository: rG LLVM Github Monorepo htt

[Lldb-commits] [PATCH] D66915: [TSanRuntime] Upstream thread swift race detector.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370286: [TSanRuntime] Upstream thread swift race detector. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D67116: [lldb][NFC] Remove unused overload of File::Read

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. You can just go ahead with patches like this one. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67116/new/ https://reviews.llvm.org/D67116 ___

[Lldb-commits] [PATCH] D67183: [Python] Implement truth testing for lldb.value

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67183/new/ https://reviews.llvm.org/D67183 ___ lldb-commits

[Lldb-commits] [PATCH] D67184: [Python] Implement __next__ for value_iter

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67184/new/ https://reviews.llvm.org/D67184 ___ lldb-commits

[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB packet struct into the reproducer. (NFC)

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Easy peasy. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67523/new/ https://reviews.llvm.org/D67523 ___ lldb-

[Lldb-commits] [PATCH] D67540: [lldb] Remove SetCount/ClearCount from Flags

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Sure. If anything something like this should live in llvm/Support, but given it's not used, it should live nowhere. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D67644: [ScriptInterpreter] Initialize globals when loading a scripting module.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67644/new/ https://reviews.llvm.org/D67644 ___ lldb-commits

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. If this doesn't break clang and gcc, fine. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67856/new/ https://reviews.llvm.org/D67856 __

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

davide added a comment. Just keep an eye on the bots as they might start whining http://green.lab.llvm.org/green/ otherwise, just go ahead. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67856/new/ https://reviews.llvm.org/D67856

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

davide added a comment. While the intentions of exposing this are good, the implementation leaks too many details. In fact, there shouldn't be anything outside of ScriptInterpreter guarded by `LLDB_DISABLE_PYTHON`. You might want also to realize that having `ePathTypePythonDir` goes against the

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

davide added a comment. @clayborg I would also like to point out that some of us fair amount of time cleaning `LLDB_DISABLE_PYTHON` leaking all over the codebase, and this is basically the last occurrence, so we're motivated to have this going away/fixed in some way. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM but this should really be fixed upstream (in libedit) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61191/new/ https://reviews.llvm.org/D61191

[Lldb-commits] [PATCH] D61244: Re-enable gmodules tests on Linux

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61244/new/ https://reviews.llvm.org/D61244 ___ lldb-commits

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

davide added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, count1); this seems ...

[Lldb-commits] [PATCH] D61299: Rename Minion to ASTImporterDelegate

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. yay :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61299/new/ https://reviews.llvm.org/D61299 _

[Lldb-commits] [PATCH] D61406: [CommandObjectCommands] Honor stop-command-source-on-error

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61406/new/ https://reviews.llvm.org/D61406 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D61414: [test] Convert TestWatchpointSetErrorCases.py to lit

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61414/new/ https://reviews.llvm.org/D61414 ___ lldb-commits

[Lldb-commits] [PATCH] D61533: Make lldb-mi optional and change how we deal with missing tools in lit

davide added inline comments. Comment at: lldb/lit/tools/lldb-instr/lit.local.cfg:1 -import sys - -if not config.have_lldb_instr: +if not "lldb-inst" in config.available_features: config.unsupported = True lldb-instr. CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo()

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. What's the scenario that's causing this? Adding a nullptr check is an obviously save thing to do, but it would be excellent if we could add a comment explaining why the symbol could

[Lldb-commits] [PATCH] D61872: [CMake] Simplify lldb-server handling

davide added inline comments. Comment at: lldb/tools/CMakeLists.txt:12 add_lldb_tool_subdirectory(lldb-mi) +add_lldb_tool_subdirectory(lldb-server) add_lldb_tool_subdirectory(lldb-vscode) This probably predates the use of `add_lldb_tool_subdirectory` in lldb.

[Lldb-commits] [PATCH] D61872: [CMake] Simplify lldb-server handling

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61872/new/ https://reviews.llvm.org/D61872 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D62219: [FileSystem] Fix regression in FileSystem::Resolve

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, also discussed in person. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62219/new/ https://reviews.llvm.org/D62219 _

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

davide added a comment. What if ~ is not writable either? I think we shouldn't fallback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62216/new/ https://reviews.llvm.org/D62216 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D62284: Replace integer literals which are cast to bool

davide accepted this revision as: LLDB. davide added a comment. Herald added a subscriber: rnkovacs. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62284/new/ https://reviews.llvm.org/D62284 ___ lldb-commits ma

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Do you have a testcase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62352/new/ https://reviews.llvm.org/D62352 ___ lldb-comm

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

davide resigned from this revision. davide added a comment. This revision is now accepted and ready to land. I don't think I'm qualified enough to comment further on this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62352/new/ https://reviews.llvm.org/D62352 _

[Lldb-commits] [PATCH] D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName

davide added a comment. To elaborate further, I'm not familiar with this code so I really shouldn't be the person to approve the patch. On the other hand I'm somewhat nervous as refactors in this area of the codebase caused bugs/crashes in lldb, fundamentally due to changes in behavior previou

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

davide added a comment. yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63311/new/ https://reviews.llvm.org/D63311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

davide added a comment. Can you add a screenshot of the final result for everybody? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62743/new/ https://reviews.llvm.org/D62743 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62743/new/ https://reviews.llvm.org/D62743 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D63679: [lit] Make lit-lldb-init configurable by CMake

davide accepted this revision. davide added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63679/new/ https://reviews.llvm.org/D63679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

davide created this revision. davide added reviewers: JDevlieghere, sgraenitz, aprantl, friss. Herald added a subscriber: mgorny. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63745 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

davide added a comment. rdar://problem/52078735 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63745/new/ https://reviews.llvm.org/D63745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

davide added a comment. In D63745#1556941 , @labath wrote: > This code should go to `tools/debugserver/source/CMakeLists.txt` so that it > is next to the code which performs the actual code signing. Doing that will > make it easier to keep it in sync wit

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

davide updated this revision to Diff 206475. davide added a comment. Address feedback from many. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63745/new/ https://reviews.llvm.org/D63745 Files: lldb/tools/debugserver/source/CMakeLists.txt Index

[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL364334: [CMake] Check that a certificate for lldb is present at build time. (authored by davide, committed by ). Herald ad

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

davide added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; clayborg wrote: > Still seems weird that any lan

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/dollar-in-variable/main.c:4-5 +int main() { + int $foo = 42; + return 0; //%self.expect("e

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/dollar-in-variable/main.c:4-5 +int main() { + int $foo = 42; + return 0; //%self.expect("expr $foo", substrs=['(int) $0 = 42']) +} davide wrote: > what if you have

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

davide added a comment. I thought about this a little more, and we discussed offline, but these are my two comments (we should understand what's the behaviour and add tests). We can address some of them as follow-up but I would like to understand what happens here. 1. For C++, lldb names expre

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64254/new/ https://reviews.llvm.org/D64254 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D64265: [CplusPlus] ISVTableName is unused. NFCI.

davide created this revision. davide added reviewers: teemperor, JDevlieghere. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64265 Files: lldb/include/lldb/Target/CPPLanguageRuntime.h lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/It

[Lldb-commits] [PATCH] D64265: [CplusPlus] ISVTableName is unused. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365243: [CplusPlus] ISVTableName is unused. NFCI. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

davide added inline comments. Comment at: lldb/source/Utility/LLDBAssert.cpp:25-26 + // In a Debug configuration lldb_assert() behaves like assert(). + assert(false && "lldb_assert failed"); + + // In a Release configuration it will print a warning and encourage the user -

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

davide added inline comments. Comment at: lldb/trunk/source/Symbol/ClangASTContext.cpp:1957 } else { -// BAD!!! +assert(false && "GetUniqueNamespaceDeclaration called with no name and " +"no namespace as decl_ctx");

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

davide added inline comments. Comment at: lldb/trunk/source/Symbol/ClangASTContext.cpp:1957 } else { -// BAD!!! +assert(false && "GetUniqueNamespaceDeclaration called with no name and " +"no namespace as decl_ctx");

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This is adding a fair amount of complexity on something that just works fine on basically every platform but AIX. If AIX has issue with `psutil`, maybe the fix should be submitted to

[Lldb-commits] [PATCH] D64546: [lldb] Make TestDeletedExecutable more reliable

davide added a comment. Yeah, I'd rather have an explicit communication between debugger and debuggee. We tried to put sleeps in the code [for e.g. `lldb-mi` tests in the past] and they end up failing anyway sporadically, which makes a pain to track the problem down. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D64545: [lldb] Don't use __FUNCTION__ as a file name

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This seems fairly straighforward and I'm in favor of it. We maybe should do the same thing with swift, I haven't checked in a while how we call the file there. I wouldn't bother adding a test f

[Lldb-commits] [PATCH] D64782: [SWIG] Deprecate SWIG 1.x

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Thanks. I fear this might break some bots, but the best way to see if that's the case is trying. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64782/ne

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/main.c:9 +#include + TWeaver wrote: > Hi there, > > this is a little nit picky, and I'm not entirely sure If im right in saying > so,

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

davide added subscribers: jasonmolenda, compnerd. davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py:212-215 + +module_name = "libsystem_malloc.dylib" +if not os_de

[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py:242-257 +break_results = lldbutil.run_break_set_command( +self, "b /%s/" % +self.regex) +

[Lldb-commits] [PATCH] D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule

davide added a comment. That real In D64769#1587992 , @kusmour wrote: > In D64769#1587318 , @labath wrote: > > > The change is fine, but for my own education, could you elaborate on what > > this "delayed calculat

[Lldb-commits] [PATCH] D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This looks good. If it bothers you a lot (given you're probably one of the few users), you can do this only under `verbose` (although now that's a single line is very concise). Repository:

[Lldb-commits] [PATCH] D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose

davide added a comment. I don't think it's worth adding a test for the logs. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64858/new/ https://reviews.llvm.org/D64858 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This is good for now. I would add a comment explaining what you explained in the differential at the beginning of the macro section. Great work! Repository: rLLDB LLDB CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D64989: [lldb] Fix crash when looking up type coming from the ClangModuleDeclVendor

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. No brainer. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64989/new/ https://reviews.llvm.org/D64989 ___ lldb-

[Lldb-commits] [PATCH] D64995: [lldb] Fix crash when tab-completing in multi-line expr

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. See if you can write a pexpect test, as Pavel suggested. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64995/new/ https://reviews.llvm.org/D64995

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

davide added a comment. Thanks for taking care of this. It's a lot of work. First round of comments. Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:12 + +CFBasicHash::~CFBasicHash() { m_address = LLDB_INVALID_ADDRESS; } + Why do you need this? Ca

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

davide added a comment. This is almost ready. After we're done with this round of cosmetics, I'll take another look a the algorithm and sign off. Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:18-19 + return true; +else if (m_ptr_size == 8 && m_ht_64) +

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

davide added a comment. This looks fine to me but please give Pavel another chance to look before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78396/new/ https://reviews.llvm.org/D78396 _

[Lldb-commits] [PATCH] D78588: [lldb/Core] Check that ArchSpec is valid.

davide added a comment. What's exactly the testcase doing? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78588/new/ https://reviews.llvm.org/D78588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. Weak functions can actually be overridden -- I'm really wondering whether this causes issues here. Do you have an example [even if it's in swift] of a symbol that's not exported correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. Saleem is the right person to review this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78972/new/ https://reviews.llvm.org/D78972 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. I'm really worried about this change -- and we should think about it very carefully because it might cause the LLVM verifier to freak out -- or even worse, causing random crashes when executing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

davide added a comment. I'm curious what happens if you end up here with something like `_T`. Did you check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.llvm.org/D79823 __

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Presumably. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.llvm.org/D79823

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

davide added a comment. Looking, as I touched `NSDate` last year. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80150/new/ https://reviews.llvm.org/D80150 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

davide accepted this revision. davide added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/DataFormatters/Mock.h:1-8 +//===-- Mock.h --*- C++ -*-===// +// +// Part of the LLVM Projec

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

davide added a comment. This is great Adrian. I feel like there are several other instances of additions that should use `llvm::checkAdd` here instead of `+`. Is this the only UB triggered in the testsuite? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80955/new/ https://reviews.llvm.

<    1   2   3   4   5   6   >