=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern
@@ -436,8 +482,8 @@ class CompilerType {
ExecutionContextScope *exe_scope);
/// Dump to stdout.
- void DumpTypeDescription(lldb::DescriptionLevel level =
- lldb::eDescriptionLevelFull) const;
DavidSpickett wrot
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/73472
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
=?utf-8?q?Jos=C3=A9?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett commented:
Some minor comments on the printing loop.
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -1618,12 +1621,15 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
if (symbol->ValueIsAddress()) {
DumpAddress(
interpret
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/73811
None
>From 27e279c17fb7747f252b4eca58e3dd1d44845191 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 29 Nov 2023 16:03:37 +
Subject: [PATCH] Do not land, just testing the formatting job!
---
DavidSpickett wrote:
Want to know if I'm allowed to add reviewers if the initial clang-format fails.
https://github.com/llvm/llvm-project/pull/73811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
DavidSpickett wrote:
I was able to add reviewers.
https://github.com/llvm/llvm-project/pull/73811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/73811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -436,8 +482,8 @@ class CompilerType {
ExecutionContextScope *exe_scope);
/// Dump to stdout.
- void DumpTypeDescription(lldb::DescriptionLevel level =
- lldb::eDescriptionLevelFull) const;
DavidSpickett wrot
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/73472
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/73472
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Please add a note to
https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.rst#changes-to-lldb,
since this is quite a substantial new feature.
> Test Plan:
Did this get discussed? I don't see any tests here.
https://github.com/llvm/llvm-project/pull/70996
DavidSpickett wrote:
If this code is calling a library - which itself is already tested, that's fine
but any smoke test we can do would be good.
E.g. set a bogus URL and expect that it fails to use it (assuming it does so
visibly). Just to check the integration.
https://github.com/llvm/llvm-p
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -252,11 +253,16 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
s
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69422
=?utf-8?q?Jos=C3=A9?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Nominating @JDevlieghere to review this.
https://github.com/llvm/llvm-project/pull/69422
DavidSpickett wrote:
I can see why the mistake was made, we have an index into a list of different
indexes? Anyway, please add a test for this.
https://github.com/llvm/llvm-project/pull/74413
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -231,6 +231,25 @@ class Str
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -70,6 +72,31 @@ size_t Stre
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -246,8 +246,8 @@ class Addr
DavidSpickett wrote:
Is testing this possible?
https://github.com/llvm/llvm-project/pull/74414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -246,8 +246,8 @@ class Addr
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https:
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -246,8 +246,8 @@ class Addr
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -246,8 +246,8 @@ class Addr
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -70,6 +72,31 @@ size_t Stre
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -70,6 +72,31 @@ size_t Stre
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -246,8 +246,8 @@ class Addr
https://github.com/DavidSpickett approved this pull request.
Testing sounds like more effort than it's worth, let's not block this on that.
https://github.com/llvm/llvm-project/pull/74414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrot
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
DavidSpickett wrote:
> doesn't appear to be anything that calls these methods
Candidate for removal then? If so it still makes sense to fix them, then remove
them. Saves fixing them again if they are brought back.
Either way, I'm not going to block this by requiring a test case.
https://githu
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
https://github.com/DavidSpickett approved this pull request.
Not 100% that the skips are going to work for AArch64 but I'll fix that if it
is the case.
https://github.com/llvm/llvm-project/pull/74818
___
lldb-commits mailing list
lldb-commits@lists.ll
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/74818
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
My intent when asking for this link was that links to the README of lldb-vscode
would end up going to the README of lldb-dap (maybe the wrong section, but at
least you'd know the name had changed). The audience for it is small but I
didn't want to make it even smaller by g
DavidSpickett wrote:
It was not the case, all green again!
https://github.com/llvm/llvm-project/pull/74818
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
Author: David Spickett
Date: 2023-12-08T11:24:07Z
New Revision: ffd61c1e96e9c8a472f305585930b45be0d639d3
URL:
https://github.com/llvm/llvm-project/commit/ffd61c1e96e9c8a472f305585930b45be0d639d3
DIFF:
https://github.com/llvm/llvm-project/commit/ffd61c1e96e9c8a472f305585930b45be0d639d3.diff
LOG
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
Author: David Spickett
Date: 2023-12-08T13:34:07Z
New Revision: ce3c7c09100803608177459b4d923f17742885f9
URL:
https://github.com/llvm/llvm-project/commit/ce3c7c09100803608177459b4d923f17742885f9
DIFF:
https://github.com/llvm/llvm-project/commit/ce3c7c09100803608177459b4d923f17742885f9.diff
LOG
Author: David Spickett
Date: 2023-12-08T13:36:41Z
New Revision: 810d09faf89af53025205c540ef9980e2286e687
URL:
https://github.com/llvm/llvm-project/commit/810d09faf89af53025205c540ef9980e2286e687
DIFF:
https://github.com/llvm/llvm-project/commit/810d09faf89af53025205c540ef9980e2286e687.diff
LOG
Author: David Spickett
Date: 2023-12-08T13:44:06Z
New Revision: 61f18255fab3c404dc43a59091a750c22e5d0ccb
URL:
https://github.com/llvm/llvm-project/commit/61f18255fab3c404dc43a59091a750c22e5d0ccb
DIFF:
https://github.com/llvm/llvm-project/commit/61f18255fab3c404dc43a59091a750c22e5d0ccb.diff
LOG
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
DavidSpickett wrote:
Going to merge this to fix the bots.
Our Windows bot does have the DIA SDK installed, but I don't know if it's being
used. We'll see, if it breaks, I'll deal with it.
https://github.com/llvm/llvm-project/pull/75272
___
lldb-commi
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/75272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-12-13T11:15:46Z
New Revision: 887f2110280fd9a37003fd2bb811c6c1dcf4370d
URL:
https://github.com/llvm/llvm-project/commit/887f2110280fd9a37003fd2bb811c6c1dcf4370d
DIFF:
https://github.com/llvm/llvm-project/commit/887f2110280fd9a37003fd2bb811c6c1dcf4370d.diff
LOG
DavidSpickett wrote:
This test crashes on Arm and AArch64:
```
TEST 'lldb-api ::
python_api/global_module_cache/TestGlobalModuleCache.py' FAILED
Script:
--
/usr/bin/python3.8
/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dot
Author: David Spickett
Date: 2023-12-13T11:34:43Z
New Revision: 35dacf2f51af251a74ac98ed29e7c454a619fcf1
URL:
https://github.com/llvm/llvm-project/commit/35dacf2f51af251a74ac98ed29e7c454a619fcf1
DIFF:
https://github.com/llvm/llvm-project/commit/35dacf2f51af251a74ac98ed29e7c454a619fcf1.diff
LOG
Author: David Spickett
Date: 2023-12-13T11:49:24Z
New Revision: e34c35a21ccc215ce507a1e19b4ff2a1ce9906f3
URL:
https://github.com/llvm/llvm-project/commit/e34c35a21ccc215ce507a1e19b4ff2a1ce9906f3
DIFF:
https://github.com/llvm/llvm-project/commit/e34c35a21ccc215ce507a1e19b4ff2a1ce9906f3.diff
LOG
Author: David Spickett
Date: 2023-12-13T12:46:16Z
New Revision: f59fed261e30ddeecb6c6bfb53e47ecd4b124e7a
URL:
https://github.com/llvm/llvm-project/commit/f59fed261e30ddeecb6c6bfb53e47ecd4b124e7a
DIFF:
https://github.com/llvm/llvm-project/commit/f59fed261e30ddeecb6c6bfb53e47ecd4b124e7a.diff
LOG
DavidSpickett wrote:
I merged your fix and a few follow ups to get it all to compile. Now we have 2
failures on Windows:
https://lab.llvm.org/buildbot/#/builders/219/builds/7554/steps/6/logs/stdio
```
Failed Tests (2):
lldb-api :: lang/cpp/unique-types4/TestUniqueTypes4.py
lldb-unit ::
Sym
DavidSpickett wrote:
@clayborg and @walter-erquinigo are lldb-dap code owners and should be able to
advise.
https://github.com/llvm/llvm-project/pull/75342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
@@ -0,0 +1,169 @@
+"""
+Test the use of the global module cache in lldb
+"""
+
+import lldb
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+import os
+import shutil
+from pathlib import Path
+import time
+
+cl
Author: David Spickett
Date: 2023-12-14T10:54:03Z
New Revision: d0f5039e5db5c2b9222f78e7242401061ab259dc
URL:
https://github.com/llvm/llvm-project/commit/d0f5039e5db5c2b9222f78e7242401061ab259dc
DIFF:
https://github.com/llvm/llvm-project/commit/d0f5039e5db5c2b9222f78e7242401061ab259dc.diff
LOG
DavidSpickett wrote:
Failures didn't reproduce locally, so this is back in with an extra assert and
logging enabled so I can catch it if it happens again.
https://github.com/llvm/llvm-project/pull/74894
___
lldb-commits mailing list
lldb-commits@lists
DavidSpickett wrote:
> If we need to expected fail the python test on window until we can look into
> it, I would vote to do this.
As it happens, I'm using the buildbot machine to reproduce this. So it's not
doing any more builds for now. I'll put in workarounds if I don't find the
issue by F
Author: David Spickett
Date: 2023-12-14T16:51:12Z
New Revision: 481bb62e50317cf20df9493aad842790162ac3e7
URL:
https://github.com/llvm/llvm-project/commit/481bb62e50317cf20df9493aad842790162ac3e7
DIFF:
https://github.com/llvm/llvm-project/commit/481bb62e50317cf20df9493aad842790162ac3e7.diff
LOG
Author: David Spickett
Date: 2023-12-14T16:55:07Z
New Revision: 71b4d7498ffecca5957fa0a63b1abf141d7b8441
URL:
https://github.com/llvm/llvm-project/commit/71b4d7498ffecca5957fa0a63b1abf141d7b8441
DIFF:
https://github.com/llvm/llvm-project/commit/71b4d7498ffecca5957fa0a63b1abf141d7b8441.diff
LOG
Author: David Spickett
Date: 2023-12-14T19:17:49Z
New Revision: 1bce61e6b01b38e04260be4f422bbae59c34c766
URL:
https://github.com/llvm/llvm-project/commit/1bce61e6b01b38e04260be4f422bbae59c34c766
DIFF:
https://github.com/llvm/llvm-project/commit/1bce61e6b01b38e04260be4f422bbae59c34c766.diff
LOG
DavidSpickett wrote:
I've caught it happening on Arm. We appear to be trying to pop the base plan
after finishing a single step, going to read through the code tomorrow to
figure out why.
In the meantime, I've removed all my modifications and skipped it on Arm and
AArch64 Linux.
https://gith
DavidSpickett wrote:
My extra logging resulted in this:
```
intern-state Thread::ShouldStop Begin
intern-state Plan stack initial state:
thread #1: tid = 0x47d2d:
Active plan stack:
Element 0: Base thread plan.
Element 1: Single stepping past breakpoint
DavidSpickett wrote:
Thanks! Testing this locally.
If it works I'll probably land this and then work on what you suggested
updating the PDB input file.
https://github.com/llvm/llvm-project/pull/75566
___
lldb-commits mailing list
lldb-commits@lists.l
DavidSpickett wrote:
Though the original assert was: `m_plans.size() > 1 && "Can't pop the base
thread plan"`
Not that there was exactly 1 plan on the stack. So `current_plan` might be the
single step plan as expected, then when we go to pop that off the stack, but
the stack has been emptied/
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/75566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Works locally, I'll do the unit test update this afternoon and get the bot
running again.
https://github.com/llvm/llvm-project/pull/75566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
DavidSpickett wrote:
Also seen on Linaro's Windows on Arm 2 stage bot:
https://lab.llvm.org/buildbot/#/builders/120/builds/5990
https://github.com/llvm/llvm-project/pull/73685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
DavidSpickett wrote:
I didn't get time for the follow up, so I'm going to put the bot back online
over the weekend and come back to it on Monday.
https://github.com/llvm/llvm-project/pull/75566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/75813
NestedClass will be found via Class::NestedClass and ClassTypedef::NestedClass.
So the first part of the test gets 2 results as the default is to find all
matching types.
In the next part, we ask for only
DavidSpickett wrote:
https://github.com/llvm/llvm-project/pull/75813 for the unit test.
https://github.com/llvm/llvm-project/pull/75566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
DavidSpickett wrote:
On the subject of `TestUniqueTypes4.py`, the program on Windows contains no
symbol data, but on Linux I see:
```
[ 78]111 Data0x00011038
0x0008 0x0021 ns::Foo::value
```
Which I think is the key here.
The puz
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/75813
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/75927
The way this code was updated in dd9587795811ba21e6ca6ad52b4531e17e6babd6 meant
that if the first module did not have the symbol, the iteration stopped as
returning true means stop. So only if every module
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/75927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
`lldb/include/lldb/Symbol/CompileUnit.h`
```
/// \param[in] lambda
/// The lambda that should be applied to every function. The lambda can
/// return true if the iteration should be aborted earlier.
///
/// \return
/// If the lambda early-exited, this
DavidSpickett wrote:
I would have thought
`lldb/test/API/lang/cpp/gmodules/templates/TestGModules.py` would have failed
then as it has >1 module.
Do you know what "external module" means in this context, as opposed to just
module? The code searches "the clang Module" first, then the external
DavidSpickett wrote:
The PDB was not the issue, it's always worked that way and the DWARF is still
in the main executable.
I've opened https://github.com/llvm/llvm-project/issues/75936 for
`TestUniqueTypes4.py` because I think this commit did not break the test that
already existed, but in ch
Author: David Spickett
Date: 2023-12-19T14:25:23Z
New Revision: 970152bec1ca2e9a924fb8dc92d098bd110b4dae
URL:
https://github.com/llvm/llvm-project/commit/970152bec1ca2e9a924fb8dc92d098bd110b4dae
DIFF:
https://github.com/llvm/llvm-project/commit/970152bec1ca2e9a924fb8dc92d098bd110b4dae.diff
LOG
Author: David Spickett
Date: 2023-12-20T08:46:10Z
New Revision: a756dc4724a279d76898bacd054a04832b02caa8
URL:
https://github.com/llvm/llvm-project/commit/a756dc4724a279d76898bacd054a04832b02caa8
DIFF:
https://github.com/llvm/llvm-project/commit/a756dc4724a279d76898bacd054a04832b02caa8.diff
LOG
DavidSpickett wrote:
> It would be interesting to see if changing the test to explicitly kill the
> process, then its target, then the Debugger makes the crash go away.
Trying this as
https://github.com/llvm/llvm-project/commit/a756dc4724a279d76898bacd054a04832b02caa8.
https://github.com/llvm
Author: David Spickett
Date: 2023-12-20T09:41:33Z
New Revision: d14d52158bc444e2d036067305cf54aeea7c9edb
URL:
https://github.com/llvm/llvm-project/commit/d14d52158bc444e2d036067305cf54aeea7c9edb
DIFF:
https://github.com/llvm/llvm-project/commit/d14d52158bc444e2d036067305cf54aeea7c9edb.diff
LOG
Author: David Spickett
Date: 2023-12-20T09:42:07Z
New Revision: 01c4ecb7ae21a61312ff0c0176c0ab9f8656c159
URL:
https://github.com/llvm/llvm-project/commit/01c4ecb7ae21a61312ff0c0176c0ab9f8656c159
DIFF:
https://github.com/llvm/llvm-project/commit/01c4ecb7ae21a61312ff0c0176c0ab9f8656c159.diff
LOG
@@ -1160,7 +1160,9 @@ Status CommandInterpreter::AddUserCommand(llvm::StringRef
name,
if (UserCommandExists(name)) {
if (!can_replace) {
- result.SetErrorString("user command exists and force replace not set");
+ result.SetErrorString(
+ "user command
@@ -1160,7 +1160,9 @@ Status CommandInterpreter::AddUserCommand(llvm::StringRef
name,
if (UserCommandExists(name)) {
if (!can_replace) {
- result.SetErrorString("user command exists and force replace not set");
+ result.SetErrorString(
+ "user command
@@ -161,6 +161,17 @@ def cleanup():
)
self.expect("my_command", substrs=["a.out"])
+# Test that without --overwrite we are not allowed to redefine the
command.
+self.expect(
+"command script add my_command --class welcome.Targetname
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/75927
>From a7770da9e2a997eefced82b9ebb305b464fec70d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 19 Dec 2023 12:46:54 +
Subject: [PATCH] [lldb][DWARF] Searchfor symbols in all external modules
T
601 - 700 of 2678 matches
Mail list logo
