[Lldb-commits] [lldb] [lldb][Docs] Various style improvements to the tutorial (PR #90594)

2024-04-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90594 * Replace "we" with either "you" (when talking to the reader) or "lldb" (when talking about the project). * Always refer to lldb as lldb not LLDB, to match what the user sees on the command line. * Remove

[Lldb-commits] [lldb] [lldb][Docs] Various style improvements to the tutorial (PR #90594)

2024-04-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Always refer to lldb as lldb not LLDB, to match what the user sees on the > command line. If this were any other doc I'd say it should always be LLDB and GDB as that's the projects' branding. In this doc I think it's better to imagine the user is looking at side by side

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

2024-04-30 Thread David Spickett via lldb-commits
@@ -1465,6 +1465,20 @@ class Process : public std::enable_shared_from_this, /// platforms where there is a difference (only Arm Thumb at this time). lldb::addr_t FixAnyAddress(lldb::addr_t pc); + /// Retrieve the actual address masks for high memory code/data, + /// wit

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

2024-04-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: On the face of it > When we have an unset high memory address mask, and we are told to set low- > and high-memory to the same new address mask, maintain the high memory mask > as unset in Process. The same thing is done with the > SBProcess::SetAddressMask API when the us

[Lldb-commits] [lldb] [lldb] Fixed SyntaxWarning invalid escape sequence '\s' in decorators.py (PR #90607)

2024-04-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Thanks for the fix! https://github.com/llvm/llvm-project/pull/90607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed SyntaxWarning invalid escape sequence '\s' in decorators.py (PR #90607)

2024-04-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed SyntaxWarning invalid escape sequence '\l' in lldbtest.py (PR #90609)

2024-04-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/90609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed SyntaxWarning invalid escape sequence '\l' in lldbtest.py (PR #90609)

2024-04-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Sort documented packets alphabetically (PR #90584)

2024-05-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90584 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Various style improvements to the tutorial (PR #90594)

2024-05-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yes fair point the docs as a whole prefer the branding. As the document itself was mostly lower case that also influenced me. I tried to put the name changes in their own commit but some are spread around, so I'll be a bit cheeky and land this as is then come back with a P

[Lldb-commits] [lldb] [lldb][Docs] Various style improvements to the tutorial (PR #90594)

2024-05-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90594 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Use proper LLDB/GDB project branding in tutorial (PR #90712)

2024-05-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90712 Except when referring to the program binaries. >From c004c331828080273679d5de8145c916285c607d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 May 2024 10:08:55 +0100 Subject: [PATCH] [lldb][Docs

[Lldb-commits] [lldb] [lldb][Docs] Use proper LLDB/GDB project branding in tutorial (PR #90712)

2024-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Remove .txt copy of tutorial (PR #90585)

2024-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Narrow vectorcall xfail to x86 platforms (PR #84024)

2024-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/84024 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Remove corefile test xfails (PR #84022)

2024-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/84022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

2024-05-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: Seems logical to me, keep the 99% use case simple and folks who know they need a high mem mask have to put in the extra effort to really consider it. https://github.com/llvm/llvm-project/pull/90533 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

2024-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/90533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: The tests for the next PR depend on the format decided by https://github.com/llvm/llvm-project/pull/90059, which needs more work. So I will land this once that's sorted out. https://github.com/llvm/llvm-project/pull/90063 ___ lld

[Lldb-commits] [lldb] d00ed83 - [lldb] Fix build on FreeBSD

2024-05-02 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-05-02T10:12:36+01:00 New Revision: d00ed836e77759414afd40c02eeca5651657438f URL: https://github.com/llvm/llvm-project/commit/d00ed836e77759414afd40c02eeca5651657438f DIFF: https://github.com/llvm/llvm-project/commit/d00ed836e77759414afd40c02eeca5651657438f.diff

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

2024-05-02 Thread David Spickett via lldb-commits
@@ -141,6 +145,24 @@ std::optional SymbolLocatorDefault::LocateExecutableSymbolFile( FileSystem::Instance().Resolve(file_spec); debug_file_search_paths.AppendIfUnique(file_spec); } +#if defined(__FreeBSD__) +// Add $LOCALBASE/lib/debug directory, where LOCA

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Account for spsr being 8 bytes in newer versions (PR #84032)

2024-05-02 Thread David Spickett via lldb-commits
@@ -362,7 +363,15 @@ TEST(RegisterContextFreeBSDTest, arm64) { EXPECT_GPR_ARM64(lr, lr); EXPECT_GPR_ARM64(sp, sp); EXPECT_GPR_ARM64(pc, elr); +#if __FreeBSD_version >= 1400084 DavidSpickett wrote: Good point. Though these tests are likely only run on the

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Account for spsr being 8 bytes in newer versions (PR #84032)

2024-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/84032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Account for spsr being 8 bytes in newer versions (PR #84032)

2024-05-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: Fixing the general issue needs more attention, so I am abandoning this fix. https://github.com/llvm/llvm-project/pull/84032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

2024-05-02 Thread David Spickett via lldb-commits
@@ -141,6 +145,24 @@ std::optional SymbolLocatorDefault::LocateExecutableSymbolFile( FileSystem::Instance().Resolve(file_spec); debug_file_search_paths.AppendIfUnique(file_spec); } +#if defined(__FreeBSD__) +// Add $LOCALBASE/lib/debug directory, where LOCA

[Lldb-commits] [lldb] [lldb] Fix Scalar::GetData for non-multiple-of-8-bits values (PR #90846)

2024-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/90846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix step in AArch64 trampoline (PR #90783)

2024-05-02 Thread David Spickett via lldb-commits
@@ -506,9 +506,29 @@ DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan(Thread &thread, Target &target = thread.GetProcess()->GetTarget(); const ModuleList &images = target.GetImages(); - images.FindSymbolsWithNameAndType(sym_name, eSymbolTypeCode, target_symbols); -

[Lldb-commits] [lldb] [lldb] fix step in AArch64 trampoline (PR #90783)

2024-05-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: My first instinct with this sort of `if arch is bla` code is to put it into a plugin, usually the ABI. However this being ELF specific, and the ELF plugin not having access to a target to get the ABI from, that's not possible. The DYLD plugin could but then we still have 2

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Remove xfails from TestGDBRemoteLoad (PR #84026)

2024-05-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: ping! https://github.com/llvm/llvm-project/pull/84026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Remove xfails from TestGDBRemoteLoad (PR #84026)

2024-05-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/84026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/90917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-05-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/88845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-05-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: > And make the note at the end of lldb/docs/use/qemu-testing.rst outdated. Removing this is the last thing to do here. https://github.com/llvm/llvm-project/pull/88845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-03 Thread David Spickett via lldb-commits
@@ -13,11 +13,42 @@ #include #include +#include "llvm/ADT/StringSet.h" + namespace lldb_private { class StreamString; class Log; +class FieldEnum { +public: + struct Enumerator { +uint64_t m_value; +// Short name for the value. Shown in tables and when printi

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-03 Thread David Spickett via lldb-commits
@@ -13,11 +13,42 @@ #include #include +#include "llvm/ADT/StringSet.h" + namespace lldb_private { class StreamString; class Log; +class FieldEnum { +public: + struct Enumerator { +uint64_t m_value; +// Short name for the value. Shown in tables and when printi

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks for the reviews. The next PR has some test output that depends on the format added in https://github.com/llvm/llvm-project/pull/90059, which itself has some complexity I didn't expect. So I'm going to work on that PR first before updating this. https://github.com/

[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)

2024-05-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: I found a few things: * Yes you can get these flags like enums with a register field as expected. * Only C++ code can manipulate a `DumpValueObjectOptions` object, there's no Python binding at all. * The only Python tests for it are things that call commands that then use th

[Lldb-commits] [lldb] 327bfc9 - Revert "[lldb] Fix TestSharedLibStrippedSymbols for #90622"

2024-05-03 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-05-03T13:04:05Z New Revision: 327bfc971e4dce3f6798843c92406cda95c07ba1 URL: https://github.com/llvm/llvm-project/commit/327bfc971e4dce3f6798843c92406cda95c07ba1 DIFF: https://github.com/llvm/llvm-project/commit/327bfc971e4dce3f6798843c92406cda95c07ba1.diff LOG

[Lldb-commits] [lldb] LLDB Debuginfod tests and a fix or two (PR #90622)

2024-05-03 Thread David Spickett via lldb-commits
@@ -87,8 +105,15 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP &module_sp, FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths(); FileSpec dsym_fspec = PluginManager::LocateExecutableSymbolFile(module_spec, search_paths); - if (!dsym_fspec)

[Lldb-commits] [lldb] LLDB Debuginfod tests and a fix or two (PR #90622)

2024-05-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] LLDB Debuginfod tests and a fix or two (PR #90622)

2024-05-03 Thread David Spickett via lldb-commits
@@ -87,8 +105,15 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP &module_sp, FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths(); FileSpec dsym_fspec = PluginManager::LocateExecutableSymbolFile(module_spec, search_paths); - if (!dsym_fspec)

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-05-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: Nope, that would be lovely and is closer than ever with the move to GitHub, but not here yet. https://github.com/llvm/llvm-project/pull/88845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-05-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/88845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix step in AArch64 trampoline (PR #90783)

2024-05-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] LLDB Debuginfod tests and a fix or two (PR #90622)

2024-05-08 Thread David Spickett via lldb-commits
@@ -87,8 +105,15 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP &module_sp, FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths(); FileSpec dsym_fspec = PluginManager::LocateExecutableSymbolFile(module_spec, search_paths); - if (!dsym_fspec)

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Fix some concurrent event tests (PR #84155)

2024-05-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: Ok for me to land this or are you still going to check them locally? https://github.com/llvm/llvm-project/pull/84155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb][ELF] Return address class map from symbol table parsing methods (PR #91585)

2024-05-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/91585 Instead of updating the member of the ObjectFileELF instance. This means that if one object file asks another to parse the symbol table, that first object's address class map is not left empty, which would

[Lldb-commits] [lldb] LLDB Debuginfod tests and a fix or two (PR #90622)

2024-05-09 Thread David Spickett via lldb-commits
@@ -87,8 +105,15 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP &module_sp, FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths(); FileSpec dsym_fspec = PluginManager::LocateExecutableSymbolFile(module_spec, search_paths); - if (!dsym_fspec)

[Lldb-commits] [lldb] [lldb][ELF] Return address class map from symbol table parsing methods (PR #91585)

2024-05-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: We can compare against the path the plugin found, though it's surprising that the plugins return anything at all so maybe there is a bug there too. It'll need a new test case, as `TestStringLiteralExpr.test` will no longer hit the code I'm changing in this PR, so I'll do i

[Lldb-commits] [lldb] [lldb][ELF] Return address class map from symbol table parsing methods (PR #91585)

2024-05-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/91585 >From 34c5ac8292b34d96039c6c69326f3fceb5cc3499 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 9 May 2024 11:23:32 + Subject: [PATCH 1/2] [lldb][ELF] Return address class map from symbol table

[Lldb-commits] [lldb] [lldb][ELF] Return address class map changes from symbol table parsing methods (PR #91585)

2024-05-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/91585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ELF] Return address class map changes from symbol table parsing methods (PR #91585)

2024-05-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/91585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ELF] Return address class map changes from symbol table parsing methods (PR #91585)

2024-05-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: I realised that as it was, the calling object file would get its map updated but not the other object file. Which is potentially a regression if we choose to use one or the other file for a lookup. So now the methods update the member map, and return the changes they made

[Lldb-commits] [lldb] [lldb][ELF] Move address class map into the symbol table (PR #91603)

2024-05-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/91603 Code in https://github.com/llvm/llvm-project/pull/90622 exposed a situation where a symbol table may be loaded via a second copy of the same object. This resulted in the first copy having its address class

[Lldb-commits] [lldb] [lldb][ELF] Return address class map changes from symbol table parsing methods (PR #91585)

2024-05-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: Alternative: https://github.com/llvm/llvm-project/pull/91603 https://github.com/llvm/llvm-project/pull/91585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ELF] Move address class map into the symbol table (PR #91603)

2024-05-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: The only thing I can think of that breaks this is if some object wanted to use the same symbol table section, but interpret it in a different way that changed the address classes. I don't see any evidence of us doing that or needing to. Even if we did it'd probably change

[Lldb-commits] [lldb] [lldb][ELF] Return address class map changes from symbol table parsing methods (PR #91585)

2024-05-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: > The Symtab class is generic, while the approach of marking address types via > fake symtab symbols is (I think) an elf invention. I didn't see any use of `AddressClass::eCodeAlternateISA` outside of ObjectFileELF so I think you're right. I'll go with this PR then. http

[Lldb-commits] [lldb] [lldb][ELF] Return address class map changes from symbol table parsing methods (PR #91585)

2024-05-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/91585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ELF] Move address class map into the symbol table (PR #91603)

2024-05-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/91603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ELF] Move address class map into the symbol table (PR #91603)

2024-05-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: Went with https://github.com/llvm/llvm-project/pull/91585 instead. https://github.com/llvm/llvm-project/pull/91603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [lldb][ELF] Move address class map into the symbol table (PR #91603)

2024-05-10 Thread David Spickett via lldb-commits
@@ -23,6 +23,8 @@ class Symtab { public: typedef std::vector IndexCollection; typedef UniqueCStringMap NameToIndexMap; + typedef std::map + FileAddressToAddressClassMap; DavidSpickett wrote: Yes, we binary search it later. I will at least add a comme

[Lldb-commits] [lldb] [lldb][ELF] Return address class map changes from symbol table parsing methods (PR #91585)

2024-05-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: There are a couple in MachO actually but you're right, different mechanism being used. https://github.com/llvm/llvm-project/pull/91585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] LLDB Debuginfod tests and a fix or two (PR #90622)

2024-05-10 Thread David Spickett via lldb-commits
@@ -87,8 +105,15 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP &module_sp, FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths(); FileSpec dsym_fspec = PluginManager::LocateExecutableSymbolFile(module_spec, search_paths); - if (!dsym_fspec)

[Lldb-commits] [lldb] LLDB Debuginfod tests and a fix or two (PR #90622)

2024-05-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: I've fixed the underlying issue on Arm, you do not need to make any changes to this code to fix it. It should "just work" now. I see some unresolved comments about other test failures, and if I reland this I'll get all the buildbot emails and have no clue what to do to fix

[Lldb-commits] [lldb] 1aca8ed - [lldb][ELF] Add a comment to explain address class map type

2024-05-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-05-10T09:25:03Z New Revision: 1aca8ed5a7eeed264fdc2694deca8a4a4dba3689 URL: https://github.com/llvm/llvm-project/commit/1aca8ed5a7eeed264fdc2694deca8a4a4dba3689 DIFF: https://github.com/llvm/llvm-project/commit/1aca8ed5a7eeed264fdc2694deca8a4a4dba3689.diff LOG

[Lldb-commits] [lldb] 3a870bf - [lldb] Add missing space in C string format memory read warning

2021-12-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-12-08T11:20:25Z New Revision: 3a870bffb108516bc1c09818538466db4f1a505d URL: https://github.com/llvm/llvm-project/commit/3a870bffb108516bc1c09818538466db4f1a505d DIFF: https://github.com/llvm/llvm-project/commit/3a870bffb108516bc1c09818538466db4f1a505d.diff LOG

[Lldb-commits] [lldb] 88fdce5 - [lldb] Remove non address bits from memory read arguments

2022-01-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-11T13:24:09Z New Revision: 88fdce5be696c7ef992cffce9da9ec6895a1abfc URL: https://github.com/llvm/llvm-project/commit/88fdce5be696c7ef992cffce9da9ec6895a1abfc DIFF: https://github.com/llvm/llvm-project/commit/88fdce5be696c7ef992cffce9da9ec6895a1abfc.diff LOG

[Lldb-commits] [lldb] 091e760 - [lldb] Don't print "Command Options Usage:" for an alias with no options

2022-01-12 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-12T10:07:38Z New Revision: 091e760cd39848f3c41900b5104b3d92028d91b4 URL: https://github.com/llvm/llvm-project/commit/091e760cd39848f3c41900b5104b3d92028d91b4 DIFF: https://github.com/llvm/llvm-project/commit/091e760cd39848f3c41900b5104b3d92028d91b4.diff LOG

[Lldb-commits] [lldb] 3fd9c90 - [lldb][AArch64] Correct top nibble setting in memory tag read tests

2022-01-12 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-12T12:28:13Z New Revision: 3fd9c90bdc04df451d9bb348450b5ad424c822c6 URL: https://github.com/llvm/llvm-project/commit/3fd9c90bdc04df451d9bb348450b5ad424c822c6 DIFF: https://github.com/llvm/llvm-project/commit/3fd9c90bdc04df451d9bb348450b5ad424c822c6.diff LOG

[Lldb-commits] [lldb] cf7bfd6 - [lldb][AArch64] Remove armv8.3-a flag from tagged memory read test

2022-01-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-13T14:25:18Z New Revision: cf7bfd6d059e58263594858e21b5547acabae568 URL: https://github.com/llvm/llvm-project/commit/cf7bfd6d059e58263594858e21b5547acabae568 DIFF: https://github.com/llvm/llvm-project/commit/cf7bfd6d059e58263594858e21b5547acabae568.diff LOG

[Lldb-commits] [lldb] 585abe3 - [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

2022-01-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-20T10:47:05Z New Revision: 585abe3ba506e410b382f8130f72b9368573a781 URL: https://github.com/llvm/llvm-project/commit/585abe3ba506e410b382f8130f72b9368573a781 DIFF: https://github.com/llvm/llvm-project/commit/585abe3ba506e410b382f8130f72b9368573a781.diff LOG

[Lldb-commits] [lldb] 787f91b - [lldb] Remove non-address bits from addresses given to memory tag commands

2022-01-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-20T10:48:14Z New Revision: 787f91b0bb34abeca86ad5c8a60ef044a7942996 URL: https://github.com/llvm/llvm-project/commit/787f91b0bb34abeca86ad5c8a60ef044a7942996 DIFF: https://github.com/llvm/llvm-project/commit/787f91b0bb34abeca86ad5c8a60ef044a7942996.diff LOG

[Lldb-commits] [lldb] 7d19566 - [lldb] Ignore non-address bits in "memory find" arguments

2022-01-24 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-24T10:42:49Z New Revision: 7d19566c3bfb3efacb629d18839e2d85761156ab URL: https://github.com/llvm/llvm-project/commit/7d19566c3bfb3efacb629d18839e2d85761156ab DIFF: https://github.com/llvm/llvm-project/commit/7d19566c3bfb3efacb629d18839e2d85761156ab.diff LOG

[Lldb-commits] [lldb] ee0c382 - [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

2022-01-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-26T11:30:10Z New Revision: ee0c3820f8862aaf39d7ad542672092c35dda266 URL: https://github.com/llvm/llvm-project/commit/ee0c3820f8862aaf39d7ad542672092c35dda266 DIFF: https://github.com/llvm/llvm-project/commit/ee0c3820f8862aaf39d7ad542672092c35dda266.diff LOG

[Lldb-commits] [lldb] 37c4bd0 - [lldb] Add MemoryTagMap class

2022-01-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-26T13:55:48Z New Revision: 37c4bd0fdbc6bc5ec6145765d6f4dcd06540201d URL: https://github.com/llvm/llvm-project/commit/37c4bd0fdbc6bc5ec6145765d6f4dcd06540201d DIFF: https://github.com/llvm/llvm-project/commit/37c4bd0fdbc6bc5ec6145765d6f4dcd06540201d.diff LOG

[Lldb-commits] [lldb] 5d2f90c - [lldb] Correct some uses of \b in Doxygen documentation

2022-01-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-26T14:05:58Z New Revision: 5d2f90cbcd5f64d3b47ba5d2738939be66f05936 URL: https://github.com/llvm/llvm-project/commit/5d2f90cbcd5f64d3b47ba5d2738939be66f05936 DIFF: https://github.com/llvm/llvm-project/commit/5d2f90cbcd5f64d3b47ba5d2738939be66f05936.diff LOG

[Lldb-commits] [lldb] 8d714e4 - [lldb] Correct \params to \param in StackFrame Doxygen comments

2022-01-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-26T14:05:58Z New Revision: 8d714e4ad592eee351afa95a2cb3d38335a70fb6 URL: https://github.com/llvm/llvm-project/commit/8d714e4ad592eee351afa95a2cb3d38335a70fb6 DIFF: https://github.com/llvm/llvm-project/commit/8d714e4ad592eee351afa95a2cb3d38335a70fb6.diff LOG

[Lldb-commits] [lldb] 070090d - [lldb] Add option to show memory tags in memory read output

2022-01-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-26T14:40:39Z New Revision: 070090d08eb506187f7203bd3b321ca1e74d9d5c URL: https://github.com/llvm/llvm-project/commit/070090d08eb506187f7203bd3b321ca1e74d9d5c DIFF: https://github.com/llvm/llvm-project/commit/070090d08eb506187f7203bd3b321ca1e74d9d5c.diff LOG

[Lldb-commits] [lldb] d1c124e - [lldb][ARM/AArch64] Update dissembler to v9.3-a

2022-01-28 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-28T09:10:04Z New Revision: d1c124e6e7006ff5597981f8adcb48b2e26b110d URL: https://github.com/llvm/llvm-project/commit/d1c124e6e7006ff5597981f8adcb48b2e26b110d DIFF: https://github.com/llvm/llvm-project/commit/d1c124e6e7006ff5597981f8adcb48b2e26b110d.diff LOG

[Lldb-commits] [lldb] 2937b28 - Reland "[lldb] Remove non address bits when looking up memory regions"

2022-02-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-02-10T10:42:49Z New Revision: 2937b282188bafb6bdb65ee87c70e9109aa910b7 URL: https://github.com/llvm/llvm-project/commit/2937b282188bafb6bdb65ee87c70e9109aa910b7 DIFF: https://github.com/llvm/llvm-project/commit/2937b282188bafb6bdb65ee87c70e9109aa910b7.diff LOG

[Lldb-commits] [lldb] 6b3b3ef - [lldb] Correct case in description of breakpoint --on-catch/throw

2022-03-03 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-03-03T10:06:11Z New Revision: 6b3b3ef344504334f43afe76c805d2e6e7b587e9 URL: https://github.com/llvm/llvm-project/commit/6b3b3ef344504334f43afe76c805d2e6e7b587e9 DIFF: https://github.com/llvm/llvm-project/commit/6b3b3ef344504334f43afe76c805d2e6e7b587e9.diff LOG

[Lldb-commits] [lldb] 742fb13 - Revert "[lldb] Correct case in description of breakpoint --on-catch/throw"

2022-03-03 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-03-03T17:20:31Z New Revision: 742fb134753b62f827677be92c48699d02f7f458 URL: https://github.com/llvm/llvm-project/commit/742fb134753b62f827677be92c48699d02f7f458 DIFF: https://github.com/llvm/llvm-project/commit/742fb134753b62f827677be92c48699d02f7f458.diff LOG

Re: [Lldb-commits] [lldb] 6b3b3ef - [lldb] Correct case in description of breakpoint --on-catch/throw

2022-03-03 Thread David Spickett via lldb-commits
dity > w/o noticing what it is for, in which case we should remove them wholesale > rather than one by one. > > Jim > > > > On Mar 3, 2022, at 2:06 AM, David Spickett via lldb-commits > > wrote: > > > > > > Author: David Spickett > >

[Lldb-commits] [lldb] e5fdcfa - [lldb][AArch64] Use "+all" feature for the disassembler

2022-07-06 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-06T12:15:01Z New Revision: e5fdcfac1bbea28c4f26721e8ff7ebddde0f9f2d URL: https://github.com/llvm/llvm-project/commit/e5fdcfac1bbea28c4f26721e8ff7ebddde0f9f2d DIFF: https://github.com/llvm/llvm-project/commit/e5fdcfac1bbea28c4f26721e8ff7ebddde0f9f2d.diff LOG

[Lldb-commits] [lldb] 1ca8a97 - [lldb][Windows] Fix memory region base addresses when a range is split

2022-07-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-07T13:55:48Z New Revision: 1ca8a978023f1c1fe6018ac87ed06b7ce26f0b77 URL: https://github.com/llvm/llvm-project/commit/1ca8a978023f1c1fe6018ac87ed06b7ce26f0b77 DIFF: https://github.com/llvm/llvm-project/commit/1ca8a978023f1c1fe6018ac87ed06b7ce26f0b77.diff LOG

[Lldb-commits] [lldb] f3d43ec - [lldb][Windows] Fixup overlapping memory regions tests

2022-07-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-07T15:36:14Z New Revision: f3d43eca34d4e3ddff2ba8a020ca21a9e963dd4f URL: https://github.com/llvm/llvm-project/commit/f3d43eca34d4e3ddff2ba8a020ca21a9e963dd4f DIFF: https://github.com/llvm/llvm-project/commit/f3d43eca34d4e3ddff2ba8a020ca21a9e963dd4f.diff LOG

[Lldb-commits] [lldb] cd2e36e - [lldb][AArch64] Enable int128 test

2022-07-15 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-15T13:35:48Z New Revision: cd2e36eadd47c2b5dc8e01d6e4856ac7bebcfc38 URL: https://github.com/llvm/llvm-project/commit/cd2e36eadd47c2b5dc8e01d6e4856ac7bebcfc38 DIFF: https://github.com/llvm/llvm-project/commit/cd2e36eadd47c2b5dc8e01d6e4856ac7bebcfc38.diff LOG

[Lldb-commits] [lldb] 1ac12a5 - [lldb][ARM] Invert emulation test assert message

2022-07-22 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-22T09:35:30Z New Revision: 1ac12a517767c0108a6859b723bc1351d8ba2157 URL: https://github.com/llvm/llvm-project/commit/1ac12a517767c0108a6859b723bc1351d8ba2157 DIFF: https://github.com/llvm/llvm-project/commit/1ac12a517767c0108a6859b723bc1351d8ba2157.diff LOG

[Lldb-commits] [lldb] ae8a660 - [lldb][ARM/AArch64] Use sys/uio.h instead of socket.h in native register context

2022-07-25 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-25T12:35:57Z New Revision: ae8a6602fb7260cc4b6d07689c8ac80f0fb4d86a URL: https://github.com/llvm/llvm-project/commit/ae8a6602fb7260cc4b6d07689c8ac80f0fb4d86a DIFF: https://github.com/llvm/llvm-project/commit/ae8a6602fb7260cc4b6d07689c8ac80f0fb4d86a.diff LOG

[Lldb-commits] [lldb] 883b0d5 - [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

2022-07-25 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-25T15:51:36+01:00 New Revision: 883b0d5b7f873a7d6f8c8ee13c7f6174a2a79a50 URL: https://github.com/llvm/llvm-project/commit/883b0d5b7f873a7d6f8c8ee13c7f6174a2a79a50 DIFF: https://github.com/llvm/llvm-project/commit/883b0d5b7f873a7d6f8c8ee13c7f6174a2a79a50.diff

[Lldb-commits] [lldb] 91098fe - [lldb][AArch64] Use macro for unused var without asserts enabled

2022-07-25 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-25T15:14:49Z New Revision: 91098fec960f501c95c6ecdede604484750367e4 URL: https://github.com/llvm/llvm-project/commit/91098fec960f501c95c6ecdede604484750367e4 DIFF: https://github.com/llvm/llvm-project/commit/91098fec960f501c95c6ecdede604484750367e4.diff LOG

[Lldb-commits] [lldb] 2f9fa9e - [lldb][AArch64] Add support for memory tags in core files

2022-07-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-26T08:46:36+01:00 New Revision: 2f9fa9ef5387de3d87b0c866c678d93695c1c1f3 URL: https://github.com/llvm/llvm-project/commit/2f9fa9ef5387de3d87b0c866c678d93695c1c1f3 DIFF: https://github.com/llvm/llvm-project/commit/2f9fa9ef5387de3d87b0c866c678d93695c1c1f3.diff

[Lldb-commits] [lldb] 290c4bc - [LLDB][ARM] Generalise adding register state in emulation tests and add D registers

2022-07-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-26T08:22:26Z New Revision: 290c4bc7be45a29d98ea2e8460ef50f4924a1c4b URL: https://github.com/llvm/llvm-project/commit/290c4bc7be45a29d98ea2e8460ef50f4924a1c4b DIFF: https://github.com/llvm/llvm-project/commit/290c4bc7be45a29d98ea2e8460ef50f4924a1c4b.diff LOG

[Lldb-commits] [lldb] 3ebd541 - [lldb][ARM] Print mismatched registers in emulation tests

2022-07-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-26T08:28:27Z New Revision: 3ebd541944466dbe6b208f21c4445c65153c3103 URL: https://github.com/llvm/llvm-project/commit/3ebd541944466dbe6b208f21c4445c65153c3103 DIFF: https://github.com/llvm/llvm-project/commit/3ebd541944466dbe6b208f21c4445c65153c3103.diff LOG

[Lldb-commits] [lldb] c4b6e5f - [lldb][ARM] Misc improvements to TestEmulations

2022-07-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-26T08:31:55Z New Revision: c4b6e5f9500fc3c44d587896eb402c8ede21eb10 URL: https://github.com/llvm/llvm-project/commit/c4b6e5f9500fc3c44d587896eb402c8ede21eb10 DIFF: https://github.com/llvm/llvm-project/commit/c4b6e5f9500fc3c44d587896eb402c8ede21eb10.diff LOG

[Lldb-commits] [lldb] 10c2bab - [lldb][ARM] Add tests for vpush/vpop D registers

2022-07-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-26T08:41:24Z New Revision: 10c2bab50e7aab5ad1cb5e8ecd3b12ddca3b19b4 URL: https://github.com/llvm/llvm-project/commit/10c2bab50e7aab5ad1cb5e8ecd3b12ddca3b19b4 DIFF: https://github.com/llvm/llvm-project/commit/10c2bab50e7aab5ad1cb5e8ecd3b12ddca3b19b4.diff LOG

[Lldb-commits] [lldb] d0479cb - [lldb][ARM] Use portable printf tokens for 64 bit types

2022-07-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-07-26T09:12:57Z New Revision: d0479cb29018d9157ef9c90a922ffa09c445aa7d URL: https://github.com/llvm/llvm-project/commit/d0479cb29018d9157ef9c90a922ffa09c445aa7d DIFF: https://github.com/llvm/llvm-project/commit/d0479cb29018d9157ef9c90a922ffa09c445aa7d.diff LOG

[Lldb-commits] [lldb] 5e538c6 - [LLDB] Add multi value test for const static enum

2022-08-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-08-10T08:50:12Z New Revision: 5e538c669c76d26642f64cd03a6c09e5eee436b0 URL: https://github.com/llvm/llvm-project/commit/5e538c669c76d26642f64cd03a6c09e5eee436b0 DIFF: https://github.com/llvm/llvm-project/commit/5e538c669c76d26642f64cd03a6c09e5eee436b0.diff LOG

[Lldb-commits] [lldb] 552dccf - [LLDB][AArch64][NFC] Fix some clang-format annotations

2022-08-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-08-10T10:22:21Z New Revision: 552dccf311c6134c6c895328602172821e3efaed URL: https://github.com/llvm/llvm-project/commit/552dccf311c6134c6c895328602172821e3efaed DIFF: https://github.com/llvm/llvm-project/commit/552dccf311c6134c6c895328602172821e3efaed.diff LOG

[Lldb-commits] [lldb] 14913fa - [LLDB][ARM] Extend testing for vpush emulation

2022-08-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-08-11T10:02:37Z New Revision: 14913fa5d0508c3e29ae69552ef0710c82913a75 URL: https://github.com/llvm/llvm-project/commit/14913fa5d0508c3e29ae69552ef0710c82913a75 DIFF: https://github.com/llvm/llvm-project/commit/14913fa5d0508c3e29ae69552ef0710c82913a75.diff LOG

<    7   8   9   10   11   12   13   14   15   16   >