DavidSpickett wrote:
`size_t` will be 32 bit on 32 bit platforms, is this ok given the expected
range of this variable?
I don't see any failures on 32 bit Arm right now but worth asking in case it
causes flaky tests later.
https://github.com/llvm/llvm-project/pull/96564
__
DavidSpickett wrote:
> The error could then be surfaced back in a meaningful way, like "hey the
> server gave me some bunk data so pretty-printing registers might look weird".
> What do you think?
IIRC GDB will do something like this, though it may just be (paraphrasing) "yo
this XML be weird
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/90059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
To be clear, this is not blocking register field enums work anymore. I decided
to push on with that because folks can `register info` to see the values if
they really need them.
Having this would be nice, but there's plenty of time to consider whether it's
worth it.
http
@@ -4179,21 +4179,124 @@ struct GdbServerTargetInfo {
RegisterSetMap reg_set_map;
};
-static std::vector ParseFlagsFields(XMLNode flags_node,
- unsigned size) {
+static FieldEnum::Enumerators ParseEnumEvalues(const XML
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/95768
>From a9b542a1686be0afd73ad89a504d2c66ba6c4a4f Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Mar 2024 10:56:29 +
Subject: [PATCH 1/5] [lldb] Parse and display register field enums
This te
@@ -4179,21 +4179,124 @@ struct GdbServerTargetInfo {
RegisterSetMap reg_set_map;
};
-static std::vector ParseFlagsFields(XMLNode flags_node,
- unsigned size) {
+static FieldEnum::Enumerators ParseEnumEvalues(const XML
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I'm assuming that `Address` keeps track of the value if it changes due to
position independent code, ASLR, etc. between runs. So this seems fine.
Can this be tested? Not sure what coverage we have of these plugins right now.
https://github.com/llvm/llvm-project/pull/9479
https://github.com/DavidSpickett requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/94785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/94785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -287,7 +287,7 @@ Status PlatformAndroid::DownloadModuleSlice(const FileSpec
&src_file_spec,
static constexpr llvm::StringLiteral k_zip_separator("!/");
size_t pos = source_file.find(k_zip_separator);
if (pos != std::string::npos)
-source_file = source_file.substr(
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/94039
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -85,13 +85,17 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
bool has_class_name = !class_name.empty();
bool has_interpreter_dict =
!(llvm::StringRef(m_interpreter.GetDictionaryName()).empty());
-if (!has_class_name && !has_interpr
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/94017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/95125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I'm going to land this now but I can fix up the map type later.
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/85058
>From 33b750696a5958ae13420796e82fb9f5b2ea8fa9 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 4 Mar 2024 14:31:40 +
Subject: [PATCH] [lldb][FreeBSD][AArch64] Enable register field detection
T
DavidSpickett wrote:
https://github.com/llvm/llvm-project/pull/95125 has now landed, so this PR is
just the new changes.
@zxombie we now check the HWCAP to see if the register exists at all, and only
if it does, generate field information. What do you think to the changes as
they are now?
An
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/96887
This enables XML output for enums and adds enums for 2 fields on AArch64:
* mte_ctrl.tcf, which controls how tag faults are delivered.
* fpcr.rmode, which sets the rounding mode for floating point operations
DavidSpickett wrote:
This is in theory the last patch for this series, but depending on
https://github.com/llvm/llvm-project/pull/90059 the format might change
slightly. So I'm going to add a release note after that's sorted.
https://github.com/llvm/llvm-project/pull/96887
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/96887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-06-27T10:39:56Z
New Revision: 0cb748b9ba7cea72bee1bcf7c94f26c646053bb1
URL:
https://github.com/llvm/llvm-project/commit/0cb748b9ba7cea72bee1bcf7c94f26c646053bb1
DIFF:
https://github.com/llvm/llvm-project/commit/0cb748b9ba7cea72bee1bcf7c94f26c646053bb1.diff
LOG
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/96907
Fixes #92541
When e69a3d18f48bc0d81b5dd12e735a2ec898ce64d added fallback register layouts,
it assumed that the choices were target XML with registers, or no target XML at
all.
In the linked issue, a user
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/96907
>From 25905a0f01c126dbebc854affd30d9ff838f259b Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 27 Jun 2024 10:55:28 +
Subject: [PATCH 1/2] [lldb] Don't call AddRemoteRegisters if the target XML
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/96907
>From 25905a0f01c126dbebc854affd30d9ff838f259b Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 27 Jun 2024 10:55:28 +
Subject: [PATCH 1/3] [lldb] Don't call AddRemoteRegisters if the target XML
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/96907
>From 25905a0f01c126dbebc854affd30d9ff838f259b Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 27 Jun 2024 10:55:28 +
Subject: [PATCH 1/4] [lldb] Don't call AddRemoteRegisters if the target XML
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/96907
>From 25905a0f01c126dbebc854affd30d9ff838f259b Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 27 Jun 2024 10:55:28 +
Subject: [PATCH 1/5] [lldb] Don't call AddRemoteRegisters if the target XML
@@ -4879,7 +4879,9 @@ bool ProcessGDBRemote::GetGDBServerRegisterInfo(ArchSpec
&arch_to_use) {
m_registers_enum_types.clear();
std::vector registers;
if (GetGDBServerRegisterInfoXMLAndProcess(arch_to_use, "target.xml",
-registe
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/96907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
These tests are not testing anything do do with character encoding, so this
LGTM.
https://github.com/llvm/llvm-project/pull/97045
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/97258
Reverts llvm/llvm-project#95768 due to a test failure on macOS with ASAN:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/425/console
>From 7e4a2ec169290640c2f16811bae9e1ad82ba2c5
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/97258
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/97270
This reverts commit d9e659c538516036e40330b6a98160cbda4ff100.
I could not reproduce the Mac OS ASAN failure locally but I narrowed it down to
the test `test_many_fields_same_enum`. This test shares an enum
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/97270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/85058
>From 33b750696a5958ae13420796e82fb9f5b2ea8fa9 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 4 Mar 2024 14:31:40 +
Subject: [PATCH 1/2] [lldb][FreeBSD][AArch64] Enable register field detectio
@@ -18,9 +18,9 @@ namespace lldb_private {
struct RegisterInfo;
/// This class manages the storage and detection of register field information
-/// for Arm64 Linux registers. The same register may have different fields on
-/// different CPUs. This class abstracts out the field
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/85058
>From 6a013c6b46306c4d170efb1a6df2956c9dc61b30 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 4 Mar 2024 14:31:40 +
Subject: [PATCH 1/2] [lldb][FreeBSD][AArch64] Enable register field detectio
DavidSpickett wrote:
CI failure is an unrelated BOLT test:
```
_bk;t=1719829907081Failed Tests (1):
<...>
_bk;t=1719829907081 BOLT :: X86/reader-stale-yaml-std.test
<...>
_bk;t=1719829907081 Failed : 1 (0.22%)
```
https://github.com/llvm/llvm-project/pull/85058
__
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/85058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Thanks for the report, fixed in https://github.com/llvm/llvm-project/pull/97270.
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -75,7 +75,7 @@ def __init__(self):
class Pipe(object):
def __init__(self, prefix):
while True:
-self.name = "lldb-" + str(random.randrange(1e10))
+self.name = "lldb-" + str(random.randrange(int(1e10)))
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97328
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I'm confused, I don't see this random call in `TestGdbRemoteConnection.py`, but
I do in
`lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py`.
Is your branch based off something other than the current `main`?
https://github.com/llvm/llvm-project/pu
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
For a while now our only Windows bot is Linaro's Windows on Arm, so there's
probably a few of these skips hanging around.
Thanks for finding this one.
https://github.com/llvm/llvm-project/pull/97324
__
Author: David Spickett
Date: 2024-07-02T09:19:59Z
New Revision: 54811a9b1194d8239cc28c2a974228ffadf80100
URL:
https://github.com/llvm/llvm-project/commit/54811a9b1194d8239cc28c2a974228ffadf80100
DIFF:
https://github.com/llvm/llvm-project/commit/54811a9b1194d8239cc28c2a974228ffadf80100.diff
LOG
DavidSpickett wrote:
I've
[disabled](https://github.com/llvm/llvm-project/commit/54811a9b1194d8239cc28c2a974228ffadf80100)
the test on Windows and Linaro will look into it.
https://github.com/llvm/llvm-project/pull/97263
___
lldb-commits mailing list
DavidSpickett wrote:
Linaro has also seen it failing on our Windows on Arm bot:
https://lab.llvm.org/buildbot/#/builders/141/builds/425
I've disabled the test
(https://github.com/llvm/llvm-project/commit/54811a9b1194d8239cc28c2a974228ffadf80100)
and one of my colleagues is going to look into
DavidSpickett wrote:
There is a skipIfWindows decorator that could be used instead but it's the same
thing anyway, going to merge this as is.
https://github.com/llvm/llvm-project/pull/97324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/97324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/96887
>From 3bb90e95fcefa986a0b375487072b775cb45ce69 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Mar 2024 10:56:50 +
Subject: [PATCH] [lldb][AArch64] Add register field enum information
This
DavidSpickett wrote:
Rebased as FreeBSD support went in yesterday and moved some files about.
https://github.com/llvm/llvm-project/pull/96887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/96887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/97553
Fixes #97514
Given this example:
```
enum E {};
int main()
{
E x = E(0);
E y = E(1);
E z = E(2);
return 0;
}
```
lldb used to print nothing for `x`, but `0x1` for `y` and `0x2` for `z`.
At
@@ -8649,19 +8649,24 @@ static bool DumpEnumValue(const clang::QualType
&qual_type, Stream &s,
// At the same time, we're applying a heuristic to determine whether we want
// to print this enum as a bitfield. We're likely dealing with a bitfield if
// every enumerator is
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97553
>From 08565607da9f35649c8ef037cdd1f9ac2f5c7e25 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 3 Jul 2024 10:28:49 +
Subject: [PATCH 1/2] [lldb] Print empty enums as if they were unrecognised
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97553
>From 08565607da9f35649c8ef037cdd1f9ac2f5c7e25 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 3 Jul 2024 10:28:49 +
Subject: [PATCH 1/3] [lldb] Print empty enums as if they were unrecognised
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/97557
Enums like this one are treated as bitfield like enums: enum FlagsLike {B=2,
C=4};
lldb recognises them as collections of flags, so you can have "B | C". If
there's any values not covered that's printed a
DavidSpickett wrote:
There is a comment in this function:
```
// Try to find an exact match for the value.
// At the same time, we're applying a heuristic to determine whether we want
// to print this enum as a bitfield. We're likely dealing with a bitfield if
// every enumerator is eithe
DavidSpickett wrote:
Thanks for all the reviews!
https://github.com/llvm/llvm-project/pull/96202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/96202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97553
>From 1a170e94ef9caf3012b1c3185f9c3f459171d362 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 3 Jul 2024 10:28:49 +
Subject: [PATCH] [lldb] Print empty enums as if they were unrecognised norma
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/97553
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/97557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-07-04T07:49:36Z
New Revision: 927def49728371d746476e79a6570cd93a4d335c
URL:
https://github.com/llvm/llvm-project/commit/927def49728371d746476e79a6570cd93a4d335c
DIFF:
https://github.com/llvm/llvm-project/commit/927def49728371d746476e79a6570cd93a4d335c.diff
LOG
Author: David Spickett
Date: 2024-07-04T08:51:23Z
New Revision: 328d9f62976defb96cba8102ea54f44cf88c8032
URL:
https://github.com/llvm/llvm-project/commit/328d9f62976defb96cba8102ea54f44cf88c8032
DIFF:
https://github.com/llvm/llvm-project/commit/328d9f62976defb96cba8102ea54f44cf88c8032.diff
LOG
DavidSpickett wrote:
> This method is used in addition to the hardcoded list and, as an example, I'm
> using it for the ObjC language support.
And does this list include languages that are not plugin provided?
I was wondering why only Objective C changed, but if the rest are not plugins
then
@@ -245,7 +245,7 @@ class Language : public PluginInterface {
// a match. But we wouldn't want this to match AnotherA::my_function. The
// user is specifying a truncated path, not a truncated set of characters.
// This function does a language-aware comparison for those
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/97675
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -319,6 +316,12 @@ class CommandObjectBreakpointSet : public
CommandObjectParsed {
error_context = "Unknown language type for exception breakpoint";
break;
default:
+ if (Language *languagePlugin = Language::FindPlugin(language)) {
--
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97796
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Yes this is due to me only testing my changes on AArch64, thanks for the patch.
https://github.com/llvm/llvm-project/pull/97796
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
DavidSpickett wrote:
Specifically changes from https://github.com/llvm/llvm-project/pull/85058.
https://github.com/llvm/llvm-project/pull/97796
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/97796
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/97824
Previously this took a reference to a map and returned a bool to say whether it
succeeded. This is an optional but with more steps.
The only reason to keep it that way was if someone was appending to an ex
@@ -1710,15 +1710,17 @@ VendorSignatures getVendorSignature(unsigned *MaxLeaf) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
-bool sys::getHostCPUFeatures(StringMap &Features) {
+std::optional> sys::getHostCPUFeatures() {
unsign
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/2] [llvm][TargetParser] Return optional from
getHostCPUFe
@@ -15,22 +15,23 @@
#include "llvm/Support/raw_ostream.h"
#include "llvm/TargetParser/Host.h"
+#include
+
using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- StringMap featu
@@ -22,13 +22,13 @@ using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- if (std::optional> features =
+ if (const std::optional> features =
sys::getHostCPUFeatures(featu
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/3] [llvm][TargetParser] Return optional from
getHostCPUFe
@@ -22,13 +22,13 @@ using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- if (std::optional> features =
+ if (const std::optional> features =
sys::getHostCPUFeatures(featu
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/98089
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/98055
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Fair point, iirc all the callers go on to iterate the map so no one is handling
failure in a special way. I'll update this.
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/4] [llvm][TargetParser] Return optional from
getHostCPUFe
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> Why not return a map every time?
Done.
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Clang's dwarf v2 output is missing `DW_AT_type`. With `g++` I see that (and
more) with v2 and v3.
v2:
```
0x0043: DW_TAG_enumeration_type
DW_AT_name ("UnsignedEnum")
DW_AT_byte_size (0x04)
DW_AT_decl_file ("/tmp/tes
Author: David Spickett
Date: 2024-07-09T14:11:26Z
New Revision: 0ad9d8f279437772d390c7fc6309c09b97406be3
URL:
https://github.com/llvm/llvm-project/commit/0ad9d8f279437772d390c7fc6309c09b97406be3
DIFF:
https://github.com/llvm/llvm-project/commit/0ad9d8f279437772d390c7fc6309c09b97406be3.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/5] [llvm][TargetParser] Return optional from
getHostCPUFe
@@ -15,21 +15,22 @@
#include "llvm/Support/raw_ostream.h"
#include "llvm/TargetParser/Host.h"
+#include
+
DavidSpickett wrote:
Done.
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
ll
@@ -13,6 +13,7 @@
#ifndef LLVM_TARGETPARSER_HOST_H
#define LLVM_TARGETPARSER_HOST_H
+#include
DavidSpickett wrote:
Done.
https://github.com/llvm/llvm-project/pull/97824
___
lldb-commits mailing list
lldb-commits@l
1 - 100 of 2667 matches
Mail list logo
