[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

DavidSpickett added a comment. Oh and: This patch also adds a new setting -- target-env-vars Might want to clarify that it adds this setting **to the qemu user platform**. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115246/new/ https://review

[Lldb-commits] [PATCH] D115246: [lldb/qemu] Separate host and target environments

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM assuming that qemu passing on the SET/UNSET vars is what you've observed. Comment at: lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:139 + //

[Lldb-commits] [PATCH] D114877: [lldb] Add missing space in C string format memory read warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a870bffb108: [lldb] Add missing space in C string format memory read warning (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1148

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

DavidSpickett added a comment. > Thanks for clarifying @DavidSpickett ! I'll change the warning accordingly. Too many Davids :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 ___

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Glad to see this, it will be useful on AArch64 Linux as well. General question, is yaml2obj not flexible enough to do this? I guess the issue would be even if it does do MachO the test could only work on a precompiled

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

DavidSpickett added a comment. > General question, is yaml2obj not flexible enough to do this? I guess the > issue would be even if it does do MachO the test could only work on a > precompiled file, this way allows you to build a.out each time. Plus you get all the Mach specific constant values

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. Just to update where I am with this, I think I've got a good argument to not show the non-address bits in the output. That being that the memory itself that we read doesn't include these bits, so showing it is just going to be more confusing that the initial confu

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. Sent https://lists.llvm.org/pipermail/lldb-dev/2021-December/017163.html to get some more input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 ___

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 393406. DavidSpickett added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 Files: lldb/source/Commands/CommandObjectMemory.cpp

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp:830 + } return (pc & pac_sign_extension) ? pc | mask : pc & (~mask); } jasonmolenda wrote: > DavidSpickett wrote: > > Can you explain this logic? The "else"

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:6984 + uint64_t slide = m_data.GetU64(&fileoff); + std::string filename = (const char *)m_data.GetCStr(&fileoff); + Seems like the cast wo

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit 0df522969a7a0128052bd79182c8d58e00556e2f

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. The original change was https://reviews.llvm.org/D102757, I'll add comments showing the new code relative to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115508/new/ ht

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added a reviewer: omjavaid. DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1671 m_cmd_name.c_str(), m_cmd_syntax.c_str()); return false; } This check has

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM assuming the change in TestFunctionStarts.py wasn't meant to be included. Comment at: lldb/test/API/macosx/function-starts/TestFunctionStarts.py:68

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

DavidSpickett updated this revision to Diff 394797. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added a release note for the new option/feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett updated this revision to Diff 394800. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added a release note for the feture of handling non-address bits in input. Including the change to the last memory region, which could conceivea

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. Since we're so close to the end of the year I'm going to give this more time and ping early next year in case of any more feedback. Though I'm feeling confident in the direction so far. While working on this I realised that the API calls should also remove the no

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 394805. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add release note for this change. Closer to release I'll see if it makes more sense to make a list of commands that have had the same changes,

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. > That looks really good, could help a lot to understand tagging related > issues. Looking forward for that patch :) https://reviews.llvm.org/D107140 is the end of the series for that if you want to see it. The test cases show various corner cases too. Repositor

[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

DavidSpickett created this revision. Herald added a subscriber: jeroen.dobbelaere. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. "shell" is an alias to "platform shell -h --". Previously you would get this help text: (lldb)

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 398916. DavidSpickett added a comment. Rebase, update some comment wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 Files: lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D103626: [lldb] Remove non address bits from memory read arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88fdce5be696: [lldb] Remove non address bits from memory read arguments (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D103626: [lldb] Remove non address bits from memory read arguments

DavidSpickett added a comment. Since there was no great pushback on this I've landed it. With the final justification being that the non-address bits are properties of the pointer not of the memory pointed to. I will do a follow up where I apply the same logic to the ReadMemory calls via the A

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett updated this revision to Diff 398921. DavidSpickett added a comment. - Revert back to the do...while structure. - Reword the explanatory comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115508/new/ https://reviews.llvm.org/D115

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added a comment. @omjavaid ping! Using `fixed address != original address` inspired by https://reviews.llvm.org/D115431#change-7Gybl0dcCOwp. I first used `<` which I think works out the same but `!=` is clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

DavidSpickett added a comment. > I also think this function is pretty confusing to read. Enough that I decided not to attempt to unpick it for this bug! I also wondered how the quit command actually worked so thanks for solving that mystery. I'll go with this as is but if I get a chance I'll tr

[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

This revision was automatically updated to reflect the committed changes. Closed by commit rG091e760cd398: [lldb] Don't print "Command Options Usage:" for an alias with no options (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112825/new/ https://reviews.llvm.org/D112825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. ping! Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:160 + // we must use an untagged address. + MemoryRegionInfo::RangeType range(RemoveNonAddressBits(addr), len);

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagMap.h:29 + /// Non-null pointer to a memory tag manager. + MemoryTagMap(const MemoryTagManager *manager); + JDevlieghere wrote: > If the pointer should be non-null, then shou

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1668 +if (argc > 1 || (argc == 0 && load_addr == LLDB_INVALID_ADDRESS) || +(abi && (abi->FixDataAddress(load_addr) != load_addr))) { result.AppendErrorWithFormat("'%s'

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:5891 + // is at or beyond the end of mappable memory. + !(abi && (abi->FixDataAddress(range_end) != range_end))); omjavaid wrote: > Just to confirm this assumes range base

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:5891 + // is at or beyond the end of mappable memory. + !(abi && (abi->FixDataAddress(range_end) != range_end))); DavidSpickett wrote: > omjavaid wrote: > > Just to confir

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett updated this revision to Diff 399654. DavidSpickett added a comment. - Fix bug where the previous end address was checked for non-address bits even when the user gave a new address. - Added testing for that situation. - Added a comment to explain that non-address bits in the start/b

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This removes the non-address bits before we try to use the addresses. Meaning that when results are shown, those results won't show non-addr

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

DavidSpickett added a comment. Omair can comment on how useful this is for SVE testing. I do use this to run the memory tagging tests on qemu, we don't have real hardware yet. Let me see what extra steps I need to run them within qemu instead. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

DavidSpickett added a comment. I'm running `lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py`. If the details matter any... In qemu: $ ./build-cross/bin/lldb-server platform --server --listen 0.0.0.0:54321 On the host: $ ./bin/lldb-dotest --platform-name remot

[Lldb-commits] [PATCH] D117671: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This better describes the intent of the method. Which for AArch64 is removing the top byte which in

[Lldb-commits] [PATCH] D117672: [lldb] Remove non-address bits from addresses given to memory tag commands

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Although the memory tag commands use a memory tag manager to handle addresses, that only removes the top byte. That top byte is 4 bits of me

[Lldb-commits] [PATCH] D117671: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. As promised on https://reviews.llvm.org/D112824. I hope to get to a point where the tag managers only remove memory tag bits so this is a step toward that. Comment at: lldb/source/Plugins/Process/Linux/N

[Lldb-commits] [PATCH] D117671: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

This revision was automatically updated to reflect the committed changes. Closed by commit rG585abe3ba506: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D117672: [lldb] Remove non-address bits from addresses given to memory tag commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG787f91b0bb34: [lldb] Remove non-address bits from addresses given to memory tag commands (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett updated this revision to Diff 401583. DavidSpickett added a comment. Rebase, update the name of RemoveTagBits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112824/new/ https://reviews.llvm.org/D112824 Files: lldb/include/lldb/Targ

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett updated this revision to Diff 401588. DavidSpickett added a comment. Change MemoryTagMap::empty() to Empty() to match lldb style. Attempted to use a const& for the tag manager and remembered why that won't work. Made the explanatory comment more clear. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagMap.h:29 + /// Non-null pointer to a memory tag manager. + MemoryTagMap(const MemoryTagManager *manager); + DavidSpickett wrote: > JDevlieghere wrote: > > If the pointer shou

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

DavidSpickett updated this revision to Diff 401592. DavidSpickett added a comment. Update with changes to previous patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

DavidSpickett updated this revision to Diff 401904. DavidSpickett added a comment. Fix "to to" in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117299/new/ https://reviews.llvm.org/D117299 Files: lldb/source/Commands/CommandObjectMemory

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/tagged_memory_access/TestAArch64LinuxTaggedMemoryAccess.py:83 +# Then that the location found does not display the tag bits. +self.assertN

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d19566c3bfb: [lldb] Ignore non-address bits in "memory find" arguments (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D117299?vs=401904&id=402441#toc Repository: rG L

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett updated this revision to Diff 402542. DavidSpickett added a comment. Rebase and update release notes format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115508/new/ https://reviews.llvm.org/D115508 Files: lldb/include/lldb/Target

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett updated this revision to Diff 402898. DavidSpickett added a comment. Since output of GetMemoryRegions will be sorted and not overlap, switch the checks to asserts and don't sort the input regions. Updated the testing to reflect that and added some comment diagrams showing what regio

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

DavidSpickett updated this revision to Diff 403197. DavidSpickett added a comment. MakeTaggedRanges now takes const MemoryRegionInfos& like MakeTaggedRange does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112824/new/ https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee0c3820f886: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

This revision was automatically updated to reflect the committed changes. Closed by commit rG37c4bd0fdbc6: [lldb] Add MemoryTagMap class (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112825/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

DavidSpickett updated this revision to Diff 403236. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 Files: lldb/include/lldb/Core/DumpDataExtractor.h lldb/source/

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG070090d08eb5: [lldb] Add option to show memory tags in memory read output (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

DavidSpickett added a comment. Thanks for the reviews @omjavaid ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D118358: [lldb][ARM/AArch64] Update dissembler to v9.3-a

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This means sve2 is enabled by default and the v8.8 mops (memcpy and memset acceleration in

[Lldb-commits] [PATCH] D118358: [lldb][ARM/AArch64] Update dissembler to v9.3-a

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1c124e6e700: [lldb][ARM/AArch64] Update dissembler to v9.3-a (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118358/new/ https:/

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit makes lldb-server on Linux strip non-address bits from addresses passed to the followin

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Without this change any memory read/write of a pointer with a signature would fail. I found it trying to extend memory find and using a pointer with both a signature and a memory tag. There's a couple of things I could do

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett added a comment. Also if anyone does know how or if debugserver handles this situation, that would be good to know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 _

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett added a comment. > I would have expected that lldb would strip these tags before the address > makes it's way over here (I'm pretty sure it needs to do that for other uses > anyway). Why is that not happening? So far we remove non-address bits for commands that need to diff pointe

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett planned changes to this revision. DavidSpickett added a comment. > check what gdb(server) does here Will do. > One side-effect of doing it server-side is that this would interfere with our > memory caching code Yes I also wanted to fix the memory cache in lldb but you're right it

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

DavidSpickett added a comment. I'm pretty sure I've seen this sort of failure before but can't remember if it was locally or on one of many bots. (which probably means all of them!) This seems like a good improvement. Comment at: lldb/packages/Python/lldbsuite/test/tools/lld

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/tools/lldb-server/main.cpp:144 +#elif defined(__aarch64__) + asm volatile("brk #0xf000"); +#elif defined(__arm__) --

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2937b282188b: Reland "[lldb] Remove non address bits when looking up memory regions" (authored by DavidSpickett). Changed prior to commit: https:/

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

DavidSpickett added inline comments. Comment at: lldb/test/API/driver/job_control/TestJobControl.py:9 +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test.lldbpexpect import PExpectTest Unused import?

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

DavidSpickett added a comment. I think I mostly get it and the code looks fine, but my signal foo is weak so @mgorny should give a second look. > we use raise to send the signal, which makes sure it gets delivered to the > thread which is running the handler https://man7.org/linux/man-pages/ma

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

DavidSpickett added a comment. Got it, thanks for the explanation. > What's important is that the second signal gets delivered (not "handled", > because at that point we have removed the handler) to the same thread, as > that's the only one we're sure that will have it unblocked (although, in

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/CodeViewRegisterMapping.cpp:51 +gpr_w27_arm64, // ARM64_W27, 37) +gpr_w28_arm64, // ARM64_W28, 38) +LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, --

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

DavidSpickett added subscribers: labrinea, DavidSpickett. DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Herald added a subscriber: Michael137. > conflicting instructions with the same encoding in different extensions, but > it doesn't seem possible within one arche

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

DavidSpickett added a comment. Now I think about it, tests could do something like "-mattr=-all" to remove it, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127741/new/ https://reviews.llvm.org/D127741 _

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

DavidSpickett added a comment. > Why not use objdump? If we only check that instructions get disassembled, it > will work fine. I just remember some tests using llvm-mc to disassemble and some using objdump. Istr that using llvm-mc for assemble and disassemble usually meant having two test fil

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. I'll give this a more thorough read later just one comment for now. In the meantime, what's your plan for testing this config going forward? This patch would be fine as the first of a series but I'd like to see the follow ups that make it usable. Will there be a

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. > I tried to fix this error with gdb, but the debugging process was too slow, > so I'm sorry for not being able to provide a test patch for verification of > my commit. Oh and if you want help with this please ask on discord/discourse. This stuff is a bit tedious

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. Overall this looks fine. Without the ability to test it I don't think we would accept it yet, so I didn't look into the details too much. > To use gdbserver by lldb requires the participation of lldb-server, so my > current plan is to allow lldb to co-op with gdbs

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128221/new/ https://reviews.llvm.org/D128221 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/unittests/Process/Utility/LinuxProcMapsTest.cpp:278 check_regions(params); } I don't see a test for a mapping with "s" for the sharing char, did I miss it?

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

DavidSpickett added a comment. Some random comments. Also agree that a test for what happens when there is no header found would be good. Comment at: lldb/test/API/macosx/unregistered-macho/TestUnregisteredMacho.py:21 +self.build() +(target, process, thread, b

[Lldb-commits] [PATCH] D129177: [lldb][AArch64] Use "+all" feature for the disassembler

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The "+all" feature name was added in https://reviews.llvm.org/D128029.

[Lldb-commits] [PATCH] D129177: [lldb][AArch64] Use "+all" feature for the disassembler

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5fdcfac1bbe: [lldb][AArch64] Use "+all" feature for the disassembler (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129177/new/

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we recorded AllocationBase as the base address of the region we get from VirtualQueryEx. However, thi

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Follow up to https://discourse.llvm.org/t/unexplained-memory-regions-on-windows/62662. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

DavidSpickett added inline comments. Comment at: lldb/test/API/macosx/unregistered-macho/TestUnregisteredMacho.py:46 +self.expect (both_gdb_packet, substrs=['response: {"images":[{"load_address":%d,' % macho_addr]) +self.expect (both_gdb_packet, substrs=['respons

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett updated this revision to Diff 442896. DavidSpickett added a comment. - Use self.process() - Check for overlapping regions instead of just the base addresses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129272/new/ https://reviews.ll

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca8a978023f: [lldb][Windows] Fix memory region base addresses when a range is split (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:119 +or (region_end > previous_base and region_end <= previous_end): +self.assertFalse(base_address in base_addresses, +

[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Fixed up in https://reviews.llvm.org/rGf3d43eca34d4. Next time I will remember to check what a test failure looks like. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Looks good from my perspective. Comment at: lldb/test/API/macosx/unregistered-macho/main.c:48 + memcpy(p, &uuid, sizeof(uuid)); + p += sizeof(uuid); + ---

[Lldb-commits] [PATCH] D129338: Tell the user which pathname was invalid...

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2640 if (!pathname || !pathname[0]) { -error.SetErrorString("invalid pathname"); +error.SetErrorString("empty path"); return false; -

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. FWIW I do get the same error in a clean directory without this patch applied: -- LLDB version: 15.0.0git CMake Error at /home/david.spickett/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:289 (message): Expected directory for clang-resource headers not f

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. > I currently don't quite understand how to configure the build bot, and how to > set the test configuration, I went through this article but didn't find > useful information for me, could someone help me. Start with https://llvm.org/docs/HowToAddABuilder.html ins

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

DavidSpickett added a comment. > then we may need to find someone with an arm machine. I tried this patch on AArch64 and did not get any new failures. You can go ahead and reland. If there's still issues I can help fix them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D129487: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the first part of support for reading MTE tags from Linux core

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This teaches ProcessElfCore to recognise the MTE tag

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett added reviewers: omjavaid, labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. This change is purely about reading the tags. There will be another change to get fault reporting working. Right now lldb only looks at `signo` so you see a segfault but not w

[Lldb-commits] [PATCH] D129736: [lldb] Skip a float16 NaN test for RISC-V

DavidSpickett added a comment. Seems fine to me. Do you have a tracking issue for this? You could just open one for "lldb riscv test failures" and add comments as you find more failures. So people can see the current state of the test suite. Comment at: lldb/unittests/Core/Du

<    1   2   3   4   5   6   7   8   9   10   >