[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 410920. d-millar added a comment. Rebased on v14 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409 Files: lldb/CMakeLists.txt lldb/bindings/CMakeLists.txt lldb/bindings/java/

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar created this revision. d-millar added a reviewer: LLDB. Herald added subscribers: teemperor, mgorny. d-millar requested review of this revision. The patch include files necessary to extend the Scripting Bridge API with Java. The edits follow the existing patterns for Python and Lua. R

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Apologies for the inclusion of that last file "patch" - that is the "git diff -U999" result, should that be useful. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409 __

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 378237. d-millar added a comment. supplying a better patch file Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409 Files: lldb/bindings/java/CMakeLists.txt patch Index: patch =

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Hmmm, well, have tried running "git clang-format" with a few different invocations, but seem to always get "No modified files to format." Suggestions? From: David Millar via Phabricator Sent: Friday, October 8, 2021 11:33:37 AM To: Da

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 378282. d-millar added a comment. Another (hopefully cleaner) attempt. If the addition of SBTraceOptions in lldb/source/API/CMakelists.txt conflicts, please feel free to delete it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 378288. d-millar added a comment. FIx for potential conflicts with master. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409 Files: lldb/bindings/java/java-typemaps.swig lldb/b

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Ah, OK, after more digging, I realize I have probably provided only half of what you would like for this commit. My primary intention was to expose the SB API so I could make calls from Java into it, but for it to be, in some sense, a full-fledged member of the API, i

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Discussing it with developers here, they agreed with your opinion that we really really ought to do 2. 😊 As you just noted, 3 is trickier. Java doesn't really have a REPL. It has jshell - we're not sure that counts. In any case, am up for tackling 2. Will keep yo

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

d-millar added subscribers: DavidSpickett, djtodoro, HirokiImai, jingham, ZeeZeeMorin, SouraVX, serhiy.redko, vadimcn, d-millar. d-millar added a comment. That discussion is extremely helpful - gives me good context for what I need to suport. THANKS! From: lld

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

d-millar added a comment. That discussion is extremely helpful - gives me good context for what I need to suport. THANKS! From: lldb-commits on behalf of Jim Ingham via Phabricator via lldb-commits Sent: Friday, October 8, 2021 5:44:49 PM To: vadi...@gmail.c

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 386169. d-millar added a comment. OK, well, took my some time but I have made an attempt to address the three areas described by Mr. Ingham: //Support for a scripting language in lldb has three distinct pieces. 1. Making the SB API's available to the scrip

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Apologies in advance - this may be a repeat message. Our server went down for maintenance mid-send. So, looking at https://llvm.org/docs/HowToAddABuilder.html, I think I need some clarification on your request regarding a build bot. Are you asking for dedicated phys

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 389021. d-millar added a comment. minor fixes re unnecessary requirement and ConstString->StringRef Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111409/new/ https://reviews.llvm.org/D111409 Files: lldb/CMakeLists.txt