[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

davidca added inline comments. Herald added a project: All. Comment at: lldb/docs/lldb-gdb-remote.txt:469 +// +//tsc_rate: { +// kind: "perf", why is all this called tsc rate? there is also offset in this conversion. What about something like tsc_conver

[Lldb-commits] [PATCH] D122859: [trace] Show ideas for the main interfaces for new HTR

davidca added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:73 + // trace + struct HTRInMemoryBlock { + Just like in the original HTR design, if you remove this abstraction, and store indices as indices in each layer, then you don't have t