[Lldb-commits] [PATCH] D88158: [lldb/examples] Add missing declaration in heap.py

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor, aprantl. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Add missing declaration for `malloc_get_all_zones` in heap.py. Repository: rG

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. Nice improvement! I think it's strange that `break delete DeleteMeNot` and `break delete --disabled DeleteMeNot ` behave differently. For the case that it supports, I would suggest

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; } ---

[Lldb-commits] [PATCH] D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`

kastiglione accepted this revision. kastiglione added a comment. sgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88181/new/ https://reviews.llvm.org/D88181 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; } ---

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; } ---

[Lldb-commits] [PATCH] D88158: [lldb/examples] Add missing declaration in heap.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGada1e2ffa117: [lldb/examples] Add missing declaration in heap.py (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88158/new/ https:/

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; } ---

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor, friss. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. The `macos-setup-codesign.sh` script has been in place for over two years. If there

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

kastiglione added a comment. I agree it's nice to have somewhere, but git history should be fine. I should elaborate on motivations, 1. ensure everyone is using the script so that any issues are surfaced, 2. prevent missteps in the manual process, which may also be bit rotting if everyone is us

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d19eb542db4: [lldb/docs] Remove manual codesigning documentation (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, teemperor. Herald added subscribers: lldb-commits, kbarton, nemanjai. Herald added a project: LLDB. kastiglione requested review of this revision. Add preconditions to `TestBase.expect()` that catch semantically

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione updated this revision to Diff 296215. kastiglione added a comment. Resyntax the isinstance asserts; Add expect() tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 Files: lldb/packages/Pyth

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must be a collection of strings" and False +if isinstance(substrs, six.string_types): +assert "substrs must be a collection o

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione added inline comments. Comment at: lldb/test/API/types/TestRecursiveTypes.py:54 +self.expect("print tpi") +self.expect("print *tpi") aprantl wrote: > I'm not not sure I understand this change? The second parameter, `msg`, is only valid

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione updated this revision to Diff 296217. kastiglione added a comment. "missing a matcher" -> "missing a matcher argument" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 Files: lldb/packages/Pyth

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

This revision was automatically updated to reflect the committed changes. Closed by commit rG010d7a388b14: [lldb/test] Catch invalid calls to expect() (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://review

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

kastiglione added a comment. About `-P`, the man page for `lldb` and the driver's `Options.td` say it: > Prints out the path to the lldb.py file for this version of lldb. Should it do just that? If so this can be simplified further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Small cleanup to `lldb_private::GetVersion()`. In parti

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296578. kastiglione added a comment. Unbreak code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.cpp ==

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296579. kastiglione added a comment. switch NULL to "" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.cpp =

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione added inline comments. Comment at: lldb/source/lldb.cpp:22 #ifdef LLDB_REVISION return LLDB_REVISION; #else this won't expand to a string as is, does this indicate it's unused? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296695. kastiglione added a comment. Restore repository handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione added a comment. @teemperor I removed the comment and restored repository handling. It becomes much more of a useless diff :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 ___

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296700. kastiglione added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.c

[Lldb-commits] [PATCH] D89273: [lldb] Handle alternative output in TestAbortExitCode

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. This test On macOS, this test can instead return `status = 0 (0x) Terminated due to

[Lldb-commits] [PATCH] D89273: [lldb] Handle alternative output in TestAbortExitCode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa52cc9b4be36: [lldb] Handle alternative output in TestAbortExitCode (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08924b54debc: [lldb] Remove unused code in GetVersion (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. Could this have undesirable side effects? I wouldn't expect `command script import` to be searching my home dir. Second question: is there value in requiring the explicit use of `~`, for ex: `command script import ~/path`. CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. In D89295#2327367 , @labath wrote: > That actually seems to work (if you add .py to the end). Yes that was my (poorly explained) point, I use this form regularly. Is it not better to require an explicit `~` instead of allowin

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. For lldbinit files, and any file that gets `command source`'d, I think it would be useful if they could perform `command script import some/path/to/command.py`, where `some` is resolved relative to the dirname of the lldb file. For example, given an lldbinit file at

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. > (and whether we should make this implicit a relative path vs for example some > kind of placeholder 'variable' or something like that). I'm not sure either, but if we do it could probably be as a `./` as prefix? CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. > I don't think it's that unreasonable to do the same for `$HOME` to be able to > use imports relative to the `.lldbinit` file in both cases. In theory I agree, but in practice I think it's unnecessary because `~` can be used (and possibly should be explicit), and b

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

kastiglione added a comment. Would you mind adding a couple tests for imports via a path to a python file, ex `command script import command.py`, maybe even a test that checks nested directories, ex: `command script import path/to/command.py`? CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

kastiglione added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:644 + // FIXME: Stop using this to control adding to the history and then replace + // this with m_command_source_dirs.size(). uint32_t m_command_source_depth;

[Lldb-commits] [PATCH] D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Implement `GetName` for `ObjCExceptionThrowFrameRecognizer`. Othe

[Lldb-commits] [PATCH] D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16cecf3752a: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName() (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D89614: [lldb] Enable cmake policy CMP0077 for option()

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kastiglione requested review of this revision. In lldb, explicitly set the "option() honors normal variables" CMake policy. This applies for

[Lldb-commits] [PATCH] D89614: [lldb] Enable cmake policy CMP0077 for option()

This revision was automatically updated to reflect the committed changes. Closed by commit rGae4fe1984f0e: [lldb] Enable cmake policy CMP0077 for option() (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89614/new/ https://re

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adds a few more aliases to the lldb translations. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69422 Files: lldb/do

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. Thanks. I thought this was reasonable since the documentation shows many uses of lldb aliases already. > intent was to train users in LLDB's more regular command syntax lldb's aliases, especially the regex ones, are great. In my experience, people prefer aliases, t

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. fwiw I have a python command called `abbrev` that takes a command and shows you the alias you can use instead. (lldb) abbrev mem read -s 8 -c 10 -f x 0xfedcba00 x/10xg 0xfedcba00 (lldb) abbrev break set -f foo.c -l 123 b foo.c:23 (lldb) abbrev thread jump -

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. > I wonder if it is time to take the gdb commands out and just make this a task > -> lldb commands table? +1 from me > The abbrev script sounds cool. We have a bunch of useful Python examples in > examples/Python, this sounds like a perfect candidate for that if yo

[Lldb-commits] [PATCH] D61778: [Docs] Replace SVN revisions with lldb versions

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replaces references to svn commits with the lldb version number those commits first appeared in. Themotivation is to show that these features are n

[Lldb-commits] [PATCH] D61778: [Docs] Replace SVN revisions with lldb versions

This revision was automatically updated to reflect the committed changes. Closed by commit rL365559: [Docs] Replace SVN revisions with lldb versions (authored by kastiglione, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione created this revision. kastiglione added reviewers: jingham, teemperor, aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Restore ability to call `expect()` with a message and no matcher. After

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you mean something else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 _

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. That's much better. I'll change those callers can be changed to `runCmd`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___ lldb-co

[Lldb-commits] [PATCH] D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Following discussion in D91193

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. Thanks for pointing this in the right direction @labath, @teemperor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___ lldb-commits

[Lldb-commits] [PATCH] D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)

kastiglione updated this revision to Diff 304568. kastiglione added a comment. Remove bogus message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91206/new/ https://reviews.llvm.org/D91206 Files: lldb/test/API/types/TestRecursiveTypes.py Inde

[Lldb-commits] [PATCH] D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0783ad9e6a2c: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91206/new/

[Lldb-commits] [PATCH] D91742: [lldb] Add examples and reword source-map help string

kastiglione created this revision. kastiglione added reviewers: aprantl, keith. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Update the help string for `target.source-map` to remove th

[Lldb-commits] [PATCH] D91742: [lldb] Add examples and reword source-map help string

kastiglione updated this revision to Diff 306723. kastiglione added a comment. Minor rewording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91742/new/ https://reviews.llvm.org/D91742 Files: lldb/source/Target/TargetProperties.td Index: lldb/s

[Lldb-commits] [PATCH] D91742: [lldb] Add examples and reword source-map help string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbcc69217a3f: [lldb] Add examples and reword source-map help string (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione created this revision. kastiglione added a reviewer: aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `is_variadic_ptr` is unused. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92778 Fil

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione abandoned this revision. kastiglione added a comment. I can't read. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92778/new/ https://reviews.llvm.org/D92778 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione updated this revision to Diff 309966. kastiglione added a comment. Remove function use of is_variadic_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92778/new/ https://reviews.llvm.org/D92778 Files: lldb/include/lldb/Symbol/Compil

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione added a comment. Yes I plan to merge this manually (rather than automerge) to ensure it's not disruptive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92778/new/ https://reviews.llvm.org/D92778 ___

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG012fd0b17f30: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D95411: [lldb] Remove unused ThreadPlanStack::GetStackOfKind (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This function isn't used. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95411 Files:

[Lldb-commits] [PATCH] D95411: [lldb] Remove unused ThreadPlanStack::GetStackOfKind (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG90b8ae016bca: [lldb] Remove unused ThreadPlanStack::GetStackOfKind (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95411/new/

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Convert `assertTrue(a == b)` to `assertEqual(a, b)` to produce better failure messages. T

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione added a comment. I haven't run tests yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95813/new/ https://reviews.llvm.org/D95813 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione added inline comments. Comment at: lldb/test/API/python_api/frame/TestFrames.py:97 sp_value, "We should have a valid Stack Pointer.") -self.assertTrue(int(sp_value.GetValue(), 0) == frame.GetSP( +self.assertEqual(in

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione updated this revision to Diff 320878. kastiglione added a comment. assertNotEqual & formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95813/new/ https://reviews.llvm.org/D95813 Files: lldb/test/API/commands/register/register/r

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG619e2e095fb1: [lldb] Convert assertTrue(a == b) to assertEqual(a, b) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D95899: [lldb] Convert more assertTrue to assertEqual (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up to D95813 , this converts multiline assertTrue

[Lldb-commits] [PATCH] D95899: [lldb] Convert more assertTrue to assertEqual (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ed758b26041: [lldb] Convert more assertTrue to assertEqual (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95899/new/ https:

[Lldb-commits] [PATCH] D96095: [lldb] Use assertIn/NotIn over assertTrue/False (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For improved failure messages, use `assertIn` over `assertTrue`. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D96096: [lldb] Emit type annotation in SWIG generated Python code.

kastiglione added a comment. This will be nice! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96096/new/ https://reviews.llvm.org/D96096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D96095: [lldb] Use assertIn/NotIn over assertTrue/False (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cc37622921f: [lldb] Use assertIn/NotIn over assertTrue/False (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These two `AppleThreadPlanStepThrough` thread plans have parameterized behavior that is unutilized. To mak

[Lldb-commits] [PATCH] D96277: [lldb] Minor cleanups to ThreadPlan.h (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While learning about ThreadPlan, I did a bit of cleanup: - Remove unused code - Move functions to protect

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

kastiglione added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:1163 - // stop_others value passed in to us here: - const bool trampoline_stop_others = fals

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

kastiglione added a comment. In D96276#2549007 , @jingham wrote: > It still seems to me like a trampoline which knew that to implement itself, > all it had to do was a couple of stepi's - for instance if a dyld stub knew > that the stub had been filled i

[Lldb-commits] [PATCH] D96307: [lldb] Fix crash in FormatEntity for mangled-name

kastiglione created this revision. kastiglione added a reviewer: mib. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Check a `Block` pointer before dereferencing. Using `function.mangled-name` led to a crash for a frame where

[Lldb-commits] [PATCH] D96307: [lldb] Fix crash in FormatEntity for mangled-name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dc324aafa2b: [lldb] Fix crash in FormatEntity for mangled-name (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG230939244937: [lldb] Inline invariant params to AppleThreadPlanSte

[Lldb-commits] [PATCH] D96368: Document the "extra_args" parameter to scripted breakpoint callbacks

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:127 + +def breakpoint_callback(frame, bp_loc, extra_args, dict): + # Your code goes here How about `internal_dict`, the name used elsewhere, and since in this

[Lldb-commits] [PATCH] D96277: [lldb] Minor cleanups to ThreadPlan.h (NFC)

kastiglione updated this revision to Diff 322773. kastiglione added a comment. Restore and call CachePlanExplainsStop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96277/new/ https://reviews.llvm.org/D96277 Files: lldb/include/lldb/Target/Thread

[Lldb-commits] [PATCH] D96277: [lldb] Minor cleanups to ThreadPlan.h (NFC)

kastiglione updated this revision to Diff 322779. kastiglione added a comment. - Make CachePlanExplainsStop private - Delete unused GetCachedPlanExplainsStop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96277/new/ https://reviews.llvm.org/D96277

[Lldb-commits] [PATCH] D96277: [lldb] Minor cleanups to ThreadPlan.h (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG606c3be85d92: [lldb] Minor cleanups to ThreadPlan.h (NFC) (authore

<    3   4   5   6   7   8