[Lldb-commits] [lldb] [lldb/crashlog] Fix typo in error message when creating a target (PR #122514)

2025-01-10 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/122514 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][cmake] Populate Clang resource dir for CMakeCache (PR #136761)

2025-04-22 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/136761 We want to be able to access the Clang resources directory in LLDB shell tests, this commit adds the ability to do this by populating the `CLANG_RESOURCE_DIR` CMake cache variable and adding it to the LLD

[Lldb-commits] [lldb] [lldb][cmake] Populate Clang resource dir for CMakeCache (PR #136761)

2025-04-22 Thread Chelsea Cassanova via lldb-commits
@@ -135,6 +135,8 @@ if(NOT APPLE_EMBEDDED) $/Resources/Clang/include COMMENT "LLDB.framework: copy clang vendor-specific headers" ) + + set(CLANG_RESOURCE_DIR ${clang_resource_headers_dir} CACHE FILEPATH "") chelcassanova wrote: Looked into

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: I

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/137383 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,13 @@ +// Skipping temporarily due to rdar://14958 chelcassanova wrote: The issue is that the tests need the clang resource dir in order to run properly (since `lldb-rpc-gen` is a `ClangTool`). They were originally skipped so that I could add tha

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: F

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > So could you draft something like that? Separate PR from this. Absolutely! I know this is a lot of code to review, so anything that can be done to break all this down is more than something I'm willing to do. I can write up a design doc in order to better explain exactly

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,19 @@ +if(LLDB_CODESIGN_IDENTITY) + # Use explicit LLDB identity + set(LLVM_CODESIGNING_IDENTITY ${LLDB_CODESIGN_IDENTITY}) +else() + # Use explicit LLVM identity or default to ad-hoc signing if empty + if(NOT LLVM_CODESIGNING_IDENTITY) +set(LLVM_CODESIGNING_IDE

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,61 @@ +#!/usr/bin/env python3 +# Usage: framework-header-version-fix.py MAJOR MINOR PATCH + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/136761 >From b8fec72b926a1cc02f9f3f4d3666c17aa42dd5d6 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 22 Apr 2025 13:28:04 -0700 Subject: [PATCH] [lldb][cmake] Add clang resource dir to LLDB shell tes

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Looking at this patch again, I think this can actually be split into 4 patches: - One that just has the Python scripts - One that has the shell tests - One with the emitters (`RPCServerSourceEmitter` and `RPCServerHeaderEmitter`) - One with the `lldb-rpc-gen` tool and the RPC

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/136761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
@@ -1,6 +1,12 @@ add_custom_target(lldb-shell-test-deps) set_target_properties(lldb-shell-test-deps PROPERTIES FOLDER "LLDB/Tests") add_dependencies(lldb-shell-test-deps lldb-test-depends) +if(LLDB_BUILT_STANDALONE) + get_target_property(CLANG_RESOURCE_DIR clang-resource-heade

[Lldb-commits] [lldb] [lldb][cmake] Error out when building debugserver with CMake 4 (PR #138020)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/138020 CMake 4 no longer sets the `CMAKE_OSX_SYSROOT` variable by default. If you've updated to CMake 4 on macOS (e.g. with brew) and try building LLDB with CMake/ninja, this will yield an error when building de

[Lldb-commits] [lldb] [lldb][cmake] Error out when building debugserver with CMake 4 (PR #138020)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138020 >From 4e7c20930b3f8bb0b8d4503544d278d1a561f0fd Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 28 Apr 2025 10:28:03 -0700 Subject: [PATCH] [lldb][cmake] Error out when building debugserver with

[Lldb-commits] [lldb] [lldb][cmake] Error out when building debugserver with CMake 4 (PR #138020)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Just updated the patch to set the `CMAKE_OSX_SYSROOT` variable. https://github.com/llvm/llvm-project/pull/138020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/138028 As part of upstreaming LLDB RPC, this commit adds python scripts that are used by LLDB RPC to modify the public lldb header files for use with RPC. https://discourse.llvm.org/t/rfc-upstreaming-lldb-rpc/85

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKRE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-04-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/138020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From c51a312cd3901a1e51d9e210b3efdc89389f0e10 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream Python scripts As part of upstre

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-02 Thread Chelsea Cassanova via lldb-commits
@@ -154,6 +154,19 @@ endif() add_definitions(-DLLDB_USE_OS_LOG) +if(CMAKE_OSX_SYSROOT) + set(${MIG_SYSROOT} CMAKE_OSX_SYSROOT) chelcassanova wrote: Good catch, this doesn't work as-is. I'll update to correct this. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138020 >From 6a100fa2a13c5e8e10981746ea45c7345d3c46c9 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 28 Apr 2025 10:28:03 -0700 Subject: [PATCH] [lldb][cmake] Error out when building debugserver with

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-05-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/136748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-05-05 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I split this large patch up into 3 smaller ones: This patch upstreams the `lldb-rpc-gen` tool itself as well as its common code: https://github.com/llvm/llvm-project/pull/138031 This upstreams the server-side emitter: https://github.com/llvm/llvm-project/pull/138032 This up

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-05-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/137383 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/138612 This mainly adds as design doc to help follow with the current PRs up for upstreaming the `lldb-rpc-gen` tool and emitters. Rate limit 路 GitHub body { backg

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-05-05 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Thanks for responding! I'll add a section on testing the tool itself (which we do with shell tests) and testing the interfaces (which we do by running the main LLDB API test suite against liblldbrpc). > Also, is there a way for a developer to set up an lldb-rpc based sessi

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > Ok so if had a very specific situation I wanted to run via lldb-rpc, I could > write an API test for it? That's cool, if I do find a bug I'd need to write a > test case anyway. Yes, you could have an API test that could then get run against liblldbrpc. We also have deco

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,18 @@ +// Copy lldb-rpc-defines.h from source. +# RUN: mkdir -p %t/input +# RUN: mkdir -p %t/output +# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input + +// Run the convert script on it, then run the framework include fix on it. The framework version fix

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,65 @@ +#!/usr/bin/env python3 +# Usage: framework-header-version-fix.py MAJOR MINOR PATCH +# This script modifies lldb-rpc-defines.h to uncomment the macro defines used for the LLDB +# major, minor and patch values as well as populating their definitions. + +import

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138612 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,94 @@ +LLDB RPC Upstreaming Design Doc +=== + +This document aims to explain the general structure of the upstreaming patches for adding LLDB RPC. The 2 primary concepts explained here will be: + +* How LLDB RPC is used +* How the ``lldb-rpc

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,65 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py +# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces references to LLDB +# with those for RPC. This happens for: +# - namespace definitions +# - namespace usage +

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,44 @@ +#!/usr/bin/env python3 +# Usage: framework-header-include-fix.py +# This script modifies all #include lines in all lldb-rpc headers +# from either filesystem or local includes to liblldbrpc includes. + +import argparse +import os +import re + + +def main(): +

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: For what it's worth, while these scripts do work for intended purpose for now, an approach I'd love is to have all this header modification be a subtool of the `lldb-rpc-gen` tool itself. Subtooling a ClangTool is something I'm not too sure on how to do so maybe a better C

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/138032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/136761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][cmake] Populate Clang resource dir for CMakeCache (PR #136761)

2025-04-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/136761 >From d5760f9eb92ef65c853148f8fd39a2ed5d052fdf Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 22 Apr 2025 13:28:04 -0700 Subject: [PATCH] [lldb][cmake] Add clang resource dir to LLDB shell tes

[Lldb-commits] [lldb] [lldb][cmake] Populate Clang resource dir for CMakeCache (PR #136761)

2025-04-24 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I redid this PR to just add the Clang resource dir to the CMake file for the LLDB shell tests so that lit can pick it up since it's not necessary that the variable be in the CMake cache, just the scope that the lit config exists in. https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/136748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-25 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/137383 The instructions to build LLDB standalone contain a CMake configure step to build LLVM standalone. This configure step needs to also have the CMake build type in order to work. >From c12f01f83d6849023635

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

2025-04-25 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I agree with Pavel, having the PC highlighted in yellow (or really in a colour that stands out) and having that column centers everything IMO. e.g. I like the cyan, but in the "Pro" scheme since it stands out from everything else. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > I'd have guessed it's required for a standalone build as well, but you're not > changing that, so it must not be? (assuming that "standalone build" here refers to "LLDB standalone build") Not as far as I can see. The LLVM top-level CMakeLists.txt file checks for the bui

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-28 Thread Chelsea Cassanova via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: I

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/136761 >From b073c45b526d42af21e9def5f990d32ba82c5360 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 22 Apr 2025 13:28:04 -0700 Subject: [PATCH] [lldb][cmake] Add clang resource dir to LLDB shell tes

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: G

[Lldb-commits] [lldb] [lldb][cmake] Add clang resource dir to LLDB shell tests config (PR #136761)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -1,6 +1,12 @@ add_custom_target(lldb-shell-test-deps) set_target_properties(lldb-shell-test-deps PROPERTIES FOLDER "LLDB/Tests") add_dependencies(lldb-shell-test-deps lldb-test-depends) +if(LLDB_BUILT_STANDALONE) + get_target_property(CLANG_RESOURCE_DIR clang-resource-heade

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess chelcassanova wrote: I'll change this, ditto for all other uses of subprocess https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

2025-04-29 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py + +import argparse +import os +import re +import subprocess + + +def main(): +parser = argparse.ArgumentParser() +parser.add_argument("input") +parser.add_argument("output") +

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-01 Thread Chelsea Cassanova via lldb-commits
@@ -154,6 +154,20 @@ endif() add_definitions(-DLLDB_USE_OS_LOG) +if(NOT CMAKE_OSX_SYSROOT) + execute_process(COMMAND xcodebuild -version -sdk macosx Path +OUTPUT_VARIABLE SDKROOT +ERROR_QUIET +OUTPUT_STRIP_TRAILING_WHITESPACE) + + if(NOT EXISTS ${SDKROOT}) +

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-01 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/138020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC shell tests (PR #138030)

2025-05-01 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/138030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC shell tests (PR #138030)

2025-05-01 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Sounds good, I can close this PR then and add the shell tests back in once the PR for the client-side emitters are up. https://github.com/llvm/llvm-project/pull/138030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-01 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138020 >From 350648f15e834a3734ab9fcafb610d27d9c6dd33 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 28 Apr 2025 10:28:03 -0700 Subject: [PATCH] [lldb][cmake] Error out when building debugserver with

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-01 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I can add shell tests 馃憤馃従 https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove progress report coalescing (PR #130329)

2025-03-07 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Makes sense, I also figured it could be restored from history if needed if we're not keeping it around, thanks for explaining! https://github.com/llvm/llvm-project/pull/130329 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,100 @@ +import os +import re +import sys +import subprocess + +import lldb + + +@lldb.command() +def fzf_history(debugger, cmdstr, ctx, result, _): +"""Use fzf to search and select from lldb command history.""" +if sys.platform != "darwin": +result.SetEr

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-12 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,546 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-09 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From ad185638b6369aea18848bcdbb38bd502d75ff71 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-09 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-09 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-09 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From 59dcdc0da49646e2152b1e2b6158dd1b7137bea5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,13 @@ +// Generate a dummy SB API file using lldb-rpc-gen. +# RUN: mkdir -p %t/server +# RUN: mkdir -p %t/lib chelcassanova wrote: > I don't see anything that would need job control, I'm wondering if a stray > character is causing the shell to think t

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,18 @@ +// Copy lldb-rpc-defines.h from source. +# RUN: mkdir -p %t/input +# RUN: mkdir -p %t/output +# RUN: cp %p/../../../../../include/lldb/lldb-defines.h %t/input + +// Run the convert script on it, then run the framework include fix on it. The framework version fix

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,13 @@ +// Generate a dummy SB API file using lldb-rpc-gen. +# RUN: mkdir -p %t/server +# RUN: mkdir -p %t/lib chelcassanova wrote: I just checked on macOS and got the same error. The error is a bit misleading, it's actually happening because I'm using

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From a00c76df4467c85a7436fc340c79d0a15ab6231a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream Python scripts As part of upstre

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: @DavidSpickett I pushed here to address most of the outstanding changes I needed to make from your comments, and this change should also fix the CI issue on BuildKite. Could you give this patch another pass over? https://github.com/llvm/llvm-project/pull/138028 ___

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova reopened https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-12 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-12 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,65 @@ +#!/usr/bin/env python3 +# Usage: convert-lldb-header-to-rpc-header.py +# This scripts takes common LLDB headers (such as lldb-defines.h) and replaces references to LLDB +# with those for RPC. This happens for: +# - namespace definitions +# - namespace usage +

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-06 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-05-13 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-14 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/138020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-14 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-14 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[Lldb-commits] [lldb] [DRAFT][lldb][RPC] Design doc for upstreaming PR (PR #138612)

2025-05-14 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138612 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-14 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Pushed again to address David's comments and remove most of the FIXMEs. There's one FIXME I've kept in for now: ``` // FIXME: SB class server references are stored as non-const references so // that we can actually change them as needed. If a parameter is marked // const, we

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-14 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: @bulbazord @JDevlieghere Is it possible to take another pass over at this? I think this should be good to land now. https://github.com/llvm/llvm-project/pull/138020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] [lldb][cmake] Set `CMAKE_OSX_SYSROOT` when building debugserver with CMake 4 (PR #138020)

2025-05-14 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138020 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 >From b6edf90f106ee2b339a162e13058167899f2ee21 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:24:03 -0700 Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters Thi

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I added some small shell tests to this patch that check the output of the emitter mainly for sanity checking. @bulbazord I think having basic tests like what I added would be good for the server-side emitter, but if there's anything other thing you can think of test here p

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,592 @@ +//===-- RPCServerSourceEmitter.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From 2b6f460e1e2a358aafef80354010cbad87ac5134 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream Python scripts As part of upstre

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 >From c209f358c0a897499bfd93508bc72d52baa25d07 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:24:03 -0700 Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters Thi

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 >From a6c3566dc11b27caaf98f1ae3c45fe30a4ee8d34 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:24:03 -0700 Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters Thi

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-05-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 >From 8732082e1c688e335c6bf42701fc064abe5de1a5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:24:03 -0700 Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters Thi

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I think this could be ready to land now @DavidSpickett and @JDevlieghere, could you give this another once over? https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/141116 >From 40793cd53f94744ee157865b579ff01eb5776f59 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 22 May 2025 11:00:06 -0700 Subject: [PATCH] [lldb][headers] Create script to fix up versioning Th

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From 4520d08763106b8d639e8afcb3f035a3070dee7f Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream LLDB to RPC converstion Python sc

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-22 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/141116 This commit creates a Python script that fixes up the versioning information in lldb-defines.h. It also moves the build logic for fixing up the lldb headers from being in the framework only to being in th

<    1   2   3   4   5   >