chelcassanova wrote:
Hey David! It looks like this commit broke the `TestXMLRegisterFlags.py` test
on macOS sanitized buildbots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/425/console
https://github.com/llvm/llvm-project/pull/95768
__
chelcassanova wrote:
Hey! Looks like this commit broke some tests on the LLDB macOS buildbots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6805/console
```
Assertion failed: (!isUnbracedLanguageLinkage(DC) || SC == SC_None), function
VarDecl, file Decl.cpp, line 2128.
P
chelcassanova wrote:
Just making sure, a setting for changing the prefix/suffix would be in
`CoreProperties.td` right?
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/102375
This commit fully namespaces callback function pointer parameters that are SB
types in `SBDefines` and `lldb-types`.
>From 6525ca91f6ef49b06613ec6e947f54d3faf73efe Mon Sep 17 00:00:00 2001
From: Chelsea C
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
> LGTM! Are these the only callbacks that need to be fully qualified ?
Yes they are, if new callback function pointers are added in the future that
use SB types in their parameter list or as their return type then ideally those
should also be fully namespaced.
https://git
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/102375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
Cool, sorry for the delay but I made changes to `Stream` and `SBStream` to add
a `GetUseColor()` accessor and to change the bool it uses in initialization to
a `std::optional` and I'm gonna put them up in a separate PR.
https://github.com/llvm/llvm-project/pull/91404
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/94518
`SBCommandInterpreter::CommandOverrideCallback` was not being exposed to the
Python API has no coverage in the
API test suite, so this commits exposes and adds a test for it. Doing this
involves also addin
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From e4ba69ac4983e4e2882200e7efe0e850eeefae21 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
SBCommandInterpreter:
@@ -1099,6 +1099,19 @@ static void
LLDBSwigPythonCallPythonSBDebuggerTerminateCallback(lldb::user_id_t
}
}
+static bool
LLDBSwigPythonCallPythonSBCommandInterpreterSetCommandOverrideCallback(void
*baton, const char **argv) {
+ bool b = false;
+ if (baton != Py_None) {
+
@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double
&number, PyObject *obj) {
$1 = $1 || PyCallable_Check(reinterpret_cast($input));
}
+%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) {
+ if (!($input == Py_None ||
+PyCallable_Chec
@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double
&number, PyObject *obj) {
$1 = $1 || PyCallable_Check(reinterpret_cast($input));
}
+%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) {
+ if (!($input == Py_None ||
+PyCallable_Chec
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From 44e8cab5d45a87eb1ea2076c498abe5be423eb1c Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
SBCommandInterpreter:
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From a7215585f55617a41f7c8e566088d3f50203fe55 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
SBCommandInterpreter:
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From 4e40f07e424458be6e44cc41d333f38763a0d0fb Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
SBCommandInterpreter:
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-06-11T15:27:10-07:00
New Revision: 7cff05ada05e87408966d56b4c1675033187ff5c
URL:
https://github.com/llvm/llvm-project/commit/7cff05ada05e87408966d56b4c1675033187ff5c
DIFF:
https://github.com/llvm/llvm-project/commit/7cff05ada05e87408966d56b4c1675033187ff5c.d
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/95181
…andOverrideCallback (#94518)"
This reverts commit 7cff05ada05e87408966d56b4c1675033187ff5c. The API test that
was added erroneously imports a module that isn't needed and wouldn't be found
which causes a
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/95181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/95318
This commit refactors the typemaps and static functions used in the SWIG
typemaps and wrappers to be in their own SWIG files that are included in the
main `python.swig` file.
>From 51ea2794e3ea5369d519710
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From 5724d6c77d29ad80e9ca03ce7ac1c3e6ed33afc0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/96001
This commit adds a unit test for SBBreakpoint::SetCallback as it wasn't being
tested before.
>From dc51494a84d6b0dac1d4c6b106eeb6e625a09b58 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 J
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 0dc804076d624883e966b58c94cae8dc5065f1e3 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
lldb/un
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/95318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
Closing this PR, we wanted to be able to do this _without_ using the
`PythonDataObjects` class in the swig wrapper that contains callback functions
but this looks to be unfeasible for callbacks that return SB objects
https://github.com/llvm/llvm-project/pull/95318
chelcassanova wrote:
Not anymore, I'll remove these.
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From aa575bbc2b91837851631cf7a14e03398e2efa48 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
lldb/in
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 2cfcef620125ed7d0ba84acfa20de3064437282c Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
lldb/in
@@ -0,0 +1,93 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 86dcffcc7a1820756fe8104d8239f25185a27733 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
lldb/in
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From 44ea5e0d0a319fa12463129ff072bcaef6112544 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
lldb/in
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/96001
>From a59949cc908d5216950f2530fe1455da8ad39b5f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 13 Jun 2024 16:02:07 -0700
Subject: [PATCH] add unit test for breakpoint::setcallback
---
lldb/in
chelcassanova wrote:
Hey Miro, looks like this change broke the LLDB MacOS buildbot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6353/
https://github.com/llvm/llvm-project/pull/95007
___
lldb-commits mailing list
lldb-commits@l
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/96560
Reverting to unblock macOS buildbots which are currently failing on these
tests. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6377/
>From 22127178761968b01be207a1c83c7048dc3ec47d Mon
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/96560
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/73605
This commit allows a final progress report upon the destruction of the
`Progress` object to happen at all times as opposed to when the progress was
not completed.
>From 8c29a2034a57174ec68f8c1f1a2c5c66a79
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/73605
>From 8c29a2034a57174ec68f8c1f1a2c5c66a7988762 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 27 Nov 2023 15:42:13 -0800
Subject: [PATCH 1/2] [lldb][progress] Always report progress upon Progre
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/73605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/6] [lldb][progress] Add discrete boolean flag to progr
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 004e0e6a8a09b34bdc694ca7eb5ef02483693e5f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 83ca6c8e94ded4378b4c0cd067aaeca1d92719d0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
@@ -1451,7 +1451,8 @@ static lldb::SectionType GetSectionType(uint32_t flags,
static ConstString g_sect_name_dwarf_debug_line_str("__debug_line_str");
static ConstString g_sect_name_dwarf_debug_loc("__debug_loc");
static ConstString g_sect_name_dwarf_debug_loclists("__deb
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 417d99ff038517fed596ebf6605e203110e88e6f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -97,6 +119,10 @@ class Progress {
/// The title of the progress activity.
std::string m_title;
std::mutex m_mutex;
+ /// Set to true if the progress event is aggregate; meaning it will happen
+ /// multiple times during a debug session as individual progress events
-
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
+ /// @param [in] report_type Enum value indicating how the progress is being
+ /// reported. Progress reports considered "aggregate" are reports done for
+ /// oper
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
+ /// @param [in] report_type Enum value indicating how the progress is being
+ /// reported. Progress reports considered "aggregate" are reports done for
+ /// oper
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 028d5b9f706fdf06ee0d9a33228d96660d68f5f0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
@@ -398,13 +398,16 @@ ValueObject::GetChildAtIndexPath(llvm::ArrayRef
idxs,
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (size_t idx : idxs) {
root = root->GetChildAtIndex(idx);
if (!root) {
i
@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath(
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (std::pair idx : idxs) {
root = root->GetChildAtIndex(idx.first, idx.second);
i
@@ -398,13 +398,16 @@ ValueObject::GetChildAtIndexPath(llvm::ArrayRef
idxs,
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (size_t idx : idxs) {
root = root->GetChildAtIndex(idx);
if (!root) {
i
chelcassanova wrote:
@clayborg Just pinging on this PR (when you have the chance) :)
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
The report type has been added as a key in the dictionary that gets returned
from `SBDebugger::GetProgressDataFromEvent` (specifically it's the key
`is_aggregate`) and that key is added in `DebuggerEvents.cpp`. To my
understanding since we can get the report type from `Get
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
- /// @param [in] total The total units of work to be done if specified, if
- /// set to UINT64_MAX then an indeterminate progress indicator should be
+ /// @param [
@@ -97,12 +119,17 @@ class Progress {
/// The title of the progress activity.
std::string m_title;
std::mutex m_mutex;
+ /// Set to eNonAggregateProgressReport if the progress event is aggregate;
chelcassanova wrote:
Mistake by me 😓
https://github.com
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -55,6 +55,11 @@ namespace lldb_private {
class Progress {
public:
+ /// Enum that indicates the type of progress report
+ enum class ProgressReportType {
+eAggregateProgressReport,
+eNonAggregateProgressReport
chelcassanova wrote:
eUmbrellaProgre
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
- /// @param [in] total The total units of work to be done if specified, if
- /// set to UINT64_MAX then an indeterminate progress indicator should be
+ /// @param [
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 06e9b990b3513443e563a91b33ceab07fdbc952b Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
@@ -55,6 +55,11 @@ namespace lldb_private {
class Progress {
public:
+ /// Enum that indicates the type of progress report
+ enum class ProgressReportType {
+eAggregateProgressReport,
+eNonAggregateProgressReport
chelcassanova wrote:
To my understan
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
chelcassanova wrote:
It looks we have kind of an impasse here, I've posted an RFC to try and clear
up any misunderstandings and get some input about how we can move forward with
this: https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717
Looking forward to everyone's feedback!
@@ -20,17 +20,15 @@ using namespace lldb_private;
// class BreakpointIDList
-BreakpointIDList::BreakpointIDList()
-: m_invalid_id(LLDB_INVALID_BREAK_ID, LLDB_INVALID_BREAK_ID) {}
+BreakpointIDList::BreakpointIDList() : m_breakpoint_ids() {}
BreakpointIDList::~Breakpoin
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/77547
Per this RFC:
https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717 on
improving progress reports, this commit separates the title field and details
field so that the title specifies the c
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/77547
>From 44a3cdca21bc9c2aa24eeaf5d82c8b8af382bfa7 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 9 Jan 2024 18:32:06 -0800
Subject: [PATCH 1/2] [lldb][Progress] Separate title and details
Per thi
@@ -1430,6 +1445,279 @@ void Debugger::SetDestroyCallback(
m_destroy_callback_baton = baton;
}
+
+ /// Notify the progress thread that there is new progress data.
+void Debugger::NotifyProgress(std::unique_ptr &data_up) {
+ // Start the progress thread if it isn't already
@@ -69,7 +69,8 @@ class Progress {
///
/// @param [in] debugger An optional debugger pointer to specify that this
/// progress is to be reported only to specific debuggers.
- Progress(std::string title, uint64_t total = UINT64_MAX,
+ Progress(std::string title, std::str
@@ -519,8 +519,7 @@ void SymbolFileDWARF::InitializeObject() {
if (apple_names.GetByteSize() > 0 || apple_namespaces.GetByteSize() > 0 ||
apple_types.GetByteSize() > 0 || apple_objc.GetByteSize() > 0) {
- Progress progress(llvm::formatv("Loading Apple DWARF in
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/77547
>From 44a3cdca21bc9c2aa24eeaf5d82c8b8af382bfa7 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 9 Jan 2024 18:32:06 -0800
Subject: [PATCH 1/3] [lldb][Progress] Separate title and details
Per thi
@@ -51,9 +56,10 @@ void Progress::Increment(uint64_t amount, std::string
update) {
void Progress::ReportProgress(std::string update) {
if (!m_complete) {
// Make sure we only send one notification that indicates the progress is
-// complete.
-m_complete = m_compl
@@ -30,18 +34,19 @@ Progress::~Progress() {
// Make sure to always report progress completed when this object is
// destructed so it indicates the progress dialog/activity should go away.
std::lock_guard guard(m_mutex);
- if (!m_completed)
-m_completed = m_total;
+
@@ -30,18 +34,19 @@ Progress::~Progress() {
// Make sure to always report progress completed when this object is
// destructed so it indicates the progress dialog/activity should go away.
std::lock_guard guard(m_mutex);
- if (!m_completed)
-m_completed = m_total;
+
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/77547
>From 44a3cdca21bc9c2aa24eeaf5d82c8b8af382bfa7 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 9 Jan 2024 18:32:06 -0800
Subject: [PATCH 1/4] [lldb][Progress] Separate title and details
Per thi
@@ -90,10 +90,11 @@ class Progress {
/// @param [in] amount The amount to increment m_completed by.
///
/// @param [in] an optional message associated with this update.
- void Increment(uint64_t amount = 1, std::string update = {});
+ void Increment(uint64_t amount = 1,
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/77547
>From 44a3cdca21bc9c2aa24eeaf5d82c8b8af382bfa7 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 9 Jan 2024 18:32:06 -0800
Subject: [PATCH 1/5] [lldb][Progress] Separate title and details
Per thi
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/66144:
This exposes the `eBroadcastBitSymbolChange` bit to the SB API to show when a
symbol change event has been broadcast as this wasn't being done before. Also
refactors `eBroadcastSymbolChange` to `eBroadcas
https://github.com/chelcassanova review_requested
https://github.com/llvm/llvm-project/pull/66144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH] [lldb][Commands] Show symbol change bit in SB API
Thi
@@ -13,6 +13,7 @@
#include "lldb/API/SBDefines.h"
#include "lldb/API/SBPlatform.h"
+#include "lldb/API/SBStructuredData.h"
chelcassanova wrote:
Correct, I left this in here by mistake.
https://github.com/llvm/llvm-project/pull/66144
_
https://github.com/chelcassanova resolved
https://github.com/llvm/llvm-project/pull/66144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -83,7 +83,7 @@ class Debugger : public
std::enable_shared_from_this,
eBroadcastBitProgress = (1 << 0),
eBroadcastBitWarning = (1 << 1),
eBroadcastBitError = (1 << 2),
-eBroadcastSymbolChange = (1 << 3),
+eBroadcastBitSymbolChange = (1 << 3),
@@ -83,7 +83,7 @@ class Debugger : public
std::enable_shared_from_this,
eBroadcastBitProgress = (1 << 0),
eBroadcastBitWarning = (1 << 1),
eBroadcastBitError = (1 << 2),
-eBroadcastSymbolChange = (1 << 3),
+eBroadcastBitSymbolChange = (1 << 3),
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/2] [lldb][Commands] Show symbol change bit in SB API
@@ -66,6 +66,7 @@
#include "llvm/ADT/ScopeExit.h"
#include "llvm/ADT/SetVector.h"
+#include <_types/_uint32_t.h>
chelcassanova wrote:
This was included by mistake
https://github.com/llvm/llvm-project/pull/66144
___
@@ -83,7 +83,7 @@ class Debugger : public
std::enable_shared_from_this,
eBroadcastBitProgress = (1 << 0),
eBroadcastBitWarning = (1 << 1),
eBroadcastBitError = (1 << 2),
-eBroadcastSymbolChange = (1 << 3),
+eBroadcastBitSymbolChange = (1 << 3),
chelcassanova wrote:
> Does this API work for eBroadcastBitSymbolsLoaded:
>
> ```
> static lldb::SBModule lldb::SBTarget::GetModuleAtIndexFromEvent(const
> uint32_t idx, const lldb::SBEvent &event);
> ```
>
> ?
>
> > Note, Jonas already added the Target::eBroadcastBitSymbolsChanged, but it
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/3] [lldb][Commands] Show symbol change bit in SB API
@@ -57,6 +57,29 @@ def test_add_dsym_with_dSYM_bundle(self):
self.exe_name = "a.out"
self.do_add_dsym_with_dSYM_bundle(self.exe_name)
+@no_debug_info_test
+def test_report_symbol_load(self):
+"""Test that when adding a symbol file, the eBroadcas
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/4] [lldb][Commands] Show symbol change bit in SB API
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/5] [lldb][Commands] Show symbol change bit in SB API
1 - 100 of 452 matches
Mail list logo
